From b45e0014ccbdedf876411c0e154844f6dfeeeaea Mon Sep 17 00:00:00 2001
From: Simone Gotti <simone.gotti@gmail.com>
Date: Tue, 14 May 2019 15:47:35 +0200
Subject: [PATCH] *: show root project group settings

---
 src/components/projectgroupsettings.vue |  5 ++++-
 src/router.js                           |  6 ++++++
 src/util/link.js                        | 21 +++++++++++----------
 src/views/Org.vue                       | 20 ++++++++++++++++----
 src/views/ProjectGroup.vue              |  3 +++
 src/views/User.vue                      | 18 +++++++++++++++---
 6 files changed, 55 insertions(+), 18 deletions(-)

diff --git a/src/components/projectgroupsettings.vue b/src/components/projectgroupsettings.vue
index 0b1b8c2..c3aec50 100644
--- a/src/components/projectgroupsettings.vue
+++ b/src/components/projectgroupsettings.vue
@@ -6,7 +6,7 @@
         <projectvars :variables="variables" :allvariables="allvariables"/>
       </div>
     </nav>
-    <nav class="panel is-danger">
+    <nav v-if="!isRootProjectGroup" class="panel is-danger">
       <p class="panel-heading is-danger">Danger Zone</p>
       <div class="panel-block is-block">
         <div>
@@ -84,6 +84,9 @@ export default {
     },
     deleteButtonEnabled: function() {
       return this.projectGroupNameToDelete == this.projectGroupName;
+    },
+    isRootProjectGroup() {
+      return this.projectgroupref.length == 0;
     }
   },
   methods: {
diff --git a/src/router.js b/src/router.js
index e5f2698..3f9c449 100644
--- a/src/router.js
+++ b/src/router.js
@@ -231,6 +231,12 @@ const router = new VueRouter({
           component: orgmembers,
           props: (route) => ({ orgname: route.params.orgname })
         },
+        /*         {
+                  path: "settings",
+                  name: "org settings",
+                  component: orgsettings,
+                  props: (route) => ({ username: route.params.username }),
+                }, */
         {
           path: "createprojectgroup",
           name: "org create project group",
diff --git a/src/util/link.js b/src/util/link.js
index 5ff6459..85ffffc 100644
--- a/src/util/link.js
+++ b/src/util/link.js
@@ -1,5 +1,9 @@
 export function parseRef(ref) {
     ref = ref.replace(/\.proj/, "")
+    // return empty array or split return an array with the empty element
+    if (!ref) {
+        return []
+    }
     return ref.split("/")
 }
 
@@ -44,19 +48,16 @@ export function orgMembersLink(orgname) {
 // escape it
 export function projectGroupPath(ownertype, ownername, projectgroupref) {
     let path = `/${ownertype}/${ownername}`
-    if (Array.isArray(projectgroupref) && projectgroupref.length) {
-        let projectgrouppath = (projectgroupref.join("/") + ".proj")
-        path = `${path}/projectgroups/${projectgrouppath}`
-    }
+    // root project group will have a .proj without a name
+    let projectgrouppath = (projectgroupref.join("/") + ".proj")
+    path = `${path}/projectgroups/${projectgrouppath}`
     return path
 }
 
 export function projectPath(ownertype, ownername, projectref) {
     let path = `/${ownertype}/${ownername}`
-    if (Array.isArray(projectref) && projectref.length) {
-        let projectpath = (projectref.join("/") + ".proj")
-        path = `${path}/projects/${projectpath}`
-    }
+    let projectpath = (projectref.join("/") + ".proj")
+    path = `${path}/projects/${projectpath}`
     return path
 }
 
@@ -105,8 +106,8 @@ export function projectRunTaskLink(ownertype, ownername, projectref, runid, task
 }
 
 export function projectGroupSettingsLink(ownertype, ownername, projectgroupref) {
-    let projectgrouppath = (projectgroupref.join("/") + ".proj")
-    return { path: `/${ownertype}/${ownername}/projectgroups/${projectgrouppath}/settings` }
+    let path = projectGroupPath(ownertype, ownername, projectgroupref)
+    return { path: `${path}/settings` }
 }
 
 export function projectSettingsLink(ownertype, ownername, projectref) {
diff --git a/src/views/Org.vue b/src/views/Org.vue
index 81eab03..511c54d 100644
--- a/src/views/Org.vue
+++ b/src/views/Org.vue
@@ -38,7 +38,15 @@
         </li>
       </ul>
       <ul class="is-right">
-        <li :class="[{ 'is-active': $route.name.endsWith('project group settings') }]">
+        <li :class="[{ 'is-active': $route.name.endsWith('org project group settings') }]">
+          <router-link :to="projectGroupSettingsLink('org', orgname, [])">
+            <span class="icon is-small">
+              <i class="mdi mdi-settings"/>
+            </span>
+            <span>Root Project Group Settings</span>
+          </router-link>
+        </li>
+        <li :class="[{ 'is-active': $route.name.endsWith('org settings') }]">
           <router-link :to="ownerSettingsLink('org', orgname)">
             <span class="icon is-small">
               <i class="mdi mdi-settings"/>
@@ -60,7 +68,8 @@ import {
   ownerSettingsLink,
   orgMembersLink,
   projectGroupCreateProjectGroupLink,
-  projectGroupCreateProjectLink
+  projectGroupCreateProjectLink,
+  projectGroupSettingsLink
 } from "@/util/link.js";
 
 import createprojectbutton from "@/components/createprojectbutton.vue";
@@ -78,13 +87,16 @@ export default {
     orgMembersLink: orgMembersLink,
     projectGroupCreateProjectGroupLink: projectGroupCreateProjectGroupLink,
     projectGroupCreateProjectLink: projectGroupCreateProjectLink,
+    projectGroupSettingsLink: projectGroupSettingsLink,
     goToCreate(type) {
       if (type == "project") {
-        this.$router.push(projectGroupCreateProjectLink("org", this.orgname));
+        this.$router.push(
+          projectGroupCreateProjectLink("org", this.orgname, [])
+        );
         return;
       }
       this.$router.push(
-        projectGroupCreateProjectGroupLink("org", this.orgname)
+        projectGroupCreateProjectGroupLink("org", this.orgname, [])
       );
     }
   }
diff --git a/src/views/ProjectGroup.vue b/src/views/ProjectGroup.vue
index a598f42..3ff860e 100644
--- a/src/views/ProjectGroup.vue
+++ b/src/views/ProjectGroup.vue
@@ -68,6 +68,9 @@ export default {
     projectGroupCreateProjectGroupLink: projectGroupCreateProjectGroupLink,
     projectGroupCreateProjectLink: projectGroupCreateProjectLink,
     projectGroupName() {
+      if (!this.projectgroupref.length) {
+        return "Root Project Group";
+      }
       return this.projectgroupref[this.projectgroupref.length - 1];
     },
     goToCreate(type) {
diff --git a/src/views/User.vue b/src/views/User.vue
index 0feb2d5..a648df7 100644
--- a/src/views/User.vue
+++ b/src/views/User.vue
@@ -71,6 +71,14 @@
         </li>
       </ul>
       <ul class="is-right">
+        <li :class="[{ 'is-active': $route.name.endsWith('user project group settings') }]">
+          <router-link :to="projectGroupSettingsLink('user', username, [])">
+            <span class="icon is-small">
+              <i class="mdi mdi-settings"/>
+            </span>
+            <span>Root Project Group Settings</span>
+          </router-link>
+        </li>
         <li :class="[{ 'is-active': $route.name.endsWith('user settings') }]">
           <router-link :to="ownerSettingsLink('user', username)">
             <span class="icon is-small">
@@ -95,7 +103,8 @@ import {
   userLocalRunTaskLink,
   ownerSettingsLink,
   projectGroupCreateProjectGroupLink,
-  projectGroupCreateProjectLink
+  projectGroupCreateProjectLink,
+  projectGroupSettingsLink
 } from "@/util/link.js";
 
 import { fetchRun } from "@/util/data.js";
@@ -135,13 +144,16 @@ export default {
     ownerSettingsLink: ownerSettingsLink,
     projectGroupCreateProjectGroupLink: projectGroupCreateProjectGroupLink,
     projectGroupCreateProjectLink: projectGroupCreateProjectLink,
+    projectGroupSettingsLink: projectGroupSettingsLink,
     goToCreate(type) {
       if (type == "project") {
-        this.$router.push(projectGroupCreateProjectLink("user", this.username));
+        this.$router.push(
+          projectGroupCreateProjectLink("user", this.username, [])
+        );
         return;
       }
       this.$router.push(
-        projectGroupCreateProjectGroupLink("user", this.username)
+        projectGroupCreateProjectGroupLink("user", this.username, [])
       );
     }
   }