From b4cd9806b02c8fc75122833199c019bc12bdbcb5 Mon Sep 17 00:00:00 2001
From: Simone Gotti <simone.gotti@gmail.com>
Date: Wed, 10 Apr 2019 11:21:18 +0200
Subject: [PATCH] Show run setup errors

---
 src/components/run.vue       | 83 +++++++++++++++++++++++++-----------
 src/components/rundetail.vue |  5 +++
 src/components/runs.vue      |  5 +++
 src/css/_variables.scss      |  1 -
 4 files changed, 69 insertions(+), 25 deletions(-)

diff --git a/src/components/run.vue b/src/components/run.vue
index b1239f9..b67855a 100644
--- a/src/components/run.vue
+++ b/src/components/run.vue
@@ -1,37 +1,53 @@
 <template>
   <div>
     <RunDetail :run="run"/>
+    <div v-if="run.phase != 'setuperror'">
+      <div class="tabs">
+        <ul>
+          <li>
+            <a>Tasks</a>
+          </li>
+        </ul>
+      </div>
 
-    <div class="tabs">
-      <ul>
-        <li>
-          <a>Tasks</a>
-        </li>
-      </ul>
-    </div>
-
-    <div v-if="run" class="tasks-list">
-      <div v-for="task in run.sortedTasks" v-bind:key="task.id" :class="taskClass(task)">
-        <div class="task-content">
-          <div class="columns">
-            <router-link class="column is-10" tag="a" :to="runTaskLink(task)">
-              <span class="name">{{task.name}}</span>
-            </router-link>
-            <div class="column">
-              <span class="tag" v-if="run.tasks_waiting_approval.includes(task.id)">Waiting approval</span>
+      <div v-if="run" class="tasks-list">
+        <div v-for="task in run.sortedTasks" v-bind:key="task.id" :class="taskClass(task)">
+          <div class="task-content">
+            <div class="columns">
+              <router-link class="column is-10" tag="a" :to="runTaskLink(task)">
+                <span class="name">{{task.name}}</span>
+              </router-link>
+              <div class="column">
+                <span
+                  class="tag"
+                  v-if="run.tasks_waiting_approval.includes(task.id)"
+                >Waiting approval</span>
+              </div>
+              <div class="parents column">
+                <span v-if="parents(task).length > 0">depends on: &nbsp;</span>
+                <span class="parent" v-for="dep in parents(task)" v-bind:key="dep">{{dep}}</span>
+              </div>
             </div>
-            <div class="parents column">
-              <span v-if="parents(task).length > 0">depends on: &nbsp;</span>
-              <span class="parent" v-for="dep in parents(task)" v-bind:key="dep">{{dep}}</span>
-            </div>
-          </div>
-          <!--               <span
+            <!--               <span
                 class="duration"
                 v-if="duration && (step.Phase == 'success' || step.Phase == 'failed') "
-          >{{duration}}</span>-->
+            >{{duration}}</span>-->
+          </div>
         </div>
       </div>
     </div>
+    <div v-else>
+      <div class="tabs">
+        <ul>
+          <li>
+            <a>Setup Errors</a>
+          </li>
+        </ul>
+      </div>
+      <div class="setuperrors">
+        <span class="error-line" v-for="(error, i) in run.setup_errors" v-bind:key="i">{{error}}</span>
+      </div>
+    </div>
   </div>
 </template>
 
@@ -156,4 +172,23 @@ export default {
     }
   }
 }
+
+.setuperrors {
+  background-color: #222;
+  color: #f1f1f1;
+  font-family: Cousine, monospace;
+  font-size: 12px;
+  line-height: 19px;
+  white-space: pre-wrap;
+  word-wrap: break-word;
+  text-align: left;
+  font-size: 12px;
+  padding: 5px;
+
+  .error-line {
+    pre {
+      line-height: 1.2;
+    }
+  }
+}
 </style>
\ No newline at end of file
diff --git a/src/components/rundetail.vue b/src/components/rundetail.vue
index 6eeb545..d4591c4 100644
--- a/src/components/rundetail.vue
+++ b/src/components/rundetail.vue
@@ -117,6 +117,7 @@ export default {
     runResultClass(run) {
       let status = this.runStatus(run);
 
+      if (status == "setuperror") return "setuperror";
       if (status == "queued") return "unknown";
       if (status == "cancelled") return "failed";
       if (status == "running") return "running";
@@ -206,6 +207,10 @@ export default {
     border-left: 5px solid $grey-lighter;
   }
 
+  .setuperror {
+    border-left: 5px solid $yellow;
+  }
+
   .name {
     font-weight: bold;
     cursor: pointer;
diff --git a/src/components/runs.vue b/src/components/runs.vue
index c838617..cc45a5f 100644
--- a/src/components/runs.vue
+++ b/src/components/runs.vue
@@ -102,6 +102,7 @@ export default {
     },
     runResultClass(run) {
       if (run.result == "unknown") {
+        if (run.phase == "setuperror") return "setuperror";
         if (run.phase == "queued") return "unknown";
         if (run.phase == "cancelled") return "failed";
         if (run.phase == "running") return "running";
@@ -218,6 +219,10 @@ export default {
     border-left: 5px solid $grey-lighter;
   }
 
+  .setuperror {
+    border-left: 5px solid $yellow;
+  }
+
   .name {
     flex: 0 0 30%;
     font-weight: bold;
diff --git a/src/css/_variables.scss b/src/css/_variables.scss
index 8db80a6..3c059e8 100644
--- a/src/css/_variables.scss
+++ b/src/css/_variables.scss
@@ -13,7 +13,6 @@ $purple: #8e44ad;
 $red: #e42522;
 $white-ter: #ecf0f1;
 $primary: #34495e !default;
-$yellow-invert: #fff;
 
 $grey-lighter-invert: findColorInvert($grey-lighter);
 $green-invert: findColorInvert($green);