a
/
agola
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity
agola/internal/datamanager/datamanager_test.go

1687 lines
44 KiB
Go
Raw Normal View History

Add initial objectstorage wal manager
2019-02-22 07:45:59 +00:00
// Copyright 2019 Sorint.lab
//
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
// You may obtain a copy of the License at
//
// http://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by applicable law or agreed to in writing, software
// distributed under the License is distributed on an "AS IS" BASIS,
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied
// See the License for the specific language governing permissions and
// limitations under the License.
wal: update and rename to datamanager * Rename to datamanager since it handles a complete "database" backed by an objectstorage and etcd * Don't write every single entry as a single file but group them in a single file. In future improve this to split the data in multiple files of a max size.
2019-04-26 14:00:03 +00:00
package datamanager
Add initial objectstorage wal manager
2019-02-22 07:45:59 +00:00
import (
datamanager: implement import/export * export: exports the newest data checkpoint. It forces a checkpoint before exporting (currently no wals are exported) * import: cleans up etcd, creates a new datasnaphot from the provided import stream and then initializes etcd. Currently no old data is removed from the object storage but it's just ignored.
2019-07-17 15:16:35 +00:00
"bytes"
Add initial objectstorage wal manager
2019-02-22 07:45:59 +00:00
"context"
datamanager: implement data files splitting split data files in multiple files of a max size (default 10Mib) In this way every data snapshot will change only the datafiles that have some changes instead of the whole single file.
2019-06-03 14:17:27 +00:00
"encoding/json"
Add initial objectstorage wal manager
2019-02-22 07:45:59 +00:00
"fmt"
datamanager: implement data files splitting split data files in multiple files of a max size (default 10Mib) In this way every data snapshot will change only the datafiles that have some changes instead of the whole single file.
2019-06-03 14:17:27 +00:00
"io"
Add initial objectstorage wal manager
2019-02-22 07:45:59 +00:00
"io/ioutil"
"os"
datamanager: check wal previouswalsequence is correct in initEtcd
2019-11-05 16:48:11 +00:00
"path"
datamanager: implement data files splitting split data files in multiple files of a max size (default 10Mib) In this way every data snapshot will change only the datafiles that have some changes instead of the whole single file.
2019-06-03 14:17:27 +00:00
"reflect"
"sort"
datamanager: check wal previouswalsequence is correct in initEtcd
2019-11-05 16:48:11 +00:00
"strings"
Add initial objectstorage wal manager
2019-02-22 07:45:59 +00:00
"testing"
"time"
*: use new errors handling library Implement a new error handling library based on pkg/errors. It provides stack saving on wrapping and exports some function to add stack saving also to external errors. It also implements custom zerolog error formatting without adding too much verbosity by just printing the chain error file:line without a full stack trace of every error. * Add a --detailed-errors options to print error with they full chain * Wrap all error returns. Use errors.WithStack to wrap without adding a new messsage and error.Wrap[f] to add a message. * Add golangci-lint wrapcheck to check that external packages errors are wrapped. This won't check that internal packages error are wrapped. But we want also to ensure this case so we'll have to find something else to check also these.
2022-02-22 14:01:29 +00:00
"agola.io/agola/internal/errors"
*: use vanity url use agola.io domain
2019-07-01 09:40:20 +00:00
"agola.io/agola/internal/objectstorage"
"agola.io/agola/internal/testutil"
Add initial objectstorage wal manager
2019-02-22 07:45:59 +00:00
*: improve error handling * objectstorage: remove `types` package and move `ErrNotExist` in base package * objectstorage: Implement .Is and add helper `IsErrNotExist` for `ErrNotExist` * util: Rename `ErrNotFound` to `ErrNotExist` * util: Add `IsErr*` helpers and use them in place of `errors.Is()` * datamanager: add `ErrNoDataStatus` to report when there's not data status in ost * runservice/common: remove `ErrNotExist` and use errors in util package
2019-11-06 12:29:42 +00:00
"github.com/google/go-cmp/cmp"
*: use zerolog for logging Replace zap with zerolog. zerolog has a cleaner interface and can be easily configured with custom error chain printing using a new error handling library that will be implemented in another PR.
2022-02-21 17:07:58 +00:00
"github.com/rs/zerolog"
Add initial objectstorage wal manager
2019-02-22 07:45:59 +00:00
)
*: use zerolog for logging Replace zap with zerolog. zerolog has a cleaner interface and can be easily configured with custom error chain printing using a new error handling library that will be implemented in another PR.
2022-02-21 17:07:58 +00:00
func setupEtcd(t *testing.T, log zerolog.Logger, dir string) *testutil.TestEmbeddedEtcd {
tetcd, err := testutil.NewTestEmbeddedEtcd(t, log, dir)
Add initial objectstorage wal manager
2019-02-22 07:45:59 +00:00
if err != nil {
t.Fatalf("unexpected err: %v", err)
}
if err := tetcd.Start(); err != nil {
t.Fatalf("unexpected err: %v", err)
}
if err := tetcd.WaitUp(30 * time.Second); err != nil {
tests: improve services logging During tests provide a zaptest Logger so all services output will be redirected to golang testing logger. When multiple services of the same type are provided add a unique name field to distinguish them.
2020-01-15 11:01:46 +00:00
t.Fatalf("error waiting on etcd up: %v", err)
Add initial objectstorage wal manager
2019-02-22 07:45:59 +00:00
}
return tetcd
}
func shutdownEtcd(tetcd *testutil.TestEmbeddedEtcd) {
if tetcd.Etcd != nil {
datamanager: fix linter errors Fix errors reported by default golangci-lint linters
2019-07-02 12:27:51 +00:00
_ = tetcd.Kill()
Add initial objectstorage wal manager
2019-02-22 07:45:59 +00:00
}
}
func TestEtcdReset(t *testing.T) {
test: use `T.TempDir` to create temporary test directory The directory created by `T.TempDir` is automatically removed when the test and all its subtests complete. Reference: https://pkg.go.dev/testing#T.TempDir Signed-off-by: Eng Zer Jun <engzerjun@gmail.com>
2022-03-01 05:57:39 +00:00
dir := t.TempDir()
*: use zerolog for logging Replace zap with zerolog. zerolog has a cleaner interface and can be easily configured with custom error chain printing using a new error handling library that will be implemented in another PR.
2022-02-21 17:07:58 +00:00
log := testutil.NewLogger(t)
tests: improve services logging During tests provide a zaptest Logger so all services output will be redirected to golang testing logger. When multiple services of the same type are provided add a unique name field to distinguish them.
2020-01-15 11:01:46 +00:00
Add initial objectstorage wal manager
2019-02-22 07:45:59 +00:00
etcdDir, err := ioutil.TempDir(dir, "etcd")
datamanager: fix linter errors Fix errors reported by default golangci-lint linters
2019-07-02 12:27:51 +00:00
if err != nil {
t.Fatalf("unexpected err: %v", err)
}
*: use zerolog for logging Replace zap with zerolog. zerolog has a cleaner interface and can be easily configured with custom error chain printing using a new error handling library that will be implemented in another PR.
2022-02-21 17:07:58 +00:00
tetcd := setupEtcd(t, log, etcdDir)
Add initial objectstorage wal manager
2019-02-22 07:45:59 +00:00
ctx, cancel := context.WithCancel(context.Background())
*: rename "lts" to "ost" `lts` was choosen to reflect a "long term storage" but currently it's just an object storage implementation. So use this term and "ost" as its abbreviation (to not clash with "os").
2019-04-27 13:16:48 +00:00
ostDir, err := ioutil.TempDir(dir, "ost")
datamanager: fix linter errors Fix errors reported by default golangci-lint linters
2019-07-02 12:27:51 +00:00
if err != nil {
t.Fatalf("unexpected err: %v", err)
}
Add initial objectstorage wal manager
2019-02-22 07:45:59 +00:00
objectstorage: use a single package remove all the subpackages and just use a single package
2019-11-08 15:25:53 +00:00
ost, err := objectstorage.NewPosix(ostDir)
Add initial objectstorage wal manager
2019-02-22 07:45:59 +00:00
if err != nil {
t.Fatalf("unexpected err: %v", err)
}
wal: update and rename to datamanager * Rename to datamanager since it handles a complete "database" backed by an objectstorage and etcd * Don't write every single entry as a single file but group them in a single file. In future improve this to split the data in multiple files of a max size.
2019-04-26 14:00:03 +00:00
dmConfig := &DataManagerConfig{
Add initial objectstorage wal manager
2019-02-22 07:45:59 +00:00
BasePath: "basepath",
E: tetcd.TestEtcd.Store,
*: rename "lts" to "ost" `lts` was choosen to reflect a "long term storage" but currently it's just an object storage implementation. So use this term and "ost" as its abbreviation (to not clash with "os").
2019-04-27 13:16:48 +00:00
OST: objectstorage.NewObjStorage(ost, "/"),
Add initial objectstorage wal manager
2019-02-22 07:45:59 +00:00
EtcdWalsKeepNum: 10,
wal: update and rename to datamanager * Rename to datamanager since it handles a complete "database" backed by an objectstorage and etcd * Don't write every single entry as a single file but group them in a single file. In future improve this to split the data in multiple files of a max size.
2019-04-26 14:00:03 +00:00
DataTypes: []string{"datatype01"},
Add initial objectstorage wal manager
2019-02-22 07:45:59 +00:00
}
*: use zerolog for logging Replace zap with zerolog. zerolog has a cleaner interface and can be easily configured with custom error chain printing using a new error handling library that will be implemented in another PR.
2022-02-21 17:07:58 +00:00
dm, err := NewDataManager(ctx, log, dmConfig)
datamanager: fix linter errors Fix errors reported by default golangci-lint linters
2019-07-02 12:27:51 +00:00
if err != nil {
t.Fatalf("unexpected err: %v", err)
}
wal: update and rename to datamanager * Rename to datamanager since it handles a complete "database" backed by an objectstorage and etcd * Don't write every single entry as a single file but group them in a single file. In future improve this to split the data in multiple files of a max size.
2019-04-26 14:00:03 +00:00
dmReadyCh := make(chan struct{})
update wal and readdb
2019-04-01 10:54:43 +00:00
wal: update and rename to datamanager * Rename to datamanager since it handles a complete "database" backed by an objectstorage and etcd * Don't write every single entry as a single file but group them in a single file. In future improve this to split the data in multiple files of a max size.
2019-04-26 14:00:03 +00:00
t.Logf("starting datamanager")
datamanager: fix linter errors Fix errors reported by default golangci-lint linters
2019-07-02 12:27:51 +00:00
go func() { _ = dm.Run(ctx, dmReadyCh) }()
wal: update and rename to datamanager * Rename to datamanager since it handles a complete "database" backed by an objectstorage and etcd * Don't write every single entry as a single file but group them in a single file. In future improve this to split the data in multiple files of a max size.
2019-04-26 14:00:03 +00:00
<-dmReadyCh
Add initial objectstorage wal manager
2019-02-22 07:45:59 +00:00
actions := []*Action{
{
ActionType: ActionTypePut,
wal: update and rename to datamanager * Rename to datamanager since it handles a complete "database" backed by an objectstorage and etcd * Don't write every single entry as a single file but group them in a single file. In future improve this to split the data in multiple files of a max size.
2019-04-26 14:00:03 +00:00
DataType: "datatype01",
Add initial objectstorage wal manager
2019-02-22 07:45:59 +00:00
Data: []byte("{}"),
},
}
for i := 0; i < 20; i++ {
update wal and readdb
2019-04-01 10:54:43 +00:00
objectID := fmt.Sprintf("object%02d", i)
actions[0].ID = objectID
wal: update and rename to datamanager * Rename to datamanager since it handles a complete "database" backed by an objectstorage and etcd * Don't write every single entry as a single file but group them in a single file. In future improve this to split the data in multiple files of a max size.
2019-04-26 14:00:03 +00:00
if _, err := dm.WriteWal(ctx, actions, nil); err != nil {
Add initial objectstorage wal manager
2019-02-22 07:45:59 +00:00
t.Fatalf("unexpected err: %v", err)
}
}
// wait for wal to be committed storage
time.Sleep(5 * time.Second)
wal: update and rename to datamanager * Rename to datamanager since it handles a complete "database" backed by an objectstorage and etcd * Don't write every single entry as a single file but group them in a single file. In future improve this to split the data in multiple files of a max size.
2019-04-26 14:00:03 +00:00
t.Logf("stopping datamanager")
update wal and readdb
2019-04-01 10:54:43 +00:00
cancel()
Add initial objectstorage wal manager
2019-02-22 07:45:59 +00:00
// Reset etcd
datamanager tests: increase etcd waitdown timeout
2019-11-12 09:47:04 +00:00
t.Logf("stopping etcd")
Add initial objectstorage wal manager
2019-02-22 07:45:59 +00:00
shutdownEtcd(tetcd)
datamanager tests: don't wait for etcd down It is causing some timeout errors since there can be another instance from another test run in parallel started on the same port.
2019-12-02 12:32:57 +00:00
update wal and readdb
2019-04-01 10:54:43 +00:00
t.Logf("resetting etcd")
Add initial objectstorage wal manager
2019-02-22 07:45:59 +00:00
os.RemoveAll(etcdDir)
update wal and readdb
2019-04-01 10:54:43 +00:00
t.Logf("starting etcd")
*: use zerolog for logging Replace zap with zerolog. zerolog has a cleaner interface and can be easily configured with custom error chain printing using a new error handling library that will be implemented in another PR.
2022-02-21 17:07:58 +00:00
tetcd = setupEtcd(t, log, etcdDir)
Add initial objectstorage wal manager
2019-02-22 07:45:59 +00:00
if err := tetcd.Start(); err != nil {
t.Fatalf("unexpected err: %v", err)
}
defer shutdownEtcd(tetcd)
update wal and readdb
2019-04-01 10:54:43 +00:00
ctx, cancel = context.WithCancel(context.Background())
wal: update and rename to datamanager * Rename to datamanager since it handles a complete "database" backed by an objectstorage and etcd * Don't write every single entry as a single file but group them in a single file. In future improve this to split the data in multiple files of a max size.
2019-04-26 14:00:03 +00:00
defer cancel()
dmConfig = &DataManagerConfig{
update wal and readdb
2019-04-01 10:54:43 +00:00
BasePath: "basepath",
E: tetcd.TestEtcd.Store,
*: rename "lts" to "ost" `lts` was choosen to reflect a "long term storage" but currently it's just an object storage implementation. So use this term and "ost" as its abbreviation (to not clash with "os").
2019-04-27 13:16:48 +00:00
OST: objectstorage.NewObjStorage(ost, "/"),
update wal and readdb
2019-04-01 10:54:43 +00:00
EtcdWalsKeepNum: 10,
wal: update and rename to datamanager * Rename to datamanager since it handles a complete "database" backed by an objectstorage and etcd * Don't write every single entry as a single file but group them in a single file. In future improve this to split the data in multiple files of a max size.
2019-04-26 14:00:03 +00:00
DataTypes: []string{"datatype01"},
update wal and readdb
2019-04-01 10:54:43 +00:00
}
*: use zerolog for logging Replace zap with zerolog. zerolog has a cleaner interface and can be easily configured with custom error chain printing using a new error handling library that will be implemented in another PR.
2022-02-21 17:07:58 +00:00
dm, err = NewDataManager(ctx, log, dmConfig)
datamanager: fix linter errors Fix errors reported by default golangci-lint linters
2019-07-02 12:27:51 +00:00
if err != nil {
t.Fatalf("unexpected err: %v", err)
}
wal: update and rename to datamanager * Rename to datamanager since it handles a complete "database" backed by an objectstorage and etcd * Don't write every single entry as a single file but group them in a single file. In future improve this to split the data in multiple files of a max size.
2019-04-26 14:00:03 +00:00
dmReadyCh = make(chan struct{})
update wal and readdb
2019-04-01 10:54:43 +00:00
datamanager: implement data files splitting split data files in multiple files of a max size (default 10Mib) In this way every data snapshot will change only the datafiles that have some changes instead of the whole single file.
2019-06-03 14:17:27 +00:00
t.Logf("starting datamanager")
datamanager: fix linter errors Fix errors reported by default golangci-lint linters
2019-07-02 12:27:51 +00:00
go func() { _ = dm.Run(ctx, dmReadyCh) }()
wal: update and rename to datamanager * Rename to datamanager since it handles a complete "database" backed by an objectstorage and etcd * Don't write every single entry as a single file but group them in a single file. In future improve this to split the data in multiple files of a max size.
2019-04-26 14:00:03 +00:00
<-dmReadyCh
Add initial objectstorage wal manager
2019-02-22 07:45:59 +00:00
update wal and readdb
2019-04-01 10:54:43 +00:00
time.Sleep(5 * time.Second)
wal: update and rename to datamanager * Rename to datamanager since it handles a complete "database" backed by an objectstorage and etcd * Don't write every single entry as a single file but group them in a single file. In future improve this to split the data in multiple files of a max size.
2019-04-26 14:00:03 +00:00
for i := 0; i < 20; i++ {
objectID := fmt.Sprintf("object%02d", i)
_, _, err = dm.ReadObject("datatype01", objectID, nil)
if err != nil {
t.Fatalf("unexpected err: %v", err)
Add initial objectstorage wal manager
2019-02-22 07:45:59 +00:00
}
}
}
datamanager: check wal previouswalsequence is correct in initEtcd
2019-11-05 16:48:11 +00:00
func TestEtcdResetWalsGap(t *testing.T) {
test: use `T.TempDir` to create temporary test directory The directory created by `T.TempDir` is automatically removed when the test and all its subtests complete. Reference: https://pkg.go.dev/testing#T.TempDir Signed-off-by: Eng Zer Jun <engzerjun@gmail.com>
2022-03-01 05:57:39 +00:00
dir := t.TempDir()
*: use zerolog for logging Replace zap with zerolog. zerolog has a cleaner interface and can be easily configured with custom error chain printing using a new error handling library that will be implemented in another PR.
2022-02-21 17:07:58 +00:00
log := testutil.NewLogger(t)
tests: improve services logging During tests provide a zaptest Logger so all services output will be redirected to golang testing logger. When multiple services of the same type are provided add a unique name field to distinguish them.
2020-01-15 11:01:46 +00:00
datamanager: check wal previouswalsequence is correct in initEtcd
2019-11-05 16:48:11 +00:00
etcdDir, err := ioutil.TempDir(dir, "etcd")
if err != nil {
t.Fatalf("unexpected err: %v", err)
}
*: use zerolog for logging Replace zap with zerolog. zerolog has a cleaner interface and can be easily configured with custom error chain printing using a new error handling library that will be implemented in another PR.
2022-02-21 17:07:58 +00:00
tetcd := setupEtcd(t, log, etcdDir)
datamanager: check wal previouswalsequence is correct in initEtcd
2019-11-05 16:48:11 +00:00
ctx, cancel := context.WithCancel(context.Background())
ostDir, err := ioutil.TempDir(dir, "ost")
if err != nil {
t.Fatalf("unexpected err: %v", err)
}
objectstorage: use a single package remove all the subpackages and just use a single package
2019-11-08 15:25:53 +00:00
ost, err := objectstorage.NewPosix(ostDir)
datamanager: check wal previouswalsequence is correct in initEtcd
2019-11-05 16:48:11 +00:00
if err != nil {
t.Fatalf("unexpected err: %v", err)
}
dmConfig := &DataManagerConfig{
BasePath: "basepath",
E: tetcd.TestEtcd.Store,
OST: objectstorage.NewObjStorage(ost, "/"),
EtcdWalsKeepNum: 10,
DataTypes: []string{"datatype01"},
}
*: use zerolog for logging Replace zap with zerolog. zerolog has a cleaner interface and can be easily configured with custom error chain printing using a new error handling library that will be implemented in another PR.
2022-02-21 17:07:58 +00:00
dm, err := NewDataManager(ctx, log, dmConfig)
datamanager: check wal previouswalsequence is correct in initEtcd
2019-11-05 16:48:11 +00:00
if err != nil {
t.Fatalf("unexpected err: %v", err)
}
dmReadyCh := make(chan struct{})
t.Logf("starting datamanager")
go func() { _ = dm.Run(ctx, dmReadyCh) }()
<-dmReadyCh
actions := []*Action{
{
ActionType: ActionTypePut,
DataType: "datatype01",
Data: []byte("{}"),
},
}
for i := 0; i < 20; i++ {
objectID := fmt.Sprintf("object%02d", i)
actions[0].ID = objectID
if _, err := dm.WriteWal(ctx, actions, nil); err != nil {
t.Fatalf("unexpected err: %v", err)
}
}
// wait for wal to be committed storage
time.Sleep(5 * time.Second)
t.Logf("stopping datamanager")
cancel()
t.Logf("stopping etcd")
// Reset etcd
shutdownEtcd(tetcd)
datamanager tests: don't wait for etcd down It is causing some timeout errors since there can be another instance from another test run in parallel started on the same port.
2019-12-02 12:32:57 +00:00
datamanager: check wal previouswalsequence is correct in initEtcd
2019-11-05 16:48:11 +00:00
t.Logf("resetting etcd")
os.RemoveAll(etcdDir)
t.Logf("starting etcd")
*: use zerolog for logging Replace zap with zerolog. zerolog has a cleaner interface and can be easily configured with custom error chain printing using a new error handling library that will be implemented in another PR.
2022-02-21 17:07:58 +00:00
tetcd = setupEtcd(t, log, etcdDir)
datamanager: check wal previouswalsequence is correct in initEtcd
2019-11-05 16:48:11 +00:00
if err := tetcd.Start(); err != nil {
t.Fatalf("unexpected err: %v", err)
}
defer shutdownEtcd(tetcd)
// Remove a wal in the middle
doneCh := make(chan struct{})
defer close(doneCh)
walStatusFiles := []string{}
for object := range dm.ost.List(path.Join(dm.basePath, storageWalsStatusDir)+"/", "", true, doneCh) {
if object.Err != nil {
t.Fatalf("unexpected err: %v", err)
}
walStatusFiles = append(walStatusFiles, object.Path)
}
if len(walStatusFiles) < 20 {
t.Fatalf("exptected at least 20 wals, got: %d wals", len(walStatusFiles))
}
removeIndex := 10
if err := dm.ost.DeleteObject(walStatusFiles[removeIndex]); err != nil {
t.Fatalf("unexpected err: %v", err)
}
errorWalSequence := strings.TrimSuffix(path.Base(walStatusFiles[removeIndex+1]), path.Ext(walStatusFiles[removeIndex+1]))
prevWalSequence := strings.TrimSuffix(path.Base(walStatusFiles[removeIndex]), path.Ext(walStatusFiles[removeIndex]))
expectedPrevWalSequence := strings.TrimSuffix(path.Base(walStatusFiles[removeIndex-1]), path.Ext(walStatusFiles[removeIndex-1]))
ctx, cancel = context.WithCancel(context.Background())
defer cancel()
dmConfig = &DataManagerConfig{
BasePath: "basepath",
E: tetcd.TestEtcd.Store,
OST: objectstorage.NewObjStorage(ost, "/"),
EtcdWalsKeepNum: 10,
DataTypes: []string{"datatype01"},
}
*: use zerolog for logging Replace zap with zerolog. zerolog has a cleaner interface and can be easily configured with custom error chain printing using a new error handling library that will be implemented in another PR.
2022-02-21 17:07:58 +00:00
dm, err = NewDataManager(ctx, log, dmConfig)
datamanager: check wal previouswalsequence is correct in initEtcd
2019-11-05 16:48:11 +00:00
if err != nil {
t.Fatalf("unexpected err: %v", err)
}
dmReadyCh = make(chan struct{})
expectedErr := errors.Errorf("wal %q previousWalSequence %q is different than expected walSequence %q", errorWalSequence, prevWalSequence, expectedPrevWalSequence)
err = dm.InitEtcd(ctx, nil)
if err == nil {
t.Fatalf("expected err: %q, got nil error", expectedErr)
}
if expectedErr.Error() != err.Error() {
t.Fatalf("expected err: %q, got err %q", expectedErr, err)
}
}
Add initial objectstorage wal manager
2019-02-22 07:45:59 +00:00
func TestConcurrentUpdate(t *testing.T) {
test: use `T.TempDir` to create temporary test directory The directory created by `T.TempDir` is automatically removed when the test and all its subtests complete. Reference: https://pkg.go.dev/testing#T.TempDir Signed-off-by: Eng Zer Jun <engzerjun@gmail.com>
2022-03-01 05:57:39 +00:00
dir := t.TempDir()
*: use zerolog for logging Replace zap with zerolog. zerolog has a cleaner interface and can be easily configured with custom error chain printing using a new error handling library that will be implemented in another PR.
2022-02-21 17:07:58 +00:00
log := testutil.NewLogger(t)
tests: improve services logging During tests provide a zaptest Logger so all services output will be redirected to golang testing logger. When multiple services of the same type are provided add a unique name field to distinguish them.
2020-01-15 11:01:46 +00:00
Add initial objectstorage wal manager
2019-02-22 07:45:59 +00:00
etcdDir, err := ioutil.TempDir(dir, "etcd")
datamanager: fix linter errors Fix errors reported by default golangci-lint linters
2019-07-02 12:27:51 +00:00
if err != nil {
t.Fatalf("unexpected err: %v", err)
}
*: use zerolog for logging Replace zap with zerolog. zerolog has a cleaner interface and can be easily configured with custom error chain printing using a new error handling library that will be implemented in another PR.
2022-02-21 17:07:58 +00:00
tetcd := setupEtcd(t, log, etcdDir)
Add initial objectstorage wal manager
2019-02-22 07:45:59 +00:00
defer shutdownEtcd(tetcd)
ctx := context.Background()
*: rename "lts" to "ost" `lts` was choosen to reflect a "long term storage" but currently it's just an object storage implementation. So use this term and "ost" as its abbreviation (to not clash with "os").
2019-04-27 13:16:48 +00:00
ostDir, err := ioutil.TempDir(dir, "ost")
datamanager: fix linter errors Fix errors reported by default golangci-lint linters
2019-07-02 12:27:51 +00:00
if err != nil {
t.Fatalf("unexpected err: %v", err)
}
Add initial objectstorage wal manager
2019-02-22 07:45:59 +00:00
objectstorage: use a single package remove all the subpackages and just use a single package
2019-11-08 15:25:53 +00:00
ost, err := objectstorage.NewPosix(ostDir)
Add initial objectstorage wal manager
2019-02-22 07:45:59 +00:00
if err != nil {
t.Fatalf("unexpected err: %v", err)
}
wal: update and rename to datamanager * Rename to datamanager since it handles a complete "database" backed by an objectstorage and etcd * Don't write every single entry as a single file but group them in a single file. In future improve this to split the data in multiple files of a max size.
2019-04-26 14:00:03 +00:00
dmConfig := &DataManagerConfig{
Add initial objectstorage wal manager
2019-02-22 07:45:59 +00:00
E: tetcd.TestEtcd.Store,
*: rename "lts" to "ost" `lts` was choosen to reflect a "long term storage" but currently it's just an object storage implementation. So use this term and "ost" as its abbreviation (to not clash with "os").
2019-04-27 13:16:48 +00:00
OST: objectstorage.NewObjStorage(ost, "/"),
Add initial objectstorage wal manager
2019-02-22 07:45:59 +00:00
EtcdWalsKeepNum: 10,
wal: update and rename to datamanager * Rename to datamanager since it handles a complete "database" backed by an objectstorage and etcd * Don't write every single entry as a single file but group them in a single file. In future improve this to split the data in multiple files of a max size.
2019-04-26 14:00:03 +00:00
DataTypes: []string{"datatype01"},
Add initial objectstorage wal manager
2019-02-22 07:45:59 +00:00
}
*: use zerolog for logging Replace zap with zerolog. zerolog has a cleaner interface and can be easily configured with custom error chain printing using a new error handling library that will be implemented in another PR.
2022-02-21 17:07:58 +00:00
dm, err := NewDataManager(ctx, log, dmConfig)
datamanager: fix linter errors Fix errors reported by default golangci-lint linters
2019-07-02 12:27:51 +00:00
if err != nil {
t.Fatalf("unexpected err: %v", err)
}
Add initial objectstorage wal manager
2019-02-22 07:45:59 +00:00
actions := []*Action{
{
ActionType: ActionTypePut,
wal: update and rename to datamanager * Rename to datamanager since it handles a complete "database" backed by an objectstorage and etcd * Don't write every single entry as a single file but group them in a single file. In future improve this to split the data in multiple files of a max size.
2019-04-26 14:00:03 +00:00
ID: "object01",
DataType: "datatype01",
Add initial objectstorage wal manager
2019-02-22 07:45:59 +00:00
Data: []byte("{}"),
},
}
wal: update and rename to datamanager * Rename to datamanager since it handles a complete "database" backed by an objectstorage and etcd * Don't write every single entry as a single file but group them in a single file. In future improve this to split the data in multiple files of a max size.
2019-04-26 14:00:03 +00:00
dmReadyCh := make(chan struct{})
datamanager: fix linter errors Fix errors reported by default golangci-lint linters
2019-07-02 12:27:51 +00:00
go func() { _ = dm.Run(ctx, dmReadyCh) }()
wal: update and rename to datamanager * Rename to datamanager since it handles a complete "database" backed by an objectstorage and etcd * Don't write every single entry as a single file but group them in a single file. In future improve this to split the data in multiple files of a max size.
2019-04-26 14:00:03 +00:00
<-dmReadyCh
Add initial objectstorage wal manager
2019-02-22 07:45:59 +00:00
update wal and readdb
2019-04-01 10:54:43 +00:00
time.Sleep(5 * time.Second)
Add initial objectstorage wal manager
2019-02-22 07:45:59 +00:00
cgNames := []string{"changegroup01", "changegroup02"}
wal: update and rename to datamanager * Rename to datamanager since it handles a complete "database" backed by an objectstorage and etcd * Don't write every single entry as a single file but group them in a single file. In future improve this to split the data in multiple files of a max size.
2019-04-26 14:00:03 +00:00
cgt, err := dm.GetChangeGroupsUpdateToken(cgNames)
wal: return error when changes isn't initialized
2019-03-28 15:01:08 +00:00
if err != nil {
t.Fatalf("unexpected err: %v", err)
}
Add initial objectstorage wal manager
2019-02-22 07:45:59 +00:00
// populate with a wal
wal: update and rename to datamanager * Rename to datamanager since it handles a complete "database" backed by an objectstorage and etcd * Don't write every single entry as a single file but group them in a single file. In future improve this to split the data in multiple files of a max size.
2019-04-26 14:00:03 +00:00
cgt, err = dm.WriteWal(ctx, actions, cgt)
Add initial objectstorage wal manager
2019-02-22 07:45:59 +00:00
if err != nil {
wal: return error when changes isn't initialized
2019-03-28 15:01:08 +00:00
t.Fatalf("unexpected err: %v", err)
Add initial objectstorage wal manager
2019-02-22 07:45:59 +00:00
}
// this must work successfully
oldcgt := cgt
wal: update and rename to datamanager * Rename to datamanager since it handles a complete "database" backed by an objectstorage and etcd * Don't write every single entry as a single file but group them in a single file. In future improve this to split the data in multiple files of a max size.
2019-04-26 14:00:03 +00:00
cgt, err = dm.WriteWal(ctx, actions, cgt)
Add initial objectstorage wal manager
2019-02-22 07:45:59 +00:00
if err != nil {
wal: return error when changes isn't initialized
2019-03-28 15:01:08 +00:00
t.Fatalf("unexpected err: %v", err)
Add initial objectstorage wal manager
2019-02-22 07:45:59 +00:00
}
// this must fail since we are using the old cgt
wal: update and rename to datamanager * Rename to datamanager since it handles a complete "database" backed by an objectstorage and etcd * Don't write every single entry as a single file but group them in a single file. In future improve this to split the data in multiple files of a max size.
2019-04-26 14:00:03 +00:00
_, err = dm.WriteWal(ctx, actions, oldcgt)
*: use errors.Is/errors.As to handle wrapped error checking Enable golangci-lint errorlint linter to check proper use of errors.Is and error.As instead of direct comparison or error type casting.
2022-02-24 11:56:52 +00:00
if !errors.Is(err, ErrConcurrency) {
Add initial objectstorage wal manager
2019-02-22 07:45:59 +00:00
t.Fatalf("expected err: %v, got %v", ErrConcurrency, err)
}
oldcgt = cgt
// this must work successfully
datamanager: fix linter errors Fix errors reported by default golangci-lint linters
2019-07-02 12:27:51 +00:00
_, err = dm.WriteWal(ctx, actions, cgt)
Add initial objectstorage wal manager
2019-02-22 07:45:59 +00:00
if err != nil {
wal: return error when changes isn't initialized
2019-03-28 15:01:08 +00:00
t.Fatalf("unexpected err: %v", err)
Add initial objectstorage wal manager
2019-02-22 07:45:59 +00:00
}
// this must fail since we are using the old cgt
wal: update and rename to datamanager * Rename to datamanager since it handles a complete "database" backed by an objectstorage and etcd * Don't write every single entry as a single file but group them in a single file. In future improve this to split the data in multiple files of a max size.
2019-04-26 14:00:03 +00:00
_, err = dm.WriteWal(ctx, actions, oldcgt)
*: use errors.Is/errors.As to handle wrapped error checking Enable golangci-lint errorlint linter to check proper use of errors.Is and error.As instead of direct comparison or error type casting.
2022-02-24 11:56:52 +00:00
if !errors.Is(err, ErrConcurrency) {
Add initial objectstorage wal manager
2019-02-22 07:45:59 +00:00
t.Fatalf("expected err: %v, got %v", ErrConcurrency, err)
}
}
datamanager: remove old storage wals Remove all wals not required by the existing data status files and not existing in etcd.
2019-11-08 09:10:56 +00:00
func TestEtcdWalCleaner(t *testing.T) {
test: use `T.TempDir` to create temporary test directory The directory created by `T.TempDir` is automatically removed when the test and all its subtests complete. Reference: https://pkg.go.dev/testing#T.TempDir Signed-off-by: Eng Zer Jun <engzerjun@gmail.com>
2022-03-01 05:57:39 +00:00
dir := t.TempDir()
*: use zerolog for logging Replace zap with zerolog. zerolog has a cleaner interface and can be easily configured with custom error chain printing using a new error handling library that will be implemented in another PR.
2022-02-21 17:07:58 +00:00
log := testutil.NewLogger(t)
tests: improve services logging During tests provide a zaptest Logger so all services output will be redirected to golang testing logger. When multiple services of the same type are provided add a unique name field to distinguish them.
2020-01-15 11:01:46 +00:00
Add initial objectstorage wal manager
2019-02-22 07:45:59 +00:00
etcdDir, err := ioutil.TempDir(dir, "etcd")
datamanager: fix linter errors Fix errors reported by default golangci-lint linters
2019-07-02 12:27:51 +00:00
if err != nil {
t.Fatalf("unexpected err: %v", err)
}
*: use zerolog for logging Replace zap with zerolog. zerolog has a cleaner interface and can be easily configured with custom error chain printing using a new error handling library that will be implemented in another PR.
2022-02-21 17:07:58 +00:00
tetcd := setupEtcd(t, log, etcdDir)
Add initial objectstorage wal manager
2019-02-22 07:45:59 +00:00
defer shutdownEtcd(tetcd)
ctx := context.Background()
*: rename "lts" to "ost" `lts` was choosen to reflect a "long term storage" but currently it's just an object storage implementation. So use this term and "ost" as its abbreviation (to not clash with "os").
2019-04-27 13:16:48 +00:00
ostDir, err := ioutil.TempDir(dir, "ost")
datamanager: fix linter errors Fix errors reported by default golangci-lint linters
2019-07-02 12:27:51 +00:00
if err != nil {
t.Fatalf("unexpected err: %v", err)
}
Add initial objectstorage wal manager
2019-02-22 07:45:59 +00:00
objectstorage: use a single package remove all the subpackages and just use a single package
2019-11-08 15:25:53 +00:00
ost, err := objectstorage.NewPosix(ostDir)
Add initial objectstorage wal manager
2019-02-22 07:45:59 +00:00
if err != nil {
t.Fatalf("unexpected err: %v", err)
}
walKeepNum := 10
wal: update and rename to datamanager * Rename to datamanager since it handles a complete "database" backed by an objectstorage and etcd * Don't write every single entry as a single file but group them in a single file. In future improve this to split the data in multiple files of a max size.
2019-04-26 14:00:03 +00:00
dmConfig := &DataManagerConfig{
E: tetcd.TestEtcd.Store,
OST: objectstorage.NewObjStorage(ost, "/"),
EtcdWalsKeepNum: walKeepNum,
DataTypes: []string{"datatype01"},
MinCheckpointWalsNum: 1,
Add initial objectstorage wal manager
2019-02-22 07:45:59 +00:00
}
*: use zerolog for logging Replace zap with zerolog. zerolog has a cleaner interface and can be easily configured with custom error chain printing using a new error handling library that will be implemented in another PR.
2022-02-21 17:07:58 +00:00
dm, err := NewDataManager(ctx, log, dmConfig)
datamanager: fix linter errors Fix errors reported by default golangci-lint linters
2019-07-02 12:27:51 +00:00
if err != nil {
t.Fatalf("unexpected err: %v", err)
}
Add initial objectstorage wal manager
2019-02-22 07:45:59 +00:00
actions := []*Action{
{
ActionType: ActionTypePut,
wal: update and rename to datamanager * Rename to datamanager since it handles a complete "database" backed by an objectstorage and etcd * Don't write every single entry as a single file but group them in a single file. In future improve this to split the data in multiple files of a max size.
2019-04-26 14:00:03 +00:00
ID: "object01",
DataType: "datatype01",
Add initial objectstorage wal manager
2019-02-22 07:45:59 +00:00
Data: []byte("{}"),
},
}
wal: update and rename to datamanager * Rename to datamanager since it handles a complete "database" backed by an objectstorage and etcd * Don't write every single entry as a single file but group them in a single file. In future improve this to split the data in multiple files of a max size.
2019-04-26 14:00:03 +00:00
dmReadyCh := make(chan struct{})
datamanager: fix linter errors Fix errors reported by default golangci-lint linters
2019-07-02 12:27:51 +00:00
go func() { _ = dm.Run(ctx, dmReadyCh) }()
wal: update and rename to datamanager * Rename to datamanager since it handles a complete "database" backed by an objectstorage and etcd * Don't write every single entry as a single file but group them in a single file. In future improve this to split the data in multiple files of a max size.
2019-04-26 14:00:03 +00:00
<-dmReadyCh
Add initial objectstorage wal manager
2019-02-22 07:45:59 +00:00
for i := 0; i < 20; i++ {
wal: update and rename to datamanager * Rename to datamanager since it handles a complete "database" backed by an objectstorage and etcd * Don't write every single entry as a single file but group them in a single file. In future improve this to split the data in multiple files of a max size.
2019-04-26 14:00:03 +00:00
if _, err := dm.WriteWal(ctx, actions, nil); err != nil {
Add initial objectstorage wal manager
2019-02-22 07:45:59 +00:00
t.Fatalf("unexpected err: %v", err)
}
}
datamanager: add option to force a checkpoint
2019-07-18 12:58:42 +00:00
if err := dm.checkpoint(ctx, true); err != nil {
datamanager: implement data files splitting split data files in multiple files of a max size (default 10Mib) In this way every data snapshot will change only the datafiles that have some changes instead of the whole single file.
2019-06-03 14:17:27 +00:00
t.Fatalf("unexpected err: %v", err)
}
datamanager: remove old storage wals Remove all wals not required by the existing data status files and not existing in etcd.
2019-11-08 09:10:56 +00:00
if err := dm.etcdWalCleaner(ctx); err != nil {
datamanager: implement data files splitting split data files in multiple files of a max size (default 10Mib) In this way every data snapshot will change only the datafiles that have some changes instead of the whole single file.
2019-06-03 14:17:27 +00:00
t.Fatalf("unexpected err: %v", err)
}
Add initial objectstorage wal manager
2019-02-22 07:45:59 +00:00
walsCount := 0
wal: update and rename to datamanager * Rename to datamanager since it handles a complete "database" backed by an objectstorage and etcd * Don't write every single entry as a single file but group them in a single file. In future improve this to split the data in multiple files of a max size.
2019-04-26 14:00:03 +00:00
for range dm.ListEtcdWals(ctx, 0) {
Add initial objectstorage wal manager
2019-02-22 07:45:59 +00:00
walsCount++
}
if walsCount != walKeepNum {
t.Fatalf("expected %d wals in etcd, got %d wals", walKeepNum, walsCount)
}
}
wal: update and rename to datamanager * Rename to datamanager since it handles a complete "database" backed by an objectstorage and etcd * Don't write every single entry as a single file but group them in a single file. In future improve this to split the data in multiple files of a max size.
2019-04-26 14:00:03 +00:00
func TestReadObject(t *testing.T) {
test: use `T.TempDir` to create temporary test directory The directory created by `T.TempDir` is automatically removed when the test and all its subtests complete. Reference: https://pkg.go.dev/testing#T.TempDir Signed-off-by: Eng Zer Jun <engzerjun@gmail.com>
2022-03-01 05:57:39 +00:00
dir := t.TempDir()
*: use zerolog for logging Replace zap with zerolog. zerolog has a cleaner interface and can be easily configured with custom error chain printing using a new error handling library that will be implemented in another PR.
2022-02-21 17:07:58 +00:00
log := testutil.NewLogger(t)
tests: improve services logging During tests provide a zaptest Logger so all services output will be redirected to golang testing logger. When multiple services of the same type are provided add a unique name field to distinguish them.
2020-01-15 11:01:46 +00:00
wal: update and rename to datamanager * Rename to datamanager since it handles a complete "database" backed by an objectstorage and etcd * Don't write every single entry as a single file but group them in a single file. In future improve this to split the data in multiple files of a max size.
2019-04-26 14:00:03 +00:00
etcdDir, err := ioutil.TempDir(dir, "etcd")
datamanager: fix linter errors Fix errors reported by default golangci-lint linters
2019-07-02 12:27:51 +00:00
if err != nil {
t.Fatalf("unexpected err: %v", err)
}
*: use zerolog for logging Replace zap with zerolog. zerolog has a cleaner interface and can be easily configured with custom error chain printing using a new error handling library that will be implemented in another PR.
2022-02-21 17:07:58 +00:00
tetcd := setupEtcd(t, log, etcdDir)
wal: update and rename to datamanager * Rename to datamanager since it handles a complete "database" backed by an objectstorage and etcd * Don't write every single entry as a single file but group them in a single file. In future improve this to split the data in multiple files of a max size.
2019-04-26 14:00:03 +00:00
defer shutdownEtcd(tetcd)
ctx := context.Background()
ostDir, err := ioutil.TempDir(dir, "ost")
datamanager: fix linter errors Fix errors reported by default golangci-lint linters
2019-07-02 12:27:51 +00:00
if err != nil {
t.Fatalf("unexpected err: %v", err)
}
objectstorage: use a single package remove all the subpackages and just use a single package
2019-11-08 15:25:53 +00:00
ost, err := objectstorage.NewPosix(ostDir)
wal: update and rename to datamanager * Rename to datamanager since it handles a complete "database" backed by an objectstorage and etcd * Don't write every single entry as a single file but group them in a single file. In future improve this to split the data in multiple files of a max size.
2019-04-26 14:00:03 +00:00
if err != nil {
t.Fatalf("unexpected err: %v", err)
}
dmConfig := &DataManagerConfig{
E: tetcd.TestEtcd.Store,
OST: objectstorage.NewObjStorage(ost, "/"),
// remove almost all wals to see that they are removed also from changes
EtcdWalsKeepNum: 1,
DataTypes: []string{"datatype01"},
}
*: use zerolog for logging Replace zap with zerolog. zerolog has a cleaner interface and can be easily configured with custom error chain printing using a new error handling library that will be implemented in another PR.
2022-02-21 17:07:58 +00:00
dm, err := NewDataManager(ctx, log, dmConfig)
datamanager: fix linter errors Fix errors reported by default golangci-lint linters
2019-07-02 12:27:51 +00:00
if err != nil {
t.Fatalf("unexpected err: %v", err)
}
wal: update and rename to datamanager * Rename to datamanager since it handles a complete "database" backed by an objectstorage and etcd * Don't write every single entry as a single file but group them in a single file. In future improve this to split the data in multiple files of a max size.
2019-04-26 14:00:03 +00:00
datamanager: implement data files splitting split data files in multiple files of a max size (default 10Mib) In this way every data snapshot will change only the datafiles that have some changes instead of the whole single file.
2019-06-03 14:17:27 +00:00
dmReadyCh := make(chan struct{})
datamanager: fix linter errors Fix errors reported by default golangci-lint linters
2019-07-02 12:27:51 +00:00
go func() { _ = dm.Run(ctx, dmReadyCh) }()
datamanager: implement data files splitting split data files in multiple files of a max size (default 10Mib) In this way every data snapshot will change only the datafiles that have some changes instead of the whole single file.
2019-06-03 14:17:27 +00:00
<-dmReadyCh
time.Sleep(5 * time.Second)
wal: update and rename to datamanager * Rename to datamanager since it handles a complete "database" backed by an objectstorage and etcd * Don't write every single entry as a single file but group them in a single file. In future improve this to split the data in multiple files of a max size.
2019-04-26 14:00:03 +00:00
actions := []*Action{}
for i := 0; i < 20; i++ {
actions = append(actions, &Action{
ActionType: ActionTypePut,
ID: fmt.Sprintf("object%d", i),
DataType: "datatype01",
Data: []byte(fmt.Sprintf(`{ "ID": "%d" }`, i)),
})
}
// populate with a wal
_, err = dm.WriteWal(ctx, actions, nil)
if err != nil {
t.Fatalf("unexpected err: %v", err)
}
// wait for the event to be read
time.Sleep(500 * time.Millisecond)
// should read it
_, _, err = dm.ReadObject("datatype01", "object1", nil)
if err != nil {
t.Fatalf("unexpected err: %v", err)
}
_, _, err = dm.ReadObject("datatype01", "object19", nil)
if err != nil {
t.Fatalf("unexpected err: %v", err)
}
actions = []*Action{}
for i := 0; i < 10; i++ {
actions = append(actions, &Action{
ActionType: ActionTypeDelete,
ID: fmt.Sprintf("object%d", i),
DataType: "datatype01",
})
}
_, err = dm.WriteWal(ctx, actions, nil)
if err != nil {
t.Fatalf("unexpected err: %v", err)
}
// wait for the event to be read
time.Sleep(500 * time.Millisecond)
// test read from changes (since not checkpoint yet)
// should not exists
_, _, err = dm.ReadObject("datatype01", "object1", nil)
*: Improve error handling * Create an APIError that should only be used for api returned errors. It'll wrap an error and can have different Kinds and optional code and message. * The http handlers will use the first APIError available in the error chain and generate a json response body containing the code and the user message. The wrapped error is internal and is not sent in the response. If no api error is available in the chain a generic internal server error will be returned. * Add a RemoteError type that will be created from remote services calls (runservice, configstore). It's similar to the APIError but a different type to not propagate to the caller response and it'll not contain any wrapped error. * Gateway: when we call a remote service, by default, we'll create a APIError using the RemoteError Kind (omitting the code and the message that usually must not be propagated). This is done for all the remote service calls as a starting point, in future, if this default behavior is not the right one for a specific remote service call, a new api error with a different kind and/or augmented with the calling service error codes and user messages could be created. * datamanager: Use a dedicated ErrNotExist (and converting objectstorage ErrNotExist).
2022-02-21 11:19:55 +00:00
if !IsNotExist(err) {
t.Fatalf("expected not exist error, got: %v", err)
wal: update and rename to datamanager * Rename to datamanager since it handles a complete "database" backed by an objectstorage and etcd * Don't write every single entry as a single file but group them in a single file. In future improve this to split the data in multiple files of a max size.
2019-04-26 14:00:03 +00:00
}
// should exist
_, _, err = dm.ReadObject("datatype01", "object19", nil)
if err != nil {
t.Fatalf("unexpected err: %v", err)
}
// do a checkpoint and wal clean
datamanager: add option to force a checkpoint
2019-07-18 12:58:42 +00:00
if err := dm.checkpoint(ctx, true); err != nil {
datamanager: implement data files splitting split data files in multiple files of a max size (default 10Mib) In this way every data snapshot will change only the datafiles that have some changes instead of the whole single file.
2019-06-03 14:17:27 +00:00
t.Fatalf("unexpected err: %v", err)
}
datamanager: remove old storage wals Remove all wals not required by the existing data status files and not existing in etcd.
2019-11-08 09:10:56 +00:00
if err := dm.etcdWalCleaner(ctx); err != nil {
datamanager: implement data files splitting split data files in multiple files of a max size (default 10Mib) In this way every data snapshot will change only the datafiles that have some changes instead of the whole single file.
2019-06-03 14:17:27 +00:00
t.Fatalf("unexpected err: %v", err)
}
wal: update and rename to datamanager * Rename to datamanager since it handles a complete "database" backed by an objectstorage and etcd * Don't write every single entry as a single file but group them in a single file. In future improve this to split the data in multiple files of a max size.
2019-04-26 14:00:03 +00:00
// wait for the event to be read
time.Sleep(500 * time.Millisecond)
// test read from data
// should not exists
_, _, err = dm.ReadObject("datatype01", "object1", nil)
*: Improve error handling * Create an APIError that should only be used for api returned errors. It'll wrap an error and can have different Kinds and optional code and message. * The http handlers will use the first APIError available in the error chain and generate a json response body containing the code and the user message. The wrapped error is internal and is not sent in the response. If no api error is available in the chain a generic internal server error will be returned. * Add a RemoteError type that will be created from remote services calls (runservice, configstore). It's similar to the APIError but a different type to not propagate to the caller response and it'll not contain any wrapped error. * Gateway: when we call a remote service, by default, we'll create a APIError using the RemoteError Kind (omitting the code and the message that usually must not be propagated). This is done for all the remote service calls as a starting point, in future, if this default behavior is not the right one for a specific remote service call, a new api error with a different kind and/or augmented with the calling service error codes and user messages could be created. * datamanager: Use a dedicated ErrNotExist (and converting objectstorage ErrNotExist).
2022-02-21 11:19:55 +00:00
if !IsNotExist(err) {
t.Fatalf("expected not exist error, got: %v", err)
wal: update and rename to datamanager * Rename to datamanager since it handles a complete "database" backed by an objectstorage and etcd * Don't write every single entry as a single file but group them in a single file. In future improve this to split the data in multiple files of a max size.
2019-04-26 14:00:03 +00:00
}
// should exist
_, _, err = dm.ReadObject("datatype01", "object19", nil)
if err != nil {
t.Fatalf("unexpected err: %v", err)
}
}
datamanager: implement data files splitting split data files in multiple files of a max size (default 10Mib) In this way every data snapshot will change only the datafiles that have some changes instead of the whole single file.
2019-06-03 14:17:27 +00:00
datamanager: always handle basepath Currently we aren't setting a basepath and it wasn't always correctly handled. Fix missing basepath handling and improve tests to also use a non empty basepath.
2019-07-03 15:03:37 +00:00
func doAndCheckCheckpoint(t *testing.T, ctx context.Context, dm *DataManager, actionGroups [][]*Action, currentEntries map[string]*DataEntry) (map[string]*DataEntry, error) {
datamanager: implement data files splitting split data files in multiple files of a max size (default 10Mib) In this way every data snapshot will change only the datafiles that have some changes instead of the whole single file.
2019-06-03 14:17:27 +00:00
expectedEntries := map[string]*DataEntry{}
for _, e := range currentEntries {
expectedEntries[e.ID] = e
}
for _, actionGroup := range actionGroups {
for _, action := range actionGroup {
switch action.ActionType {
case ActionTypePut:
expectedEntries[action.ID] = &DataEntry{ID: action.ID, DataType: action.DataType, Data: action.Data}
case ActionTypeDelete:
delete(expectedEntries, action.ID)
}
}
}
for _, actionGroup := range actionGroups {
// populate with a wal
_, err := dm.WriteWal(ctx, actionGroup, nil)
if err != nil {
*: use new errors handling library Implement a new error handling library based on pkg/errors. It provides stack saving on wrapping and exports some function to add stack saving also to external errors. It also implements custom zerolog error formatting without adding too much verbosity by just printing the chain error file:line without a full stack trace of every error. * Add a --detailed-errors options to print error with they full chain * Wrap all error returns. Use errors.WithStack to wrap without adding a new messsage and error.Wrap[f] to add a message. * Add golangci-lint wrapcheck to check that external packages errors are wrapped. This won't check that internal packages error are wrapped. But we want also to ensure this case so we'll have to find something else to check also these.
2022-02-22 14:01:29 +00:00
return nil, errors.WithStack(err)
datamanager: implement data files splitting split data files in multiple files of a max size (default 10Mib) In this way every data snapshot will change only the datafiles that have some changes instead of the whole single file.
2019-06-03 14:17:27 +00:00
}
}
// wait for the event to be read
time.Sleep(500 * time.Millisecond)
// do a checkpoint
datamanager: add option to force a checkpoint
2019-07-18 12:58:42 +00:00
if err := dm.checkpoint(ctx, true); err != nil {
*: use new errors handling library Implement a new error handling library based on pkg/errors. It provides stack saving on wrapping and exports some function to add stack saving also to external errors. It also implements custom zerolog error formatting without adding too much verbosity by just printing the chain error file:line without a full stack trace of every error. * Add a --detailed-errors options to print error with they full chain * Wrap all error returns. Use errors.WithStack to wrap without adding a new messsage and error.Wrap[f] to add a message. * Add golangci-lint wrapcheck to check that external packages errors are wrapped. This won't check that internal packages error are wrapped. But we want also to ensure this case so we'll have to find something else to check also these.
2022-02-22 14:01:29 +00:00
return nil, errors.WithStack(err)
datamanager: implement data files splitting split data files in multiple files of a max size (default 10Mib) In this way every data snapshot will change only the datafiles that have some changes instead of the whole single file.
2019-06-03 14:17:27 +00:00
}
if err := checkDataFiles(ctx, t, dm, expectedEntries); err != nil {
*: use new errors handling library Implement a new error handling library based on pkg/errors. It provides stack saving on wrapping and exports some function to add stack saving also to external errors. It also implements custom zerolog error formatting without adding too much verbosity by just printing the chain error file:line without a full stack trace of every error. * Add a --detailed-errors options to print error with they full chain * Wrap all error returns. Use errors.WithStack to wrap without adding a new messsage and error.Wrap[f] to add a message. * Add golangci-lint wrapcheck to check that external packages errors are wrapped. This won't check that internal packages error are wrapped. But we want also to ensure this case so we'll have to find something else to check also these.
2022-02-22 14:01:29 +00:00
return nil, errors.WithStack(err)
datamanager: implement data files splitting split data files in multiple files of a max size (default 10Mib) In this way every data snapshot will change only the datafiles that have some changes instead of the whole single file.
2019-06-03 14:17:27 +00:00
}
return expectedEntries, nil
}
datamanager: clean old data files keep the last n (now set to 3) data status files and remove all other data status files and unneeded data files.
2019-10-29 12:23:42 +00:00
func checkDataFiles(ctx context.Context, t *testing.T, dm *DataManager, expectedEntriesMap map[string]*DataEntry) error {
// read the data file
curDataStatus, err := dm.GetLastDataStatus()
if err != nil {
*: use new errors handling library Implement a new error handling library based on pkg/errors. It provides stack saving on wrapping and exports some function to add stack saving also to external errors. It also implements custom zerolog error formatting without adding too much verbosity by just printing the chain error file:line without a full stack trace of every error. * Add a --detailed-errors options to print error with they full chain * Wrap all error returns. Use errors.WithStack to wrap without adding a new messsage and error.Wrap[f] to add a message. * Add golangci-lint wrapcheck to check that external packages errors are wrapped. This won't check that internal packages error are wrapped. But we want also to ensure this case so we'll have to find something else to check also these.
2022-02-22 14:01:29 +00:00
return errors.WithStack(err)
datamanager: clean old data files keep the last n (now set to 3) data status files and remove all other data status files and unneeded data files.
2019-10-29 12:23:42 +00:00
}
allEntriesMap := map[string]*DataEntry{}
for dataType := range curDataStatus.Files {
var prevLastEntryID string
for i, file := range curDataStatus.Files[dataType] {
dataFileIndexf, err := dm.ost.ReadObject(dm.DataFileIndexPath(dataType, file.ID))
if err != nil {
*: use new errors handling library Implement a new error handling library based on pkg/errors. It provides stack saving on wrapping and exports some function to add stack saving also to external errors. It also implements custom zerolog error formatting without adding too much verbosity by just printing the chain error file:line without a full stack trace of every error. * Add a --detailed-errors options to print error with they full chain * Wrap all error returns. Use errors.WithStack to wrap without adding a new messsage and error.Wrap[f] to add a message. * Add golangci-lint wrapcheck to check that external packages errors are wrapped. This won't check that internal packages error are wrapped. But we want also to ensure this case so we'll have to find something else to check also these.
2022-02-22 14:01:29 +00:00
return errors.WithStack(err)
datamanager: clean old data files keep the last n (now set to 3) data status files and remove all other data status files and unneeded data files.
2019-10-29 12:23:42 +00:00
}
var dataFileIndex *DataFileIndex
dec := json.NewDecoder(dataFileIndexf)
err = dec.Decode(&dataFileIndex)
if err != nil {
dataFileIndexf.Close()
*: use new errors handling library Implement a new error handling library based on pkg/errors. It provides stack saving on wrapping and exports some function to add stack saving also to external errors. It also implements custom zerolog error formatting without adding too much verbosity by just printing the chain error file:line without a full stack trace of every error. * Add a --detailed-errors options to print error with they full chain * Wrap all error returns. Use errors.WithStack to wrap without adding a new messsage and error.Wrap[f] to add a message. * Add golangci-lint wrapcheck to check that external packages errors are wrapped. This won't check that internal packages error are wrapped. But we want also to ensure this case so we'll have to find something else to check also these.
2022-02-22 14:01:29 +00:00
return errors.WithStack(err)
datamanager: clean old data files keep the last n (now set to 3) data status files and remove all other data status files and unneeded data files.
2019-10-29 12:23:42 +00:00
}
dataFileIndexf.Close()
dataEntriesMap := map[string]*DataEntry{}
dataEntries := []*DataEntry{}
dataf, err := dm.ost.ReadObject(dm.DataFilePath(dataType, file.ID))
if err != nil {
*: use new errors handling library Implement a new error handling library based on pkg/errors. It provides stack saving on wrapping and exports some function to add stack saving also to external errors. It also implements custom zerolog error formatting without adding too much verbosity by just printing the chain error file:line without a full stack trace of every error. * Add a --detailed-errors options to print error with they full chain * Wrap all error returns. Use errors.WithStack to wrap without adding a new messsage and error.Wrap[f] to add a message. * Add golangci-lint wrapcheck to check that external packages errors are wrapped. This won't check that internal packages error are wrapped. But we want also to ensure this case so we'll have to find something else to check also these.
2022-02-22 14:01:29 +00:00
return errors.WithStack(err)
datamanager: clean old data files keep the last n (now set to 3) data status files and remove all other data status files and unneeded data files.
2019-10-29 12:23:42 +00:00
}
dec = json.NewDecoder(dataf)
var prevEntryID string
for {
var de *DataEntry
err := dec.Decode(&de)
*: use errors.Is/errors.As to handle wrapped error checking Enable golangci-lint errorlint linter to check proper use of errors.Is and error.As instead of direct comparison or error type casting.
2022-02-24 11:56:52 +00:00
if errors.Is(err, io.EOF) {
datamanager: clean old data files keep the last n (now set to 3) data status files and remove all other data status files and unneeded data files.
2019-10-29 12:23:42 +00:00
// all done
break
}
if err != nil {
dataf.Close()
*: use new errors handling library Implement a new error handling library based on pkg/errors. It provides stack saving on wrapping and exports some function to add stack saving also to external errors. It also implements custom zerolog error formatting without adding too much verbosity by just printing the chain error file:line without a full stack trace of every error. * Add a --detailed-errors options to print error with they full chain * Wrap all error returns. Use errors.WithStack to wrap without adding a new messsage and error.Wrap[f] to add a message. * Add golangci-lint wrapcheck to check that external packages errors are wrapped. This won't check that internal packages error are wrapped. But we want also to ensure this case so we'll have to find something else to check also these.
2022-02-22 14:01:29 +00:00
return errors.WithStack(err)
datamanager: clean old data files keep the last n (now set to 3) data status files and remove all other data status files and unneeded data files.
2019-10-29 12:23:42 +00:00
}
// check that there are no duplicate entries
if _, ok := allEntriesMap[de.ID]; ok {
*: use new errors handling library Implement a new error handling library based on pkg/errors. It provides stack saving on wrapping and exports some function to add stack saving also to external errors. It also implements custom zerolog error formatting without adding too much verbosity by just printing the chain error file:line without a full stack trace of every error. * Add a --detailed-errors options to print error with they full chain * Wrap all error returns. Use errors.WithStack to wrap without adding a new messsage and error.Wrap[f] to add a message. * Add golangci-lint wrapcheck to check that external packages errors are wrapped. This won't check that internal packages error are wrapped. But we want also to ensure this case so we'll have to find something else to check also these.
2022-02-22 14:01:29 +00:00
return errors.Errorf("duplicate entry id: %s", de.ID)
datamanager: clean old data files keep the last n (now set to 3) data status files and remove all other data status files and unneeded data files.
2019-10-29 12:23:42 +00:00
}
// check that the entries are in order
if de.ID < prevEntryID {
*: use new errors handling library Implement a new error handling library based on pkg/errors. It provides stack saving on wrapping and exports some function to add stack saving also to external errors. It also implements custom zerolog error formatting without adding too much verbosity by just printing the chain error file:line without a full stack trace of every error. * Add a --detailed-errors options to print error with they full chain * Wrap all error returns. Use errors.WithStack to wrap without adding a new messsage and error.Wrap[f] to add a message. * Add golangci-lint wrapcheck to check that external packages errors are wrapped. This won't check that internal packages error are wrapped. But we want also to ensure this case so we'll have to find something else to check also these.
2022-02-22 14:01:29 +00:00
return errors.Errorf("previous entry id: %s greater than entry id: %s", prevEntryID, de.ID)
datamanager: clean old data files keep the last n (now set to 3) data status files and remove all other data status files and unneeded data files.
2019-10-29 12:23:42 +00:00
}
dataEntriesMap[de.ID] = de
dataEntries = append(dataEntries, de)
allEntriesMap[de.ID] = de
}
dataf.Close()
// check that the index matches the entries
if len(dataFileIndex.Index) != len(dataEntriesMap) {
*: use new errors handling library Implement a new error handling library based on pkg/errors. It provides stack saving on wrapping and exports some function to add stack saving also to external errors. It also implements custom zerolog error formatting without adding too much verbosity by just printing the chain error file:line without a full stack trace of every error. * Add a --detailed-errors options to print error with they full chain * Wrap all error returns. Use errors.WithStack to wrap without adding a new messsage and error.Wrap[f] to add a message. * Add golangci-lint wrapcheck to check that external packages errors are wrapped. This won't check that internal packages error are wrapped. But we want also to ensure this case so we'll have to find something else to check also these.
2022-02-22 14:01:29 +00:00
return errors.Errorf("index entries: %d different than data entries: %d", len(dataFileIndex.Index), len(dataEntriesMap))
datamanager: clean old data files keep the last n (now set to 3) data status files and remove all other data status files and unneeded data files.
2019-10-29 12:23:42 +00:00
}
indexIDs := make([]string, len(dataFileIndex.Index))
entriesIDs := make([]string, len(dataEntriesMap))
for id := range dataFileIndex.Index {
indexIDs = append(indexIDs, id)
}
for id := range dataEntriesMap {
entriesIDs = append(entriesIDs, id)
}
sort.Strings(indexIDs)
sort.Strings(entriesIDs)
if !reflect.DeepEqual(indexIDs, entriesIDs) {
*: use new errors handling library Implement a new error handling library based on pkg/errors. It provides stack saving on wrapping and exports some function to add stack saving also to external errors. It also implements custom zerolog error formatting without adding too much verbosity by just printing the chain error file:line without a full stack trace of every error. * Add a --detailed-errors options to print error with they full chain * Wrap all error returns. Use errors.WithStack to wrap without adding a new messsage and error.Wrap[f] to add a message. * Add golangci-lint wrapcheck to check that external packages errors are wrapped. This won't check that internal packages error are wrapped. But we want also to ensure this case so we'll have to find something else to check also these.
2022-02-22 14:01:29 +00:00
return errors.Errorf("index entries ids don't match data entries ids: index: %v, data: %v", indexIDs, entriesIDs)
datamanager: clean old data files keep the last n (now set to 3) data status files and remove all other data status files and unneeded data files.
2019-10-29 12:23:42 +00:00
}
if file.LastEntryID != dataEntries[len(dataEntries)-1].ID {
*: use new errors handling library Implement a new error handling library based on pkg/errors. It provides stack saving on wrapping and exports some function to add stack saving also to external errors. It also implements custom zerolog error formatting without adding too much verbosity by just printing the chain error file:line without a full stack trace of every error. * Add a --detailed-errors options to print error with they full chain * Wrap all error returns. Use errors.WithStack to wrap without adding a new messsage and error.Wrap[f] to add a message. * Add golangci-lint wrapcheck to check that external packages errors are wrapped. This won't check that internal packages error are wrapped. But we want also to ensure this case so we'll have to find something else to check also these.
2022-02-22 14:01:29 +00:00
return errors.Errorf("lastEntryID for datafile %d: %s is different than real last entry id: %s", i, file.LastEntryID, dataEntries[len(dataEntries)-1].ID)
datamanager: clean old data files keep the last n (now set to 3) data status files and remove all other data status files and unneeded data files.
2019-10-29 12:23:42 +00:00
}
// check that all the files are in order
if file.LastEntryID == prevLastEntryID {
*: use new errors handling library Implement a new error handling library based on pkg/errors. It provides stack saving on wrapping and exports some function to add stack saving also to external errors. It also implements custom zerolog error formatting without adding too much verbosity by just printing the chain error file:line without a full stack trace of every error. * Add a --detailed-errors options to print error with they full chain * Wrap all error returns. Use errors.WithStack to wrap without adding a new messsage and error.Wrap[f] to add a message. * Add golangci-lint wrapcheck to check that external packages errors are wrapped. This won't check that internal packages error are wrapped. But we want also to ensure this case so we'll have to find something else to check also these.
2022-02-22 14:01:29 +00:00
return errors.Errorf("lastEntryID for datafile %d is equal than previous file lastEntryID: %s == %s", i, file.LastEntryID, prevLastEntryID)
datamanager: clean old data files keep the last n (now set to 3) data status files and remove all other data status files and unneeded data files.
2019-10-29 12:23:42 +00:00
}
if file.LastEntryID < prevLastEntryID {
*: use new errors handling library Implement a new error handling library based on pkg/errors. It provides stack saving on wrapping and exports some function to add stack saving also to external errors. It also implements custom zerolog error formatting without adding too much verbosity by just printing the chain error file:line without a full stack trace of every error. * Add a --detailed-errors options to print error with they full chain * Wrap all error returns. Use errors.WithStack to wrap without adding a new messsage and error.Wrap[f] to add a message. * Add golangci-lint wrapcheck to check that external packages errors are wrapped. This won't check that internal packages error are wrapped. But we want also to ensure this case so we'll have to find something else to check also these.
2022-02-22 14:01:29 +00:00
return errors.Errorf("lastEntryID for datafile %d is less than previous file lastEntryID: %s < %s", i, file.LastEntryID, prevLastEntryID)
datamanager: clean old data files keep the last n (now set to 3) data status files and remove all other data status files and unneeded data files.
2019-10-29 12:23:42 +00:00
}
prevLastEntryID = file.LastEntryID
}
}
// check that the number of entries is right
if len(allEntriesMap) != len(expectedEntriesMap) {
*: use new errors handling library Implement a new error handling library based on pkg/errors. It provides stack saving on wrapping and exports some function to add stack saving also to external errors. It also implements custom zerolog error formatting without adding too much verbosity by just printing the chain error file:line without a full stack trace of every error. * Add a --detailed-errors options to print error with they full chain * Wrap all error returns. Use errors.WithStack to wrap without adding a new messsage and error.Wrap[f] to add a message. * Add golangci-lint wrapcheck to check that external packages errors are wrapped. This won't check that internal packages error are wrapped. But we want also to ensure this case so we'll have to find something else to check also these.
2022-02-22 14:01:29 +00:00
return errors.Errorf("expected %d total entries, got %d", len(expectedEntriesMap), len(allEntriesMap))
datamanager: clean old data files keep the last n (now set to 3) data status files and remove all other data status files and unneeded data files.
2019-10-29 12:23:42 +00:00
}
if !reflect.DeepEqual(expectedEntriesMap, allEntriesMap) {
*: use new errors handling library Implement a new error handling library based on pkg/errors. It provides stack saving on wrapping and exports some function to add stack saving also to external errors. It also implements custom zerolog error formatting without adding too much verbosity by just printing the chain error file:line without a full stack trace of every error. * Add a --detailed-errors options to print error with they full chain * Wrap all error returns. Use errors.WithStack to wrap without adding a new messsage and error.Wrap[f] to add a message. * Add golangci-lint wrapcheck to check that external packages errors are wrapped. This won't check that internal packages error are wrapped. But we want also to ensure this case so we'll have to find something else to check also these.
2022-02-22 14:01:29 +00:00
return errors.Errorf("expected entries don't match current entries")
datamanager: clean old data files keep the last n (now set to 3) data status files and remove all other data status files and unneeded data files.
2019-10-29 12:23:42 +00:00
}
return nil
}
datamanager: implement data files splitting split data files in multiple files of a max size (default 10Mib) In this way every data snapshot will change only the datafiles that have some changes instead of the whole single file.
2019-06-03 14:17:27 +00:00
// TODO(sgotti) some fuzzy testing will be really good
func TestCheckpoint(t *testing.T) {
datamanager: always handle basepath Currently we aren't setting a basepath and it wasn't always correctly handled. Fix missing basepath handling and improve tests to also use a non empty basepath.
2019-07-03 15:03:37 +00:00
tests := []struct {
name string
basePath string
}{
{
name: "test with empty basepath",
basePath: "",
},
{
name: "test with relative basepath",
basePath: "base/path",
},
}
for _, tt := range tests {
t.Run(tt.name, func(t *testing.T) {
testCheckpoint(t, tt.basePath)
})
}
}
func testCheckpoint(t *testing.T, basePath string) {
test: use `T.TempDir` to create temporary test directory The directory created by `T.TempDir` is automatically removed when the test and all its subtests complete. Reference: https://pkg.go.dev/testing#T.TempDir Signed-off-by: Eng Zer Jun <engzerjun@gmail.com>
2022-03-01 05:57:39 +00:00
dir := t.TempDir()
*: use zerolog for logging Replace zap with zerolog. zerolog has a cleaner interface and can be easily configured with custom error chain printing using a new error handling library that will be implemented in another PR.
2022-02-21 17:07:58 +00:00
log := testutil.NewLogger(t)
tests: improve services logging During tests provide a zaptest Logger so all services output will be redirected to golang testing logger. When multiple services of the same type are provided add a unique name field to distinguish them.
2020-01-15 11:01:46 +00:00
datamanager: implement data files splitting split data files in multiple files of a max size (default 10Mib) In this way every data snapshot will change only the datafiles that have some changes instead of the whole single file.
2019-06-03 14:17:27 +00:00
etcdDir, err := ioutil.TempDir(dir, "etcd")
datamanager: fix linter errors Fix errors reported by default golangci-lint linters
2019-07-02 12:27:51 +00:00
if err != nil {
t.Fatalf("unexpected err: %v", err)
}
*: use zerolog for logging Replace zap with zerolog. zerolog has a cleaner interface and can be easily configured with custom error chain printing using a new error handling library that will be implemented in another PR.
2022-02-21 17:07:58 +00:00
tetcd := setupEtcd(t, log, etcdDir)
datamanager: implement data files splitting split data files in multiple files of a max size (default 10Mib) In this way every data snapshot will change only the datafiles that have some changes instead of the whole single file.
2019-06-03 14:17:27 +00:00
defer shutdownEtcd(tetcd)
ctx := context.Background()
ostDir, err := ioutil.TempDir(dir, "ost")
datamanager: fix linter errors Fix errors reported by default golangci-lint linters
2019-07-02 12:27:51 +00:00
if err != nil {
t.Fatalf("unexpected err: %v", err)
}
objectstorage: use a single package remove all the subpackages and just use a single package
2019-11-08 15:25:53 +00:00
ost, err := objectstorage.NewPosix(ostDir)
datamanager: implement data files splitting split data files in multiple files of a max size (default 10Mib) In this way every data snapshot will change only the datafiles that have some changes instead of the whole single file.
2019-06-03 14:17:27 +00:00
if err != nil {
t.Fatalf("unexpected err: %v", err)
}
dmConfig := &DataManagerConfig{
datamanager: always handle basepath Currently we aren't setting a basepath and it wasn't always correctly handled. Fix missing basepath handling and improve tests to also use a non empty basepath.
2019-07-03 15:03:37 +00:00
BasePath: basePath,
E: tetcd.TestEtcd.Store,
OST: objectstorage.NewObjStorage(ost, "/"),
datamanager: implement data files splitting split data files in multiple files of a max size (default 10Mib) In this way every data snapshot will change only the datafiles that have some changes instead of the whole single file.
2019-06-03 14:17:27 +00:00
// remove almost all wals to see that they are removed also from changes
EtcdWalsKeepNum: 1,
DataTypes: []string{"datatype01"},
// checkpoint also with only one wal
MinCheckpointWalsNum: 1,
// use a small maxDataFileSize
MaxDataFileSize: 10 * 1024,
}
*: use zerolog for logging Replace zap with zerolog. zerolog has a cleaner interface and can be easily configured with custom error chain printing using a new error handling library that will be implemented in another PR.
2022-02-21 17:07:58 +00:00
dm, err := NewDataManager(ctx, log, dmConfig)
datamanager: fix linter errors Fix errors reported by default golangci-lint linters
2019-07-02 12:27:51 +00:00
if err != nil {
t.Fatalf("unexpected err: %v", err)
}
datamanager: implement data files splitting split data files in multiple files of a max size (default 10Mib) In this way every data snapshot will change only the datafiles that have some changes instead of the whole single file.
2019-06-03 14:17:27 +00:00
dmReadyCh := make(chan struct{})
datamanager: fix linter errors Fix errors reported by default golangci-lint linters
2019-07-02 12:27:51 +00:00
go func() { _ = dm.Run(ctx, dmReadyCh) }()
datamanager: implement data files splitting split data files in multiple files of a max size (default 10Mib) In this way every data snapshot will change only the datafiles that have some changes instead of the whole single file.
2019-06-03 14:17:27 +00:00
<-dmReadyCh
time.Sleep(5 * time.Second)
contents := "aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa"
// test insert from scratch (no current entries)
actions := []*Action{}
for i := 200; i < 400; i++ {
action := &Action{
ActionType: ActionTypePut,
ID: fmt.Sprintf("object%04d", i),
DataType: "datatype01",
Data: []byte(fmt.Sprintf(`{ "ID": "%d", "Contents": %s }`, i, contents)),
}
actions = append(actions, action)
}
datamanager: always handle basepath Currently we aren't setting a basepath and it wasn't always correctly handled. Fix missing basepath handling and improve tests to also use a non empty basepath.
2019-07-03 15:03:37 +00:00
currentEntries, err := doAndCheckCheckpoint(t, ctx, dm, [][]*Action{actions}, nil)
datamanager: implement data files splitting split data files in multiple files of a max size (default 10Mib) In this way every data snapshot will change only the datafiles that have some changes instead of the whole single file.
2019-06-03 14:17:27 +00:00
if err != nil {
t.Fatalf("unexpected err: %v", err)
}
// test delete of all existing entries
actions = []*Action{}
for i := 200; i < 400; i++ {
actions = append(actions, &Action{
ActionType: ActionTypeDelete,
ID: fmt.Sprintf("object%04d", i),
DataType: "datatype01",
})
}
datamanager: always handle basepath Currently we aren't setting a basepath and it wasn't always correctly handled. Fix missing basepath handling and improve tests to also use a non empty basepath.
2019-07-03 15:03:37 +00:00
currentEntries, err = doAndCheckCheckpoint(t, ctx, dm, [][]*Action{actions}, currentEntries)
datamanager: implement data files splitting split data files in multiple files of a max size (default 10Mib) In this way every data snapshot will change only the datafiles that have some changes instead of the whole single file.
2019-06-03 14:17:27 +00:00
if err != nil {
t.Fatalf("unexpected err: %v", err)
}
// test insert from scratch again (no current entries)
actions = []*Action{}
for i := 200; i < 400; i++ {
action := &Action{
ActionType: ActionTypePut,
ID: fmt.Sprintf("object%04d", i),
DataType: "datatype01",
Data: []byte(fmt.Sprintf(`{ "ID": "%d", "Contents": %s }`, i, contents)),
}
actions = append(actions, action)
}
datamanager: always handle basepath Currently we aren't setting a basepath and it wasn't always correctly handled. Fix missing basepath handling and improve tests to also use a non empty basepath.
2019-07-03 15:03:37 +00:00
currentEntries, err = doAndCheckCheckpoint(t, ctx, dm, [][]*Action{actions}, currentEntries)
datamanager: implement data files splitting split data files in multiple files of a max size (default 10Mib) In this way every data snapshot will change only the datafiles that have some changes instead of the whole single file.
2019-06-03 14:17:27 +00:00
if err != nil {
t.Fatalf("unexpected err: %v", err)
}
// test delete some existing entries in the middle
actions = []*Action{}
for i := 250; i < 350; i++ {
action := &Action{
ActionType: ActionTypeDelete,
ID: fmt.Sprintf("object%04d", i),
DataType: "datatype01",
}
actions = append(actions, action)
}
datamanager: always handle basepath Currently we aren't setting a basepath and it wasn't always correctly handled. Fix missing basepath handling and improve tests to also use a non empty basepath.
2019-07-03 15:03:37 +00:00
currentEntries, err = doAndCheckCheckpoint(t, ctx, dm, [][]*Action{actions}, currentEntries)
datamanager: implement data files splitting split data files in multiple files of a max size (default 10Mib) In this way every data snapshot will change only the datafiles that have some changes instead of the whole single file.
2019-06-03 14:17:27 +00:00
if err != nil {
t.Fatalf("unexpected err: %v", err)
}
// test delete of unexisting entries
actions = []*Action{}
for i := 1000; i < 1010; i++ {
action := &Action{
ActionType: ActionTypeDelete,
ID: fmt.Sprintf("object%04d", i),
DataType: "datatype01",
}
actions = append(actions, action)
}
datamanager: always handle basepath Currently we aren't setting a basepath and it wasn't always correctly handled. Fix missing basepath handling and improve tests to also use a non empty basepath.
2019-07-03 15:03:37 +00:00
currentEntries, err = doAndCheckCheckpoint(t, ctx, dm, [][]*Action{actions}, currentEntries)
datamanager: implement data files splitting split data files in multiple files of a max size (default 10Mib) In this way every data snapshot will change only the datafiles that have some changes instead of the whole single file.
2019-06-03 14:17:27 +00:00
if err != nil {
t.Fatalf("unexpected err: %v", err)
}
// test update and insert at the end
actions = []*Action{}
for i := 300; i < 500; i++ {
action := &Action{
ActionType: ActionTypePut,
ID: fmt.Sprintf("object%04d", i),
DataType: "datatype01",
Data: []byte(fmt.Sprintf(`{ "ID": "%d", "Contents": %s }`, i, contents)),
}
actions = append(actions, action)
}
datamanager: always handle basepath Currently we aren't setting a basepath and it wasn't always correctly handled. Fix missing basepath handling and improve tests to also use a non empty basepath.
2019-07-03 15:03:37 +00:00
currentEntries, err = doAndCheckCheckpoint(t, ctx, dm, [][]*Action{actions}, currentEntries)
datamanager: implement data files splitting split data files in multiple files of a max size (default 10Mib) In this way every data snapshot will change only the datafiles that have some changes instead of the whole single file.
2019-06-03 14:17:27 +00:00
if err != nil {
t.Fatalf("unexpected err: %v", err)
}
// test update and insert at the start
actions = []*Action{}
for i := 0; i < 300; i++ {
action := &Action{
ActionType: ActionTypePut,
ID: fmt.Sprintf("object%04d", i),
DataType: "datatype01",
Data: []byte(fmt.Sprintf(`{ "ID": "%d", "Contents": %s }`, i, contents)),
}
actions = append(actions, action)
}
datamanager: always handle basepath Currently we aren't setting a basepath and it wasn't always correctly handled. Fix missing basepath handling and improve tests to also use a non empty basepath.
2019-07-03 15:03:37 +00:00
currentEntries, err = doAndCheckCheckpoint(t, ctx, dm, [][]*Action{actions}, currentEntries)
datamanager: implement data files splitting split data files in multiple files of a max size (default 10Mib) In this way every data snapshot will change only the datafiles that have some changes instead of the whole single file.
2019-06-03 14:17:27 +00:00
if err != nil {
t.Fatalf("unexpected err: %v", err)
}
// test multiple wals with different insert, updated, deletes
actionGroups := [][]*Action{}
for i := 0; i < 150; i++ {
action := &Action{
ActionType: ActionTypePut,
ID: fmt.Sprintf("object%04d", i),
DataType: "datatype01",
Data: []byte(fmt.Sprintf(`{ "ID": "%d", "Contents": %s }`, i, contents)),
}
actions = append(actions, action)
}
actionGroups = append(actionGroups, actions)
for i := 50; i < 100; i++ {
action := &Action{
ActionType: ActionTypeDelete,
ID: fmt.Sprintf("object%04d", i),
DataType: "datatype01",
Data: []byte(fmt.Sprintf(`{ "ID": "%d", "Contents": %s }`, i, contents)),
}
actions = append(actions, action)
}
actionGroups = append(actionGroups, actions)
for i := 250; i < 300; i++ {
action := &Action{
ActionType: ActionTypeDelete,
ID: fmt.Sprintf("object%04d", i),
DataType: "datatype01",
Data: []byte(fmt.Sprintf(`{ "ID": "%d", "Contents": %s }`, i, contents)),
}
actions = append(actions, action)
}
for i := 70; i < 80; i++ {
action := &Action{
ActionType: ActionTypePut,
ID: fmt.Sprintf("object%04d", i),
DataType: "datatype01",
Data: []byte(fmt.Sprintf(`{ "ID": "%d", "Contents": %s }`, i, contents)),
}
actions = append(actions, action)
}
actionGroups = append(actionGroups, actions)
datamanager: always handle basepath Currently we aren't setting a basepath and it wasn't always correctly handled. Fix missing basepath handling and improve tests to also use a non empty basepath.
2019-07-03 15:03:37 +00:00
_, err = doAndCheckCheckpoint(t, ctx, dm, actionGroups, currentEntries)
datamanager: implement data files splitting split data files in multiple files of a max size (default 10Mib) In this way every data snapshot will change only the datafiles that have some changes instead of the whole single file.
2019-06-03 14:17:27 +00:00
if err != nil {
t.Fatalf("unexpected err: %v", err)
}
datamanager: clean old data files keep the last n (now set to 3) data status files and remove all other data status files and unneeded data files.
2019-10-29 12:23:42 +00:00
if err := dm.CleanOldCheckpoints(ctx); err != nil {
t.Fatalf("unexpected err: %v", err)
}
datamanager: implement data files splitting split data files in multiple files of a max size (default 10Mib) In this way every data snapshot will change only the datafiles that have some changes instead of the whole single file.
2019-06-03 14:17:27 +00:00
}
datamanager: fix index creation on multiple data files When during a checkpoint more than one file is created the entries position in the index is not right since it's not reset at every new index. Fix it and add related tests.
2019-11-06 12:33:01 +00:00
func TestRead(t *testing.T) {
test: use `T.TempDir` to create temporary test directory The directory created by `T.TempDir` is automatically removed when the test and all its subtests complete. Reference: https://pkg.go.dev/testing#T.TempDir Signed-off-by: Eng Zer Jun <engzerjun@gmail.com>
2022-03-01 05:57:39 +00:00
dir := t.TempDir()
*: use zerolog for logging Replace zap with zerolog. zerolog has a cleaner interface and can be easily configured with custom error chain printing using a new error handling library that will be implemented in another PR.
2022-02-21 17:07:58 +00:00
log := testutil.NewLogger(t)
tests: improve services logging During tests provide a zaptest Logger so all services output will be redirected to golang testing logger. When multiple services of the same type are provided add a unique name field to distinguish them.
2020-01-15 11:01:46 +00:00
datamanager: fix index creation on multiple data files When during a checkpoint more than one file is created the entries position in the index is not right since it's not reset at every new index. Fix it and add related tests.
2019-11-06 12:33:01 +00:00
etcdDir, err := ioutil.TempDir(dir, "etcd")
if err != nil {
t.Fatalf("unexpected err: %v", err)
}
*: use zerolog for logging Replace zap with zerolog. zerolog has a cleaner interface and can be easily configured with custom error chain printing using a new error handling library that will be implemented in another PR.
2022-02-21 17:07:58 +00:00
tetcd := setupEtcd(t, log, etcdDir)
datamanager: fix index creation on multiple data files When during a checkpoint more than one file is created the entries position in the index is not right since it's not reset at every new index. Fix it and add related tests.
2019-11-06 12:33:01 +00:00
defer shutdownEtcd(tetcd)
ctx := context.Background()
ostDir, err := ioutil.TempDir(dir, "ost")
if err != nil {
t.Fatalf("unexpected err: %v", err)
}
objectstorage: use a single package remove all the subpackages and just use a single package
2019-11-08 15:25:53 +00:00
ost, err := objectstorage.NewPosix(ostDir)
datamanager: fix index creation on multiple data files When during a checkpoint more than one file is created the entries position in the index is not right since it's not reset at every new index. Fix it and add related tests.
2019-11-06 12:33:01 +00:00
if err != nil {
t.Fatalf("unexpected err: %v", err)
}
dmConfig := &DataManagerConfig{
BasePath: "basepath",
E: tetcd.TestEtcd.Store,
OST: objectstorage.NewObjStorage(ost, "/"),
// remove almost all wals to see that they are removed also from changes
EtcdWalsKeepNum: 1,
DataTypes: []string{"datatype01"},
// checkpoint also with only one wal
MinCheckpointWalsNum: 1,
// use a small maxDataFileSize
MaxDataFileSize: 10 * 1024,
}
*: use zerolog for logging Replace zap with zerolog. zerolog has a cleaner interface and can be easily configured with custom error chain printing using a new error handling library that will be implemented in another PR.
2022-02-21 17:07:58 +00:00
dm, err := NewDataManager(ctx, log, dmConfig)
datamanager: fix index creation on multiple data files When during a checkpoint more than one file is created the entries position in the index is not right since it's not reset at every new index. Fix it and add related tests.
2019-11-06 12:33:01 +00:00
if err != nil {
t.Fatalf("unexpected err: %v", err)
}
dmReadyCh := make(chan struct{})
go func() { _ = dm.Run(ctx, dmReadyCh) }()
<-dmReadyCh
time.Sleep(5 * time.Second)
contents := "aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa"
// test insert from scratch (no current entries)
actions := []*Action{}
for i := 0; i < 2000; i++ {
action := &Action{
ActionType: ActionTypePut,
ID: fmt.Sprintf("object%04d", i),
DataType: "datatype01",
Data: []byte(fmt.Sprintf(`{ "ID": "%d", "Contents": %s }`, i, contents)),
}
actions = append(actions, action)
}
currentEntries, err := doAndCheckCheckpoint(t, ctx, dm, [][]*Action{actions}, nil)
if err != nil {
t.Fatalf("unexpected err: %v", err)
}
// ensure that at least three datafiles are created
curDataStatus, err := dm.GetLastDataStatus()
if err != nil {
t.Fatalf("unexpected err: %v", err)
}
if len(curDataStatus.Files["datatype01"]) < 3 {
t.Fatalf("expected at least 3 datafiles, got: %d", len(curDataStatus.Files["datatype01"]))
}
for i := 0; i < 2000; i++ {
id := fmt.Sprintf("object%04d", i)
er, err := dm.Read("datatype01", id)
if err != nil {
t.Fatalf("unexpected err: %v", err)
}
data, err := ioutil.ReadAll(er)
if err != nil {
t.Fatalf("unexpected err: %v", err)
}
if !reflect.DeepEqual(data, currentEntries[id].Data) {
t.Fatalf("expected data: %v, got data: %v", currentEntries[id].Data, data)
}
}
}
datamanager: clean old data files keep the last n (now set to 3) data status files and remove all other data status files and unneeded data files.
2019-10-29 12:23:42 +00:00
func TestClean(t *testing.T) {
tests := []struct {
name string
basePath string
}{
{
name: "test with empty basepath",
basePath: "",
},
{
name: "test with relative basepath",
basePath: "base/path",
},
}
for _, tt := range tests {
t.Run(tt.name, func(t *testing.T) {
testClean(t, tt.basePath)
})
}
}
func testClean(t *testing.T, basePath string) {
test: use `T.TempDir` to create temporary test directory The directory created by `T.TempDir` is automatically removed when the test and all its subtests complete. Reference: https://pkg.go.dev/testing#T.TempDir Signed-off-by: Eng Zer Jun <engzerjun@gmail.com>
2022-03-01 05:57:39 +00:00
dir := t.TempDir()
*: use zerolog for logging Replace zap with zerolog. zerolog has a cleaner interface and can be easily configured with custom error chain printing using a new error handling library that will be implemented in another PR.
2022-02-21 17:07:58 +00:00
log := testutil.NewLogger(t)
tests: improve services logging During tests provide a zaptest Logger so all services output will be redirected to golang testing logger. When multiple services of the same type are provided add a unique name field to distinguish them.
2020-01-15 11:01:46 +00:00
datamanager: clean old data files keep the last n (now set to 3) data status files and remove all other data status files and unneeded data files.
2019-10-29 12:23:42 +00:00
etcdDir, err := ioutil.TempDir(dir, "etcd")
if err != nil {
t.Fatalf("unexpected err: %v", err)
}
*: use zerolog for logging Replace zap with zerolog. zerolog has a cleaner interface and can be easily configured with custom error chain printing using a new error handling library that will be implemented in another PR.
2022-02-21 17:07:58 +00:00
tetcd := setupEtcd(t, log, etcdDir)
datamanager: clean old data files keep the last n (now set to 3) data status files and remove all other data status files and unneeded data files.
2019-10-29 12:23:42 +00:00
defer shutdownEtcd(tetcd)
datamanager: implement data files splitting split data files in multiple files of a max size (default 10Mib) In this way every data snapshot will change only the datafiles that have some changes instead of the whole single file.
2019-06-03 14:17:27 +00:00
datamanager: clean old data files keep the last n (now set to 3) data status files and remove all other data status files and unneeded data files.
2019-10-29 12:23:42 +00:00
ctx := context.Background()
datamanager: implement import/export * export: exports the newest data checkpoint. It forces a checkpoint before exporting (currently no wals are exported) * import: cleans up etcd, creates a new datasnaphot from the provided import stream and then initializes etcd. Currently no old data is removed from the object storage but it's just ignored.
2019-07-17 15:16:35 +00:00
datamanager: clean old data files keep the last n (now set to 3) data status files and remove all other data status files and unneeded data files.
2019-10-29 12:23:42 +00:00
ostDir, err := ioutil.TempDir(dir, "ost")
if err != nil {
t.Fatalf("unexpected err: %v", err)
}
objectstorage: use a single package remove all the subpackages and just use a single package
2019-11-08 15:25:53 +00:00
ost, err := objectstorage.NewPosix(ostDir)
datamanager: clean old data files keep the last n (now set to 3) data status files and remove all other data status files and unneeded data files.
2019-10-29 12:23:42 +00:00
if err != nil {
t.Fatalf("unexpected err: %v", err)
}
datamanager: implement import/export * export: exports the newest data checkpoint. It forces a checkpoint before exporting (currently no wals are exported) * import: cleans up etcd, creates a new datasnaphot from the provided import stream and then initializes etcd. Currently no old data is removed from the object storage but it's just ignored.
2019-07-17 15:16:35 +00:00
datamanager: clean old data files keep the last n (now set to 3) data status files and remove all other data status files and unneeded data files.
2019-10-29 12:23:42 +00:00
dmConfig := &DataManagerConfig{
BasePath: basePath,
E: tetcd.TestEtcd.Store,
OST: objectstorage.NewObjStorage(ost, "/"),
// remove almost all wals to see that they are removed also from changes
EtcdWalsKeepNum: 1,
DataTypes: []string{"datatype01"},
// checkpoint also with only one wal
MinCheckpointWalsNum: 1,
// use a small maxDataFileSize
MaxDataFileSize: 10 * 1024,
}
*: use zerolog for logging Replace zap with zerolog. zerolog has a cleaner interface and can be easily configured with custom error chain printing using a new error handling library that will be implemented in another PR.
2022-02-21 17:07:58 +00:00
dm, err := NewDataManager(ctx, log, dmConfig)
datamanager: clean old data files keep the last n (now set to 3) data status files and remove all other data status files and unneeded data files.
2019-10-29 12:23:42 +00:00
if err != nil {
t.Fatalf("unexpected err: %v", err)
}
dmReadyCh := make(chan struct{})
go func() { _ = dm.Run(ctx, dmReadyCh) }()
<-dmReadyCh
datamanager: implement import/export * export: exports the newest data checkpoint. It forces a checkpoint before exporting (currently no wals are exported) * import: cleans up etcd, creates a new datasnaphot from the provided import stream and then initializes etcd. Currently no old data is removed from the object storage but it's just ignored.
2019-07-17 15:16:35 +00:00
datamanager: clean old data files keep the last n (now set to 3) data status files and remove all other data status files and unneeded data files.
2019-10-29 12:23:42 +00:00
time.Sleep(5 * time.Second)
datamanager: implement data files splitting split data files in multiple files of a max size (default 10Mib) In this way every data snapshot will change only the datafiles that have some changes instead of the whole single file.
2019-06-03 14:17:27 +00:00
datamanager: clean old data files keep the last n (now set to 3) data status files and remove all other data status files and unneeded data files.
2019-10-29 12:23:42 +00:00
contents := "aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa"
datamanager: implement import/export * export: exports the newest data checkpoint. It forces a checkpoint before exporting (currently no wals are exported) * import: cleans up etcd, creates a new datasnaphot from the provided import stream and then initializes etcd. Currently no old data is removed from the object storage but it's just ignored.
2019-07-17 15:16:35 +00:00
datamanager: clean old data files keep the last n (now set to 3) data status files and remove all other data status files and unneeded data files.
2019-10-29 12:23:42 +00:00
var currentEntries map[string]*DataEntry
actions := []*Action{}
for n := 0; n < 10; n++ {
for i := 0; i < 400; i++ {
action := &Action{
ActionType: ActionTypePut,
ID: fmt.Sprintf("object%04d", i),
DataType: "datatype01",
Data: []byte(fmt.Sprintf(`{ "ID": "%d", "Contents": %s }`, i, contents)),
datamanager: implement import/export * export: exports the newest data checkpoint. It forces a checkpoint before exporting (currently no wals are exported) * import: cleans up etcd, creates a new datasnaphot from the provided import stream and then initializes etcd. Currently no old data is removed from the object storage but it's just ignored.
2019-07-17 15:16:35 +00:00
}
datamanager: clean old data files keep the last n (now set to 3) data status files and remove all other data status files and unneeded data files.
2019-10-29 12:23:42 +00:00
actions = append(actions, action)
}
datamanager: implement import/export * export: exports the newest data checkpoint. It forces a checkpoint before exporting (currently no wals are exported) * import: cleans up etcd, creates a new datasnaphot from the provided import stream and then initializes etcd. Currently no old data is removed from the object storage but it's just ignored.
2019-07-17 15:16:35 +00:00
datamanager: clean old data files keep the last n (now set to 3) data status files and remove all other data status files and unneeded data files.
2019-10-29 12:23:42 +00:00
currentEntries, err = doAndCheckCheckpoint(t, ctx, dm, [][]*Action{actions}, currentEntries)
if err != nil {
t.Fatalf("unexpected err: %v", err)
}
}
// get the last data status sequence
lastDataStatusSequences, err := dm.GetLastDataStatusSequences(dataStatusToKeep)
if err != nil {
t.Fatalf("unexpected err: %v", err)
}
if err := dm.CleanOldCheckpoints(ctx); err != nil {
t.Fatalf("unexpected err: %v", err)
}
// check last data file
if err := checkDataFiles(ctx, t, dm, currentEntries); err != nil {
t.Fatalf("unexpected err: %v", err)
}
// check that only the last dataStatusToKeep status files are left
curDataStatusSequences, err := dm.GetLastDataStatusSequences(1000)
if err != nil {
t.Fatalf("unexpected err: %v", err)
}
if len(curDataStatusSequences) != dataStatusToKeep {
t.Fatalf("expected %d data status files, got %d: %s", dataStatusToKeep, len(curDataStatusSequences), curDataStatusSequences)
}
if diff := cmp.Diff(lastDataStatusSequences, curDataStatusSequences); diff != "" {
t.Fatalf("different data status sequences: %v", diff)
}
}
func TestCleanConcurrentCheckpoint(t *testing.T) {
tests := []struct {
name string
basePath string
}{
{
name: "test with empty basepath",
basePath: "",
},
{
name: "test with relative basepath",
basePath: "base/path",
},
}
for _, tt := range tests {
t.Run(tt.name, func(t *testing.T) {
testCleanConcurrentCheckpoint(t, tt.basePath)
})
}
}
func testCleanConcurrentCheckpoint(t *testing.T, basePath string) {
test: use `T.TempDir` to create temporary test directory The directory created by `T.TempDir` is automatically removed when the test and all its subtests complete. Reference: https://pkg.go.dev/testing#T.TempDir Signed-off-by: Eng Zer Jun <engzerjun@gmail.com>
2022-03-01 05:57:39 +00:00
dir := t.TempDir()
*: use zerolog for logging Replace zap with zerolog. zerolog has a cleaner interface and can be easily configured with custom error chain printing using a new error handling library that will be implemented in another PR.
2022-02-21 17:07:58 +00:00
log := testutil.NewLogger(t)
tests: improve services logging During tests provide a zaptest Logger so all services output will be redirected to golang testing logger. When multiple services of the same type are provided add a unique name field to distinguish them.
2020-01-15 11:01:46 +00:00
datamanager: clean old data files keep the last n (now set to 3) data status files and remove all other data status files and unneeded data files.
2019-10-29 12:23:42 +00:00
etcdDir, err := ioutil.TempDir(dir, "etcd")
if err != nil {
t.Fatalf("unexpected err: %v", err)
}
*: use zerolog for logging Replace zap with zerolog. zerolog has a cleaner interface and can be easily configured with custom error chain printing using a new error handling library that will be implemented in another PR.
2022-02-21 17:07:58 +00:00
tetcd := setupEtcd(t, log, etcdDir)
datamanager: clean old data files keep the last n (now set to 3) data status files and remove all other data status files and unneeded data files.
2019-10-29 12:23:42 +00:00
defer shutdownEtcd(tetcd)
ctx := context.Background()
ostDir, err := ioutil.TempDir(dir, "ost")
if err != nil {
t.Fatalf("unexpected err: %v", err)
}
objectstorage: use a single package remove all the subpackages and just use a single package
2019-11-08 15:25:53 +00:00
ost, err := objectstorage.NewPosix(ostDir)
datamanager: clean old data files keep the last n (now set to 3) data status files and remove all other data status files and unneeded data files.
2019-10-29 12:23:42 +00:00
if err != nil {
t.Fatalf("unexpected err: %v", err)
}
dmConfig := &DataManagerConfig{
BasePath: basePath,
E: tetcd.TestEtcd.Store,
OST: objectstorage.NewObjStorage(ost, "/"),
// remove almost all wals to see that they are removed also from changes
EtcdWalsKeepNum: 1,
DataTypes: []string{"datatype01"},
// checkpoint also with only one wal
MinCheckpointWalsNum: 1,
// use a small maxDataFileSize
MaxDataFileSize: 10 * 1024,
}
*: use zerolog for logging Replace zap with zerolog. zerolog has a cleaner interface and can be easily configured with custom error chain printing using a new error handling library that will be implemented in another PR.
2022-02-21 17:07:58 +00:00
dm, err := NewDataManager(ctx, log, dmConfig)
datamanager: clean old data files keep the last n (now set to 3) data status files and remove all other data status files and unneeded data files.
2019-10-29 12:23:42 +00:00
if err != nil {
t.Fatalf("unexpected err: %v", err)
}
dmReadyCh := make(chan struct{})
go func() { _ = dm.Run(ctx, dmReadyCh) }()
<-dmReadyCh
time.Sleep(5 * time.Second)
contents := "aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa"
var currentEntries map[string]*DataEntry
actions := []*Action{}
for n := 0; n < 10; n++ {
for i := 0; i < 400; i++ {
action := &Action{
ActionType: ActionTypePut,
ID: fmt.Sprintf("object%04d", i),
DataType: "datatype01",
Data: []byte(fmt.Sprintf(`{ "ID": "%d", "Contents": %s }`, i, contents)),
datamanager: implement import/export * export: exports the newest data checkpoint. It forces a checkpoint before exporting (currently no wals are exported) * import: cleans up etcd, creates a new datasnaphot from the provided import stream and then initializes etcd. Currently no old data is removed from the object storage but it's just ignored.
2019-07-17 15:16:35 +00:00
}
datamanager: clean old data files keep the last n (now set to 3) data status files and remove all other data status files and unneeded data files.
2019-10-29 12:23:42 +00:00
actions = append(actions, action)
}
currentEntries, err = doAndCheckCheckpoint(t, ctx, dm, [][]*Action{actions}, currentEntries)
if err != nil {
t.Fatalf("unexpected err: %v", err)
datamanager: implement data files splitting split data files in multiple files of a max size (default 10Mib) In this way every data snapshot will change only the datafiles that have some changes instead of the whole single file.
2019-06-03 14:17:27 +00:00
}
datamanager: implement import/export * export: exports the newest data checkpoint. It forces a checkpoint before exporting (currently no wals are exported) * import: cleans up etcd, creates a new datasnaphot from the provided import stream and then initializes etcd. Currently no old data is removed from the object storage but it's just ignored.
2019-07-17 15:16:35 +00:00
}
datamanager: clean old data files keep the last n (now set to 3) data status files and remove all other data status files and unneeded data files.
2019-10-29 12:23:42 +00:00
// get the current last data status sequences before doing other actions and checkpoints
dataStatusSequences, err := dm.GetLastDataStatusSequences(dataStatusToKeep)
if err != nil {
t.Fatalf("unexpected err: %v", err)
datamanager: implement import/export * export: exports the newest data checkpoint. It forces a checkpoint before exporting (currently no wals are exported) * import: cleans up etcd, creates a new datasnaphot from the provided import stream and then initializes etcd. Currently no old data is removed from the object storage but it's just ignored.
2019-07-17 15:16:35 +00:00
}
datamanager: clean old data files keep the last n (now set to 3) data status files and remove all other data status files and unneeded data files.
2019-10-29 12:23:42 +00:00
for i := 0; i < 400; i++ {
action := &Action{
ActionType: ActionTypePut,
ID: fmt.Sprintf("object%04d", i),
DataType: "datatype01",
Data: []byte(fmt.Sprintf(`{ "ID": "%d", "Contents": %s }`, i, contents)),
}
actions = append(actions, action)
datamanager: implement import/export * export: exports the newest data checkpoint. It forces a checkpoint before exporting (currently no wals are exported) * import: cleans up etcd, creates a new datasnaphot from the provided import stream and then initializes etcd. Currently no old data is removed from the object storage but it's just ignored.
2019-07-17 15:16:35 +00:00
}
datamanager: clean old data files keep the last n (now set to 3) data status files and remove all other data status files and unneeded data files.
2019-10-29 12:23:42 +00:00
if _, err = doAndCheckCheckpoint(t, ctx, dm, [][]*Action{actions}, currentEntries); err != nil {
t.Fatalf("unexpected err: %v", err)
}
if err := dm.cleanOldCheckpoints(ctx, dataStatusSequences); err != nil {
t.Fatalf("unexpected err: %v", err)
}
// check the datastatus after clean
curDataStatus, err := dm.GetLastDataStatus()
if err != nil {
t.Fatalf("unexpected err: %v", err)
}
if curDataStatus.DataSequence <= dataStatusSequences[0].String() {
t.Fatalf("expected data status sequence greater than %q", dataStatusSequences[0])
}
// check last data file
if err := checkDataFiles(ctx, t, dm, currentEntries); err != nil {
t.Fatalf("unexpected err: %v", err)
}
datamanager: implement import/export * export: exports the newest data checkpoint. It forces a checkpoint before exporting (currently no wals are exported) * import: cleans up etcd, creates a new datasnaphot from the provided import stream and then initializes etcd. Currently no old data is removed from the object storage but it's just ignored.
2019-07-17 15:16:35 +00:00
}
datamanager: remove old storage wals Remove all wals not required by the existing data status files and not existing in etcd.
2019-11-08 09:10:56 +00:00
func TestStorageWalCleaner(t *testing.T) {
tests := []struct {
name string
basePath string
}{
{
name: "test with empty basepath",
basePath: "",
},
{
name: "test with relative basepath",
basePath: "base/path",
},
}
for _, tt := range tests {
t.Run(tt.name, func(t *testing.T) {
testStorageWalCleaner(t, tt.basePath)
})
}
}
func testStorageWalCleaner(t *testing.T, basePath string) {
test: use `T.TempDir` to create temporary test directory The directory created by `T.TempDir` is automatically removed when the test and all its subtests complete. Reference: https://pkg.go.dev/testing#T.TempDir Signed-off-by: Eng Zer Jun <engzerjun@gmail.com>
2022-03-01 05:57:39 +00:00
dir := t.TempDir()
*: use zerolog for logging Replace zap with zerolog. zerolog has a cleaner interface and can be easily configured with custom error chain printing using a new error handling library that will be implemented in another PR.
2022-02-21 17:07:58 +00:00
log := testutil.NewLogger(t)
tests: improve services logging During tests provide a zaptest Logger so all services output will be redirected to golang testing logger. When multiple services of the same type are provided add a unique name field to distinguish them.
2020-01-15 11:01:46 +00:00
datamanager: remove old storage wals Remove all wals not required by the existing data status files and not existing in etcd.
2019-11-08 09:10:56 +00:00
etcdDir, err := ioutil.TempDir(dir, "etcd")
if err != nil {
t.Fatalf("unexpected err: %v", err)
}
*: use zerolog for logging Replace zap with zerolog. zerolog has a cleaner interface and can be easily configured with custom error chain printing using a new error handling library that will be implemented in another PR.
2022-02-21 17:07:58 +00:00
tetcd := setupEtcd(t, log, etcdDir)
datamanager: remove old storage wals Remove all wals not required by the existing data status files and not existing in etcd.
2019-11-08 09:10:56 +00:00
defer shutdownEtcd(tetcd)
ctx := context.Background()
ostDir, err := ioutil.TempDir(dir, "ost")
if err != nil {
t.Fatalf("unexpected err: %v", err)
}
objectstorage: use a single package remove all the subpackages and just use a single package
2019-11-08 15:25:53 +00:00
ost, err := objectstorage.NewPosix(ostDir)
datamanager: remove old storage wals Remove all wals not required by the existing data status files and not existing in etcd.
2019-11-08 09:10:56 +00:00
if err != nil {
t.Fatalf("unexpected err: %v", err)
}
dmConfig := &DataManagerConfig{
BasePath: basePath,
E: tetcd.TestEtcd.Store,
OST: objectstorage.NewObjStorage(ost, "/"),
// remove almost all wals to see that they are removed also from changes
EtcdWalsKeepNum: 1,
DataTypes: []string{"datatype01"},
// checkpoint also with only one wal
MinCheckpointWalsNum: 1,
// use a small maxDataFileSize
MaxDataFileSize: 10 * 1024,
}
*: use zerolog for logging Replace zap with zerolog. zerolog has a cleaner interface and can be easily configured with custom error chain printing using a new error handling library that will be implemented in another PR.
2022-02-21 17:07:58 +00:00
dm, err := NewDataManager(ctx, log, dmConfig)
datamanager: remove old storage wals Remove all wals not required by the existing data status files and not existing in etcd.
2019-11-08 09:10:56 +00:00
if err != nil {
t.Fatalf("unexpected err: %v", err)
}
dmReadyCh := make(chan struct{})
go func() { _ = dm.Run(ctx, dmReadyCh) }()
<-dmReadyCh
time.Sleep(5 * time.Second)
contents := "aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa"
var currentEntries map[string]*DataEntry
actions := []*Action{}
for n := 0; n < 10; n++ {
for i := 0; i < 400; i++ {
action := &Action{
ActionType: ActionTypePut,
ID: fmt.Sprintf("object%04d", i),
DataType: "datatype01",
Data: []byte(fmt.Sprintf(`{ "ID": "%d", "Contents": %s }`, i, contents)),
}
actions = append(actions, action)
}
currentEntries, err = doAndCheckCheckpoint(t, ctx, dm, [][]*Action{actions}, currentEntries)
if err != nil {
t.Fatalf("unexpected err: %v", err)
}
}
// get the last data status sequence
lastDataStatusSequences, err := dm.GetLastDataStatusSequences(dataStatusToKeep)
if err != nil {
t.Fatalf("unexpected err: %v", err)
}
// Use the first dataStatusToKeep data status
dataStatus, err := dm.GetDataStatus(lastDataStatusSequences[dataStatusToKeep-1])
if err != nil {
t.Fatalf("unexpected err: %v", err)
}
// get the list of expected wals
doneCh := make(chan struct{})
defer close(doneCh)
expectedWalStatusFiles := []string{}
expectedWalDataFiles := []string{}
for object := range dm.ost.List(dm.storageWalStatusDir()+"/", "", true, doneCh) {
if object.Err != nil {
t.Fatalf("unexpected err: %v", err)
}
name := path.Base(object.Path)
ext := path.Ext(name)
walSequence := strings.TrimSuffix(name, ext)
if walSequence < dataStatus.WalSequence {
continue
}
header, err := dm.ReadWal(walSequence)
if err != nil {
t.Fatalf("unexpected err: %v", err)
}
expectedWalStatusFiles = append(expectedWalStatusFiles, object.Path)
expectedWalDataFiles = append(expectedWalDataFiles, dm.storageWalDataFile(header.WalDataFileID))
}
sort.Strings(expectedWalDataFiles)
if err := dm.CleanOldCheckpoints(ctx); err != nil {
t.Fatalf("unexpected err: %v", err)
}
if err := dm.storageWalCleaner(ctx); err != nil {
t.Fatalf("unexpected err: %v", err)
}
currentWalStatusFiles := []string{}
currentWalDataFiles := []string{}
for object := range dm.ost.List(dm.storageWalStatusDir()+"/", "", true, doneCh) {
if object.Err != nil {
t.Fatalf("unexpected err: %v", err)
}
currentWalStatusFiles = append(currentWalStatusFiles, object.Path)
}
for object := range dm.ost.List(dm.storageWalDataDir()+"/", "", true, doneCh) {
if object.Err != nil {
t.Fatalf("unexpected err: %v", err)
}
currentWalDataFiles = append(currentWalDataFiles, object.Path)
}
sort.Strings(currentWalDataFiles)
if diff := cmp.Diff(currentWalStatusFiles, expectedWalStatusFiles); diff != "" {
t.Fatalf("different wal status files: %v", diff)
}
if diff := cmp.Diff(currentWalDataFiles, expectedWalDataFiles); diff != "" {
t.Fatalf("different wal data files: %v", diff)
}
}
datamanager: implement import/export * export: exports the newest data checkpoint. It forces a checkpoint before exporting (currently no wals are exported) * import: cleans up etcd, creates a new datasnaphot from the provided import stream and then initializes etcd. Currently no old data is removed from the object storage but it's just ignored.
2019-07-17 15:16:35 +00:00
func TestExportImport(t *testing.T) {
test: use `T.TempDir` to create temporary test directory The directory created by `T.TempDir` is automatically removed when the test and all its subtests complete. Reference: https://pkg.go.dev/testing#T.TempDir Signed-off-by: Eng Zer Jun <engzerjun@gmail.com>
2022-03-01 05:57:39 +00:00
dir := t.TempDir()
*: use zerolog for logging Replace zap with zerolog. zerolog has a cleaner interface and can be easily configured with custom error chain printing using a new error handling library that will be implemented in another PR.
2022-02-21 17:07:58 +00:00
log := testutil.NewLogger(t)
tests: improve services logging During tests provide a zaptest Logger so all services output will be redirected to golang testing logger. When multiple services of the same type are provided add a unique name field to distinguish them.
2020-01-15 11:01:46 +00:00
datamanager: implement import/export * export: exports the newest data checkpoint. It forces a checkpoint before exporting (currently no wals are exported) * import: cleans up etcd, creates a new datasnaphot from the provided import stream and then initializes etcd. Currently no old data is removed from the object storage but it's just ignored.
2019-07-17 15:16:35 +00:00
etcdDir, err := ioutil.TempDir(dir, "etcd")
if err != nil {
t.Fatalf("unexpected err: %v", err)
}
*: use zerolog for logging Replace zap with zerolog. zerolog has a cleaner interface and can be easily configured with custom error chain printing using a new error handling library that will be implemented in another PR.
2022-02-21 17:07:58 +00:00
tetcd := setupEtcd(t, log, etcdDir)
datamanager: implement import/export * export: exports the newest data checkpoint. It forces a checkpoint before exporting (currently no wals are exported) * import: cleans up etcd, creates a new datasnaphot from the provided import stream and then initializes etcd. Currently no old data is removed from the object storage but it's just ignored.
2019-07-17 15:16:35 +00:00
ctx, cancel := context.WithCancel(context.Background())
ostDir, err := ioutil.TempDir(dir, "ost")
if err != nil {
t.Fatalf("unexpected err: %v", err)
}
objectstorage: use a single package remove all the subpackages and just use a single package
2019-11-08 15:25:53 +00:00
ost, err := objectstorage.NewPosix(ostDir)
datamanager: implement import/export * export: exports the newest data checkpoint. It forces a checkpoint before exporting (currently no wals are exported) * import: cleans up etcd, creates a new datasnaphot from the provided import stream and then initializes etcd. Currently no old data is removed from the object storage but it's just ignored.
2019-07-17 15:16:35 +00:00
if err != nil {
t.Fatalf("unexpected err: %v", err)
}
dmConfig := &DataManagerConfig{
BasePath: "basepath",
E: tetcd.TestEtcd.Store,
OST: objectstorage.NewObjStorage(ost, "/"),
// remove almost all wals to see that they are removed also from changes
EtcdWalsKeepNum: 1,
DataTypes: []string{"datatype01", "datatype02"},
// checkpoint also with only one wal
MinCheckpointWalsNum: 1,
// use a small maxDataFileSize
MaxDataFileSize: 10 * 1024,
}
*: use zerolog for logging Replace zap with zerolog. zerolog has a cleaner interface and can be easily configured with custom error chain printing using a new error handling library that will be implemented in another PR.
2022-02-21 17:07:58 +00:00
dm, err := NewDataManager(ctx, log, dmConfig)
datamanager: implement import/export * export: exports the newest data checkpoint. It forces a checkpoint before exporting (currently no wals are exported) * import: cleans up etcd, creates a new datasnaphot from the provided import stream and then initializes etcd. Currently no old data is removed from the object storage but it's just ignored.
2019-07-17 15:16:35 +00:00
if err != nil {
t.Fatalf("unexpected err: %v", err)
}
dmReadyCh := make(chan struct{})
go func() { _ = dm.Run(ctx, dmReadyCh) }()
<-dmReadyCh
time.Sleep(5 * time.Second)
contents := "aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa"
datamanager: implement data files splitting split data files in multiple files of a max size (default 10Mib) In this way every data snapshot will change only the datafiles that have some changes instead of the whole single file.
2019-06-03 14:17:27 +00:00
datamanager: implement import/export * export: exports the newest data checkpoint. It forces a checkpoint before exporting (currently no wals are exported) * import: cleans up etcd, creates a new datasnaphot from the provided import stream and then initializes etcd. Currently no old data is removed from the object storage but it's just ignored.
2019-07-17 15:16:35 +00:00
expectedEntries := map[string]*DataEntry{}
// test insert from scratch (no current entries)
actionGroups := [][]*Action{}
actions := []*Action{}
for i := 200; i < 400; i++ {
action := &Action{
ActionType: ActionTypePut,
ID: fmt.Sprintf("object%04d", i),
DataType: "datatype01",
Data: []byte(fmt.Sprintf(`{ "ID": "%d", "Contents": %s }`, i, contents)),
datamanager: implement data files splitting split data files in multiple files of a max size (default 10Mib) In this way every data snapshot will change only the datafiles that have some changes instead of the whole single file.
2019-06-03 14:17:27 +00:00
}
datamanager: implement import/export * export: exports the newest data checkpoint. It forces a checkpoint before exporting (currently no wals are exported) * import: cleans up etcd, creates a new datasnaphot from the provided import stream and then initializes etcd. Currently no old data is removed from the object storage but it's just ignored.
2019-07-17 15:16:35 +00:00
actions = append(actions, action)
}
actionGroups = append(actionGroups, actions)
actions = []*Action{}
for i := 600; i < 1000; i++ {
action := &Action{
ActionType: ActionTypePut,
ID: fmt.Sprintf("object%04d", i),
DataType: "datatype02",
Data: []byte(fmt.Sprintf(`{ "ID": "%d", "Contents": %s }`, i, contents)),
datamanager: implement data files splitting split data files in multiple files of a max size (default 10Mib) In this way every data snapshot will change only the datafiles that have some changes instead of the whole single file.
2019-06-03 14:17:27 +00:00
}
datamanager: implement import/export * export: exports the newest data checkpoint. It forces a checkpoint before exporting (currently no wals are exported) * import: cleans up etcd, creates a new datasnaphot from the provided import stream and then initializes etcd. Currently no old data is removed from the object storage but it's just ignored.
2019-07-17 15:16:35 +00:00
actions = append(actions, action)
}
actionGroups = append(actionGroups, actions)
for _, actionGroup := range actionGroups {
for _, action := range actionGroup {
switch action.ActionType {
case ActionTypePut:
expectedEntries[action.ID] = &DataEntry{ID: action.ID, DataType: action.DataType, Data: action.Data}
case ActionTypeDelete:
delete(expectedEntries, action.ID)
}
datamanager: implement data files splitting split data files in multiple files of a max size (default 10Mib) In this way every data snapshot will change only the datafiles that have some changes instead of the whole single file.
2019-06-03 14:17:27 +00:00
}
datamanager: implement import/export * export: exports the newest data checkpoint. It forces a checkpoint before exporting (currently no wals are exported) * import: cleans up etcd, creates a new datasnaphot from the provided import stream and then initializes etcd. Currently no old data is removed from the object storage but it's just ignored.
2019-07-17 15:16:35 +00:00
}
for _, actionGroup := range actionGroups {
// populate with a wal
_, err := dm.WriteWal(ctx, actionGroup, nil)
if err != nil {
t.Fatalf("unexpected err: %v", err)
datamanager: implement data files splitting split data files in multiple files of a max size (default 10Mib) In this way every data snapshot will change only the datafiles that have some changes instead of the whole single file.
2019-06-03 14:17:27 +00:00
}
datamanager: implement import/export * export: exports the newest data checkpoint. It forces a checkpoint before exporting (currently no wals are exported) * import: cleans up etcd, creates a new datasnaphot from the provided import stream and then initializes etcd. Currently no old data is removed from the object storage but it's just ignored.
2019-07-17 15:16:35 +00:00
}
// wait for the event to be read
time.Sleep(500 * time.Millisecond)
var export bytes.Buffer
if err := dm.Export(ctx, &export); err != nil {
t.Fatalf("unexpected err: %v", err)
}
t.Logf("stopping datamanager")
cancel()
datamanager: implement data files splitting split data files in multiple files of a max size (default 10Mib) In this way every data snapshot will change only the datafiles that have some changes instead of the whole single file.
2019-06-03 14:17:27 +00:00
datamanager: implement import/export * export: exports the newest data checkpoint. It forces a checkpoint before exporting (currently no wals are exported) * import: cleans up etcd, creates a new datasnaphot from the provided import stream and then initializes etcd. Currently no old data is removed from the object storage but it's just ignored.
2019-07-17 15:16:35 +00:00
time.Sleep(5 * time.Second)
t.Logf("stopping etcd")
// Reset etcd
shutdownEtcd(tetcd)
datamanager tests: don't wait for etcd down It is causing some timeout errors since there can be another instance from another test run in parallel started on the same port.
2019-12-02 12:32:57 +00:00
datamanager: implement import/export * export: exports the newest data checkpoint. It forces a checkpoint before exporting (currently no wals are exported) * import: cleans up etcd, creates a new datasnaphot from the provided import stream and then initializes etcd. Currently no old data is removed from the object storage but it's just ignored.
2019-07-17 15:16:35 +00:00
t.Logf("resetting etcd")
os.RemoveAll(etcdDir)
t.Logf("starting etcd")
*: use zerolog for logging Replace zap with zerolog. zerolog has a cleaner interface and can be easily configured with custom error chain printing using a new error handling library that will be implemented in another PR.
2022-02-21 17:07:58 +00:00
tetcd = setupEtcd(t, log, etcdDir)
datamanager: implement import/export * export: exports the newest data checkpoint. It forces a checkpoint before exporting (currently no wals are exported) * import: cleans up etcd, creates a new datasnaphot from the provided import stream and then initializes etcd. Currently no old data is removed from the object storage but it's just ignored.
2019-07-17 15:16:35 +00:00
if err := tetcd.Start(); err != nil {
t.Fatalf("unexpected err: %v", err)
}
defer shutdownEtcd(tetcd)
ostDir, err = ioutil.TempDir(dir, "ost")
if err != nil {
t.Fatalf("unexpected err: %v", err)
}
objectstorage: use a single package remove all the subpackages and just use a single package
2019-11-08 15:25:53 +00:00
ost, err = objectstorage.NewPosix(ostDir)
datamanager: implement import/export * export: exports the newest data checkpoint. It forces a checkpoint before exporting (currently no wals are exported) * import: cleans up etcd, creates a new datasnaphot from the provided import stream and then initializes etcd. Currently no old data is removed from the object storage but it's just ignored.
2019-07-17 15:16:35 +00:00
if err != nil {
t.Fatalf("unexpected err: %v", err)
}
ctx, cancel = context.WithCancel(context.Background())
dmConfig = &DataManagerConfig{
BasePath: "basepath",
E: tetcd.TestEtcd.Store,
OST: objectstorage.NewObjStorage(ost, "/"),
// remove almost all wals to see that they are removed also from changes
EtcdWalsKeepNum: 1,
DataTypes: []string{"datatype01", "datatype02"},
// checkpoint also with only one wal
MinCheckpointWalsNum: 1,
// use a small maxDataFileSize
MaxDataFileSize: 10 * 1024,
MaintenanceMode: true,
}
*: use zerolog for logging Replace zap with zerolog. zerolog has a cleaner interface and can be easily configured with custom error chain printing using a new error handling library that will be implemented in another PR.
2022-02-21 17:07:58 +00:00
dm, err = NewDataManager(ctx, log, dmConfig)
datamanager: implement import/export * export: exports the newest data checkpoint. It forces a checkpoint before exporting (currently no wals are exported) * import: cleans up etcd, creates a new datasnaphot from the provided import stream and then initializes etcd. Currently no old data is removed from the object storage but it's just ignored.
2019-07-17 15:16:35 +00:00
if err != nil {
t.Fatalf("unexpected err: %v", err)
}
dmReadyCh = make(chan struct{})
go func() { _ = dm.Run(ctx, dmReadyCh) }()
<-dmReadyCh
time.Sleep(5 * time.Second)
if err := dm.Import(ctx, &export); err != nil {
t.Fatalf("unexpected err: %v", err)
}
if err := checkDataFiles(ctx, t, dm, expectedEntries); err != nil {
t.Fatalf("unexpected err: %v", err)
}
t.Logf("stopping datamanager")
cancel()
time.Sleep(5 * time.Second)
ctx = context.Background()
// restart datamanager in normal mode
dmConfig = &DataManagerConfig{
BasePath: "basepath",
E: tetcd.TestEtcd.Store,
OST: objectstorage.NewObjStorage(ost, "/"),
// remove almost all wals to see that they are removed also from changes
EtcdWalsKeepNum: 1,
DataTypes: []string{"datatype01", "datatype02"},
// checkpoint also with only one wal
MinCheckpointWalsNum: 1,
// use a small maxDataFileSize
MaxDataFileSize: 10 * 1024,
}
*: use zerolog for logging Replace zap with zerolog. zerolog has a cleaner interface and can be easily configured with custom error chain printing using a new error handling library that will be implemented in another PR.
2022-02-21 17:07:58 +00:00
dm, err = NewDataManager(ctx, log, dmConfig)
datamanager: implement import/export * export: exports the newest data checkpoint. It forces a checkpoint before exporting (currently no wals are exported) * import: cleans up etcd, creates a new datasnaphot from the provided import stream and then initializes etcd. Currently no old data is removed from the object storage but it's just ignored.
2019-07-17 15:16:35 +00:00
if err != nil {
t.Fatalf("unexpected err: %v", err)
}
dmReadyCh = make(chan struct{})
go func() { _ = dm.Run(ctx, dmReadyCh) }()
<-dmReadyCh
time.Sleep(5 * time.Second)
if err := checkDataFiles(ctx, t, dm, expectedEntries); err != nil {
t.Fatalf("unexpected err: %v", err)
}
actionGroups = [][]*Action{}
actions = []*Action{}
for i := 400; i < 600; i++ {
action := &Action{
ActionType: ActionTypePut,
ID: fmt.Sprintf("object%04d", i),
DataType: "datatype01",
Data: []byte(fmt.Sprintf(`{ "ID": "%d", "Contents": %s }`, i, contents)),
datamanager: implement data files splitting split data files in multiple files of a max size (default 10Mib) In this way every data snapshot will change only the datafiles that have some changes instead of the whole single file.
2019-06-03 14:17:27 +00:00
}
datamanager: implement import/export * export: exports the newest data checkpoint. It forces a checkpoint before exporting (currently no wals are exported) * import: cleans up etcd, creates a new datasnaphot from the provided import stream and then initializes etcd. Currently no old data is removed from the object storage but it's just ignored.
2019-07-17 15:16:35 +00:00
actions = append(actions, action)
}
actionGroups = append(actionGroups, actions)
datamanager: implement data files splitting split data files in multiple files of a max size (default 10Mib) In this way every data snapshot will change only the datafiles that have some changes instead of the whole single file.
2019-06-03 14:17:27 +00:00
datamanager: implement import/export * export: exports the newest data checkpoint. It forces a checkpoint before exporting (currently no wals are exported) * import: cleans up etcd, creates a new datasnaphot from the provided import stream and then initializes etcd. Currently no old data is removed from the object storage but it's just ignored.
2019-07-17 15:16:35 +00:00
actions = []*Action{}
for i := 1000; i < 1400; i++ {
action := &Action{
ActionType: ActionTypePut,
ID: fmt.Sprintf("object%04d", i),
DataType: "datatype02",
Data: []byte(fmt.Sprintf(`{ "ID": "%d", "Contents": %s }`, i, contents)),
datamanager: implement data files splitting split data files in multiple files of a max size (default 10Mib) In this way every data snapshot will change only the datafiles that have some changes instead of the whole single file.
2019-06-03 14:17:27 +00:00
}
datamanager: implement import/export * export: exports the newest data checkpoint. It forces a checkpoint before exporting (currently no wals are exported) * import: cleans up etcd, creates a new datasnaphot from the provided import stream and then initializes etcd. Currently no old data is removed from the object storage but it's just ignored.
2019-07-17 15:16:35 +00:00
actions = append(actions, action)
}
actionGroups = append(actionGroups, actions)
for _, actionGroup := range actionGroups {
for _, action := range actionGroup {
switch action.ActionType {
case ActionTypePut:
expectedEntries[action.ID] = &DataEntry{ID: action.ID, DataType: action.DataType, Data: action.Data}
case ActionTypeDelete:
delete(expectedEntries, action.ID)
}
datamanager: implement data files splitting split data files in multiple files of a max size (default 10Mib) In this way every data snapshot will change only the datafiles that have some changes instead of the whole single file.
2019-06-03 14:17:27 +00:00
}
}
datamanager: implement import/export * export: exports the newest data checkpoint. It forces a checkpoint before exporting (currently no wals are exported) * import: cleans up etcd, creates a new datasnaphot from the provided import stream and then initializes etcd. Currently no old data is removed from the object storage but it's just ignored.
2019-07-17 15:16:35 +00:00
for _, actionGroup := range actionGroups {
// populate with a wal
_, err := dm.WriteWal(ctx, actionGroup, nil)
if err != nil {
t.Fatalf("unexpected err: %v", err)
}
datamanager: implement data files splitting split data files in multiple files of a max size (default 10Mib) In this way every data snapshot will change only the datafiles that have some changes instead of the whole single file.
2019-06-03 14:17:27 +00:00
}
datamanager: implement import/export * export: exports the newest data checkpoint. It forces a checkpoint before exporting (currently no wals are exported) * import: cleans up etcd, creates a new datasnaphot from the provided import stream and then initializes etcd. Currently no old data is removed from the object storage but it's just ignored.
2019-07-17 15:16:35 +00:00
// wait for the event to be read
time.Sleep(500 * time.Millisecond)
if err := dm.checkpoint(ctx, false); err != nil {
t.Fatalf("unexpected err: %v", err)
datamanager: implement data files splitting split data files in multiple files of a max size (default 10Mib) In this way every data snapshot will change only the datafiles that have some changes instead of the whole single file.
2019-06-03 14:17:27 +00:00
}
datamanager: implement import/export * export: exports the newest data checkpoint. It forces a checkpoint before exporting (currently no wals are exported) * import: cleans up etcd, creates a new datasnaphot from the provided import stream and then initializes etcd. Currently no old data is removed from the object storage but it's just ignored.
2019-07-17 15:16:35 +00:00
if err := checkDataFiles(ctx, t, dm, expectedEntries); err != nil {
t.Fatalf("unexpected err: %v", err)
}
datamanager: implement data files splitting split data files in multiple files of a max size (default 10Mib) In this way every data snapshot will change only the datafiles that have some changes instead of the whole single file.
2019-06-03 14:17:27 +00:00
}