a
/
agola
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

gateway: show run/tasks/steps if the project is public 

If the project is public don't require the user to be logged in to show the
run/tasks/logs
This commit is contained in:
Simone Gotti 2019-07-01 16:40:02 +02:00
parent 8d67844cc4
commit 5c2bf8642f
2 changed files with 5 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
internal/services/gateway/action/auth.go
View File

@ -194,13 +194,13 @@ func (h *ActionHandler) CanGetRun(ctx context.Context, runGroup string) (bool, e
visibility = types.VisibilityPrivate visibility = types.VisibilityPrivate
} }
if visibility == types.VisibilityPublic {
return true, nil
}
isProjectMember, err := h.IsProjectMember(ctx, ownerType, ownerID) isProjectMember, err := h.IsProjectMember(ctx, ownerType, ownerID)
if err != nil { if err != nil {
return false, errors.Errorf("failed to determine ownership: %w", err) return false, errors.Errorf("failed to determine ownership: %w", err)
} }
if visibility == types.VisibilityPublic {
return true, nil
}
if !isProjectMember { if !isProjectMember {
return false, nil return false, nil
} }

4
internal/services/gateway/gateway.go
View File

@ -286,9 +286,9 @@ func (g *Gateway) Run(ctx context.Context) error {
apirouter.Handle("/orgs/{orgref}/members/{userref}", authForcedHandler(addOrgMemberHandler)).Methods("PUT") apirouter.Handle("/orgs/{orgref}/members/{userref}", authForcedHandler(addOrgMemberHandler)).Methods("PUT")
apirouter.Handle("/orgs/{orgref}/members/{userref}", authForcedHandler(removeOrgMemberHandler)).Methods("DELETE") apirouter.Handle("/orgs/{orgref}/members/{userref}", authForcedHandler(removeOrgMemberHandler)).Methods("DELETE")
apirouter.Handle("/runs/{runid}", authForcedHandler(runHandler)).Methods("GET") apirouter.Handle("/runs/{runid}", authOptionalHandler(runHandler)).Methods("GET")
apirouter.Handle("/runs/{runid}/actions", authForcedHandler(runActionsHandler)).Methods("PUT") apirouter.Handle("/runs/{runid}/actions", authForcedHandler(runActionsHandler)).Methods("PUT")
apirouter.Handle("/runs/{runid}/tasks/{taskid}", authForcedHandler(runtaskHandler)).Methods("GET") apirouter.Handle("/runs/{runid}/tasks/{taskid}", authOptionalHandler(runtaskHandler)).Methods("GET")
apirouter.Handle("/runs/{runid}/tasks/{taskid}/actions", authForcedHandler(runTaskActionsHandler)).Methods("PUT") apirouter.Handle("/runs/{runid}/tasks/{taskid}/actions", authForcedHandler(runTaskActionsHandler)).Methods("PUT")
apirouter.Handle("/runs", authForcedHandler(runsHandler)).Methods("GET") apirouter.Handle("/runs", authForcedHandler(runsHandler)).Methods("GET")