From 97d145a9d3f1f7a9dbfc90bd65f9259c7238cb3b Mon Sep 17 00:00:00 2001 From: Simone Gotti Date: Fri, 28 Feb 2020 10:42:46 +0100 Subject: [PATCH] executor: fix stopping of not running tasks When a related runningTask doesn't exist and the executor task status is running just report it as failed ignoring if it's marked to stop. --- internal/services/executor/executor.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/internal/services/executor/executor.go b/internal/services/executor/executor.go index d006a59..b535c57 100644 --- a/internal/services/executor/executor.go +++ b/internal/services/executor/executor.go @@ -1168,7 +1168,7 @@ func (e *Executor) taskUpdater(ctx context.Context, et *types.ExecutorTask) { }() } - if !et.Spec.Stop && et.Status.Phase == types.ExecutorTaskPhaseRunning { + if et.Status.Phase == types.ExecutorTaskPhaseRunning { log.Infof("marking executor task %s as failed since there's no running task", et.ID) et.Status.Phase = types.ExecutorTaskPhaseFailed et.Status.EndTime = util.TimeP(time.Now())