From afece4d8467713ee8d0a1e6ab477e6d43ffc5394 Mon Sep 17 00:00:00 2001
From: Simone Gotti <simone.gotti@gmail.com>
Date: Tue, 25 May 2021 10:27:04 +0200
Subject: [PATCH] executor: use busybox:stable as default init image

Use "busybox:stable" as default init image name so it won't be checked/pulled
any time.
---
 internal/services/config/config.go               | 2 +-
 internal/services/executor/driver/docker_test.go | 2 +-
 internal/services/executor/driver/k8s_test.go    | 2 +-
 tests/setup_test.go                              | 2 +-
 4 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/internal/services/config/config.go b/internal/services/config/config.go
index 9afe5b1..5f5046f 100644
--- a/internal/services/config/config.go
+++ b/internal/services/config/config.go
@@ -235,7 +235,7 @@ var defaultConfig = Config{
 	},
 	Executor: Executor{
 		InitImage: InitImage{
-			Image: "busybox",
+			Image: "busybox:stable",
 		},
 		ActiveTasksLimit: 2,
 	},
diff --git a/internal/services/executor/driver/docker_test.go b/internal/services/executor/driver/docker_test.go
index 119e28b..3f2813f 100644
--- a/internal/services/executor/driver/docker_test.go
+++ b/internal/services/executor/driver/docker_test.go
@@ -42,7 +42,7 @@ func TestDockerPod(t *testing.T) {
 
 	logger := zaptest.NewLogger(t, zaptest.Level(zap.InfoLevel))
 
-	initImage := "busybox"
+	initImage := "busybox:stable"
 
 	d, err := NewDockerDriver(logger, "executorid01", toolboxPath, initImage)
 	if err != nil {
diff --git a/internal/services/executor/driver/k8s_test.go b/internal/services/executor/driver/k8s_test.go
index 75a5c27..41d0859 100644
--- a/internal/services/executor/driver/k8s_test.go
+++ b/internal/services/executor/driver/k8s_test.go
@@ -41,7 +41,7 @@ func TestK8sPod(t *testing.T) {
 
 	logger := zaptest.NewLogger(t, zaptest.Level(zap.InfoLevel))
 
-	initImage := "busybox"
+	initImage := "busybox:stable"
 
 	d, err := NewK8sDriver(logger, "executorid01", toolboxPath, initImage)
 	if err != nil {
diff --git a/tests/setup_test.go b/tests/setup_test.go
index 698f163..a9776c6 100644
--- a/tests/setup_test.go
+++ b/tests/setup_test.go
@@ -265,7 +265,7 @@ func setup(ctx context.Context, t *testing.T, dir string) (*testutil.TestEmbedde
 			Labels:           map[string]string{},
 			ActiveTasksLimit: 2,
 			InitImage: config.InitImage{
-				Image: "busybox",
+				Image: "busybox:stable",
 			},
 		},
 		Configstore: config.Configstore{