a/agola
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

runservice: check changegroup name

Browse Source
This commit is contained in:
Simone Gotti 2019-04-29 10:12:34 +02:00
parent b85786dc56
commit f5cf3b9fa7
1 changed files with 16 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
internal/services/runservice/scheduler/store/store.go
View File

@ -33,6 +33,10 @@ import (
etcdclientv3 "go.etcd.io/etcd/clientv3" etcdclientv3 "go.etcd.io/etcd/clientv3"
) )
const (
MaxChangegroupNameLength = 256
)
func OSTSubGroupsAndGroupTypes(group string) []string { func OSTSubGroupsAndGroupTypes(group string) []string {
h := util.PathHierarchy(group) h := util.PathHierarchy(group)
if len(h)%2 != 1 { if len(h)%2 != 1 {
@ -388,6 +392,18 @@ func GetRun(ctx context.Context, e *etcd.Store, runID string) (*types.Run, int64
} }
func AtomicPutRun(ctx context.Context, e *etcd.Store, r *types.Run, runEvent *common.RunEvent, cgt *types.ChangeGroupsUpdateToken) (*types.Run, error) { func AtomicPutRun(ctx context.Context, e *etcd.Store, r *types.Run, runEvent *common.RunEvent, cgt *types.ChangeGroupsUpdateToken) (*types.Run, error) {
// check changegroups name
if cgt != nil {
for cgName := range cgt.ChangeGroupsRevisions {
if strings.Contains(cgName, "/") {
return nil, fmt.Errorf(`changegroup name %q must not contain "/"`, cgName)
}
if len(cgName) > MaxChangegroupNameLength {
return nil, fmt.Errorf("changegroup name %q too long", cgName)
}
}
}
// insert only if the run as changed // insert only if the run as changed
curRun, _, err := GetRun(ctx, e, r.ID) curRun, _, err := GetRun(ctx, e, r.ID)
if err != nil && err != etcd.ErrKeyNotFound { if err != nil && err != etcd.ErrKeyNotFound {