4d7605a86b
Don't create an ErrFromRemote wrapping the returned error but wrap the ErrFromRemote Also use xerrors Is/As to get the underlying error to return to api clients while maintaining context for logging
131 lines
3.4 KiB
Go
131 lines
3.4 KiB
Go
// Copyright 2019 Sorint.lab
|
|
//
|
|
// Licensed under the Apache License, Version 2.0 (the "License");
|
|
// you may not use this file except in compliance with the License.
|
|
// You may obtain a copy of the License at
|
|
//
|
|
// http://www.apache.org/licenses/LICENSE-2.0
|
|
//
|
|
// Unless required by applicable law or agreed to in writing, software
|
|
// distributed under the License is distributed on an "AS IS" BASIS,
|
|
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied
|
|
// See the License for the specific language governing permissions and
|
|
// limitations under the License.
|
|
|
|
package api
|
|
|
|
import (
|
|
"encoding/json"
|
|
"net/http"
|
|
"net/url"
|
|
|
|
"github.com/gorilla/mux"
|
|
"github.com/sorintlab/agola/internal/services/types"
|
|
"github.com/sorintlab/agola/internal/util"
|
|
errors "golang.org/x/xerrors"
|
|
)
|
|
|
|
type ErrorResponse struct {
|
|
Message string `json:"message"`
|
|
}
|
|
|
|
func ErrorResponseFromError(err error) *ErrorResponse {
|
|
var aerr error
|
|
// use inner errors if of these types
|
|
switch {
|
|
case errors.Is(err, &util.ErrBadRequest{}):
|
|
var cerr *util.ErrBadRequest
|
|
errors.As(err, &cerr)
|
|
aerr = cerr
|
|
case errors.Is(err, &util.ErrNotFound{}):
|
|
var cerr *util.ErrNotFound
|
|
errors.As(err, &cerr)
|
|
aerr = cerr
|
|
case errors.Is(err, &util.ErrForbidden{}):
|
|
var cerr *util.ErrForbidden
|
|
errors.As(err, &cerr)
|
|
aerr = cerr
|
|
case errors.Is(err, &util.ErrUnauthorized{}):
|
|
var cerr *util.ErrUnauthorized
|
|
errors.As(err, &cerr)
|
|
aerr = cerr
|
|
}
|
|
|
|
if aerr != nil {
|
|
return &ErrorResponse{Message: aerr.Error()}
|
|
}
|
|
|
|
// on generic error return an generic message to not leak the real error
|
|
return &ErrorResponse{Message: "internal server error"}
|
|
}
|
|
|
|
func httpError(w http.ResponseWriter, err error) bool {
|
|
if err == nil {
|
|
return false
|
|
}
|
|
|
|
response := ErrorResponseFromError(err)
|
|
resj, merr := json.Marshal(response)
|
|
if merr != nil {
|
|
w.WriteHeader(http.StatusInternalServerError)
|
|
return true
|
|
}
|
|
switch {
|
|
case errors.Is(err, &util.ErrBadRequest{}):
|
|
w.WriteHeader(http.StatusBadRequest)
|
|
w.Write(resj)
|
|
case errors.Is(err, &util.ErrNotFound{}):
|
|
w.WriteHeader(http.StatusNotFound)
|
|
w.Write(resj)
|
|
case errors.Is(err, &util.ErrForbidden{}):
|
|
w.WriteHeader(http.StatusForbidden)
|
|
w.Write(resj)
|
|
case errors.Is(err, &util.ErrUnauthorized{}):
|
|
w.WriteHeader(http.StatusUnauthorized)
|
|
w.Write(resj)
|
|
default:
|
|
w.WriteHeader(http.StatusInternalServerError)
|
|
w.Write(resj)
|
|
}
|
|
return true
|
|
}
|
|
|
|
func httpResponse(w http.ResponseWriter, code int, res interface{}) error {
|
|
w.Header().Set("Content-Type", "application/json")
|
|
|
|
if res != nil {
|
|
resj, err := json.Marshal(res)
|
|
if err != nil {
|
|
httpError(w, err)
|
|
return err
|
|
}
|
|
w.WriteHeader(code)
|
|
_, err = w.Write(resj)
|
|
return err
|
|
}
|
|
|
|
w.WriteHeader(code)
|
|
return nil
|
|
}
|
|
|
|
func GetConfigTypeRef(r *http.Request) (types.ConfigType, string, error) {
|
|
vars := mux.Vars(r)
|
|
projectRef, err := url.PathUnescape(vars["projectref"])
|
|
if err != nil {
|
|
return "", "", util.NewErrBadRequest(errors.Errorf("wrong projectref %q: %w", vars["projectref"], err))
|
|
}
|
|
if projectRef != "" {
|
|
return types.ConfigTypeProject, projectRef, nil
|
|
}
|
|
|
|
projectGroupRef, err := url.PathUnescape(vars["projectgroupref"])
|
|
if err != nil {
|
|
return "", "", util.NewErrBadRequest(errors.Errorf("wrong projectgroupref %q: %w", vars["projectgroupref"], err))
|
|
}
|
|
if projectGroupRef != "" {
|
|
return types.ConfigTypeProjectGroup, projectGroupRef, nil
|
|
}
|
|
|
|
return "", "", util.NewErrBadRequest(errors.Errorf("cannot get project or projectgroup ref"))
|
|
}
|