a
/
agola
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity
agola/internal/runconfig/runconfig_test.go

685 lines
13 KiB
Go
Raw Blame History

// Copyright 2019 Sorint.lab
//
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
// You may obtain a copy of the License at
//
// http://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by applicable law or agreed to in writing, software
// distributed under the License is distributed on an "AS IS" BASIS,
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied
// See the License for the specific language governing permissions and
// limitations under the License.
package runconfig
import (
"fmt"
"reflect"
"testing"
"github.com/pkg/errors"
"github.com/sorintlab/agola/internal/services/runservice/types"
"github.com/sorintlab/agola/internal/util"
)
func TestGenTasksLevels(t *testing.T) {
type task struct {
ID string
Level int
Depends []*types.RunConfigTaskDepend
}
tests := []struct {
name string
in []task
out []task
err error
}{
{
name: "test single task",
in: []task{
{
ID: "1",
Level: -1,
},
},
out: []task{
{
ID: "1",
Level: 0,
},
},
},
{
name: "test multiple root tasks",
in: []task{
{
ID: "1",
Level: -1,
},
{
ID: "2",
Level: -1,
},
},
out: []task{
{
ID: "1",
Level: 0,
},
{
ID: "2",
Level: 0,
},
},
},
{
name: "test dependency between two tasks",
in: []task{
{
ID: "1",
Level: -1,
},
{
ID: "2",
Level: -1,
Depends: []*types.RunConfigTaskDepend{
&types.RunConfigTaskDepend{
TaskID: "1",
},
},
},
},
out: []task{
{
ID: "1",
Level: 0,
},
{
ID: "2",
Level: 1,
Depends: []*types.RunConfigTaskDepend{
&types.RunConfigTaskDepend{
TaskID: "1",
},
},
},
},
},
{
name: "Test circular dependency between two tasks: a -> b -> a",
in: []task{
{
ID: "1",
Level: -1,
Depends: []*types.RunConfigTaskDepend{
&types.RunConfigTaskDepend{
TaskID: "2",
},
},
},
{
ID: "2",
Level: -1,
Depends: []*types.RunConfigTaskDepend{
&types.RunConfigTaskDepend{
TaskID: "1",
},
},
},
},
err: fmt.Errorf("circular dependency detected"),
},
{
name: "Test circular dependency between 3 tasks: a -> b -> c -> a",
in: []task{
{
ID: "1",
Level: -1,
Depends: []*types.RunConfigTaskDepend{
&types.RunConfigTaskDepend{
TaskID: "2",
},
},
},
{
ID: "2",
Level: -1,
Depends: []*types.RunConfigTaskDepend{
&types.RunConfigTaskDepend{
TaskID: "3",
},
},
},
{
ID: "3",
Level: -1,
Depends: []*types.RunConfigTaskDepend{
&types.RunConfigTaskDepend{
TaskID: "1",
},
},
},
},
err: fmt.Errorf("circular dependency detected"),
},
{
name: "Test circular dependency between 3 tasks: a -> b -> c -> b",
in: []task{
{
ID: "1",
Level: -1,
Depends: []*types.RunConfigTaskDepend{
&types.RunConfigTaskDepend{
TaskID: "2",
},
},
},
{
ID: "2",
Level: -1,
Depends: []*types.RunConfigTaskDepend{
&types.RunConfigTaskDepend{
TaskID: "3",
},
},
},
{
ID: "3",
Level: -1,
Depends: []*types.RunConfigTaskDepend{
&types.RunConfigTaskDepend{
TaskID: "2",
},
},
},
},
err: fmt.Errorf("circular dependency detected"),
},
}
for _, tt := range tests {
t.Run(tt.name, func(t *testing.T) {
inRunConfig := &types.RunConfig{Tasks: map[string]*types.RunConfigTask{}}
for _, t := range tt.in {
inRunConfig.Tasks[t.ID] = &types.RunConfigTask{
ID: t.ID,
Level: t.Level,
Depends: t.Depends,
}
}
outRunConfig := &types.RunConfig{Tasks: map[string]*types.RunConfigTask{}}
for _, t := range tt.out {
outRunConfig.Tasks[t.ID] = &types.RunConfigTask{
ID: t.ID,
Level: t.Level,
Depends: t.Depends,
}
}
if err := GenTasksLevels(inRunConfig); err != nil {
if err.Error() != tt.err.Error() {
t.Fatalf("got error: %v, want error: %v", err, tt.err)
}
return
}
if tt.err != nil {
t.Fatalf("got nil error, want error: %v", tt.err)
}
if !reflect.DeepEqual(inRunConfig.Tasks, outRunConfig.Tasks) {
t.Fatalf("got %s, expected %s", util.Dump(inRunConfig), util.Dump(outRunConfig))
}
})
}
}
func TestGetAllParents(t *testing.T) {
type task struct {
ID string
Level int
Depends []*types.RunConfigTaskDepend
}
tests := []struct {
name string
in []task
out map[string][]string
}{
{
name: "test single task",
in: []task{
{
ID: "1",
Level: -1,
},
},
out: map[string][]string{
"1": []string{},
},
},
{
name: "test multiple root tasks",
in: []task{
{
ID: "1",
Level: -1,
},
{
ID: "2",
Level: -1,
},
},
out: map[string][]string{
"1": []string{},
"2": []string{},
},
},
{
name: "test dependency from a task to itself",
in: []task{
{
ID: "1",
Level: -1,
Depends: []*types.RunConfigTaskDepend{
&types.RunConfigTaskDepend{
TaskID: "1",
},
},
},
},
out: map[string][]string{
"1": []string{"1"},
},
},
{
name: "test dependency between two tasks",
in: []task{
{
ID: "1",
Level: -1,
},
{
ID: "2",
Level: -1,
Depends: []*types.RunConfigTaskDepend{
&types.RunConfigTaskDepend{
TaskID: "1",
},
},
},
},
out: map[string][]string{
"1": []string{},
"2": []string{"1"},
},
},
{
name: "Test dependency between 5 tasks: a -> (b, c) -> (d, e)",
in: []task{
{
ID: "1",
Level: -1,
Depends: []*types.RunConfigTaskDepend{
&types.RunConfigTaskDepend{
TaskID: "2",
},
&types.RunConfigTaskDepend{
TaskID: "3",
},
},
},
{
ID: "2",
Level: -1,
Depends: []*types.RunConfigTaskDepend{
&types.RunConfigTaskDepend{
TaskID: "4",
},
},
},
{
ID: "3",
Level: -1,
Depends: []*types.RunConfigTaskDepend{
&types.RunConfigTaskDepend{
TaskID: "5",
},
},
},
{
ID: "4",
Level: -1,
},
{
ID: "5",
Level: -1,
},
},
out: map[string][]string{
"1": []string{"2", "3", "4", "5"},
"2": []string{"4"},
"3": []string{"5"},
"4": []string{},
"5": []string{},
},
},
{
name: "Test circular dependency between two tasks: a -> b -> a",
in: []task{
{
ID: "1",
Level: -1,
Depends: []*types.RunConfigTaskDepend{
&types.RunConfigTaskDepend{
TaskID: "2",
},
},
},
{
ID: "2",
Level: -1,
Depends: []*types.RunConfigTaskDepend{
&types.RunConfigTaskDepend{
TaskID: "1",
},
},
},
},
out: map[string][]string{
"1": []string{"2", "1"},
"2": []string{"1", "2"},
},
},
{
name: "Test circular dependency between 3 tasks: a -> b -> c -> a",
in: []task{
{
ID: "1",
Level: -1,
Depends: []*types.RunConfigTaskDepend{
&types.RunConfigTaskDepend{
TaskID: "2",
},
},
},
{
ID: "2",
Level: -1,
Depends: []*types.RunConfigTaskDepend{
&types.RunConfigTaskDepend{
TaskID: "3",
},
},
},
{
ID: "3",
Level: -1,
Depends: []*types.RunConfigTaskDepend{
&types.RunConfigTaskDepend{
TaskID: "1",
},
},
},
},
out: map[string][]string{
"1": []string{"2", "3", "1"},
"2": []string{"3", "1", "2"},
"3": []string{"1", "2", "3"},
},
},
{
name: "Test circular dependency between 3 tasks: a -> b -> c -> b",
in: []task{
{
ID: "1",
Level: -1,
Depends: []*types.RunConfigTaskDepend{
&types.RunConfigTaskDepend{
TaskID: "2",
},
},
},
{
ID: "2",
Level: -1,
Depends: []*types.RunConfigTaskDepend{
&types.RunConfigTaskDepend{
TaskID: "3",
},
},
},
{
ID: "3",
Level: -1,
Depends: []*types.RunConfigTaskDepend{
&types.RunConfigTaskDepend{
TaskID: "2",
},
},
},
},
out: map[string][]string{
"1": []string{"2", "3"},
"2": []string{"3", "2"},
"3": []string{"2", "3"},
},
},
}
for _, tt := range tests {
t.Run(tt.name, func(t *testing.T) {
inRunConfig := &types.RunConfig{Tasks: map[string]*types.RunConfigTask{}}
for _, t := range tt.in {
inRunConfig.Tasks[t.ID] = &types.RunConfigTask{
ID: t.ID,
Level: t.Level,
Depends: t.Depends,
}
}
for _, task := range inRunConfig.Tasks {
allParents := GetAllParents(inRunConfig, task)
allParentsList := []string{}
for _, p := range allParents {
allParentsList = append(allParentsList, p.ID)
}
if !util.CompareStringSliceNoOrder(tt.out[task.ID], allParentsList) {
t.Fatalf("task: %s, got %s, expected %s", task.ID, util.Dump(allParentsList), util.Dump(tt.out[task.ID]))
}
}
})
}
}
func TestCheckRunConfig(t *testing.T) {
type task struct {
ID string
Level int
Depends []*types.RunConfigTaskDepend
}
tests := []struct {
name string
in []task
err error
}{
{
name: "test single task",
in: []task{
{
ID: "1",
Level: -1,
},
},
},
{
name: "test multiple root tasks",
in: []task{
{
ID: "1",
Level: -1,
},
{
ID: "2",
Level: -1,
},
},
},
{
name: "test dependency between two tasks",
in: []task{
{
ID: "1",
Level: -1,
},
{
ID: "2",
Level: -1,
Depends: []*types.RunConfigTaskDepend{
&types.RunConfigTaskDepend{
TaskID: "1",
},
},
},
},
},
{
name: "Test circular dependency between two tasks: a -> b -> a",
in: []task{
{
ID: "1",
Level: -1,
Depends: []*types.RunConfigTaskDepend{
&types.RunConfigTaskDepend{
TaskID: "2",
},
},
},
{
ID: "2",
Level: -1,
Depends: []*types.RunConfigTaskDepend{
&types.RunConfigTaskDepend{
TaskID: "1",
},
},
},
},
err: &util.Errors{
Errs: []error{
errors.Errorf("circular dependency between task %q and tasks %q", "task1", "task2"),
errors.Errorf("circular dependency between task %q and tasks %q", "task2", "task1"),
},
},
},
{
name: "Test circular dependency between 3 tasks: a -> b -> c -> a",
in: []task{
{
ID: "1",
Level: -1,
Depends: []*types.RunConfigTaskDepend{
&types.RunConfigTaskDepend{
TaskID: "2",
},
},
},
{
ID: "2",
Level: -1,
Depends: []*types.RunConfigTaskDepend{
&types.RunConfigTaskDepend{
TaskID: "3",
},
},
},
{
ID: "3",
Level: -1,
Depends: []*types.RunConfigTaskDepend{
&types.RunConfigTaskDepend{
TaskID: "1",
},
},
},
},
err: &util.Errors{
Errs: []error{
errors.Errorf("circular dependency between task %q and tasks %q", "task1", "task3"),
errors.Errorf("circular dependency between task %q and tasks %q", "task2", "task1"),
errors.Errorf("circular dependency between task %q and tasks %q", "task3", "task2"),
},
},
},
{
name: "Test circular dependency between 3 tasks: a -> b -> c -> b",
in: []task{
{
ID: "1",
Level: -1,
Depends: []*types.RunConfigTaskDepend{
&types.RunConfigTaskDepend{
TaskID: "2",
},
},
},
{
ID: "2",
Level: -1,
Depends: []*types.RunConfigTaskDepend{
&types.RunConfigTaskDepend{
TaskID: "3",
},
},
},
{
ID: "3",
Level: -1,
Depends: []*types.RunConfigTaskDepend{
&types.RunConfigTaskDepend{
TaskID: "2",
},
},
},
},
err: &util.Errors{
Errs: []error{
errors.Errorf("circular dependency between task %q and tasks %q", "task2", "task3"),
errors.Errorf("circular dependency between task %q and tasks %q", "task3", "task2"),
},
},
},
}
for _, tt := range tests {
t.Run(tt.name, func(t *testing.T) {
inRunConfig := &types.RunConfig{Tasks: map[string]*types.RunConfigTask{}}
for _, t := range tt.in {
inRunConfig.Tasks[t.ID] = &types.RunConfigTask{
Name: fmt.Sprintf("task%s", t.ID),
ID: t.ID,
Level: t.Level,
Depends: t.Depends,
}
}
if err := CheckRunConfig(inRunConfig); err != nil {
if errs, ok := err.(*util.Errors); ok {
if !errs.Equal(tt.err) {
t.Fatalf("got error: %v, want error: %v", err, tt.err)
}
} else {
if err.Error() != tt.err.Error() {
t.Fatalf("got error: %v, want error: %v", err, tt.err)
}
}
return
}
if tt.err != nil {
t.Fatalf("got nil error, want error: %v", tt.err)
}
})
}
}
Reference in New Issue View Git Blame Copy Permalink