agola/internal/services/gitserver/gitserver_test.go
Simone Gotti d2b09d854f *: use new errors handling library
Implement a new error handling library based on pkg/errors. It provides
stack saving on wrapping and exports some function to add stack saving
also to external errors.
It also implements custom zerolog error formatting without adding too
much verbosity by just printing the chain error file:line without a full
stack trace of every error.

* Add a --detailed-errors options to print error with they full chain
* Wrap all error returns. Use errors.WithStack to wrap without adding a
  new messsage and error.Wrap[f] to add a message.
* Add golangci-lint wrapcheck to check that external packages errors are
  wrapped. This won't check that internal packages error are wrapped.
  But we want also to ensure this case so we'll have to find something
  else to check also these.
2022-02-28 12:49:13 +01:00

205 lines
5.2 KiB
Go

// Copyright 2019 Sorint.lab
//
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
// You may obtain a copy of the License at
//
// http://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by applicable law or agreed to in writing, software
// distributed under the License is distributed on an "AS IS" BASIS,
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied
// See the License for the specific language governing permissions and
// limitations under the License.
package gitserver
import (
"context"
"io/ioutil"
"os"
"path/filepath"
"testing"
"time"
"agola.io/agola/internal/errors"
"agola.io/agola/internal/services/config"
"agola.io/agola/internal/testutil"
"agola.io/agola/internal/util"
)
const (
branchName = "master"
tagName = "v1.0"
)
func createTag(t *testing.T, ctx context.Context, git *util.Git, committerTime time.Time) {
if _, err := git.Output(ctx, nil, "branch", "test"); err != nil {
t.Fatalf("unexpected err: %v", err)
}
if _, err := git.Output(ctx, nil, "checkout", "test"); err != nil {
t.Fatalf("unexpected err: %v", err)
}
git.Env = append(git.Env, "GIT_COMMITTER_DATE="+committerTime.Format(time.RFC3339))
if _, err := git.Output(ctx, nil, "commit", "--allow-empty", "-m", "root commit"); err != nil {
t.Fatalf("unexpected err: %v", err)
}
if _, err := git.Output(ctx, nil, "tag", tagName, "-m", "tag test"); err != nil {
t.Fatalf("unexpected err: %v", err)
}
}
func createBranch(t *testing.T, ctx context.Context, git *util.Git, committerTime time.Time) {
git.Env = append(git.Env, "GIT_COMMITTER_DATE="+committerTime.Format(time.RFC3339))
if _, err := git.Output(ctx, nil, "commit", "--allow-empty", "-m", "'root commit'"); err != nil {
t.Fatalf("unexpected err: %v", err)
}
}
func TestRepoCleaner(t *testing.T) {
tests := []struct {
name string
branchOldTime bool
tagOldTime bool
}{
{
name: "test delete branch",
branchOldTime: true,
tagOldTime: false,
},
{
name: "test delete tag",
branchOldTime: false,
tagOldTime: true,
},
{
name: "test delete repository dir",
branchOldTime: true,
tagOldTime: true,
},
}
oldCommitterTime := time.Date(2015, time.January, 15, 1, 1, 1, 1, time.UTC)
for _, tt := range tests {
t.Run(tt.name, func(t *testing.T) {
log := testutil.NewLogger(t)
dir, err := ioutil.TempDir("", "agola")
if err != nil {
t.Fatalf("unexpected err: %v", err)
}
defer os.RemoveAll(dir)
ctx, cancel := context.WithCancel(context.Background())
defer cancel()
gitDataDir := filepath.Join(dir, "gitserver")
config := &config.Gitserver{
DataDir: gitDataDir,
RepositoryCleanupInterval: 10 * time.Second,
RepositoryRefsExpireInterval: 24 * time.Hour,
}
gs, err := NewGitserver(ctx, log, config)
if err != nil {
t.Fatalf("unexpected err: %v", err)
}
userDirRepo := filepath.Join(gitDataDir, "user01", "repo01")
err = os.MkdirAll(userDirRepo, os.ModePerm)
if err != nil {
t.Fatalf("unexpected err: %v", err)
}
git := &util.Git{GitDir: userDirRepo}
if _, err := git.Output(ctx, nil, "init"); err != nil {
t.Fatalf("unexpected err: %v", err)
}
if _, err := git.Output(ctx, nil, "config", "--unset", "core.bare"); err != nil {
t.Fatalf("unexpected err: %v", err)
}
if _, err := git.Output(ctx, nil, "config", "user.email", "user01@example.com"); err != nil {
t.Fatalf("unexpected err: %v", err)
}
if _, err := git.Output(ctx, nil, "config", "user.name", "user01"); err != nil {
t.Fatalf("unexpected err: %v", err)
}
var committerTime time.Time
if tt.branchOldTime {
committerTime = oldCommitterTime
} else {
committerTime = time.Now()
}
createBranch(t, ctx, git, committerTime)
if tt.tagOldTime {
committerTime = oldCommitterTime
} else {
committerTime = time.Now()
}
createTag(t, ctx, git, committerTime)
if _, err := git.Output(ctx, nil, "config", "--bool", "core.bare", "true"); err != nil {
t.Fatalf("unexpected err: %v", err)
}
if err := gs.scanRepos(ctx); err != nil {
t.Fatalf("unexpected err: %v", err)
}
if tt.branchOldTime && tt.tagOldTime {
_, err = os.Open(userDirRepo)
if !errors.Is(err, os.ErrNotExist) {
t.Fatalf("got %v error, want error: %v", err, os.ErrNotExist)
}
return
}
branches, err := gs.getBranches(git, ctx)
if err != nil {
t.Fatalf("unexpected err: %v", err)
}
found := false
for _, b := range branches {
if b == branchName {
found = true
break
}
}
if tt.branchOldTime && found {
t.Fatalf("expected branch %s deleted", branchName)
}
if !tt.branchOldTime && !found {
t.Fatalf("expected branch %s", branchName)
}
tags, err := gs.getTags(git, ctx)
if err != nil {
t.Fatalf("unexpected err: %v", err)
}
found = false
for _, b := range tags {
if b == tagName {
found = true
break
}
}
if tt.tagOldTime && found {
t.Fatalf("expected tag %s deleted", tagName)
}
if !tt.tagOldTime && !found {
t.Fatalf("expected tag %s", tagName)
}
})
}
}