a
/
badguardhome
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

- control: fix race in /control/version.json handler

This commit is contained in:
Simon Zolin 2019-04-24 15:02:41 +03:00 committed by Ildar Kamalov
parent 7bb40bca0f
commit 392c7b6ee1
1 changed files with 10 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
control.go
View File

@ -559,11 +559,17 @@ func checkDNS(input string, bootstrap []string) error {
func handleGetVersionJSON(w http.ResponseWriter, r *http.Request) { func handleGetVersionJSON(w http.ResponseWriter, r *http.Request) {
log.Tracef("%s %v", r.Method, r.URL) log.Tracef("%s %v", r.Method, r.URL)
now := time.Now() now := time.Now()
if now.Sub(versionCheckLastTime) <= versionCheckPeriod && len(versionCheckJSON) != 0 { controlLock.Lock()
cached := now.Sub(versionCheckLastTime) <= versionCheckPeriod && len(versionCheckJSON) != 0
data := versionCheckJSON
controlLock.Unlock()
if cached {
// return cached copy // return cached copy
w.Header().Set("Content-Type", "application/json") w.Header().Set("Content-Type", "application/json")
w.Write(versionCheckJSON) w.Write(data)
return return
} }
@ -589,8 +595,10 @@ func handleGetVersionJSON(w http.ResponseWriter, r *http.Request) {
httpError(w, http.StatusInternalServerError, "Couldn't write body: %s", err) httpError(w, http.StatusInternalServerError, "Couldn't write body: %s", err)
} }
controlLock.Lock()
versionCheckLastTime = now versionCheckLastTime = now
versionCheckJSON = body versionCheckJSON = body
controlLock.Unlock()
} }
// --------- // ---------