From 531ee2098845401adf202c8b95346ed918c1940d Mon Sep 17 00:00:00 2001 From: Ildar Kamalov Date: Fri, 5 Jul 2019 14:54:52 +0300 Subject: [PATCH] * client: show DNS-over-HTTPS and DNS-over-TLS addresses --- client/src/__locales/en.json | 7 +- .../components/Settings/Encryption/Form.js | 4 +- client/src/components/SetupGuide/index.js | 2 +- client/src/components/ui/Guide.js | 647 ++++++++++-------- client/src/helpers/form.js | 9 + 5 files changed, 376 insertions(+), 293 deletions(-) diff --git a/client/src/__locales/en.json b/client/src/__locales/en.json index 7830de81..7b166c3a 100644 --- a/client/src/__locales/en.json +++ b/client/src/__locales/en.json @@ -201,12 +201,12 @@ "install_auth_password_enter": "Enter password", "install_step": "Step", "install_devices_title": "Configure your devices", - "install_devices_desc": "In order for AdGuard Home to start working, you need to configure your devices to use it.", + "install_devices_desc": "To start using AdGuard Home, you need to configure your devices to use it.", "install_submit_title": "Congratulations!", "install_submit_desc": "The setup procedure is finished and you are ready to start using AdGuard Home.", "install_devices_router": "Router", "install_devices_router_desc": "This setup will automatically cover all the devices connected to your home router and you will not need to configure each of them manually.", - "install_devices_address": "AdGuard Home DNS server is listening to the following addresses", + "install_devices_address": "AdGuard Home DNS server is listening on the following addresses", "install_devices_router_list_1": "Open the preferences for your router. Usually, you can access it from your browser via a URL (like http:\/\/192.168.0.1\/ or http:\/\/192.168.1.1\/). You may be asked to enter the password. If you don't remember it, you can often reset the password by pressing a button on the router itself. Some routers require a specific application, which in that case should be already installed on your computer\/phone.", "install_devices_router_list_2": "Find the DHCP\/DNS settings. Look for the DNS letters next to a field which allows two or three sets of numbers, each broken into four groups of one to three digits.", "install_devices_router_list_3": "Enter your AdGuard Home server addresses there.", @@ -329,5 +329,6 @@ "setup_dns_privacy_other_2": "<0>dnsproxy supports all known secure DNS protocols.", "setup_dns_privacy_other_3": "<0>dnscrypt-proxy supports <1>DNS-over-HTTPS.", "setup_dns_privacy_other_4": "<0>Mozilla Firefox supports <1>DNS-over-HTTPS.", - "setup_dns_privacy_other_5": "You will find more implementations <0>here and <1>here." + "setup_dns_privacy_other_5": "You will find more implementations <0>here and <1>here.", + "setup_dns_notice": "In order to use <1>DNS-over-HTTPS or <1>DNS-over-TLS, you need to <0>configure Encryption in AdGuard Home settings." } \ No newline at end of file diff --git a/client/src/components/Settings/Encryption/Form.js b/client/src/components/Settings/Encryption/Form.js index 0b60271a..94e9923c 100644 --- a/client/src/components/Settings/Encryption/Form.js +++ b/client/src/components/Settings/Encryption/Form.js @@ -6,7 +6,7 @@ import { Trans, withNamespaces } from 'react-i18next'; import flow from 'lodash/flow'; import format from 'date-fns/format'; -import { renderField, renderSelectField, toNumber, port, isSafePort } from '../../../helpers/form'; +import { renderField, renderSelectField, toNumber, port, portTLS, isSafePort } from '../../../helpers/form'; import { EMPTY_DATE } from '../../../helpers/constants'; import i18n from '../../../i18n'; @@ -167,7 +167,7 @@ let Form = (props) => { type="number" className="form-control" placeholder={t('encryption_dot')} - validate={[port]} + validate={[portTLS]} normalize={toNumber} onChange={handleChange} disabled={!isEnabled} diff --git a/client/src/components/SetupGuide/index.js b/client/src/components/SetupGuide/index.js index 103f9fa5..4fb68d64 100644 --- a/client/src/components/SetupGuide/index.js +++ b/client/src/components/SetupGuide/index.js @@ -28,7 +28,7 @@ const SetupGuide = ({ {dnsAddresses.map(ip =>
  • {ip}
    • )} - + ); diff --git a/client/src/components/ui/Guide.js b/client/src/components/ui/Guide.js index 640b114d..ba8eb54b 100644 --- a/client/src/components/ui/Guide.js +++ b/client/src/components/ui/Guide.js @@ -1,299 +1,372 @@ -import React from 'react'; +import React, { Fragment } from 'react'; import PropTypes from 'prop-types'; import { Trans, withNamespaces } from 'react-i18next'; import Tabs from '../ui/Tabs'; import Icons from '../ui/Icons'; -const Guide = props => ( -
    - - -
    -
    - install_devices_router -
    -
    -

    install_devices_router_desc

    -
      -
    1. install_devices_router_list_1
      2. -
    2. install_devices_router_list_2
      3. -
    3. install_devices_router_list_3
      4. -
    -
    -
    -
    -
    - Windows -
    -
    -
      -
    1. install_devices_windows_list_1
      2. -
    2. install_devices_windows_list_2
      3. -
    3. install_devices_windows_list_3
      4. -
    4. install_devices_windows_list_4
      5. -
    5. install_devices_windows_list_5
      6. -
    6. install_devices_windows_list_6
      7. -
    -
    -
    -
    -
    - macOS -
    -
    -
      -
    1. install_devices_macos_list_1
      2. -
    2. install_devices_macos_list_2
      3. -
    3. install_devices_macos_list_3
      4. -
    4. install_devices_macos_list_4
      5. -
    -
    -
    -
    -
    - Android -
    -
    -
      -
    1. install_devices_android_list_1
      2. -
    2. install_devices_android_list_2
      3. -
    3. install_devices_android_list_3
      4. -
    4. install_devices_android_list_4
      5. -
    5. install_devices_android_list_5
      6. -
    -
    -
    -
    -
    - iOS -
    -
    -
      -
    1. install_devices_ios_list_1
      2. -
    2. install_devices_ios_list_2
      3. -
    3. install_devices_ios_list_3
      4. -
    4. install_devices_ios_list_4
      5. -
    -
    -
    -
    -
    - dns_privacy -
    -
    -
    - text, - text, - ]} - > - setup_dns_privacy_1 - -
    -
    - text, - text, - ]} - > - setup_dns_privacy_2 - -
    -
    - text

    , - ]} - > - setup_dns_privacy_3 -     -
    -
    - Android -
      -
    • - setup_dns_privacy_android_1 -
      • -
    • - - link - , - text, - ]} - > - setup_dns_privacy_android_2 - -
      • -
    • - - link - , - text, - ]} - > - setup_dns_privacy_android_3 - -
      • -
    -
    -
    - iOS -
      -
    • - - link - , - text, - - link - , - ]} - > - setup_dns_privacy_ios_1 - -
      • -
    • - - link - , - text, - ]} - > - setup_dns_privacy_ios_2 - -
      • -
    -
    -
    - - setup_dns_privacy_other_title - -
      -
    • - setup_dns_privacy_other_1 -
      • -
    • - - link - , - ]} - > - setup_dns_privacy_other_2 - -
      • -
    • - - link - , - text, - ]} - > - setup_dns_privacy_other_3 - -
      • -
    • - - link - , - text, - ]} - > - setup_dns_privacy_other_4 - -
      • -
    • - - link - , - - link - , - ]} - > - setup_dns_privacy_other_5 - -
      • -
    -
    -
    -
    -     -
    -); +const Guide = (props) => { + const { dnsAddresses } = props; + const tlsAddress = (dnsAddresses && dnsAddresses.filter(item => item.includes('tls://'))) || ''; + const httpsAddress = + (dnsAddresses && dnsAddresses.filter(item => item.includes('https://'))) || ''; + const showDnsPrivacyNotice = httpsAddress.length < 1 && tlsAddress.length < 1; + return ( +
    + + +
    +
    + install_devices_router +
    +
    +

    + install_devices_router_desc +

    +
      +
    1. + install_devices_router_list_1 +
      2. +
    2. + install_devices_router_list_2 +
      3. +
    3. + install_devices_router_list_3 +
      4. +
    +
    +
    +
    +
    Windows
    +
    +
      +
    1. + install_devices_windows_list_1 +
      2. +
    2. + install_devices_windows_list_2 +
      3. +
    3. + install_devices_windows_list_3 +
      4. +
    4. + install_devices_windows_list_4 +
      5. +
    5. + install_devices_windows_list_5 +
      6. +
    6. + install_devices_windows_list_6 +
      7. +
    +
    +
    +
    +
    macOS
    +
    +
      +
    1. + install_devices_macos_list_1 +
      2. +
    2. + install_devices_macos_list_2 +
      3. +
    3. + install_devices_macos_list_3 +
      4. +
    4. + install_devices_macos_list_4 +
      5. +
    +
    +
    +
    +
    Android
    +
    +
      +
    1. + install_devices_android_list_1 +
      2. +
    2. + install_devices_android_list_2 +
      3. +
    3. + install_devices_android_list_3 +
      4. +
    4. + install_devices_android_list_4 +
      5. +
    5. + install_devices_android_list_5 +
      6. +
    +
    +
    +
    +
    iOS
    +
    +
      +
    1. + install_devices_ios_list_1 +
      2. +
    2. + install_devices_ios_list_2 +
      3. +
    3. + install_devices_ios_list_3 +
      4. +
    4. + install_devices_ios_list_4 +
      5. +
    +
    +
    +
    +
    + dns_privacy +
    +
    + {tlsAddress && tlsAddress.length > 0 && ( +
    + text, + text, + ]} + > + setup_dns_privacy_1 + +
    + )} + {httpsAddress && httpsAddress.length > 0 && ( +
    + text, + text, + ]} + > + setup_dns_privacy_2 + +
    + )} + {showDnsPrivacyNotice && ( +
    + + link + , + text, + ]} + > + setup_dns_notice + +
    + )} + {!showDnsPrivacyNotice && ( + +
    + text

    ]}> + setup_dns_privacy_3 +     +
    +
    + Android +
      +
    • + setup_dns_privacy_android_1 +
      • +
    • + + link + , + text, + ]} + > + setup_dns_privacy_android_2 + +
      • +
    • + + link + , + text, + ]} + > + setup_dns_privacy_android_3 + +
      • +
    +
    +
    + iOS +
      +
    • + + link + , + text, + + link + , + ]} + > + setup_dns_privacy_ios_1 + +
      • +
    • + + link + , + text, + ]} + > + setup_dns_privacy_ios_2 + +
      • +
    +
    +
    + + setup_dns_privacy_other_title + +
      +
    • + setup_dns_privacy_other_1 +
      • +
    • + + link + , + ]} + > + setup_dns_privacy_other_2 + +
      • +
    • + + link + , + text, + ]} + > + setup_dns_privacy_other_3 + +
      • +
    • + + link + , + text, + ]} + > + setup_dns_privacy_other_4 + +
      • +
    • + + link + , + + link + , + ]} + > + setup_dns_privacy_other_5 + +
      • +
    +
    +     + )} +
    +
    +     +
    + ); +}; + +Guide.defaultProps = { + dnsAddresses: [], +}; Guide.propTypes = { + dnsAddresses: PropTypes.array, t: PropTypes.func.isRequired, }; diff --git a/client/src/helpers/form.js b/client/src/helpers/form.js index 72397396..39c4b7aa 100644 --- a/client/src/helpers/form.js +++ b/client/src/helpers/form.js @@ -76,6 +76,15 @@ export const port = (value) => { return false; }; +export const portTLS = (value) => { + if (value === 0) { + return false; + } else if (value && (value < 80 || value > 65535)) { + return form_error_port_range; + } + return false; +}; + export const isSafePort = (value) => { if (UNSAFE_PORTS.includes(value)) { return form_error_port_unsafe;