home: improve error handling

internal/home/controlupdate.go

@@ -2,12 +2,12 @@ package home
 
 import (
 	"encoding/json"
+	"errors"
 	"net/http"
 	"os"
 	"os/exec"
 	"path/filepath"
 	"runtime"
-	"strings"
 	"syscall"
 	"time"
 
@@ -20,6 +20,13 @@ type getVersionJSONRequest struct {
 	RecheckNow bool `json:"recheck_now"`
 }
 
+// temoraryError is the interface for temporary errors from the Go standard
+// library.
+type temoraryError interface {
+	error
+	Temporary() (ok bool)
+}
+
 // Get the latest available version from the Internet
 func handleGetVersionJSON(w http.ResponseWriter, r *http.Request) {
 	if Context.disableUpdate {
@@ -42,15 +49,29 @@ func handleGetVersionJSON(w http.ResponseWriter, r *http.Request) {
 
 	var info update.VersionInfo
 	for i := 0; i != 3; i++ {
+		func() {
 			Context.controlLock.Lock()
+			defer Context.controlLock.Unlock()
+
 			info, err = Context.updater.GetVersionResponse(req.RecheckNow)
-		Context.controlLock.Unlock()
+		}()
-		if err != nil && strings.HasSuffix(err.Error(), "i/o timeout") {
+
-			// This case may happen while we're restarting DNS server
+		if err != nil {
-			// https://github.com/AdguardTeam/AdGuardHome/issues/934
+			var terr temoraryError
-			time.Sleep(time.Duration(i) * time.Second)
+			if errors.As(err, &terr) && terr.Temporary() {
+				// Temporary network error.  This case may happen while
+				// we're restarting our DNS server.  Log and sleep for
+				// some time.
+				//
+				// See https://github.com/AdguardTeam/AdGuardHome/issues/934.
+				d := time.Duration(i) * time.Second
+				log.Info("temp net error: %q; sleeping for %s and retrying", err, d)
+				time.Sleep(d)
+
 				continue
 			}
+		}
+
 		break
 	}
 	if err != nil {