Merge: - service stop: fix race

Close #799

* commit '131aa4c93ccd6e2603e8025dfd4d3693aa9dd561':
  - service stop: fix race

home/config.go

@@ -51,6 +51,7 @@ type configuration struct {
 	// runningAsService flag is set to true when options are passed from the service runner
 	runningAsService bool
 	disableUpdate    bool // If set, don't check for updates
+	appSignalChannel chan os.Signal
 
 	BindHost     string `yaml:"bind_host"`     // BindHost is the IP address of the HTTP server to bind to
 	BindPort     int    `yaml:"bind_port"`     // BindPort is the port the HTTP server

home/home.go

@@ -99,10 +99,10 @@ func run(args options) {
 		requireAdminRights()
 	}
 
-	signalChannel := make(chan os.Signal)
+	config.appSignalChannel = make(chan os.Signal)
-	signal.Notify(signalChannel, syscall.SIGINT, syscall.SIGTERM, syscall.SIGHUP, syscall.SIGQUIT)
+	signal.Notify(config.appSignalChannel, syscall.SIGINT, syscall.SIGTERM, syscall.SIGHUP, syscall.SIGQUIT)
 	go func() {
-		<-signalChannel
+		<-config.appSignalChannel
 		cleanup()
 		cleanupAlways()
 		os.Exit(0)

home/service.go

@@ -3,6 +3,7 @@ package home
 import (
 	"os"
 	"runtime"
+	"syscall"
 
 	"github.com/AdguardTeam/golibs/log"
 	"github.com/kardianos/service"
@@ -31,9 +32,10 @@ func (p *program) Start(s service.Service) error {
 // Stop stops the program
 func (p *program) Stop(s service.Service) error {
 	// Stop should not block. Return with a few seconds.
-	cleanup()
+	if config.appSignalChannel == nil {
-	cleanupAlways()
 		os.Exit(0)
+	}
+	config.appSignalChannel <- syscall.SIGINT
 	return nil
 }