code-server-2/test/unit/cli.test.ts

408 lines
12 KiB
TypeScript
Raw Normal View History

import { Level, logger } from "@coder/logger"
2020-09-15 21:51:43 +00:00
import * as fs from "fs-extra"
import * as net from "net"
import * as os from "os"
2020-02-07 00:26:07 +00:00
import * as path from "path"
2021-03-09 23:32:31 +00:00
import { Args, parse, setDefaults, shouldOpenInExistingInstance } from "../../src/node/cli"
import { paths, tmpdir } from "../../src/node/util"
2020-02-07 00:26:07 +00:00
2020-09-15 21:51:43 +00:00
type Mutable<T> = {
-readonly [P in keyof T]: T[P]
}
describe("parser", () => {
beforeEach(() => {
delete process.env.LOG_LEVEL
delete process.env.PASSWORD
2021-01-25 23:34:43 +00:00
console.log = jest.fn()
})
// The parser should not set any defaults so the caller can determine what
2020-09-15 21:51:43 +00:00
// values the user actually set. These are only set after explicitly calling
// `setDefaults`.
const defaults = {
auth: "password",
host: "localhost",
port: 8080,
"proxy-domain": [],
usingEnvPassword: false,
usingEnvHashedPassword: false,
"extensions-dir": path.join(paths.data, "extensions"),
"user-data-dir": paths.data,
}
it("should parse nothing", () => {
expect(parse([])).toStrictEqual({ _: [] })
})
2020-02-07 00:26:07 +00:00
it("should parse all available options", () => {
2021-01-08 20:55:47 +00:00
expect(
parse([
"--bind-addr=192.169.0.1:8080",
2020-02-07 00:26:07 +00:00
"--auth",
"none",
"--extensions-dir",
"foo",
"--builtin-extensions-dir",
"foobar",
"--extra-extensions-dir",
"nozzle",
"1",
"--extra-builtin-extensions-dir",
"bazzle",
"--verbose",
"2",
"--log",
"error",
"--help",
2020-12-10 17:24:37 +00:00
"--home=http://localhost:8080/",
2020-02-07 00:26:07 +00:00
"--open",
"--socket=mumble",
2020-02-07 00:26:07 +00:00
"3",
"--user-data-dir",
"bar",
"--cert=baz",
2020-02-07 00:26:07 +00:00
"--cert-key",
"qux",
"--version",
"--json",
"--port=8081",
2020-02-07 00:26:07 +00:00
"--host",
"0.0.0.0",
"4",
"--",
"-5",
"--6",
]),
).toEqual({
_: ["1", "2", "3", "4", "-5", "--6"],
auth: "none",
"builtin-extensions-dir": path.resolve("foobar"),
"cert-key": path.resolve("qux"),
cert: {
value: path.resolve("baz"),
2020-02-15 00:46:00 +00:00
},
"extensions-dir": path.resolve("foo"),
"extra-builtin-extensions-dir": [path.resolve("bazzle")],
"extra-extensions-dir": [path.resolve("nozzle")],
help: true,
home: "http://localhost:8080/",
host: "0.0.0.0",
json: true,
log: "error",
open: true,
port: 8081,
socket: path.resolve("mumble"),
"user-data-dir": path.resolve("bar"),
verbose: true,
version: true,
"bind-addr": "192.169.0.1:8080",
})
2020-02-07 00:26:07 +00:00
})
it("should work with short options", () => {
2021-01-08 20:55:47 +00:00
expect(parse(["-vvv", "-v"])).toEqual({
_: [],
2020-02-07 00:26:07 +00:00
verbose: true,
version: true,
})
})
it("should use log level env var", async () => {
const args = parse([])
2021-01-08 20:55:47 +00:00
expect(args).toEqual({ _: [] })
process.env.LOG_LEVEL = "debug"
2021-01-08 20:55:47 +00:00
const defaults = await setDefaults(args)
2021-01-11 18:37:27 +00:00
expect(defaults).toStrictEqual({
...defaults,
_: [],
log: "debug",
verbose: false,
})
2021-01-08 20:55:47 +00:00
expect(process.env.LOG_LEVEL).toEqual("debug")
expect(logger.level).toEqual(Level.Debug)
process.env.LOG_LEVEL = "trace"
2021-01-08 20:55:47 +00:00
const updated = await setDefaults(args)
expect(updated).toStrictEqual({
2021-01-08 20:55:47 +00:00
...updated,
_: [],
log: "trace",
verbose: true,
})
2021-01-08 20:55:47 +00:00
expect(process.env.LOG_LEVEL).toEqual("trace")
expect(logger.level).toEqual(Level.Trace)
})
it("should prefer --log to env var and --verbose to --log", async () => {
let args = parse(["--log", "info"])
2021-01-08 20:55:47 +00:00
expect(args).toEqual({
_: [],
log: "info",
})
process.env.LOG_LEVEL = "debug"
const defaults = await setDefaults(args)
2021-01-08 20:55:47 +00:00
expect(defaults).toEqual({
...defaults,
_: [],
log: "info",
verbose: false,
})
2021-01-08 20:55:47 +00:00
expect(process.env.LOG_LEVEL).toEqual("info")
expect(logger.level).toEqual(Level.Info)
process.env.LOG_LEVEL = "trace"
2021-01-08 20:55:47 +00:00
const updated = await setDefaults(args)
expect(updated).toEqual({
...defaults,
_: [],
log: "info",
verbose: false,
})
2021-01-08 20:55:47 +00:00
expect(process.env.LOG_LEVEL).toEqual("info")
expect(logger.level).toEqual(Level.Info)
args = parse(["--log", "info", "--verbose"])
2021-01-08 20:55:47 +00:00
expect(args).toEqual({
_: [],
log: "info",
verbose: true,
})
process.env.LOG_LEVEL = "warn"
2021-01-08 20:55:47 +00:00
const updatedAgain = await setDefaults(args)
expect(updatedAgain).toEqual({
...defaults,
_: [],
log: "trace",
verbose: true,
})
2021-01-08 20:55:47 +00:00
expect(process.env.LOG_LEVEL).toEqual("trace")
expect(logger.level).toEqual(Level.Trace)
})
it("should ignore invalid log level env var", async () => {
process.env.LOG_LEVEL = "bogus"
2021-01-08 20:55:47 +00:00
const defaults = await setDefaults(parse([]))
expect(defaults).toEqual({
...defaults,
2021-01-08 20:55:47 +00:00
_: [],
})
2020-02-07 00:26:07 +00:00
})
it("should error if value isn't provided", () => {
2021-01-08 20:55:47 +00:00
expect(() => parse(["--auth"])).toThrowError(/--auth requires a value/)
expect(() => parse(["--auth=", "--log=debug"])).toThrowError(/--auth requires a value/)
expect(() => parse(["--auth", "--log"])).toThrowError(/--auth requires a value/)
expect(() => parse(["--auth", "--invalid"])).toThrowError(/--auth requires a value/)
expect(() => parse(["--bind-addr"])).toThrowError(/--bind-addr requires a value/)
2020-02-07 00:26:07 +00:00
})
it("should error if value is invalid", () => {
2021-01-08 20:55:47 +00:00
expect(() => parse(["--port", "foo"])).toThrowError(/--port must be a number/)
expect(() => parse(["--auth", "invalid"])).toThrowError(/--auth valid values: \[password, none\]/)
expect(() => parse(["--log", "invalid"])).toThrowError(/--log valid values: \[trace, debug, info, warn, error\]/)
2020-02-07 00:26:07 +00:00
})
it("should error if the option doesn't exist", () => {
expect(() => parse(["--foo"])).toThrowError(/Unknown option --foo/)
2020-02-07 00:26:07 +00:00
})
it("should not error if the value is optional", () => {
2021-01-08 20:55:47 +00:00
expect(parse(["--cert"])).toEqual({
_: [],
2020-02-07 00:26:07 +00:00
cert: {
value: undefined,
},
})
})
it("should not allow option-like values", () => {
2021-01-08 20:55:47 +00:00
expect(() => parse(["--socket", "--socket-path-value"])).toThrowError(/--socket requires a value/)
2020-02-07 00:26:07 +00:00
// If you actually had a path like this you would do this instead:
2021-01-08 20:55:47 +00:00
expect(parse(["--socket", "./--socket-path-value"])).toEqual({
_: [],
2020-02-07 00:26:07 +00:00
socket: path.resolve("--socket-path-value"),
})
2021-01-08 20:55:47 +00:00
expect(() => parse(["--cert", "--socket-path-value"])).toThrowError(/Unknown option --socket-path-value/)
2020-02-07 00:26:07 +00:00
})
it("should allow positional arguments before options", () => {
2021-01-08 20:55:47 +00:00
expect(parse(["foo", "test", "--auth", "none"])).toEqual({
_: ["foo", "test"],
auth: "none",
})
})
it("should support repeatable flags", () => {
2021-01-08 20:55:47 +00:00
expect(parse(["--proxy-domain", "*.coder.com"])).toEqual({
_: [],
"proxy-domain": ["*.coder.com"],
})
2021-01-08 20:55:47 +00:00
expect(parse(["--proxy-domain", "*.coder.com", "--proxy-domain", "test.com"])).toEqual({
_: [],
"proxy-domain": ["*.coder.com", "test.com"],
})
})
it("should enforce cert-key with cert value or otherwise generate one", async () => {
const args = parse(["--cert"])
expect(args).toEqual({
_: [],
cert: {
value: undefined,
},
})
expect(() => parse(["--cert", "test"])).toThrowError(/--cert-key is missing/)
const defaultArgs = await setDefaults(args)
expect(defaultArgs).toEqual({
_: [],
...defaults,
cert: {
value: path.join(paths.data, "localhost.crt"),
},
"cert-key": path.join(paths.data, "localhost.key"),
})
})
it("should override with --link", async () => {
const args = parse("--cert test --cert-key test --socket test --host 0.0.0.0 --port 8888 --link test".split(" "))
2021-01-08 20:55:47 +00:00
const defaultArgs = await setDefaults(args)
expect(defaultArgs).toEqual({
_: [],
...defaults,
auth: "none",
host: "localhost",
link: {
value: "test",
},
port: 0,
cert: undefined,
"cert-key": path.resolve("test"),
socket: undefined,
})
})
it("should use env var password", async () => {
process.env.PASSWORD = "test"
const args = parse([])
2021-01-08 20:55:47 +00:00
expect(args).toEqual({
_: [],
})
2021-01-08 20:55:47 +00:00
const defaultArgs = await setDefaults(args)
expect(defaultArgs).toEqual({
...defaults,
_: [],
password: "test",
usingEnvPassword: true,
})
})
it("should use env var hashed password", async () => {
process.env.HASHED_PASSWORD = "9f86d081884c7d659a2feaa0c55ad015a3bf4f1b2b0b822cd15d6c15b0f00a08" // test
const args = parse([])
2021-01-08 20:55:47 +00:00
expect(args).toEqual({
_: [],
})
const defaultArgs = await setDefaults(args)
2021-01-08 20:55:47 +00:00
expect(defaultArgs).toEqual({
...defaults,
_: [],
"hashed-password": "9f86d081884c7d659a2feaa0c55ad015a3bf4f1b2b0b822cd15d6c15b0f00a08",
usingEnvHashedPassword: true,
})
})
it("should filter proxy domains", async () => {
const args = parse(["--proxy-domain", "*.coder.com", "--proxy-domain", "coder.com", "--proxy-domain", "coder.org"])
2021-01-08 20:55:47 +00:00
expect(args).toEqual({
_: [],
"proxy-domain": ["*.coder.com", "coder.com", "coder.org"],
})
2021-01-08 20:55:47 +00:00
const defaultArgs = await setDefaults(args)
expect(defaultArgs).toEqual({
...defaults,
_: [],
"proxy-domain": ["coder.com", "coder.org"],
})
})
2020-02-07 00:26:07 +00:00
})
2020-09-15 21:51:43 +00:00
describe("cli", () => {
let args: Mutable<Args> = { _: [] }
const testDir = path.join(tmpdir, "tests/cli")
const vscodeIpcPath = path.join(os.tmpdir(), "vscode-ipc")
2021-01-08 20:55:47 +00:00
beforeAll(async () => {
2020-09-15 21:51:43 +00:00
await fs.remove(testDir)
await fs.mkdirp(testDir)
})
beforeEach(async () => {
delete process.env.VSCODE_IPC_HOOK_CLI
args = { _: [] }
await fs.remove(vscodeIpcPath)
})
it("should use existing if inside code-server", async () => {
process.env.VSCODE_IPC_HOOK_CLI = "test"
2021-01-11 18:37:27 +00:00
expect(await shouldOpenInExistingInstance(args)).toStrictEqual("test")
2020-09-15 21:51:43 +00:00
args.port = 8081
args._.push("./file")
2021-01-11 18:37:27 +00:00
expect(await shouldOpenInExistingInstance(args)).toStrictEqual("test")
2020-09-15 21:51:43 +00:00
})
it("should use existing if --reuse-window is set", async () => {
args["reuse-window"] = true
2021-01-11 18:37:27 +00:00
await expect(await shouldOpenInExistingInstance(args)).toStrictEqual(undefined)
2020-09-15 21:51:43 +00:00
await fs.writeFile(vscodeIpcPath, "test")
2021-01-08 20:55:47 +00:00
await expect(shouldOpenInExistingInstance(args)).resolves.toStrictEqual("test")
2020-09-15 21:51:43 +00:00
args.port = 8081
2021-01-08 20:55:47 +00:00
await expect(shouldOpenInExistingInstance(args)).resolves.toStrictEqual("test")
2020-09-15 21:51:43 +00:00
})
2020-09-15 21:51:43 +00:00
it("should use existing if --new-window is set", async () => {
args["new-window"] = true
2021-01-11 18:37:27 +00:00
expect(await shouldOpenInExistingInstance(args)).toStrictEqual(undefined)
2020-09-15 21:51:43 +00:00
await fs.writeFile(vscodeIpcPath, "test")
2021-01-11 18:37:27 +00:00
expect(await shouldOpenInExistingInstance(args)).toStrictEqual("test")
2020-09-15 21:51:43 +00:00
args.port = 8081
2021-01-11 18:37:27 +00:00
expect(await shouldOpenInExistingInstance(args)).toStrictEqual("test")
2020-09-15 21:51:43 +00:00
})
it("should use existing if no unrelated flags are set, has positional, and socket is active", async () => {
expect(await shouldOpenInExistingInstance(args)).toStrictEqual(undefined)
args._.push("./file")
expect(await shouldOpenInExistingInstance(args)).toStrictEqual(undefined)
const socketPath = path.join(testDir, "socket")
await fs.writeFile(vscodeIpcPath, socketPath)
expect(await shouldOpenInExistingInstance(args)).toStrictEqual(undefined)
await new Promise((resolve) => {
const server = net.createServer(() => {
// Close after getting the first connection.
server.close()
2020-09-15 21:51:43 +00:00
})
server.once("listening", () => resolve(server))
server.listen(socketPath)
})
2020-09-15 21:51:43 +00:00
expect(await shouldOpenInExistingInstance(args)).toStrictEqual(socketPath)
2020-09-15 21:51:43 +00:00
args.port = 8081
expect(await shouldOpenInExistingInstance(args)).toStrictEqual(undefined)
})
2020-09-15 21:51:43 +00:00
})