Update proxy path passthrough documentation

Includes updated create-react-app docs.

Closes #2565
This commit is contained in:
Anmol Sethi 2021-02-05 02:31:18 -05:00
parent c08e3bb06d
commit 05a0f213a7
No known key found for this signature in database
GPG Key ID: 8CEF1878FF10ADEB
2 changed files with 17 additions and 14 deletions

View File

@ -16,6 +16,7 @@
- [Sub-paths](#sub-paths) - [Sub-paths](#sub-paths)
- [Sub-domains](#sub-domains) - [Sub-domains](#sub-domains)
- [Why does the code-server proxy strip `/proxy/<port>` from the request path?](#why-does-the-code-server-proxy-strip-proxyport-from-the-request-path) - [Why does the code-server proxy strip `/proxy/<port>` from the request path?](#why-does-the-code-server-proxy-strip-proxyport-from-the-request-path)
- [Proxying to Create React App](#proxying-to-create-react-app)
- [Multi-tenancy](#multi-tenancy) - [Multi-tenancy](#multi-tenancy)
- [Docker in code-server container?](#docker-in-code-server-container) - [Docker in code-server container?](#docker-in-code-server-container)
- [How can I disable telemetry?](#how-can-i-disable-telemetry) - [How can I disable telemetry?](#how-can-i-disable-telemetry)
@ -226,25 +227,28 @@ However many people prefer the cleaner aesthetic of no trailing slashes. This co
to the base path as you cannot use relative redirects correctly anymore. See the above to the base path as you cannot use relative redirects correctly anymore. See the above
link. link.
For users who are ok with this tradeoff, pass `--proxy-path-passthrough` to code-server For users who are ok with this tradeoff, use `/absproxy` instead and the path will be
and the path will be passed as is. passed as is. e.g. `/absproxy/3000/my-app-path`
This is particularly a problem with the `start` script in create-react-app. See ### Proxying to Create React App
You must use `/absproxy/<port>` with create-react-app.
See [#2565](https://github.com/cdr/code-server/issues/2565) and
[#2222](https://github.com/cdr/code-server/issues/2222). You will need to inform [#2222](https://github.com/cdr/code-server/issues/2222). You will need to inform
create-react-app of the path at which you are serving via `homepage` field in your create-react-app of the path at which you are serving via `$PUBLIC_URL` and webpack
`package.json`. e.g. you'd add the following for the default CRA port: via `$WDS_SOCKET_PATH`.
```json e.g.
"homepage": "/proxy/3000",
```sh
PUBLIC_URL=/absproxy/3000 \
WDS_SOCKET_PATH=$PUBLIC_URL/sockjs-node \
BROWSER=none yarn start
``` ```
Then visit `https://my-code-server-address.io/proxy/3000` to see your app exposed through Then visit `https://my-code-server-address.io/absproxy/3000` to see your app exposed through
code-server! code-server!
Unfortunately `webpack-dev-server`'s websocket connections will not go through as it
always uses `/sockjs-node`. So hot reloading will not work until the `create-react-app`
team fix this bug.
Highly recommend using the subdomain approach instead to avoid this class of issue. Highly recommend using the subdomain approach instead to avoid this class of issue.
## Multi-tenancy ## Multi-tenancy

View File

@ -9,8 +9,7 @@ proxy.on("error", (error, _, res) => {
}) })
// Intercept the response to rewrite absolute redirects against the base path. // Intercept the response to rewrite absolute redirects against the base path.
// Is disabled when the request has no base path which means --proxy-path-passthrough has // Is disabled when the request has no base path which means /absproxy is in use.
// been enabled.
proxy.on("proxyRes", (res, req) => { proxy.on("proxyRes", (res, req) => {
if (res.headers.location && res.headers.location.startsWith("/") && (req as any).base) { if (res.headers.location && res.headers.location.startsWith("/") && (req as any).base) {
res.headers.location = (req as any).base + res.headers.location res.headers.location = (req as any).base + res.headers.location