From 8136769b66a9b1c2be3ca1890460817896442de4 Mon Sep 17 00:00:00 2001 From: Joe Previte Date: Mon, 4 Oct 2021 12:06:12 -0700 Subject: [PATCH 1/3] fix: close vscodeServer on server close if defined --- src/node/routes/index.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/node/routes/index.ts b/src/node/routes/index.ts index 08a2dcc1..13232f70 100644 --- a/src/node/routes/index.ts +++ b/src/node/routes/index.ts @@ -162,7 +162,7 @@ export const register = async ( } server.on("close", () => { - vscode.vscodeServer.close() + vscode?.vscodeServer.close() }) app.use(() => { From 7183b5a43e133fd65cfa01497af0ed779e99126c Mon Sep 17 00:00:00 2001 From: Joe Previte Date: Mon, 4 Oct 2021 12:06:33 -0700 Subject: [PATCH 2/3] chore(testing): fix casing in error messsage --- test/unit/node/routes/static.test.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/test/unit/node/routes/static.test.ts b/test/unit/node/routes/static.test.ts index 3856e0f6..49d4716a 100644 --- a/test/unit/node/routes/static.test.ts +++ b/test/unit/node/routes/static.test.ts @@ -7,7 +7,7 @@ import * as integration from "../../../utils/integration" const NOT_FOUND = { code: 404, - message: "not found", + message: "Not Found", } describe("/_static", () => { From a8d873f9f89cd410c1130d6ebf16b68a3953fdf5 Mon Sep 17 00:00:00 2001 From: Joe Previte Date: Mon, 4 Oct 2021 12:07:45 -0700 Subject: [PATCH 3/3] refactor(ci): fix unit tests job --- .github/workflows/ci.yaml | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/.github/workflows/ci.yaml b/.github/workflows/ci.yaml index b4cfc9f1..497203af 100644 --- a/.github/workflows/ci.yaml +++ b/.github/workflows/ci.yaml @@ -54,6 +54,10 @@ jobs: run: yarn lint if: success() + - name: Run code-server unit tests + run: yarn test:unit + if: success() + - name: Upload coverage report to Codecov run: yarn coverage if: success() @@ -404,9 +408,6 @@ jobs: rm -r node_modules/playwright yarn install --check-files - - name: Run end-to-end tests - run: yarn test:unit - - name: Run end-to-end tests run: yarn test:e2e