From b40722869eb40ee7acd862a381cc3892672101aa Mon Sep 17 00:00:00 2001 From: Asher Date: Fri, 1 Feb 2019 12:32:42 -0600 Subject: [PATCH] Move mouse wheel fix out of patch --- packages/vscode/src/client.ts | 1 + packages/vscode/src/fill/mouseEvent.ts | 19 +++++++++++++++++ scripts/vscode.patch | 29 -------------------------- 3 files changed, 20 insertions(+), 29 deletions(-) create mode 100644 packages/vscode/src/fill/mouseEvent.ts diff --git a/packages/vscode/src/client.ts b/packages/vscode/src/client.ts index fa31b7ea..3266e6ed 100644 --- a/packages/vscode/src/client.ts +++ b/packages/vscode/src/client.ts @@ -6,6 +6,7 @@ import "./fill/windowsService"; import "./fill/environmentService"; import "./fill/vscodeTextmate"; import "./fill/codeEditor"; +import "./fill/mouseEvent"; import { PasteAction } from "./fill/paste"; import "./fill/dom"; import "./vscode.scss"; diff --git a/packages/vscode/src/fill/mouseEvent.ts b/packages/vscode/src/fill/mouseEvent.ts new file mode 100644 index 00000000..bfef104d --- /dev/null +++ b/packages/vscode/src/fill/mouseEvent.ts @@ -0,0 +1,19 @@ +import * as mouse from "vs/base/browser/mouseEvent"; + +/** + * Fix the wheel event for Firefox. + */ +class StandardWheelEvent extends mouse.StandardWheelEvent { + + public constructor(event: mouse.IMouseWheelEvent | null) { + super( + event, + (-(event as any as MouseWheelEvent).deltaX || 0) / 3, // tslint:disable-line no-any + (-(event as any as MouseWheelEvent).deltaY || 0) / 3, // tslint:disable-line no-any + ); + } + +} + +const target = mouse as typeof mouse; +target.StandardWheelEvent = StandardWheelEvent; diff --git a/scripts/vscode.patch b/scripts/vscode.patch index 39360307..51af9d26 100644 --- a/scripts/vscode.patch +++ b/scripts/vscode.patch @@ -1,32 +1,3 @@ -diff --git a/src/vs/base/browser/mouseEvent.ts b/src/vs/base/browser/mouseEvent.ts -index 89ff65ec49..bc0cf2b08c 100644 ---- a/src/vs/base/browser/mouseEvent.ts -+++ b/src/vs/base/browser/mouseEvent.ts -@@ -147,12 +147,15 @@ export class StandardWheelEvent { - if (e) { - let e1 = e; - let e2 = e; -+ let e3 = e; - - // vertical delta scroll - if (typeof e1.wheelDeltaY !== 'undefined') { - this.deltaY = e1.wheelDeltaY / 120; - } else if (typeof e2.VERTICAL_AXIS !== 'undefined' && e2.axis === e2.VERTICAL_AXIS) { - this.deltaY = -e2.detail / 3; -+ } else if (typeof e3.deltaY !== "undefined") { -+ this.deltaY = -e3.deltaY / 3; - } - - // horizontal delta scroll -@@ -164,6 +167,8 @@ export class StandardWheelEvent { - } - } else if (typeof e2.HORIZONTAL_AXIS !== 'undefined' && e2.axis === e2.HORIZONTAL_AXIS) { - this.deltaX = -e.detail / 3; -+ } else if (typeof e3.deltaX !== "undefined") { -+ this.deltaX = -e3.deltaX / 3; - } - - // Assume a vertical scroll if nothing else worked diff --git a/src/vs/base/browser/ui/scrollbar/scrollableElement.ts b/src/vs/base/browser/ui/scrollbar/scrollableElement.ts index a6256deeba..69819e0f3a 100644 --- a/src/vs/base/browser/ui/scrollbar/scrollableElement.ts