Fix build and Dockerfile issues (#176)

* build: fix yarn corruption issues

Closes #100

Thanks @zerdos

* Dockerfile: add default Entrypoint and mount data dir

Closes #170
Closes #78

Thanks @ay-b
This commit is contained in:
Anmol Sethi 2019-03-09 17:51:51 -05:00 committed by Kyle Carberry
parent c471babc69
commit f37533579d
3 changed files with 4 additions and 6 deletions

View File

@ -28,5 +28,6 @@ RUN apt-get install -y locales && \
# We unfortunately cannot use update-locale because docker will not use the env variables # We unfortunately cannot use update-locale because docker will not use the env variables
# configured in /etc/default/locale so we need to set it manually. # configured in /etc/default/locale so we need to set it manually.
ENV LANG=en_US.UTF-8 ENV LANG=en_US.UTF-8
# Unfortunately `.` does not work with code-server. ENTRYPOINT code-server
# Unfortunately `.` does not work with code-server so we use shell form.
CMD code-server $PWD CMD code-server $PWD

View File

@ -9,7 +9,7 @@
Try it out: Try it out:
```bash ```bash
docker run -p 127.0.0.1:8443:8443 -v "${PWD}:/root/project" codercom/code-server code-server --allow-http --no-auth docker run -p 127.0.0.1:8443:8443 -v "${PWD}:/root/project" -v ~/.code-server:/root/.code-server codercom/code-server --allow-http --no-auth
``` ```
- Code on your Chromebook, tablet, and laptop with a consistent dev environment. - Code on your Chromebook, tablet, and laptop with a consistent dev environment.

View File

@ -41,10 +41,7 @@ const handlePackages = async (dir: string): Promise<void> => {
const pkgDir = join(dir, pkg); const pkgDir = join(dir, pkg);
const pkgJsonPath = join(pkgDir, "package.json"); const pkgJsonPath = join(pkgDir, "package.json");
if (existsSync(pkgJsonPath)) { if (existsSync(pkgJsonPath)) {
const ip = doInstall(pkg, pkgDir); const ip = await doInstall(pkg, pkgDir);
if (os.platform() === "win32") {
await ip;
}
} }
} }
}; };