Asher
34225e2bdf
Use ensureAuthenticated as middleware
2020-11-04 17:07:40 -06:00
Asher
476379a77e
Fix cookie domain
...
Had double Domain=
2020-11-04 17:07:39 -06:00
Asher
210fc049c4
Document VS Code endpoints
2020-11-04 17:07:39 -06:00
Asher
e5c8e0aad1
Remove useless ||
2020-11-04 17:07:38 -06:00
Asher
c5ce365482
Use query variable to force update check
2020-11-04 17:07:37 -06:00
Asher
a653b93ce2
Include protocol on printed address
...
This makes it clickable from the terminal.
2020-11-04 17:07:36 -06:00
Asher
e2c35facdb
Remove invalid comment on maybeProxy
...
It no longer handles authentication.
2020-11-04 17:07:35 -06:00
Asher
75b93f9dc5
Fix bind address priority
...
Broke when converting to a loop.
2020-11-04 17:07:24 -06:00
Jon Ayers
1eebde56ab
Specify that Coder Alpha requires v3.6.2 ( #2270 )
2020-11-03 18:03:28 -06:00
Asher
e27188c2f9
Merge pull request #2268 from cdr/update-alpha
...
Update README Alpha section to remove reference to typeform
2020-11-03 17:33:02 -06:00
Jon Ayers
ddbac8dd78
Update README Alpha section to remove reference to typeform
2020-11-03 23:31:08 +00:00
Asher
8066da12fe
Remove unused Locals interface
2020-11-03 15:37:22 -06:00
Asher
03e0013112
Unbind error/exit events once handshakes resolve
2020-11-03 15:27:21 -06:00
Asher
e243f6e369
Return early when forking to reduce indentation
2020-11-03 15:27:21 -06:00
Asher
c10450c4c5
Move isFile into util
...
That allows its use in entry.ts as well.
2020-11-03 15:27:20 -06:00
Asher
c72c53f64d
Fix not being able to dispose vscode after failed disposal
2020-11-03 14:36:27 -06:00
Asher
f4e5855318
Simplify update request
2020-11-03 14:35:23 -06:00
Asher
3a074fd844
Skip unnecessary auth type check when using --link
2020-11-03 14:30:34 -06:00
Asher
8a9e61defb
Use Addr interface everywhere and loop over arg sources
2020-11-03 14:28:49 -06:00
Asher
1067507c41
Proxy to 0.0.0.0 instead of localhost
2020-11-03 14:28:48 -06:00
Anmol Sethi
f9e0990594
Merge pull request #2255 from cdr/self-signed-3b2c
...
Fix self signed certificate for iPad
2020-11-03 14:04:47 -05:00
Anmol Sethi
c07296cce0
docs: Add known issues to iPad docs and add more links to iPad docs
...
Closes #1816
2020-11-03 14:04:19 -05:00
Anmol Sethi
31306f7fdd
docs: Add iPad self signed certificate documentation
...
Closes #1816
Closes #1566
2020-11-03 14:04:19 -05:00
Matthew Beckett
7affce5801
Merge branch 'v3.6.2' into feature/helm3
2020-11-03 12:28:29 +00:00
Asher
37b87dd2b8
Merge pull request #2264 from cdr/v3.6.2
...
v3.6.2
2020-11-02 18:07:53 -06:00
Asher
9bde62fbd6
v3.6.2
2020-11-02 17:17:25 -06:00
Asher
6fbbb1047f
fmt
2020-11-02 17:17:09 -06:00
Asher
e07a591745
Catch cloud agent download failure
...
- See #2251 and #2229 .
2020-11-02 16:48:25 -06:00
Asher
676c7bf915
Merge pull request #2250 from cdr/disconnects
...
Experimental initial connection fix
2020-11-02 16:46:14 -06:00
Asher
9ad7d0b7a3
Fix potential 500 when loading in parallel
2020-10-30 16:16:46 -05:00
Asher
07e7c38ea2
Immediately pause web socket
...
This will buffer any data sent to it until something is ready to listen
on it.
2020-10-30 16:16:46 -05:00
Asher
0b9af6ef67
Initiate connection handshake from server
...
This way the connection can be initiated by either side. It looks like
sometimes the initial message from the client is lost (it never makes it
into the onControlMessage callback) but I'm still not sure why or if
that is preventable.
Also added a timeout on the server end to clean things up in case the
client never responds.
2020-10-30 16:16:45 -05:00
Asher
c63dc3a1ea
Add more logging around connections
2020-10-30 16:16:44 -05:00
Anmol Sethi
a1b61d1659
src/node/util.ts: Mark generated certificates as CA
...
Required for access under iPad.
2020-10-30 13:36:53 -04:00
Anmol Sethi
bae28727bd
src/node/cli.ts: Add --cert-host to configure generated certificate hostname
2020-10-30 13:36:53 -04:00
Anmol Sethi
8b85006996
src/node/util.ts: Make certificate generation "modern"
...
Now we add a subject alt name, set extendedKeyUsage and use the
correct certificate extension.
The above allow it to be properly trusted by iOS.
See https://support.apple.com/en-us/HT210176
*.cert isn't a real extension for certificates, *.crt is correct
for it to be recognized by e.g. keychain or when importing as a profile
into iOS.
Updates #1566
I've been able to successfully connect from my iPad Pro now to my
code-server instance with a self signed certificate! Next commit
will be docs.
2020-10-30 13:36:53 -04:00
Anmol Sethi
10b3028196
util: Generate self signed certificate into data directory
...
Closes #1778
2020-10-30 13:36:53 -04:00
Katie Horne
860c99e3b8
Docs copyedits: README.md + CONTRIBUTING.md ( #2242 )
...
* Edit README
* Edit CONTRIBUTING
* Format CONTRIBUTING.MD
* Incorporate feedback
* Revert movement of CONTRIBUTING.MD and format
2020-10-29 17:21:47 -04:00
Asher
f2f1fee6f1
Short-circuit heartbeat when alive
2020-10-27 17:48:37 -05:00
Asher
504d89638b
Fix open line being printed when open fails
...
Opening the URL can fail if the user doesn't have something appropriate
installed to handle it.
2020-10-27 17:43:11 -05:00
Asher
dc177ab505
Unambiguify address replacement
...
Co-authored-by: Teffen Ellis <TeffenEllis@users.noreply.github.com>
2020-10-27 17:38:54 -05:00
Asher
cde94d5ed4
Remove redundant serverAddress check
...
We now guarantee there is an address.
2020-10-27 17:35:42 -05:00
Asher
305348f0ac
Improve proxy fallthrough logic
...
- Use accept header.
- Match /login and /login/ exactly.
- Match /static/ (trailing slash).
- Use req.path. Same result but feels more accurate to me.
2020-10-27 17:31:37 -05:00
Asher
6ab6cb4f07
Fix error handler types
2020-10-27 17:20:13 -05:00
Asher
6422a8d74b
Fix webview resource path
2020-10-27 17:17:05 -05:00
Asher
257d9a4fa4
Make authentication work with sub-domain proxy
2020-10-26 17:56:14 -05:00
Asher
112eda4605
Convert routes to Express
2020-10-26 17:56:13 -05:00
Asher
4b6cbacbad
Add file for global constants
2020-10-26 17:56:12 -05:00
Asher
71dc5c7542
Switch to Express
...
It doesn't do anything yet.
2020-10-26 17:56:11 -05:00
Asher
7e1e9d1249
Merge pull request #2205 from cdr/v3.6.1
...
v3.6.1
2020-10-23 17:04:33 -05:00
