code-server-2

Commit Graph

Author	SHA1	Message	Date
Joe Previte	83746c8a1f	refactor: remove null check in register.ts options.base Inside registerServiceWorker, we were originally using the nullash coalescing operator to check if options.base was null or undefined. However, I realized this check is not necessary. If you look at getOptions' return value, we return an object with a key "base" which is of type "string". We get that value by calling resolveBase which always returns a string. As a result, we didn't need to check if options.base was null or undefined because it never can be.	2021-04-23 17:09:03 -07:00
Joe Previte	6f2709bcaa	feat: add tests for registerServiceWorker	2021-04-23 16:31:56 -07:00
Joe Previte	3f7104bb4e	refactor: move unit tests to test/unit	2021-03-12 12:00:56 -07:00

Author

SHA1

Message

Date

Joe Previte

83746c8a1f

refactor: remove null check in register.ts options.base

Inside registerServiceWorker, we were originally using the nullash coalescing
operator to check if options.base was null or undefined. However, I realized
this check is not necessary.

If you look at getOptions' return value, we return an object with a key "base"
which is of type "string". We get that value by calling resolveBase which always
returns a string.

As a result, we didn't need to check if options.base was null or undefined
because it never can be.

2021-04-23 17:09:03 -07:00

Joe Previte

6f2709bcaa

feat: add tests for registerServiceWorker

2021-04-23 16:31:56 -07:00

Joe Previte

3f7104bb4e

refactor: move unit tests to test/unit

2021-03-12 12:00:56 -07:00

3 Commits