Commit Graph

148 Commits

Author SHA1 Message Date
Asher b9c80b8520
Merge pull request #3178 from code-asher/connections
Minor connections refactor
2021-04-21 12:22:45 -05:00
Asher 16fc315afa
Catch socket close during protocol handshake
zlib errors can cause the protocol handshake to not reject (until the
timeout).
2021-04-21 11:48:46 -05:00
Asher f0bafa387f
Move connection logic into connection class
- Moved everything I could into the class itself.
- Improve the logging situation a bit.
- Switch some trace logs to debug.
- Get debug port from message arguments.
2021-04-21 11:48:45 -05:00
Asher ae6089f852
Improve protocol class
- Move destroy logic into the class itself
- Improve logging a bit
- Remove the record option; we should always do this when using
  permessage-deflate.
- Let debug port be null (it can be null in the message args).
- Add setSocket so we don't have to initiate a connection to set it.
- Move inflate bytes logic into the class itself.
2021-04-21 11:48:43 -05:00
Akash Satheesan f21884cce5
chore(deps): deduplicate deps in yarn.lock (#3167) 2021-04-19 22:22:07 +05:30
dependabot[bot] 818e2207f8
chore(deps): bump ssri from 6.0.1 to 6.0.2 in /lib/vscode (#3165)
Bumps [ssri](https://github.com/npm/ssri) from 6.0.1 to 6.0.2.
- [Release notes](https://github.com/npm/ssri/releases)
- [Changelog](https://github.com/npm/ssri/blob/v6.0.2/CHANGELOG.md)
- [Commits](https://github.com/npm/ssri/compare/v6.0.1...v6.0.2)

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2021-04-19 20:35:48 +05:30
Akash Satheesan 578b2de131
chore(lib/vscode): clean up comments 2021-04-16 00:39:02 +05:30
Akash Satheesan bdf555a06e
fix(lib/vscode): refactor productService 2021-04-16 00:14:16 +05:30
Akash Satheesan 8ffb87dbc9
fix(lib/vscode): restore localizatizons support 2021-04-16 00:06:38 +05:30
Akash Satheesan 2f6d256745 feat(lib/vscode): pull in changes for 1.55.2
Microsoft recently released an update that fixes some security
issues. Squash and pull these changes into our tree.
2021-04-14 19:00:56 +05:30
Akash Satheesan 9f256cd87a
fix(lib/vscode): fix lint errors 2021-04-14 18:58:41 +05:30
Akash Satheesan 093743e365
fix(.../platform/terminal): fix compile, add notes 2021-04-14 18:58:17 +05:30
Akash Satheesan f472b000b5
fix(lib/vscode/test/smoke): update yarn.lock 2021-04-14 18:35:17 +05:30
Asher 5ebb096db5
Get terminals working
- Instead of a single listener per terminal that handles all events VS
  Code now has a single listener per event that handles that event for
  all terminals.
- Refactor Terminal to extend TerminalProcess to avoid duplicating
  methods. This required some modifications to TerminalProcess to access
  the pid and title and to set the ID.
- Remove our async change to shutdown. This was necessary to avoid
  disposing too early but shutdown already calls dispose so it turns out
  we didn't need to call it ourselves.
- Rename methods to match the command strings.
- Fix getting system shell (uses process.env).
- Use a single bufferer. Since it already supports buffering for
  multiple terminals there's no need to have one per terminal.
- Remove replay/reconnect logic. It's broken and unused so there doesn't
  seem much point in trying to refactor it to fit the changes right now.

While terminals work now there are still a lot of todos.
2021-04-13 16:35:13 -05:00
Akash Satheesan b1fb9f780b
fix(lib/vscode): add listProcesses to terminal channel 2021-04-09 20:20:49 +05:30
Akash Satheesan feb7013b3a
fix(lib/vscode): rename terminal events 2021-04-09 19:16:00 +05:30
Akash Satheesan f3b1076f1d
fix(lib/vscode): get vscode to compile 2021-04-09 17:50:11 +05:30
Akash Satheesan 5e63b7f53c
fix(lib/vscode): fix merge conflicts in localizationsService.ts 2021-04-09 17:49:14 +05:30
Akash Satheesan 448ba0ccf2
fix(lib/vscode): fix conflicts in environmentService.ts 2021-04-09 12:50:53 +05:30
Akash Satheesan b73260d561
fix(lib/vscode): fix conflicts in sandbox.simpleservices.ts 2021-04-09 12:50:45 +05:30
Akash Satheesan 15a5d20edf
fix(lib/vscode): fix conflicts in extensionsScanner.ts 2021-04-09 12:39:27 +05:30
Akash Satheesan 4ab306efeb
fix(lib/vscode): fix conflicts in workbench/workbench.web.main.ts 2021-04-09 12:09:36 +05:30
Akash Satheesan 5bd253709f
fix(lib/vscode): package.json and yarn.lock 2021-04-09 11:54:28 +05:30
Akash Satheesan 8fb96b9967 chore(vscode): update to 1.55.2 2021-04-09 11:32:27 +05:30
Joe Previte 003dc0feeb
chore(release): bump version to 3.9.3 2021-04-08 11:18:56 -07:00
Joe Previte f241e38907
chore: fix typo in extensionDownloader 2021-04-06 15:46:57 -07:00
Asher 230b0dfce4
Ignore ipc.d.ts during VS Code lint
We already lint it on our side.
2021-04-02 11:12:13 -05:00
Asher 101c2a01f1
Fix tsc watch restarting when it shouldn't
It seems reaching into lib/vscode for the types caused tsc to establish
watches that caused it to restart over and over while vscode was
building.

The strategy used here is to symlink it instead which is the same thing
we do for the proxy agent.
2021-04-01 10:58:56 -05:00
Akash Satheesan 8332a6abc9
fix(lib/vscode): remove native-keymap and keytar (#2961)
native-keymap and keytar are only used in the electron process,
so we don't need them. This allows us to drop our dependencies on
libx11-dev, libxkbfile-dev, and libsecret-dev.
2021-03-25 22:20:58 +05:30
Joe Previte 090687d057
feat: add e2e test for logout 2021-03-23 10:02:03 -07:00
Joe Previte 5cec6208d0
refactor: add cookie.ts to lib/vscode 2021-03-23 10:02:03 -07:00
Joe Previte 9f790fd2f3
feat(lib/vscode): add log out to application menu
This adds a new option to the Application Menu called Log out.

It deletes the code-server cookie and logs a user out.
2021-03-23 10:02:02 -07:00
Joe Previte aae17cb749
fixup: fix comment in server.ts 2021-03-22 10:43:02 -07:00
Joe Previte 19c2f31f22
fixup: remove comment in server.ts 2021-03-22 10:37:44 -07:00
Joe Previte 36714da613
fixup: move openHelpAbout 2021-03-17 11:25:33 -07:00
Joe Previte d3df963d39
Merge branch 'main' into jsjoeio/upgrade-vscode-1.54 2021-03-16 14:42:51 -07:00
Joe Previte bcdca86539
refactor: change goHome test to helpAbout 2021-03-16 14:25:28 -07:00
Joe Previte ae02023454
fix(lib/vscode): register LogLevelChannel 2021-03-16 14:25:27 -07:00
Asher 050a1bb146
Fix localizations service import
It was moved from electron-browser to electron-sandbox.
2021-03-16 10:20:14 -07:00
Joe Previte 875dfb66a4
fix(lib/vscode): update path for logService 2021-03-16 10:20:14 -07:00
Joe Previte 8f414b5005
fix(lib/vscode): make mkdir recursive 2021-03-16 10:20:14 -07:00
Joe Previte 25dbb5b1b6
fix(lib/vscode0: localizations import in client 2021-03-16 10:20:14 -07:00
Joe Previte 34189e4d49
fix(lib/vscode): add getAppRoot to VariableResolverService
Not sure if it's used because it can return undefined, but it's
there now!
2021-03-16 10:20:13 -07:00
Joe Previte dc08bc68c6
fix(lib/vscode): fix terminalLayoutInfoArgs
It looks like before, the ISetTerminalLAyoutInfoArgs and
IGetTerminalLayoutInfoArgs were part of the terminal interface, but now they're
just interfaces so this commit fixes the imports to get them from
vs/platform/terminal/common/terminalProcess.
2021-03-16 10:20:13 -07:00
Joe Previte e5b7438695
fix(lib/vscode): update imports in channel.ts for terminal
It looks like they moved a bunch of terminal-related files around.

This only fixes the imports.
2021-03-16 10:20:13 -07:00
Joe Previte c42240f182
fix(lib/vscode): refactor mkdirp to fs.promises
They removed mkdirp in favor of fs.promises.

Updated in marketplace.ts
2021-03-16 10:20:13 -07:00
Joe Previte 350ddc3c27
fix(lib/vscode): update log service in server.ts
This required a bit more work.

We moved a few things around and made use of multiplexLogService.
2021-03-16 10:20:13 -07:00
Joe Previte eaf63deb56
fix(lib/vscode): fix return type shutdown in ptyService
In the squash/merge update, we forgot to update the return type.

Add Promise<void> instead of void for shutdown method.
2021-03-16 10:20:12 -07:00
Joe Previte cc8e4ee97c
fix(lib/vscode): update extensionManagementService
Looks like a few import updates and one minor update for language packs.

We had made this change ourselves, but now it's officially in the vscode
codebase. Super cool.
2021-03-16 10:20:12 -07:00
Akash Satheesan 702485139a
chore: update vulnerable dependencies (#2861)
Cherry-pick dependencies with security issues to update.

Signed-off-by: Akash Satheesan <akash@coder.com>
2021-03-12 01:46:40 +05:30