1
0
mirror of https://git.tuxpa.in/a/code-server.git synced 2024-12-28 21:25:25 +00:00
code-server-2/src
Joe Previte 83746c8a1f
refactor: remove null check in register.ts options.base
Inside registerServiceWorker, we were originally using the nullash coalescing
operator to check if options.base was null or undefined. However, I realized
this check is not necessary.

If you look at getOptions' return value, we return an object with a key "base"
which is of type "string". We get that value by calling resolveBase which always
returns a string.

As a result, we didn't need to check if options.base was null or undefined
because it never can be.
2021-04-23 17:09:03 -07:00
..
browser refactor: remove null check in register.ts options.base 2021-04-23 17:09:03 -07:00
common app.ts: Fix createApp to log all http server errors 2021-01-20 02:06:43 -05:00
node Merge pull request #3178 from code-asher/connections 2021-04-21 12:22:45 -05:00