From 0f18d1fddc2e404e4bdefa2021987fe7675128cb Mon Sep 17 00:00:00 2001 From: Joe Previte Date: Thu, 25 Feb 2021 16:44:08 -0700 Subject: [PATCH] fix: update import in channel.ts getSystemShell --- lib/vscode/src/vs/server/node/channel.ts | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/lib/vscode/src/vs/server/node/channel.ts b/lib/vscode/src/vs/server/node/channel.ts index 1ec8eabe..4dfa038e 100644 --- a/lib/vscode/src/vs/server/node/channel.ts +++ b/lib/vscode/src/vs/server/node/channel.ts @@ -30,7 +30,7 @@ import * as terminal from 'vs/workbench/contrib/terminal/common/remoteTerminalCh import { IShellLaunchConfig, ITerminalEnvironment, ITerminalLaunchError } from 'vs/workbench/contrib/terminal/common/terminal'; import { TerminalDataBufferer } from 'vs/workbench/contrib/terminal/common/terminalDataBuffering'; import * as terminalEnvironment from 'vs/workbench/contrib/terminal/common/terminalEnvironment'; -import { getSystemShell } from 'vs/workbench/contrib/terminal/node/terminal'; +import { getSystemShell } from 'vs/base/node/shell'; import { getMainProcessParentEnv } from 'vs/workbench/contrib/terminal/node/terminalEnvironment'; import { TerminalProcess } from 'vs/workbench/contrib/terminal/node/terminalProcess'; import { AbstractVariableResolverService } from 'vs/workbench/services/configurationResolver/common/variableResolver'; @@ -263,6 +263,7 @@ export class ExtensionEnvironmentChannel implements IServerChannel { workspaceStorageHome: this.environment.workspaceStorageHome, userHome: this.environment.userHome, os: platform.OS, + marks: [] }; } @@ -681,7 +682,7 @@ export class TerminalProviderChannel implements IServerChannel { + const getDefaultShellAndArgs = async (): Promise<{ executable: string; args: string[] | string }> => { if (shellLaunchConfig.executable) { const executable = resolverService.resolve(activeWorkspace, shellLaunchConfig.executable); let resolvedArgs: string[] | string = []; @@ -698,7 +699,7 @@ export class TerminalProviderChannel implements IServerChannel args.configuration[key], args.isWorkspaceShellAllowed, - getSystemShell(platform.platform), + await getSystemShell(platform.platform), process.env.hasOwnProperty('PROCESSOR_ARCHITEW6432'), process.env.windir, resolver,