From f92fd2c92e1e155d8ea0690e0e0ee12027c58f2f Mon Sep 17 00:00:00 2001 From: Ben Date: Mon, 8 Feb 2021 09:12:57 -0500 Subject: [PATCH 1/4] clarify alpine on install docs --- docs/install.md | 2 ++ 1 file changed, 2 insertions(+) diff --git a/docs/install.md b/docs/install.md index 3a1f7909..84c6d72f 100644 --- a/docs/install.md +++ b/docs/install.md @@ -1,5 +1,6 @@ + # Install - [Upgrading](#upgrading) @@ -126,6 +127,7 @@ We recommend installing with `yarn` or `npm` when: 1. You aren't on `amd64` or `arm64`. 2. If you're on Linux with glibc < v2.17 or glibcxx < v3.4.18 +3. You're running Alpine Linux. See [#1430](https://github.com/cdr/code-server/issues/1430#issuecomment-629883198) **note:** Installing via `yarn` or `npm` builds native modules on install and so requires C dependencies. See [./npm.md](./npm.md) for installing these dependencies. From 4318ac6834e22198156c1c7ae72eb06f072312ff Mon Sep 17 00:00:00 2001 From: Ben Date: Mon, 8 Feb 2021 09:14:45 -0500 Subject: [PATCH 2/4] fix whitespace --- docs/install.md | 1 - 1 file changed, 1 deletion(-) diff --git a/docs/install.md b/docs/install.md index 84c6d72f..f69d24c9 100644 --- a/docs/install.md +++ b/docs/install.md @@ -1,6 +1,5 @@ - # Install - [Upgrading](#upgrading) From 3dcb92be40f304ba0aeb9c38a15b53eb96ca50f8 Mon Sep 17 00:00:00 2001 From: Ben Date: Mon, 8 Feb 2021 09:32:43 -0500 Subject: [PATCH 3/4] fix npm docs link in install.sh --- install.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/install.sh b/install.sh index bf341cae..0e81885c 100755 --- a/install.sh +++ b/install.sh @@ -419,7 +419,7 @@ install_npm() { echoh echoerr "Please install npm or yarn to install code-server!" echoerr "You will need at least node v12 and a few C dependencies." - echoerr "See the docs https://github.com/cdr/code-server#yarn-npm" + echoerr "See the docs https://github.com/cdr/code-server/blob/master/docs/install.md#yarn-npm" exit 1 } From e4c82a097e3ff8f84172a221f147e1c481b17e86 Mon Sep 17 00:00:00 2001 From: Ben Date: Tue, 9 Feb 2021 07:38:00 -0500 Subject: [PATCH 4/4] update branch in URLs --- install.sh | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/install.sh b/install.sh index 0e81885c..7b39d9da 100755 --- a/install.sh +++ b/install.sh @@ -2,7 +2,7 @@ set -eu # code-server's automatic install script. -# See https://github.com/cdr/code-server/blob/master/docs/install.md +# See https://github.com/cdr/code-server/blob/v3.8.1/docs/install.md usage() { arg0="$0" @@ -67,7 +67,7 @@ Usage: It will cache all downloaded assets into ~/.cache/code-server -More installation docs are at https://github.com/cdr/code-server/blob/master/docs/install.md +More installation docs are at https://github.com/cdr/code-server/blob/v3.8.1/docs/install.md EOF } @@ -419,7 +419,7 @@ install_npm() { echoh echoerr "Please install npm or yarn to install code-server!" echoerr "You will need at least node v12 and a few C dependencies." - echoerr "See the docs https://github.com/cdr/code-server/blob/master/docs/install.md#yarn-npm" + echoerr "See the docs https://github.com/cdr/code-server/blob/v3.8.1/docs/install.md#yarn-npm" exit 1 }