a
/
code-server
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Move address output to the listen callback 

Since listening is asynchronous, this guarantees the address will be
filled out.
This commit is contained in:
Asher 2019-06-17 13:44:24 -05:00
parent a9d17882e7
commit 28c93612e6
No known key found for this signature in database
GPG Key ID: 7BB4BA9C783D2BBC
1 changed files with 24 additions and 22 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

46
packages/server/src/cli.ts
View File

@ -281,10 +281,32 @@ const bold = (text: string | number): string | number => {
if (options.socket) { if (options.socket) {
logger.info("Starting webserver via socket...", field("socket", options.socket)); logger.info("Starting webserver via socket...", field("socket", options.socket));
app.server.listen(options.socket); app.server.listen(options.socket, () => {
logger.info(" ");
logger.info("Started on socket address:");
logger.info(options.socket!);
logger.info(" ");
});
} else { } else {
logger.info("Starting webserver...", field("host", options.host), field("port", options.port)); logger.info("Starting webserver...", field("host", options.host), field("port", options.port));
app.server.listen(options.port, options.host); app.server.listen(options.port, options.host, async () => {
const protocol = options.allowHttp ? "http" : "https";
const address = app.server.address();
const port = typeof address === "string" ? options.port : address.port;
const url = `${protocol}://localhost:${port}/`;
logger.info(" ");
logger.info("Started (click the link below to open):");
logger.info(url);
logger.info(" ");
if (options.open) {
try {
await opn(url);
} catch (e) {
logger.warn("Url couldn't be opened automatically.", field("url", url), field("error", e.message));
}
}
});
} }
let clientId = 1; let clientId = 1;
app.wss.on("connection", (ws, req) => { app.wss.on("connection", (ws, req) => {
@ -327,26 +349,6 @@ const bold = (text: string | number): string | number => {
logger.info(" "); logger.info(" ");
logger.info("Telemetry is disabled."); logger.info("Telemetry is disabled.");
} }
logger.info(" ");
if (options.socket) {
logger.info("Started on socket address:");
logger.info(options.socket);
} else {
const protocol = options.allowHttp ? "http" : "https";
const url = `${protocol}://localhost:${app.server.address().port}/`;
logger.info("Started (click the link below to open):");
logger.info(url);
}
logger.info(" ");
if (options.open) {
try {
await opn(url);
} catch (e) {
logger.warn("Url couldn't be opened automatically.", field("url", url), field("exception", e));
}
}
})().catch((ex) => { })().catch((ex) => {
logger.error(ex); logger.error(ex);
}); });