From 6b887dcc9cbd43d0a9c26b9bd8cc5bd76582db0b Mon Sep 17 00:00:00 2001 From: John McCambridge Date: Tue, 23 Apr 2019 16:38:49 -0500 Subject: [PATCH] Fix no-auth to still use HTTPS, set default for no-auth to false (#573) --- packages/server/src/cli.ts | 2 +- packages/server/src/server.ts | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/packages/server/src/cli.ts b/packages/server/src/cli.ts index 42ef342f..7183d45b 100644 --- a/packages/server/src/cli.ts +++ b/packages/server/src/cli.ts @@ -26,7 +26,7 @@ commander.version(process.env.VERSION || "development") .option("-h, --host ", "Customize the hostname.", "0.0.0.0") .option("-o, --open", "Open in the browser on startup.", false) .option("-p, --port ", "Port to bind on.", parseInt(process.env.PORT!, 10) || 8443) - .option("-N, --no-auth", "Start without requiring authentication.", undefined) + .option("-N, --no-auth", "Start without requiring authentication.", false) .option("-H, --allow-http", "Allow http connections.", false) .option("-P, --password ", "DEPRECATED: Use the PASSWORD environment variable instead. Specify a password for authentication.") .option("--disable-telemetry", "Disables ALL telemetry.", false) diff --git a/packages/server/src/server.ts b/packages/server/src/server.ts index 1b112bfe..b7d9a12c 100644 --- a/packages/server/src/server.ts +++ b/packages/server/src/server.ts @@ -133,7 +133,7 @@ export const createApp = async (options: CreateAppOptions): Promise<{ }); }); - const server = httpolyglot.createServer(options.bypassAuth ? {} : options.httpsOptions || certs, app) as http.Server; + const server = httpolyglot.createServer(options.allowHttp ? {} : options.httpsOptions || certs, app) as http.Server; const wss = new ws.Server({ server }); wss.shouldHandle = (req): boolean => {