From 78b6b3afdfaf7e1f475015287d98163473be6edd Mon Sep 17 00:00:00 2001 From: Asher Date: Fri, 23 Aug 2019 13:43:45 -0500 Subject: [PATCH] Add check for missing reconnection token This means something is misconfigured. --- src/server.ts | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/src/server.ts b/src/server.ts index 28b2a1a0..c7214d21 100644 --- a/src/server.ts +++ b/src/server.ts @@ -266,7 +266,7 @@ export abstract class Server { await this.preHandleWebSocket(request, socket); } catch (error) { socket.destroy(); - console.error(error); + console.error(error.message); } } @@ -421,8 +421,11 @@ export class MainServer extends Server { } protected async handleWebSocket(socket: net.Socket, parsedUrl: url.UrlWithParsedQuery): Promise { + if (!parsedUrl.query.reconnectionToken) { + throw new Error("Reconnection token is missing from query parameters"); + } const protocol = new Protocol(await this.createProxy(socket), { - reconnectionToken: parsedUrl.query.reconnectionToken || "", + reconnectionToken: parsedUrl.query.reconnectionToken, reconnection: parsedUrl.query.reconnection === "true", skipWebSocketFrames: parsedUrl.query.skipWebSocketFrames === "true", });