a
/
code-server
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Merge pull request #4306 from cdr/jsjoeio-fix-broken-tests 

fix: revert CI change + fix broken tests
This commit is contained in:
Joe Previte 2021-10-04 12:20:31 -07:00 committed by GitHub
parent 672038c6af a8d873f9f8
commit 8a4ed5a2e0
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 6 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
.github/workflows/ci.yaml vendored
View File

@ -54,6 +54,10 @@ jobs:
run: yarn lint run: yarn lint
if: success() if: success()
- name: Run code-server unit tests
run: yarn test:unit
if: success()
- name: Upload coverage report to Codecov - name: Upload coverage report to Codecov
run: yarn coverage run: yarn coverage
if: success() if: success()
@ -404,9 +408,6 @@ jobs:
rm -r node_modules/playwright rm -r node_modules/playwright
yarn install --check-files yarn install --check-files
- name: Run end-to-end tests
run: yarn test:unit
- name: Run end-to-end tests - name: Run end-to-end tests
run: yarn test:e2e run: yarn test:e2e

2
src/node/routes/index.ts
View File

@ -162,7 +162,7 @@ export const register = async (
} }
server.on("close", () => { server.on("close", () => {
vscode.vscodeServer.close() vscode?.vscodeServer.close()
}) })
app.use(() => { app.use(() => {

2
test/unit/node/routes/static.test.ts
View File

@ -7,7 +7,7 @@ import * as integration from "../../../utils/integration"
const NOT_FOUND = { const NOT_FOUND = {
code: 404, code: 404,
message: "not found", message: "Not Found",
} }
describe("/_static", () => { describe("/_static", () => {