a
/
code-server
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

fix(lib/vscode): refactor mkdirp to fs.promises 

They removed mkdirp in favor of fs.promises.

Updated in marketplace.ts
This commit is contained in:
Joe Previte 2021-03-11 15:10:42 -07:00
parent 350ddc3c27
commit c42240f182
No known key found for this signature in database
GPG Key ID: 2C91590C6B742C24
1 changed files with 12 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
lib/vscode/src/vs/server/node/marketplace.ts
View File

@ -3,7 +3,6 @@ import * as path from 'path';
import * as tarStream from 'tar-stream'; import * as tarStream from 'tar-stream';
import * as util from 'util'; import * as util from 'util';
import { CancellationToken } from 'vs/base/common/cancellation'; import { CancellationToken } from 'vs/base/common/cancellation';
import { mkdirp } from 'vs/base/node/pfs';
import * as vszip from 'vs/base/node/zip'; import * as vszip from 'vs/base/node/zip';
import * as nls from 'vs/nls'; import * as nls from 'vs/nls';
import product from 'vs/platform/product/common/product'; import product from 'vs/platform/product/common/product';
@ -133,7 +132,12 @@ const extractTar = async (tarPath: string, targetPath: string, options: IExtract
const fileName = rawName.replace(sourcePathRegex, ''); const fileName = rawName.replace(sourcePathRegex, '');
const targetFileName = path.join(targetPath, fileName); const targetFileName = path.join(targetPath, fileName);
if (/\/$/.test(fileName)) { if (/\/$/.test(fileName)) {
return mkdirp(targetFileName).then(nextEntry); /*
NOTE:@coder: they removed mkdirp in favor of fs.promises
See commit: https://github.com/microsoft/vscode/commit/a0d76bb9834b63a02fba8017a6306511fe1ab4fe#diff-2bf233effbb62ea789bb7c4739d222a43ccd97ed9f1219f75bb07e9dee91c1a7
3/11/21 @jsjoeio
*/
return fs.promises.mkdir(targetFileName).then(nextEntry)
} }
const dirName = path.dirname(fileName); const dirName = path.dirname(fileName);
@ -142,7 +146,12 @@ const extractTar = async (tarPath: string, targetPath: string, options: IExtract
return fail(new Error(nls.localize('invalid file', 'Error extracting {0}. Invalid file.', fileName))); return fail(new Error(nls.localize('invalid file', 'Error extracting {0}. Invalid file.', fileName)));
} }
await mkdirp(targetDirName, undefined); /*
NOTE:@coder: they removed mkdirp in favor of fs.promises
See commit: https://github.com/microsoft/vscode/commit/a0d76bb9834b63a02fba8017a6306511fe1ab4fe#diff-2bf233effbb62ea789bb7c4739d222a43ccd97ed9f1219f75bb07e9dee91c1a7
3/11/21 @jsjoeio
*/
await fs.promises.mkdir(targetDirName)
const fstream = fs.createWriteStream(targetFileName, { mode: header.mode }); const fstream = fs.createWriteStream(targetFileName, { mode: header.mode });
fstream.once('close', () => next()); fstream.once('close', () => next());