fix: coveragePathIgnorePatterns to /out
We were accidentally ignoring `node/routes` because we had "out" instead of "/out" in `coveragePathIgnorePatterns` which caused us to not collect coverage for those files. Now we do.
This commit is contained in:
parent
027106a5e1
commit
cb5ab48d48
|
@ -142,7 +142,7 @@
|
|||
"clover"
|
||||
],
|
||||
"coveragePathIgnorePatterns": [
|
||||
"out"
|
||||
"/out"
|
||||
],
|
||||
"coverageThreshold": {
|
||||
"global": {
|
||||
|
|
|
@ -6,17 +6,42 @@ import { loggerModule } from "../utils/helpers"
|
|||
jest.mock("@coder/logger", () => require("../utils/helpers").loggerModule)
|
||||
|
||||
describe("constants", () => {
|
||||
describe("getPackageJson", () => {
|
||||
const { getPackageJson } = require("../../src/node/constants")
|
||||
afterEach(() => {
|
||||
beforeAll(() => {
|
||||
jest.clearAllMocks()
|
||||
jest.resetModules()
|
||||
})
|
||||
describe("with package.json defined", () => {
|
||||
const { getPackageJson } = require("../../src/node/constants")
|
||||
let mockPackageJson = {
|
||||
name: "mock-code-server",
|
||||
description: "Run VS Code on a remote server.",
|
||||
repository: "https://github.com/cdr/code-server",
|
||||
version: "1.0.0",
|
||||
commit: "f6b2be2838f4afb217c2fd8f03eafedd8d55ef9b",
|
||||
}
|
||||
let version = ""
|
||||
let commit = ""
|
||||
|
||||
beforeEach(() => {
|
||||
jest.mock("../../package.json", () => mockPackageJson, { virtual: true })
|
||||
commit = require("../../src/node/constants").commit
|
||||
version = require("../../src/node/constants").version
|
||||
})
|
||||
|
||||
afterAll(() => {
|
||||
jest.restoreAllMocks()
|
||||
jest.clearAllMocks()
|
||||
jest.resetModules()
|
||||
})
|
||||
|
||||
it("should provide the commit", () => {
|
||||
expect(commit).toBe("f6b2be2838f4afb217c2fd8f03eafedd8d55ef9b")
|
||||
})
|
||||
|
||||
it("should return the package.json version", () => {
|
||||
expect(version).toBe(mockPackageJson.version)
|
||||
})
|
||||
|
||||
describe("getPackageJson", () => {
|
||||
it("should log a warning if package.json not found", () => {
|
||||
const expectedErrorMessage = "Cannot find module './package.json' from 'src/node/constants.ts'"
|
||||
|
||||
|
@ -31,103 +56,38 @@ describe("constants", () => {
|
|||
// so to get the root package.json we need to use ../../
|
||||
const packageJson = getPackageJson("../../package.json")
|
||||
expect(Object.keys(packageJson).length).toBeGreaterThan(0)
|
||||
expect(packageJson.name).toBe("code-server")
|
||||
expect(packageJson.name).toBe("mock-code-server")
|
||||
expect(packageJson.description).toBe("Run VS Code on a remote server.")
|
||||
expect(packageJson.repository).toBe("https://github.com/cdr/code-server")
|
||||
})
|
||||
})
|
||||
describe("version", () => {
|
||||
describe("with package.json.version defined", () => {
|
||||
let mockPackageJson = {
|
||||
name: "mock-code-server",
|
||||
version: "1.0.0",
|
||||
}
|
||||
let version = ""
|
||||
|
||||
beforeEach(() => {
|
||||
jest.mock("../../package.json", () => mockPackageJson, { virtual: true })
|
||||
version = require("../../src/node/constants").version
|
||||
})
|
||||
|
||||
afterEach(() => {
|
||||
jest.resetAllMocks()
|
||||
jest.resetModules()
|
||||
})
|
||||
|
||||
it("should return the package.json version", () => {
|
||||
// Source: https://gist.github.com/jhorsman/62eeea161a13b80e39f5249281e17c39#gistcomment-2896416
|
||||
const validSemVar = new RegExp("^(0|[1-9]d*).(0|[1-9]d*).(0|[1-9]d*)")
|
||||
const isValidSemVar = validSemVar.test(version)
|
||||
expect(version).not.toBe(null)
|
||||
expect(isValidSemVar).toBe(true)
|
||||
expect(version).toBe("1.0.0")
|
||||
})
|
||||
})
|
||||
describe("with package.json.version missing", () => {
|
||||
describe("with incomplete package.json", () => {
|
||||
let mockPackageJson = {
|
||||
name: "mock-code-server",
|
||||
}
|
||||
let version = ""
|
||||
let commit = ""
|
||||
|
||||
beforeEach(() => {
|
||||
jest.mock("../../package.json", () => mockPackageJson, { virtual: true })
|
||||
version = require("../../src/node/constants").version
|
||||
commit = require("../../src/node/constants").commit
|
||||
})
|
||||
|
||||
afterEach(() => {
|
||||
jest.resetAllMocks()
|
||||
jest.clearAllMocks()
|
||||
jest.resetModules()
|
||||
})
|
||||
|
||||
it("should return 'development'", () => {
|
||||
it("version should return 'development'", () => {
|
||||
expect(version).toBe("development")
|
||||
})
|
||||
})
|
||||
})
|
||||
describe("commit", () => {
|
||||
describe("with package.json.commit defined", () => {
|
||||
let mockPackageJson = {
|
||||
name: "mock-code-server",
|
||||
commit: "f6b2be2838f4afb217c2fd8f03eafedd8d55ef9b",
|
||||
}
|
||||
let commit = ""
|
||||
|
||||
beforeEach(() => {
|
||||
jest.mock("../../package.json", () => mockPackageJson, { virtual: true })
|
||||
commit = require("../../src/node/constants").commit
|
||||
})
|
||||
|
||||
afterEach(() => {
|
||||
jest.resetAllMocks()
|
||||
jest.resetModules()
|
||||
})
|
||||
|
||||
it("should return the package.json.commit", () => {
|
||||
// Source: https://gist.github.com/jhorsman/62eeea161a13b80e39f5249281e17c39#gistcomment-2896416
|
||||
expect(commit).toBe("f6b2be2838f4afb217c2fd8f03eafedd8d55ef9b")
|
||||
})
|
||||
})
|
||||
describe("with package.json.commit missing", () => {
|
||||
let mockPackageJson = {
|
||||
name: "mock-code-server",
|
||||
}
|
||||
let commit = ""
|
||||
|
||||
beforeEach(() => {
|
||||
jest.mock("../../package.json", () => mockPackageJson, { virtual: true })
|
||||
commit = require("../../src/node/constants").commit
|
||||
})
|
||||
|
||||
afterEach(() => {
|
||||
jest.resetAllMocks()
|
||||
jest.resetModules()
|
||||
})
|
||||
|
||||
it("should return 'development'", () => {
|
||||
it("commit should return 'development'", () => {
|
||||
expect(commit).toBe("development")
|
||||
})
|
||||
})
|
||||
})
|
||||
})
|
||||
|
||||
describe("test constants", () => {
|
||||
|
|
Loading…
Reference in New Issue