a
/
code-server
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Avoid npx for Playwright dependencies (#4437) 

It was causing version mismatch errors.

It might make more sense to have this in the postinstall but for now I
have foregone that as it would be installed in every step including
those that do not run e2e tests.
This commit is contained in:
Asher 2021-11-03 16:17:43 -05:00 committed by GitHub
parent 13404df267
commit dcc9cf3dd2
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 2 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
.github/workflows/ci.yaml vendored
View File

@ -378,9 +378,6 @@ jobs:
with: with:
node-version: "14" node-version: "14"
- name: Install playwright OS dependencies
run: npx playwright install-deps
- name: Fetch dependencies from cache - name: Fetch dependencies from cache
id: cache-yarn id: cache-yarn
uses: actions/cache@v2 uses: actions/cache@v2
@ -406,14 +403,8 @@ jobs:
if: steps.cache-yarn.outputs.cache-hit != 'true' if: steps.cache-yarn.outputs.cache-hit != 'true'
run: yarn --frozen-lockfile run: yarn --frozen-lockfile
# HACK: this shouldn't need to exist, but put it here anyway - name: Install Playwright OS dependencies
# in an attempt to solve Playwright cache failures. run: ./test/node_modules/.bin/playwright install-deps
- name: Reinstall playwright
if: steps.cache-yarn.outputs.cache-hit == 'true'
run: |
cd test/
rm -r node_modules/playwright
yarn install --check-files
- name: Run end-to-end tests - name: Run end-to-end tests
run: yarn test:e2e run: yarn test:e2e