From f10b703e84e66ea049a0944cd17b6368a58f18f1 Mon Sep 17 00:00:00 2001 From: Akash Satheesan Date: Mon, 3 May 2021 20:34:48 +0530 Subject: [PATCH] fix(lib/vscode): fix types in server.ts --- lib/vscode/src/vs/server/node/server.ts | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/lib/vscode/src/vs/server/node/server.ts b/lib/vscode/src/vs/server/node/server.ts index cf7faf37..645e73c8 100644 --- a/lib/vscode/src/vs/server/node/server.ts +++ b/lib/vscode/src/vs/server/node/server.ts @@ -1,6 +1,6 @@ import * as fs from 'fs'; import * as net from 'net'; -import { release } from 'os'; +import { hostname, release } from 'os'; import * as path from 'path'; import { Emitter } from 'vs/base/common/event'; import { Schemas } from 'vs/base/common/network'; @@ -255,6 +255,7 @@ export class Vscode { instantiationService.invokeFunction((accessor) => { instantiationService.createInstance(LogsDataCleaner); + const commit = typeof product.commit === 'string' ? product.commit : 'unknown'; let telemetryService: ITelemetryService; if (!environmentService.disableTelemetry) { telemetryService = new TelemetryService({ @@ -264,8 +265,8 @@ export class Vscode { ), sendErrorTelemetry: true, commonProperties: resolveCommonProperties( - fileService, release(), process.arch, product.commit, product.version, machineId, - [], environmentService.installSourcePath, 'code-server', + fileService, release(), hostname(), process.arch, commit, product.version, machineId, + undefined, environmentService.installSourcePath, 'code-server', ), piiPaths, }, configurationService);