2092f82270
fixup! fix: escape error.message on login failure
2021-07-01 10:43:37 -07:00
c505fc45a8
feat: add escapeHtml function
...
This can be used to escape any special characters in a string with HTML before
sending from the server back to the client. This is important to prevent a
cross-site scripting attack.
2021-07-01 10:43:36 -07:00
7f12fab3ca
fix(isHashMatch): check that hash starts with $
...
Previously, we used argon2 to verify the hash with the password.
If the hash didn't start with a $, then it would enter the catch block.
Now we check the hash before trying to verify it and we also throw an Error if
the verify fails.
This makes the isHashMatch function more robust.
2021-06-30 15:00:21 -07:00
2238d7391e
Fix occasional logout failure
...
It seems a dialog sometimes appears asking if you want to lose
changes (even though we have no changes; it seems based on timers in
some way). Playwright defaults to dismissing them (so quickly you might
not even see them) so accepting instead fixes navigation to the logout
page getting canceled.
2021-06-29 12:06:48 -05:00
43c6ffcb8f
Remove login steps from logout test
...
I figure login is already tested so we can skip this and just use the
cookie.
2021-06-29 12:06:47 -05:00
49c7cc6e8a
Retain failed e2e videos only
2021-06-29 12:06:46 -05:00
f2fa7701a9
Centralize credential handling
...
My thinking is that this may reduce the cognitive overhead for
developers writing new test suites.
This also allows us to perform different setup steps (like ensuring the
editor is visible when authenticated).
2021-06-29 12:06:45 -05:00
da4de439e0
Spawn a code-server instance for each test suite
...
This uses the current dev build by default but can be overidden with
CODE_SERVER_TEST_ENTRY (for example to test a release or some other
version).
Each instance has a separate state directory. This should make
parallelization work.
This also means you are no longer required to specify the password and
address yourself (or the extension directory once we add a test
extension). `yarn test:e2e` should just work as-is.
Lastly, it means the tests are no longer subject to yarn watch randomly
restarting.
2021-06-29 12:06:38 -05:00
49c44818d9
Move onLine to utilities
...
This way it can be used by the tests when spawning code-server on a
random port to look for the address.
2021-06-29 12:04:31 -05:00
add55ecd62
Import utils as a group in tests
...
This should simplify testing new utils a bit.
2021-06-29 12:03:38 -05:00
ba0364a522
Run each e2e test in a new workspace
...
The workspaces also have settings to prevent the welcome page from
appearing.
2021-06-29 12:03:37 -05:00
6e1455da88
feat: add custom codecov
2021-06-28 11:41:48 -07:00
b597519ab5
feat(test): add tests for src/browser/login
2021-06-28 11:41:48 -07:00
02b9489489
refactor: add func getNlsConfiguration & tests
...
This PR refactors part of vscode.ts and adds a function to get the NLS
Configuration.
This makes the code more readable and easier to test.
And it adds multiple tests for this part of the codebase.
2021-06-23 13:42:06 -07:00
dbb34ad710
chore: upgrade to Playwright 1.12 with its new test-runner
2021-06-10 15:09:38 +02:00
1e55a648a5
feat: check for empty str in isHashMatch
2021-06-08 15:10:59 -07:00
3b50bfc17d
fix: sanitize password and cookie key
2021-06-08 14:33:17 -07:00
8c2bb61af9
refactor: parse options with multiple = in cli
...
There was a case with the hashed-password which had multiple equal signs in the
value and it wasn't being parsed correctly. This uses a new function and adds a
few tests.
2021-06-08 14:33:17 -07:00
531b7c0c25
feat: add splitOnFirstEquals function
2021-06-08 14:33:16 -07:00
517aaf71c5
docs: update FAQ with new hashing instructions
2021-06-08 14:33:16 -07:00
6020480b30
feat: add isCookieValid function and tests
2021-06-08 14:33:16 -07:00
a14ea39c4a
feat: add handlePasswordValidation + tests
2021-06-08 14:33:15 -07:00
7ff4117531
feat: add getPasswordMethod & test for it
2021-06-08 14:33:15 -07:00
ffa5c16e51
feat: update cli and test for hashed-password
2021-06-08 14:33:15 -07:00
788b958e20
refactor: update hash fn in test config
2021-06-08 14:33:14 -07:00
fd3cb6cfa0
refactor: update unit tests for hash fns
...
Since the hash and isHashMatch are now async, I had to update the tests
accordingly. Now everything is working.
2021-06-08 14:33:13 -07:00
51f8341959
chore: update to argon2 in test
2021-06-08 14:33:13 -07:00
fc3326f1f2
feat: add tests using real hashes
2021-06-08 14:33:12 -07:00
aaf044728f
refactor: add functions to check hash password
2021-06-08 14:33:12 -07:00
f35120c0a3
feat: add unit test for hash function
2021-06-08 14:33:12 -07:00
17be8c5cd3
refactor: use bcrypt in e2e setup
2021-06-08 14:33:12 -07:00
0832df1a3f
chore(deps): bump ws from 7.4.2 to 7.4.6 in /test ( #3510 )
...
Bumps [ws](https://github.com/websockets/ws ) from 7.4.2 to 7.4.6.
- [Release notes](https://github.com/websockets/ws/releases )
- [Commits](https://github.com/websockets/ws/compare/7.4.2...7.4.6 )
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2021-05-31 20:12:53 +05:30
20874c1833
chore(deps): bump browserslist from 4.16.4 to 4.16.6 in /test
...
Bumps [browserslist](https://github.com/browserslist/browserslist ) from 4.16.4 to 4.16.6.
- [Release notes](https://github.com/browserslist/browserslist/releases )
- [Changelog](https://github.com/browserslist/browserslist/blob/main/CHANGELOG.md )
- [Commits](https://github.com/browserslist/browserslist/compare/4.16.4...4.16.6 )
Signed-off-by: dependabot[bot] <support@github.com>
2021-05-24 21:28:37 +00:00
46fe77d464
chore: update CHANGELOG
2021-05-13 12:10:22 -07:00
2a657ab930
feat: add tests for getEnvPaths
2021-05-13 12:10:21 -07:00
adc9b57080
chore: reformat with new prettier
2021-05-12 01:14:04 +05:30
65c2510faa
chore(deps): bump hosted-git-info from 2.8.8 to 2.8.9 in /test ( #3312 )
...
Bumps [hosted-git-info](https://github.com/npm/hosted-git-info ) from 2.8.8 to 2.8.9.
- [Release notes](https://github.com/npm/hosted-git-info/releases )
- [Changelog](https://github.com/npm/hosted-git-info/blob/v2.8.9/CHANGELOG.md )
- [Commits](https://github.com/npm/hosted-git-info/compare/v2.8.8...v2.8.9 )
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2021-05-08 00:04:25 +05:30
4f320ad3e0
Merge pull request #3297 from code-asher/test-static
2021-05-06 18:24:44 -05:00
e8443e2602
Fix helpers not working in e2e tests
...
It errors that jest is not defined so put it behind a function instead
of immediately creating the mock (this is probably a better pattern
anyway).
The constant tests had to be reworked a little. Since the logger mock is
hoisted it runs before createLoggerMock is imported. I moved it into a
beforeAll which means the require call also needed to be moved
there (since we need to mock the logger before requiring the constants
or it'll pull the non-mocked logger).
This means getPackageJson needs to be a let and assigned afterward. To
avoid having to define a type for getPackageJson I just added a let var
set to the type of the imported constants file and modified the other
areas to use the same paradigm.
I also replaced some hardcoded strings with the mocked package.json
object.
2021-05-06 15:01:35 -05:00
14dbd16a7a
chore(deps): bump lodash from 4.17.20 to 4.17.21 in /test ( #3300 )
...
Bumps [lodash](https://github.com/lodash/lodash ) from 4.17.20 to 4.17.21.
- [Release notes](https://github.com/lodash/lodash/releases )
- [Commits](https://github.com/lodash/lodash/compare/4.17.20...4.17.21 )
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2021-05-07 01:30:47 +05:30
ad4a70c684
Use warn log level for integration tests
...
Just to limit all the noise from code-server's startup output.
2021-05-06 14:27:16 -05:00
4925e97080
Add static route tests
2021-05-06 14:27:11 -05:00
1789cd1bcb
Move temp test dirs under a `tests` sub-directory
...
This is to match the other tests that create temp directories. It also
lets you clean up test temp directories all at once separately from
other non-test temporary directories.
2021-05-06 14:25:51 -05:00
52cf2fcf29
Move tmpdir test helper to test helpers file
2021-05-06 14:25:50 -05:00
0e4672f6b9
Move health route tests to routes directory
2021-05-06 14:25:49 -05:00
cb5ab48d48
fix: coveragePathIgnorePatterns to /out
...
We were accidentally ignoring `node/routes` because we had "out"
instead of "/out" in `coveragePathIgnorePatterns` which caused
us to not collect coverage for those files. Now we do.
2021-05-06 11:53:17 -07:00
027106a5e1
feat(testing): add test for constants "version" and commit
2021-05-05 15:34:48 -07:00
a882be5748
Refactor integration tests to use main entry point
2021-05-05 12:24:41 -05:00
083400b50a
Add flag to enable permessage-deflate
2021-05-05 12:24:34 -05:00
8b2c78c4a4
Re-enable update tests
2021-05-04 13:29:42 -05:00
10babb4a0c
Replace console with logger in sw register
2021-05-04 13:29:41 -05:00
a48ac5080b
Share common util code with VS Code
...
This lets us re-use the normalized base path so when we expire/clear the
cookie we use the same base path.
2021-05-04 13:29:40 -05:00
8e6c10e7ff
Merge pull request #3263 from cdr/jsjoeio/fix-e2e-test
...
fix(testing): reduce flakiness of terminal.test.ts and use 1 worker for e2e tests
2021-04-30 15:38:32 -07:00
cde30579c4
refactor: change to reloadUntilEditorIsReady
2021-04-30 13:44:16 -07:00
2cb499385a
feat: add isConnected method to CodeServer model
2021-04-30 13:36:46 -07:00
7309ea9d10
fix(e2e): use one worker to reduce flakiness
2021-04-29 16:27:19 -07:00
17f4c4c330
fix(e2e): remove quotes from terminal type command
2021-04-29 16:22:21 -07:00
d07317ad01
docs: add maintaining.md with workflow
2021-04-28 11:25:25 -07:00
449c6da77c
refactor: add timeout to terminal.test.ts
2021-04-27 14:35:31 -07:00
8c727d96d6
refactor: make CodeServer methods more stable
2021-04-27 14:35:09 -07:00
07d682392e
Merge pull request #3169 from cdr/jsjoeio/add-terminal-e2e-test
...
feat(testing): add e2e tests for code-server and terminal
2021-04-26 15:16:06 -07:00
83746c8a1f
refactor: remove null check in register.ts options.base
...
Inside registerServiceWorker, we were originally using the nullash coalescing
operator to check if options.base was null or undefined. However, I realized
this check is not necessary.
If you look at getOptions' return value, we return an object with a key "base"
which is of type "string". We get that value by calling resolveBase which always
returns a string.
As a result, we didn't need to check if options.base was null or undefined
because it never can be.
2021-04-23 17:09:03 -07:00
7bfdd13cb3
refactor: tmpdir and add to test utils
2021-04-23 16:40:39 -07:00
6f2709bcaa
feat: add tests for registerServiceWorker
2021-04-23 16:31:56 -07:00
b0ecff338f
refactor: globalSetup to use CodeServer model
2021-04-23 14:35:33 -07:00
cb65590b98
refactor: move tmpdir into src/node/constants
2021-04-23 14:35:32 -07:00
cc99fddf24
feat: add test for terminal echo to file
2021-04-23 14:35:32 -07:00
2bf0a0e76e
refactor: fix tests to check visibility correctly
2021-04-23 14:35:31 -07:00
2665a4f61b
feat: add CodeServer page object for e2e tests
2021-04-23 14:35:31 -07:00
f80d5c3764
refactor: rateLimiter.canTry logic to check >= 1
2021-04-19 13:14:19 -07:00
958f01262b
refactor: check errorMessage in login e2e test
2021-04-19 11:11:52 -07:00
a3f18d6158
refactor: change limiter.Try() to .removeToken()
2021-04-19 10:57:50 -07:00
7928dc2bff
feat: add test for limiter.canTry()
2021-04-19 10:41:00 -07:00
a8719e1f79
refactor: change config to save all e2e videos
2021-04-19 10:40:59 -07:00
1e6f4f2a14
feat(testing): add test for rate limiter
2021-04-19 10:40:59 -07:00
83cfbf82cf
feat: increase timeout for playwright tests
2021-04-19 10:40:59 -07:00
faaa0a9e60
feat(testing): add e2e tests for password
2021-04-19 10:40:59 -07:00
ebbabc6e04
refactor(testing): combine loginPage with login
2021-04-19 10:40:58 -07:00
58e17c5e50
feat(testing): add tests for RateLimiter
2021-04-19 10:40:58 -07:00
450fcd5ba7
refactor: pass all args to test-e2e script
2021-04-15 11:46:45 -07:00
d6f0725399
fix: update path for e2e videos
2021-04-15 11:46:45 -07:00
c9fa931a0b
fix: add retry 2 for failing e2e tests
2021-04-15 11:46:44 -07:00
92b7c1e9a8
refactor: test-e2e.sh script
2021-04-15 11:46:44 -07:00
6c3bb101cd
chore(deps): add resolution for newest playwright
2021-04-15 11:46:44 -07:00
7ea6d22b3e
refactor: add login to config.js for e2e tests
2021-04-15 11:46:44 -07:00
52586706c4
refactor: use playwright-test syntax for e2e tests
2021-04-15 11:46:43 -07:00
08cd2d8191
refactor: add new e2e config
2021-04-15 11:46:43 -07:00
0a090bf12b
chore(deps): add @playwright/test
2021-04-15 11:46:43 -07:00
ad0f12e664
refactor: check for editor consistently in tests
2021-04-06 15:46:58 -07:00
dd80eed5b0
feat: add logger to tests
2021-04-06 15:46:57 -07:00
fd69f2db88
refactor: logout test
2021-04-06 15:46:57 -07:00
c666b47668
refactor: globalSetup and create cookie manually
2021-04-06 15:46:56 -07:00
51010e73cb
feat: add test for globalSetup
2021-04-06 15:46:56 -07:00
4b703cbd4d
refactor: e2e tests based on jest-playwright
2021-04-06 15:46:56 -07:00
1782f2a239
refactor: rename e2e test to loginPage
2021-04-06 15:46:56 -07:00
bd55cb94be
refactor: move test dir to jest e2e config
2021-04-06 15:46:56 -07:00
6b3db06c7a
feat: add new e2e test to test browser
2021-04-06 15:46:56 -07:00
3db19843e2
chore: add eslint plugin for jest-playwright
2021-04-06 15:46:55 -07:00
b4193b8c68
feat: add jest-playwright and packages
2021-04-06 15:46:55 -07:00
9eff1f0702
fix: add timeout to logout test
2021-03-23 12:14:42 -07:00
Joe Previte
Asher
Max Schmitt
dependabot[bot]
Akash Satheesan