59f667ec14
Fix: use pipe to spawn child process to re-enable file logging ( #4293 )
...
We pipe the child's stdout and stderr to the log file (and to the parent's streams) but since we used `inherit` for `stdio` this caused the child to use the parent's streams directly which made `child.stdout` and `child.stderr` non-existent and thus we had no file logging.
Using `pipe` creates stdin and stderr on the child.
2021-10-05 10:55:40 -05:00
816152ddbd
fix typo
2021-10-04 17:41:36 -05:00
45319ec648
woo!
2021-10-04 15:04:07 -07:00
e588f8b0b0
feat(cli): add tests for password, hashed-password
2021-10-04 14:51:14 -07:00
7c26a82a17
format
2021-10-04 14:57:58 -05:00
75e44fdc84
update comparisons in FAQ
2021-10-04 14:48:31 -05:00
8a4ed5a2e0
Merge pull request #4306 from cdr/jsjoeio-fix-broken-tests
...
fix: revert CI change + fix broken tests
2021-10-04 12:20:31 -07:00
a8d873f9f8
refactor(ci): fix unit tests job
2021-10-04 12:07:45 -07:00
7183b5a43e
chore(testing): fix casing in error messsage
2021-10-04 12:06:33 -07:00
8136769b66
fix: close vscodeServer on server close if defined
2021-10-04 12:06:12 -07:00
672038c6af
Fix issue where marketplace is undefined.
...
- Fix error logging from child process.
2021-10-04 13:26:16 -04:00
2d7aeb5bf9
Merge pull request #4290 from cdr/jsjoeio-vscode
...
chore(vscode): update to latest commit of fork
2021-10-01 14:57:02 -07:00
f342c327f3
chore(vscode): update to latest commit of fork
2021-10-01 14:47:20 -07:00
4619786019
Merge pull request #4274 from cdr/jsjoeio-testing-guidelines
...
docs: update section around testing
2021-10-01 11:15:15 -07:00
1dfcd0448e
Merge pull request #4273 from cdr/jsjoeio-bump-helm-chart
...
chore(helm-chart): bump to 1.0.5
2021-10-01 11:10:21 -07:00
48ce49eec8
Merge pull request #4281 from toddewilliams/patch-1
...
Update collaboration.md
2021-09-30 16:43:48 -07:00
d8c344beda
Refactor vscode endpoints to use fork directly.
2021-09-30 19:14:17 -04:00
beebf53adc
Add linkup command to improve link functionality
2021-09-30 19:14:17 -04:00
a14fa862da
fixup! Update collaboration.md
2021-09-30 15:23:16 -07:00
fc0d127470
Update collaboration.md
...
I updated the CodeTogether description to include some enhancements that we just shipped in CodeTogether 4.2. I also added a bit more detail to the feature list and provided some hyperlinks in a couple of places where people would likely appreciate more detail.
I made no changes to the other sections.
2021-09-30 11:51:42 -05:00
6eda7ae81f
Merge pull request #4243 from cdr/renovate/ws-8.x
...
chore(deps): update dependency @types/ws to v8
2021-09-29 15:17:58 -07:00
3f75aa2db1
Merge pull request #4254 from cdr/ipad-copy-paste
...
iPad docs: add copy & paste known issue
2021-09-29 15:11:20 -07:00
328b864534
chore(deps): update dependency @types/ws to v8
2021-09-29 22:06:02 +00:00
876d0275b3
iPad docs: add copy & paste known issue
2021-09-29 15:04:51 -07:00
b9989ca2db
docs(MAINTAINING): add Testing section
2021-09-29 15:02:11 -07:00
4e310b4985
docs(CONTRIBUTING): add scrip tests section
2021-09-29 15:02:11 -07:00
d54b4accac
fix
2021-09-29 14:39:48 -07:00
5e7b419820
chore: bump helm-chart version to 1.0.5
...
We've had two patches to the helm-chart since the last time we bumped the Chart
version.
- 1ffca5751c5a36627aae
2021-09-29 14:38:13 -07:00
1b80244af7
Merge pull request #4265 from cdr/jsjoeio-add-tests
...
feat(cli): add test for defaultConfigFile
2021-09-28 16:19:32 -07:00
999960eef5
Merge pull request #4236 from cdr/jsjoeio/fix-brew-bump
...
fix(brew-bump.sh): add checks and handle errors
2021-09-28 16:13:24 -07:00
6c95f72d2b
refactor: make password param to defaultConfigFile
2021-09-28 16:13:13 -07:00
8ef950af4c
feat(brew-bump): add check for cleanup step
2021-09-28 16:07:01 -07:00
e5f03e0b06
fix: add checks and handle errors brew-bump.sh
...
feat(script): add steps-lib, is_env_var_set & test
feat(brew-bump): add check for VERSION
feat(brew-bump): check HOMEBREW_GITHUB_API_TOKEN
feat(steps-lib): add directory_exists helper fn
fix(brew-bump): check that git clone worked
feat(brew-bump): add check for remote upstream
fix: remove upstream command thing
feat(steps-lib): add file_exists helper function
feat(brew-bump): add check for git-askpass.sh
feat(steps-lib): add is_executable function & test
feat(brew-bump): add check for is_executable
refactor: use GIT_ASKPASS as variable
2021-09-28 16:06:57 -07:00
77c1150b8d
feat(cli): add test for defaultConfigFile
2021-09-28 15:45:44 -07:00
fb2625dbe8
chore(cli): export defaultConfigFile + add JSDoc
2021-09-28 15:38:59 -07:00
82d93186f8
feat(cli): add test for defaultConfigFile
2021-09-28 14:41:38 -07:00
8f72481712
chore: upgrade preview Node.js from 12 to 14 ( #4255 )
2021-09-28 09:21:39 -07:00
edb3b41800
Merge pull request #4253 from cdr/jsjoeio-codeowners
...
fix: update CODEOWNERS for helm-chart
2021-09-27 16:32:33 -07:00
97a292235f
fix: update CODEOWNERS for helm-chart
2021-09-27 16:26:27 -07:00
4c6e43d8d6
Merge pull request #4244 from jlandowner/main
...
Use Ingress v1 from Kubernetes v1.19 in helm chart
2021-09-27 13:24:58 -07:00
8bae81dd83
Merge pull request #4251 from cdr/jsjoeio-fix-trivy
...
chore(deps): upgrade ansi-regex to 5.0.1 and tmpl to 1.0.5
2021-09-27 12:31:56 -07:00
be90b5de35
chore(deps): upgarde tmpl to 1.0.5
2021-09-27 12:20:04 -07:00
1f819fa534
chore(deps): upgrade ansi-regex to 5.0.1
2021-09-27 12:15:18 -07:00
5a36627aae
Use Ingress v1 from k8s v1.19
2021-09-25 23:07:06 +09:00
c11d51ed7a
Update package.json
2021-09-24 17:49:58 -04:00
900c34c613
Merge pull request #4234 from cdr/jsjoeio/update-npm-maintainence
...
docs(MAINTAINING): update release section + add team section
2021-09-23 22:52:34 +00:00
c91033c611
docs(maintaining): fix #4174
2021-09-23 15:45:29 -07:00
2c6a47d42b
docs(maintaining): add note for each release platform
2021-09-23 15:45:28 -07:00
05d66c1358
docs(maintaining): add onboarding and offboarding
2021-09-23 15:45:28 -07:00
bf10341e3f
docs(maintaining): refactor and add Team section
2021-09-23 15:45:27 -07:00
Tian Jian
Ben Potter
Joe Previte
Teffen Ellis
Todd Williams
Renovate Bot
Jonathan Yu
jlandowner
Abdullah Bin Jahed