6bf51caa17
fix(app.ts): resolve with server
2021-01-21 10:11:10 -07:00
f13ba9401b
fix(TS error): add void to promise in util
2021-01-21 10:11:10 -07:00
28e98c0ee0
Merge pull request #2563 from cdr/proxy-path-passthrough-0bb9
...
pathProxy.ts: Implement --proxy-path-passthrough
2021-01-20 02:44:29 -05:00
c32d8b155f
heart.ts: Fix leak when server closes
...
This had me very confused for quite a while until I did a binary search
inspection on route/index.ts. Only with the heart.beat line commented
out did my tests pass without leaking.
They weren't leaking fds but just this heartbeat timer and node of
course prints just fds that are active when it detects some sort of leak
I guess and that made the whole thing very confusing. These fds are not
leaked and will close when node's event loop detects there are no more
callbacks to run.
no of handles 3
tcp stream {
fd: 20,
readable: false,
writable: true,
address: {},
serverAddr: null
}
tcp stream {
fd: 22,
readable: false,
writable: true,
address: {},
serverAddr: null
}
tcp stream {
fd: 23,
readable: true,
writable: false,
address: {},
serverAddr: null
}
It kept printing the above text again and again for 60s and then the
test binary times out I think. I'm not sure if it was node printing the
stuff above or if it was a mocha thing. But it was really confusing...
cc @code-asher for thoughts on what was going on.
edit: It was the leaked-handles import in socket.test.ts!!!
Not sure if we should keep it, this was really confusing and misleading.
2021-01-20 02:06:44 -05:00
5c06646f58
Formatting and linting fixes
2021-01-20 02:06:44 -05:00
240c8e266e
test: Implement integration.ts for near full stack integration testing
2021-01-20 02:06:44 -05:00
d3074278ca
app.ts: Fix createApp to log all http server errors
...
cc @code-asher
2021-01-20 02:06:43 -05:00
ba4a24809c
routes/index.ts: Correctly register wsErrorHandler
...
express requires all 4 arguments to be declared for a error handler.
It's very unfortunate that our types do not handle this.
2021-01-20 02:06:43 -05:00
f169e3ac66
pathProxy.ts: Implement --proxy-path-passthrough
...
Closes #2222
2021-01-20 02:06:43 -05:00
d234ddc1e1
vscode.ts: Fix close current folder
...
Fixes VscodeProvider to correctly obey the ew parameter.
Based on changes by @rdbeach. See the previous commit.
2021-01-18 11:29:18 -05:00
28c7340608
Fix Close Folder/Workspace ( #2532 )
...
When you choose to close the current folder, it doesn't close properly
because the lastVisiited setting is still use. This fixes that.
2021-01-18 11:28:29 -05:00
f15580b28a
favicon: Add dark mode support
...
Closes #2538
Works as expected on latest Firefox and Chromium.
2021-01-11 12:54:25 -05:00
693fdbefb4
browser: Add favicon.afdesign
...
It requires git-lfs to pull down if you want to adjust the favicon and
also the affinity designer software available only on Windows and Mac.
Might be a good idea to switch to Figma at some point and commit a
.fig file.
2021-01-08 23:03:34 -05:00
f763319bc3
Merge pull request #2160 from cdr/github-auth
...
Fix GitHub auth
2020-12-18 10:54:51 -08:00
cb446666fa
Merge pull request #2487 from cdr/proxy-docs-86d4
...
proxy-agent: Use proxy-from-env and add docs
2020-12-18 13:06:47 -05:00
5f7f7f1a92
Simplify query concatenation in URL callback
...
Cases in URLs like ?&a=b or ?a=b& appear to be handled just fine.
2020-12-18 11:31:25 -06:00
d14c2e5bb7
Swap negative check for positive check
2020-12-18 11:21:06 -06:00
60c270aef5
cli: hashedPassword -> hashed-password ( #2454 )
...
Capital letters in the CLI are evil.
cc @code-asher
2020-12-18 12:20:38 -05:00
ae902b9dd1
proxy_agent: Use proxy-from-env for robustness
...
Now we support pretty much every variable under the sun along with
$NO_PROXY all correctly and with minimal code on our end.
2020-12-18 11:10:07 -05:00
94b4ba131e
proxy_agent: Implement $HTTPS_PROXY
...
Just convention, see https://golang.org/pkg/net/http/#ProxyFromEnvironment
2020-12-18 10:39:31 -05:00
ecb4d07364
proxy_agent: Improve documentation
2020-12-18 10:38:46 -05:00
3efd515cdf
proxy_agent: Fix very embarrassing mistake
2020-12-18 04:24:27 -05:00
58c1be57fa
Implement callback endpoints
...
VS Code uses these during the authentication flow.
2020-12-17 15:49:36 -06:00
f8b782bd68
Move ignore-last-opened to ipc.d.ts
...
This is so it can be used in VS Code. Don't tell anyone but I forgot to
run `yarn ci`.
2020-12-15 11:14:21 -06:00
cc584f86b9
Merge pull request #2435 from cdr/issue-2328-customize-go-home
...
cli: add --home flag to customize "Go Home" button
2020-12-15 09:52:39 -07:00
f4ca41329a
Add --ignore-last-opened option ( #2434 )
...
This allows bypassing the last opened behavior for certain cases where that's not desirable.
Fixes #1951
2020-12-15 10:22:58 -06:00
8daba6ca80
feat: add home as a cli option
2020-12-14 16:23:35 -07:00
244afa402e
routes: Redirect from /login when auth is disabled ( #2456 )
...
Sometimes I start with auth but then disable. Now I can just reload the
login page in my browser to be greeted with code-server.
2020-12-14 12:33:36 -05:00
affb92f281
cli: Show beta flags in help output
...
Looks like
```
-r --reuse-window Force to open a file or folder in an already opened window.
-vvv --verbose Enable verbose logging.
--link (beta) Securely bind code-server via Coder Cloud with the passed name. You'll get a URL like
https://myname.coder-cloud.com at which you can easily access your code-server instance.
Authorization is done via GitHub.
```
Based on commits by @JammSpread in #2405
Closes #2396
2020-12-08 19:00:33 -05:00
6c693000eb
Merge pull request #2405 from JammSpread/master
...
Modify --link arg and README (Cdr Cloud)
2020-12-08 18:30:34 -05:00
1dd7e4b4e1
Add hashedPassword config ( #2409 )
...
Resolve #2225 .
2020-12-08 14:54:17 -06:00
4d295e3195
Modify link arg and its desc to not be beta
2020-12-05 01:23:48 +00:00
eb4864f9a5
Merge pull request #2400 from cdr/HTTP_PROXY-7e1f
...
Use proxy-agent to support $HTTP_PROXY
2020-12-04 16:12:45 -05:00
58bbf2584a
proxy_agent.ts: Document why there is no $HTTPS_PROXY support
2020-12-04 13:52:52 -05:00
a021bf5d35
Fix CI
2020-12-04 13:52:52 -05:00
6738cff544
media: Improve icon size ( #2401 )
...
See https://github.com/cdr/code-server/pull/2383#issuecomment-738024951
2020-12-04 11:31:45 -05:00
a72c642125
proxy_agent.ts: Document that no other code passes in explicit agent
...
From my inspection as of this date anyway.
2020-12-04 02:34:43 -05:00
691d44d4a8
Use proxy-agent to support $HTTP_PROXY
...
Closes #124
This works by monkey patching the http and https modules's default agent
at runtime to the one given by the proxy-agent package.
2020-12-04 02:34:43 -05:00
cee88ad637
update.ts: Fix response memory leak
2020-12-04 02:34:43 -05:00
67470f0254
node: coder-cloud -> coder_cloud
...
File names should not have dashes.
2020-12-04 02:34:43 -05:00
04357ddd88
Remove logs mentioning --link being beta
2020-12-04 01:50:47 +00:00
0d53441950
Add "disabled by --link" note to certificate arg
2020-12-04 01:45:20 +00:00
7e1bb8fc96
browser: Fix HTML formatting
2020-11-30 19:16:00 -05:00
ebe4d7ef29
Revamp icons ( #2383 )
...
I took our website's SVG favicon and plopped it on a round
white rectangle in Affinity Designer. The I exported it as an SVG and
wrote a script that uses imagemagick to convert to the various sizes and
formats we need.
Closes #2307
2020-11-30 19:11:26 -05:00
cc18175ce3
cli: Add --disable-update-check flag
...
Closes #2361
2020-11-30 15:30:06 -05:00
be37821ab9
update.ts: Simplify comparison
2020-11-24 12:42:26 -05:00
fb63c0cd22
vscode: Show notification when upgrade is available
...
And link to the release notes.
2020-11-24 12:13:21 -05:00
fb835838db
Remove semver-umd link
...
This is included in the bundle now.
2020-11-20 15:35:18 -06:00
b540737b10
Merge pull request #2339 from cdr/ios-input-3cf7
...
login.css: Disable webkit appearance for input elements
2020-11-19 11:31:07 -05:00
4380356e0c
Merge pull request #2334 from cdr/wrappers
...
Separate process wrappers and pass arguments
2020-11-19 10:28:54 -06:00
Joe Previte
Anmol Sethi
Robert Beach
Asher
JammSpread
SPGoding
JK