Commit Graph

2505 Commits

Author SHA1 Message Date
repo-ranger[bot] 85ded73195
Merge pull request #3227 from cdr/jsjoeio/fix-coverage-shield
docs(readme): refactor to use codecov shield
2021-04-26 21:27:53 +00:00
Joe Previte cb5997b513
docs(readme): add codecov badge 2021-04-26 14:13:02 -07:00
Joe Previte 9d5f05efaf
refactor: remove old coverage shield workflow 2021-04-26 14:11:10 -07:00
Akash Satheesan d6cdeabb16
chore(deps): update dependencies with CVEs (#3223) 2021-04-26 23:56:26 +05:30
repo-ranger[bot] a872850295
Merge pull request #3217 from catthehacker/caddy-sub-path
docs(guide.md): add `caddy` example for serving from sub-path
2021-04-26 18:04:55 +00:00
Asher f746212d80
Revamp debugging section (#3224)
- Most people leave the logs out so add a section for them in the issue
  template.
- Remove the VS Code logs because those get sent to stdout now and will
  show up in our logs.
- Separate browser console and network.
2021-04-26 12:56:12 -05:00
dependabot[bot] 4fd39b25f9
chore(deps-dev): bump stylelint from 13.12.0 to 13.13.0 (#3218)
Bumps [stylelint](https://github.com/stylelint/stylelint) from 13.12.0 to 13.13.0.
- [Release notes](https://github.com/stylelint/stylelint/releases)
- [Changelog](https://github.com/stylelint/stylelint/blob/master/CHANGELOG.md)
- [Commits](https://github.com/stylelint/stylelint/compare/13.12.0...13.13.0)

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2021-04-26 18:03:26 +05:30
dependabot[bot] eb745c8824
chore(deps-dev): bump eslint from 7.24.0 to 7.25.0 (#3219)
Bumps [eslint](https://github.com/eslint/eslint) from 7.24.0 to 7.25.0.
- [Release notes](https://github.com/eslint/eslint/releases)
- [Changelog](https://github.com/eslint/eslint/blob/master/CHANGELOG.md)
- [Commits](https://github.com/eslint/eslint/compare/v7.24.0...v7.25.0)

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2021-04-26 18:01:23 +05:30
dependabot[bot] f1aff8cd19
chore(deps-dev): bump @types/semver from 7.3.4 to 7.3.5 (#3220)
Bumps [@types/semver](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/semver) from 7.3.4 to 7.3.5.
- [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases)
- [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/semver)

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2021-04-26 17:59:36 +05:30
dependabot[bot] ca0d7c2ede
chore(deps-dev): bump eslint-config-prettier from 8.2.0 to 8.3.0 (#3221)
Bumps [eslint-config-prettier](https://github.com/prettier/eslint-config-prettier) from 8.2.0 to 8.3.0.
- [Release notes](https://github.com/prettier/eslint-config-prettier/releases)
- [Changelog](https://github.com/prettier/eslint-config-prettier/blob/main/CHANGELOG.md)
- [Commits](https://github.com/prettier/eslint-config-prettier/compare/v8.2.0...v8.3.0)

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2021-04-26 17:58:29 +05:30
dependabot[bot] c46a7c5fe6
chore(deps-dev): bump @types/js-yaml from 4.0.0 to 4.0.1 (#3222)
Bumps [@types/js-yaml](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/js-yaml) from 4.0.0 to 4.0.1.
- [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases)
- [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/js-yaml)

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2021-04-26 17:57:13 +05:30
hackercat 95164d024c
feat: add `caddy` example for serving from sub-path 2021-04-26 08:16:32 +02:00
repo-ranger[bot] d31439ec34
Merge pull request #3200 from cdr/jsjoeio/add-test-browser-register
feat(testing): add tests for registerServiceWorker
2021-04-24 00:23:37 +00:00
Joe Previte 83746c8a1f
refactor: remove null check in register.ts options.base
Inside registerServiceWorker, we were originally using the nullash coalescing
operator to check if options.base was null or undefined. However, I realized
this check is not necessary.

If you look at getOptions' return value, we return an object with a key "base"
which is of type "string". We get that value by calling resolveBase which always
returns a string.

As a result, we didn't need to check if options.base was null or undefined
because it never can be.
2021-04-23 17:09:03 -07:00
Joe Previte 7bfdd13cb3
refactor: tmpdir and add to test utils 2021-04-23 16:40:39 -07:00
Joe Previte 6f2709bcaa
feat: add tests for registerServiceWorker 2021-04-23 16:31:56 -07:00
Joe Previte b0ecff338f
refactor: globalSetup to use CodeServer model 2021-04-23 14:35:33 -07:00
Joe Previte cb65590b98
refactor: move tmpdir into src/node/constants 2021-04-23 14:35:32 -07:00
Joe Previte cc99fddf24
feat: add test for terminal echo to file 2021-04-23 14:35:32 -07:00
Joe Previte 2bf0a0e76e
refactor: fix tests to check visibility correctly 2021-04-23 14:35:31 -07:00
Joe Previte 2665a4f61b
feat: add CodeServer page object for e2e tests 2021-04-23 14:35:31 -07:00
repo-ranger[bot] 5ad8e686bc
Merge pull request #3194 from cdr/jsjoeio/add-code-coverage-reporter
feat(testing): add codecov to generate test coverage reports
2021-04-22 22:46:45 +00:00
Joe Previte bb0414e7bb
feat: add ci step upload coverage report Codecov 2021-04-22 15:28:30 -07:00
Joe Previte 537fbd040a
feat: add coverage script using codecov 2021-04-22 15:27:54 -07:00
Joe Previte a777bf05c7
feat: add clover to get test coverage in xml
Codecov requires .xml format.

We can get this from Jest by adding "clover"
to our coverageReporters.
2021-04-22 15:03:15 -07:00
Akash Satheesan 72ca12c098
chore(lib/vscode): update netmask (#3187) 2021-04-22 02:57:35 +05:30
Asher b9c80b8520
Merge pull request #3178 from code-asher/connections
Minor connections refactor
2021-04-21 12:22:45 -05:00
Asher 16fc315afa
Catch socket close during protocol handshake
zlib errors can cause the protocol handshake to not reject (until the
timeout).
2021-04-21 11:48:46 -05:00
Asher f0bafa387f
Move connection logic into connection class
- Moved everything I could into the class itself.
- Improve the logging situation a bit.
- Switch some trace logs to debug.
- Get debug port from message arguments.
2021-04-21 11:48:45 -05:00
Asher ae6089f852
Improve protocol class
- Move destroy logic into the class itself
- Improve logging a bit
- Remove the record option; we should always do this when using
  permessage-deflate.
- Let debug port be null (it can be null in the message args).
- Add setSocket so we don't have to initiate a connection to set it.
- Move inflate bytes logic into the class itself.
2021-04-21 11:48:43 -05:00
Akash Satheesan 4ed7ae9c96
chore(ranger): fix syntax for extension-request (#3172) 2021-04-20 10:27:06 -07:00
Akash Satheesan 724ee93e81
chore(ci): migrate from hub to gh (#3168) 2021-04-20 02:21:33 +05:30
repo-ranger[bot] 6d65680c23
Merge pull request #3141 from cdr/jsjoeio/fix-login-rate-limiter
fix(login): rate limiter shouldn't count successful logins
2021-04-19 20:29:11 +00:00
Joe Previte f80d5c3764
refactor: rateLimiter.canTry logic to check >= 1 2021-04-19 13:14:19 -07:00
Joe Previte 7a5042176e
fix: update logic for removing token from limiter 2021-04-19 11:12:43 -07:00
Joe Previte 958f01262b
refactor: check errorMessage in login e2e test 2021-04-19 11:11:52 -07:00
Joe Previte a3f18d6158
refactor: change limiter.Try() to .removeToken() 2021-04-19 10:57:50 -07:00
Joe Previte 7928dc2bff
feat: add test for limiter.canTry() 2021-04-19 10:41:00 -07:00
Joe Previte d8e45057c7
refactor: update rateLimiter to check try
This changes adds a new method called `.canTry` to the rate limiter to check if
there are tokens remaining in the bucket.

It also adds suggestions from @oxy to make sure the user can brute force past
the rate limiter.
2021-04-19 10:40:59 -07:00
Joe Previte a8719e1f79
refactor: change config to save all e2e videos 2021-04-19 10:40:59 -07:00
Joe Previte 1e6f4f2a14
feat(testing): add test for rate limiter 2021-04-19 10:40:59 -07:00
Joe Previte 08521077f0
refactor(login): move rate limiter after successful login
Before, we weren't checking if a login was successful before counting it
against the rate limiter.

With this change, we only count unsuccessful logins against the rate limiter.

We did this because this was a bug but also because it caused problems with our
e2e tests hitting the rate limit.
2021-04-19 10:40:59 -07:00
Joe Previte 83cfbf82cf
feat: increase timeout for playwright tests 2021-04-19 10:40:59 -07:00
Joe Previte faaa0a9e60
feat(testing): add e2e tests for password 2021-04-19 10:40:59 -07:00
Joe Previte ebbabc6e04
refactor(testing): combine loginPage with login 2021-04-19 10:40:58 -07:00
Joe Previte 58e17c5e50
feat(testing): add tests for RateLimiter 2021-04-19 10:40:58 -07:00
Joe Previte 4683d8a077
fix: update comment and export rateLimiter 2021-04-19 10:40:58 -07:00
Akash Satheesan f21884cce5
chore(deps): deduplicate deps in yarn.lock (#3167) 2021-04-19 22:22:07 +05:30
dependabot[bot] 818e2207f8
chore(deps): bump ssri from 6.0.1 to 6.0.2 in /lib/vscode (#3165)
Bumps [ssri](https://github.com/npm/ssri) from 6.0.1 to 6.0.2.
- [Release notes](https://github.com/npm/ssri/releases)
- [Changelog](https://github.com/npm/ssri/blob/v6.0.2/CHANGELOG.md)
- [Commits](https://github.com/npm/ssri/compare/v6.0.1...v6.0.2)

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2021-04-19 20:35:48 +05:30
dependabot[bot] 7f6b3da8d5
chore(deps): bump ws from 7.4.4 to 7.4.5 (#3163)
Bumps [ws](https://github.com/websockets/ws) from 7.4.4 to 7.4.5.
- [Release notes](https://github.com/websockets/ws/releases)
- [Commits](https://github.com/websockets/ws/compare/7.4.4...7.4.5)

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2021-04-19 20:31:57 +05:30