Added the Social Groups plugin. This is still under construction.
Made a few improvements to the ForumStore, including bringing it's API closer in line with the other datastores, adding stubs for future subforum functionality, and improving efficiency in a few places.
The auth interface now handles all the authentication stuff.
Renamed the debug config variable to debug_mode.
Added the PluginPerms API.
Internal Errors will now dump the stack trace in the console.
Added support for installable plugins.
Refactored the routing logic so that the router now handles the common PreRoute logic(exc. /static/)
Added the CreateTable method to the query generator. It might need some tweaking to better support other database systems.
Added the same CreateTable method to the query builder.
Began work on PostgreSQL support.
Added the string-string hook type
Added the pre_render hook type.
Added the ParentID and ParentType fields to forums.
Added the get_forum_url_prefix function.
Added a more generic build_slug function.
Added the get_topic_url_prefix function.
Added the override_perms and override_forum_perms functions for bulk setting and unsetting permissions.
Added more ExtData fields in a few structs and removed them on the Perms struct as the PluginPerms API supersedes them there.
Plugins can now see the router instance.
The plugin initialisation handlers can now throw errors.
Plugins are now initialised after all the forum's subsystems are.
Refactored the unit test logic. For instance, we now use the proper .Log method rather than fmt.Println in many cases.
Sorry, we'll have to break Github's generated file detection, as the build instructions aren't working, unless I put them at the top, and they're far, far more important than getting Github to recognise the generated code as generated code.
Fixed an issue with mysql.go's _init_database() overwriting the dbpassword variable. Not a huge issue, but it is a "gotcha" for those not expecting a ':' at the start.
Fixed an issue with forum creation where the forum permissions didn't get cached.
Fixed a bug in plugin_bbcode where negative numbers in rand would crash Gosora.
Made the outputs of plugin_markdown and plugin_bbcode more compliant with the tests.
Revamped the phrase system to make it easier for us to add language pack related features in the future.
Added the WidgetMenu widget type.
Revamped the theme again. I'm experimenting to see which approach I like most.
- Excuse the little W3C rage. Some things about CSS drive me crazy :p
Tests:
Added 22 bbcode_full_parse tests.
Added 19 bbcode_regex_parse tests.
Added 27 markdown_parse tests.
Added four UserStore tests. More to come when the test database functionality is added.
Added 18 name_to_slug tests.
Hooks:
Added the pre_render hook.
Added the pre_render_forum_list hook.
Added the pre_render_view_forum hook.
Added the pre_render_topic_list hook.
Added the pre_render_view_topic hook.
Added the pre_render_profile hook.
Added the pre_render_custom_page hook.
Added the pre_render_overview hook.
Added the pre_render_create_topic hook.
Added the pre_render_account_own_edit_critical hook.
Added the pre_render_account_own_edit_avatar hook.
Added the pre_render_account_own_edit_username hook.
Added the pre_render_account_own_edit_email hook.
Added the pre_render_login hook.
Added the pre_render_register hook.
Added the pre_render_ban hook.
Added the pre_render_panel_dashboard hook.
Added the pre_render_panel_forums hook.
Added the pre_render_panel_delete_forum hook.
Added the pre_render_panel_edit_forum hook.
Added the pre_render_panel_settings hook.
Added the pre_render_panel_setting hook.
Added the pre_render_panel_plugins hook.
Added the pre_render_panel_users hook.
Added the pre_render_panel_edit_user hook.
Added the pre_render_panel_groups hook.
Added the pre_render_panel_edit_group hook.
Added the pre_render_panel_edit_group_perms hook.
Added the pre_render_panel_themes hook.
Added the pre_render_panel_mod_log hook.
Added the pre_render_error hook.
Added the pre_render_security_error hook.
Added the create_group_preappend hook.
Added the intercept_build_widgets hook.
Added the simple_forum_check_pre_perms hook.
Added the forum_check_pre_perms hook.
2017-07-09 12:06:04 +00:00
package main
2017-10-16 07:32:58 +00:00
import (
2017-10-21 00:27:47 +00:00
"bytes"
2017-10-16 07:32:58 +00:00
"fmt"
2017-10-21 00:27:47 +00:00
"net/http/httptest"
2017-10-16 07:32:58 +00:00
"runtime/debug"
2018-06-06 00:21:22 +00:00
"strconv"
2017-10-16 07:32:58 +00:00
"testing"
"time"
2017-11-11 04:06:16 +00:00
"./common"
2017-10-16 07:32:58 +00:00
)
2017-10-21 00:27:47 +00:00
func recordMustExist ( t * testing . T , err error , errmsg string , args ... interface { } ) {
2017-10-16 07:32:58 +00:00
if err == ErrNoRows {
2018-05-28 06:27:12 +00:00
debug . PrintStack ( )
2017-10-21 00:27:47 +00:00
t . Errorf ( errmsg , args ... )
2017-10-16 07:32:58 +00:00
} else if err != nil {
2018-05-28 06:27:12 +00:00
debug . PrintStack ( )
2017-10-16 07:32:58 +00:00
t . Fatal ( err )
}
}
2017-10-21 00:27:47 +00:00
func recordMustNotExist ( t * testing . T , err error , errmsg string , args ... interface { } ) {
2017-10-16 07:32:58 +00:00
if err == nil {
2018-05-28 06:27:12 +00:00
debug . PrintStack ( )
2017-10-21 00:27:47 +00:00
t . Errorf ( errmsg , args ... )
2017-10-16 07:32:58 +00:00
} else if err != ErrNoRows {
2018-05-28 06:27:12 +00:00
debug . PrintStack ( )
2017-10-16 07:32:58 +00:00
t . Fatal ( err )
}
}
Added the Social Groups plugin. This is still under construction.
Made a few improvements to the ForumStore, including bringing it's API closer in line with the other datastores, adding stubs for future subforum functionality, and improving efficiency in a few places.
The auth interface now handles all the authentication stuff.
Renamed the debug config variable to debug_mode.
Added the PluginPerms API.
Internal Errors will now dump the stack trace in the console.
Added support for installable plugins.
Refactored the routing logic so that the router now handles the common PreRoute logic(exc. /static/)
Added the CreateTable method to the query generator. It might need some tweaking to better support other database systems.
Added the same CreateTable method to the query builder.
Began work on PostgreSQL support.
Added the string-string hook type
Added the pre_render hook type.
Added the ParentID and ParentType fields to forums.
Added the get_forum_url_prefix function.
Added a more generic build_slug function.
Added the get_topic_url_prefix function.
Added the override_perms and override_forum_perms functions for bulk setting and unsetting permissions.
Added more ExtData fields in a few structs and removed them on the Perms struct as the PluginPerms API supersedes them there.
Plugins can now see the router instance.
The plugin initialisation handlers can now throw errors.
Plugins are now initialised after all the forum's subsystems are.
Refactored the unit test logic. For instance, we now use the proper .Log method rather than fmt.Println in many cases.
Sorry, we'll have to break Github's generated file detection, as the build instructions aren't working, unless I put them at the top, and they're far, far more important than getting Github to recognise the generated code as generated code.
Fixed an issue with mysql.go's _init_database() overwriting the dbpassword variable. Not a huge issue, but it is a "gotcha" for those not expecting a ':' at the start.
Fixed an issue with forum creation where the forum permissions didn't get cached.
Fixed a bug in plugin_bbcode where negative numbers in rand would crash Gosora.
Made the outputs of plugin_markdown and plugin_bbcode more compliant with the tests.
Revamped the phrase system to make it easier for us to add language pack related features in the future.
Added the WidgetMenu widget type.
Revamped the theme again. I'm experimenting to see which approach I like most.
- Excuse the little W3C rage. Some things about CSS drive me crazy :p
Tests:
Added 22 bbcode_full_parse tests.
Added 19 bbcode_regex_parse tests.
Added 27 markdown_parse tests.
Added four UserStore tests. More to come when the test database functionality is added.
Added 18 name_to_slug tests.
Hooks:
Added the pre_render hook.
Added the pre_render_forum_list hook.
Added the pre_render_view_forum hook.
Added the pre_render_topic_list hook.
Added the pre_render_view_topic hook.
Added the pre_render_profile hook.
Added the pre_render_custom_page hook.
Added the pre_render_overview hook.
Added the pre_render_create_topic hook.
Added the pre_render_account_own_edit_critical hook.
Added the pre_render_account_own_edit_avatar hook.
Added the pre_render_account_own_edit_username hook.
Added the pre_render_account_own_edit_email hook.
Added the pre_render_login hook.
Added the pre_render_register hook.
Added the pre_render_ban hook.
Added the pre_render_panel_dashboard hook.
Added the pre_render_panel_forums hook.
Added the pre_render_panel_delete_forum hook.
Added the pre_render_panel_edit_forum hook.
Added the pre_render_panel_settings hook.
Added the pre_render_panel_setting hook.
Added the pre_render_panel_plugins hook.
Added the pre_render_panel_users hook.
Added the pre_render_panel_edit_user hook.
Added the pre_render_panel_groups hook.
Added the pre_render_panel_edit_group hook.
Added the pre_render_panel_edit_group_perms hook.
Added the pre_render_panel_themes hook.
Added the pre_render_panel_mod_log hook.
Added the pre_render_error hook.
Added the pre_render_security_error hook.
Added the create_group_preappend hook.
Added the intercept_build_widgets hook.
Added the simple_forum_check_pre_perms hook.
Added the forum_check_pre_perms hook.
2017-07-09 12:06:04 +00:00
func TestUserStore ( t * testing . T ) {
2017-09-03 04:50:31 +00:00
if ! gloinited {
err := gloinit ( )
if err != nil {
t . Fatal ( err )
}
}
2017-11-11 08:46:30 +00:00
if ! common . PluginsInited {
common . InitPlugins ( )
2017-09-03 04:50:31 +00:00
}
2017-11-02 13:35:19 +00:00
var err error
2017-11-23 05:37:08 +00:00
ucache := common . NewMemoryUserCache ( common . Config . UserCacheCapacity )
common . Users , err = common . NewDefaultUserStore ( ucache )
2017-11-02 13:35:19 +00:00
expectNilErr ( t , err )
2017-11-23 05:37:08 +00:00
ucache . Flush ( )
2017-10-16 07:32:58 +00:00
userStoreTest ( t , 2 )
2017-11-23 05:37:08 +00:00
common . Users , err = common . NewDefaultUserStore ( nil )
2017-11-02 13:35:19 +00:00
expectNilErr ( t , err )
2017-10-16 07:32:58 +00:00
userStoreTest ( t , 3 )
2017-09-15 22:20:01 +00:00
}
2017-10-16 07:32:58 +00:00
func userStoreTest ( t * testing . T , newUserID int ) {
2017-11-23 05:37:08 +00:00
ucache := common . Users . GetCache ( )
2017-10-21 00:27:47 +00:00
// Go doesn't have short-circuiting, so this'll allow us to do one liner tests
2017-11-23 05:37:08 +00:00
isCacheLengthZero := func ( ucache common . UserCache ) bool {
if ucache == nil {
return true
}
return ucache . Length ( ) == 0
}
cacheLength := func ( ucache common . UserCache ) int {
if ucache == nil {
return 0
}
return ucache . Length ( )
2017-09-18 17:03:52 +00:00
}
2017-11-23 05:37:08 +00:00
expect ( t , isCacheLengthZero ( ucache ) , fmt . Sprintf ( "The initial ucache length should be zero, not %d" , cacheLength ( ucache ) ) )
2017-09-03 04:50:31 +00:00
2017-11-11 04:06:16 +00:00
_ , err := common . Users . Get ( - 1 )
2017-10-16 07:32:58 +00:00
recordMustNotExist ( t , err , "UID #-1 shouldn't exist" )
2017-11-23 05:37:08 +00:00
expect ( t , isCacheLengthZero ( ucache ) , fmt . Sprintf ( "We found %d items in the user cache and it's supposed to be empty" , cacheLength ( ucache ) ) )
2017-09-18 17:03:52 +00:00
2017-11-11 04:06:16 +00:00
_ , err = common . Users . Get ( 0 )
2017-10-16 07:32:58 +00:00
recordMustNotExist ( t , err , "UID #0 shouldn't exist" )
2017-11-23 05:37:08 +00:00
expect ( t , isCacheLengthZero ( ucache ) , fmt . Sprintf ( "We found %d items in the user cache and it's supposed to be empty" , cacheLength ( ucache ) ) )
2017-09-03 04:50:31 +00:00
2017-11-11 04:06:16 +00:00
user , err := common . Users . Get ( 1 )
2017-10-16 07:32:58 +00:00
recordMustExist ( t , err , "Couldn't find UID #1" )
2017-09-03 04:50:31 +00:00
2017-10-21 00:27:47 +00:00
expect ( t , user . ID == 1 , fmt . Sprintf ( "user.ID should be 1. Got '%d' instead." , user . ID ) )
expect ( t , user . Name == "Admin" , fmt . Sprintf ( "user.Name should be 'Admin', not '%s'" , user . Name ) )
expect ( t , user . Group == 1 , "Admin should be in group 1" )
expect ( t , user . IsSuperAdmin , "Admin should be a super admin" )
expect ( t , user . IsAdmin , "Admin should be an admin" )
expect ( t , user . IsSuperMod , "Admin should be a super mod" )
expect ( t , user . IsMod , "Admin should be a mod" )
expect ( t , ! user . IsBanned , "Admin should not be banned" )
2017-10-16 07:32:58 +00:00
2017-11-11 04:06:16 +00:00
_ , err = common . Users . Get ( newUserID )
2017-10-16 07:32:58 +00:00
recordMustNotExist ( t , err , fmt . Sprintf ( "UID #%d shouldn't exist" , newUserID ) )
2017-09-03 04:50:31 +00:00
2017-11-23 05:37:08 +00:00
if ucache != nil {
2017-10-16 07:32:58 +00:00
expectIntToBeX ( t , ucache . Length ( ) , 1 , "User cache length should be 1, not %d" )
2017-09-18 17:03:52 +00:00
2017-11-23 05:37:08 +00:00
_ , err = ucache . Get ( - 1 )
2017-10-16 07:32:58 +00:00
recordMustNotExist ( t , err , "UID #-1 shouldn't exist, even in the cache" )
2017-11-23 05:37:08 +00:00
_ , err = ucache . Get ( 0 )
2017-10-16 07:32:58 +00:00
recordMustNotExist ( t , err , "UID #0 shouldn't exist, even in the cache" )
2017-11-23 05:37:08 +00:00
user , err = ucache . Get ( 1 )
2017-10-16 07:32:58 +00:00
recordMustExist ( t , err , "Couldn't find UID #1 in the cache" )
2017-09-18 17:03:52 +00:00
2017-11-23 05:37:08 +00:00
expect ( t , user . ID == 1 , fmt . Sprintf ( "user.ID does not match the requested UID. Got '%d' instead." , user . ID ) )
expect ( t , user . Name == "Admin" , fmt . Sprintf ( "user.Name should be 'Admin', not '%s'" , user . Name ) )
2017-10-16 07:32:58 +00:00
2017-11-23 05:37:08 +00:00
_ , err = ucache . Get ( newUserID )
2017-10-21 00:27:47 +00:00
recordMustNotExist ( t , err , "UID #%d shouldn't exist, even in the cache" , newUserID )
2017-09-18 17:03:52 +00:00
ucache . Flush ( )
2017-10-16 07:32:58 +00:00
expectIntToBeX ( t , ucache . Length ( ) , 0 , "User cache length should be 0, not %d" )
2017-09-18 17:03:52 +00:00
}
2017-09-10 16:57:22 +00:00
// TODO: Lock onto the specific error type. Is this even possible without sacrificing the detailed information in the error message?
2017-11-11 08:46:30 +00:00
var userList map [ int ] * common . User
2017-11-11 04:06:16 +00:00
userList , _ = common . Users . BulkGetMap ( [ ] int { - 1 } )
2017-11-23 05:37:08 +00:00
expect ( t , len ( userList ) == 0 , fmt . Sprintf ( "The userList length should be 0, not %d" , len ( userList ) ) )
expect ( t , isCacheLengthZero ( ucache ) , fmt . Sprintf ( "User cache length should be 0, not %d" , cacheLength ( ucache ) ) )
2017-09-18 17:03:52 +00:00
2017-11-11 04:06:16 +00:00
userList , _ = common . Users . BulkGetMap ( [ ] int { 0 } )
2017-11-23 05:37:08 +00:00
expect ( t , len ( userList ) == 0 , fmt . Sprintf ( "The userList length should be 0, not %d" , len ( userList ) ) )
expect ( t , isCacheLengthZero ( ucache ) , fmt . Sprintf ( "User cache length should be 0, not %d" , cacheLength ( ucache ) ) )
2017-09-18 17:03:52 +00:00
2017-11-11 04:06:16 +00:00
userList , _ = common . Users . BulkGetMap ( [ ] int { 1 } )
2018-06-06 06:13:55 +00:00
expect ( t , len ( userList ) == 1 , fmt . Sprintf ( "Returned map should have one result (UID #1), not %d" , len ( userList ) ) )
2017-09-15 22:20:01 +00:00
user , ok := userList [ 1 ]
if ! ok {
t . Error ( "We couldn't find UID #1 in the returned map" )
t . Error ( "userList" , userList )
2017-12-25 06:12:19 +00:00
return
2017-09-15 22:20:01 +00:00
}
2017-11-23 05:37:08 +00:00
expect ( t , user . ID == 1 , fmt . Sprintf ( "user.ID does not match the requested UID. Got '%d' instead." , user . ID ) )
2017-09-15 22:20:01 +00:00
2017-11-23 05:37:08 +00:00
if ucache != nil {
2017-10-16 07:32:58 +00:00
expectIntToBeX ( t , ucache . Length ( ) , 1 , "User cache length should be 1, not %d" )
2017-11-23 05:37:08 +00:00
user , err = ucache . Get ( 1 )
2017-10-16 07:32:58 +00:00
recordMustExist ( t , err , "Couldn't find UID #1 in the cache" )
2017-09-18 17:03:52 +00:00
2017-11-23 05:37:08 +00:00
expect ( t , user . ID == 1 , fmt . Sprintf ( "user.ID does not match the requested UID. Got '%d' instead." , user . ID ) )
2017-09-18 17:03:52 +00:00
ucache . Flush ( )
}
2017-11-11 08:46:30 +00:00
expect ( t , ! common . Users . Exists ( - 1 ) , "UID #-1 shouldn't exist" )
expect ( t , ! common . Users . Exists ( 0 ) , "UID #0 shouldn't exist" )
2017-11-11 04:06:16 +00:00
expect ( t , common . Users . Exists ( 1 ) , "UID #1 should exist" )
2017-11-11 08:46:30 +00:00
expect ( t , ! common . Users . Exists ( newUserID ) , fmt . Sprintf ( "UID #%d shouldn't exist" , newUserID ) )
2017-10-16 07:32:58 +00:00
2017-11-23 05:37:08 +00:00
expect ( t , isCacheLengthZero ( ucache ) , fmt . Sprintf ( "User cache length should be 0, not %d" , cacheLength ( ucache ) ) )
2017-11-11 04:06:16 +00:00
expectIntToBeX ( t , common . Users . GlobalCount ( ) , 1 , "The number of users should be one, not %d" )
2017-09-03 04:50:31 +00:00
2017-10-16 07:32:58 +00:00
var awaitingActivation = 5
2017-11-11 04:06:16 +00:00
uid , err := common . Users . Create ( "Sam" , "ReallyBadPassword" , "sam@localhost.loc" , awaitingActivation , false )
2017-10-21 00:27:47 +00:00
expectNilErr ( t , err )
expect ( t , uid == newUserID , fmt . Sprintf ( "The UID of the new user should be %d" , newUserID ) )
2017-11-11 04:06:16 +00:00
expect ( t , common . Users . Exists ( newUserID ) , fmt . Sprintf ( "UID #%d should exist" , newUserID ) )
2017-09-03 04:50:31 +00:00
2017-11-11 04:06:16 +00:00
user , err = common . Users . Get ( newUserID )
2017-10-21 00:27:47 +00:00
recordMustExist ( t , err , "Couldn't find UID #%d" , newUserID )
2017-11-23 05:37:08 +00:00
expect ( t , user . ID == newUserID , fmt . Sprintf ( "The UID of the user record should be %d" , newUserID ) )
2017-10-21 00:27:47 +00:00
expect ( t , user . Name == "Sam" , "The user should be named Sam" )
expect ( t , ! user . IsSuperAdmin , "Sam should not be a super admin" )
expect ( t , ! user . IsAdmin , "Sam should not be an admin" )
expect ( t , ! user . IsSuperMod , "Sam should not be a super mod" )
expect ( t , ! user . IsMod , "Sam should not be a mod" )
expect ( t , ! user . IsBanned , "Sam should not be banned" )
2017-10-16 07:32:58 +00:00
expectIntToBeX ( t , user . Group , 5 , "Sam should be in group 5" )
2017-09-15 22:20:01 +00:00
2017-11-23 05:37:08 +00:00
if ucache != nil {
2017-10-16 07:32:58 +00:00
expectIntToBeX ( t , ucache . Length ( ) , 1 , "User cache length should be 1, not %d" )
2017-11-23 05:37:08 +00:00
user , err = ucache . Get ( newUserID )
2017-10-21 00:27:47 +00:00
recordMustExist ( t , err , "Couldn't find UID #%d in the cache" , newUserID )
expect ( t , user . ID == newUserID , fmt . Sprintf ( "user.ID does not match the requested UID. Got '%d' instead." , user . ID ) )
2017-09-18 17:03:52 +00:00
}
2017-10-16 07:32:58 +00:00
err = user . Activate ( )
2017-10-21 00:27:47 +00:00
expectNilErr ( t , err )
2017-10-16 07:32:58 +00:00
expectIntToBeX ( t , user . Group , 5 , "Sam should still be in group 5 in this copy" )
// ? - What if we change the caching mechanism so it isn't hard purged and reloaded? We'll deal with that when we come to it, but for now, this is a sign of a cache bug
2017-11-23 05:37:08 +00:00
if ucache != nil {
2017-10-16 07:32:58 +00:00
expectIntToBeX ( t , ucache . Length ( ) , 0 , "User cache length should be 0, not %d" )
2017-11-23 05:37:08 +00:00
_ , err = ucache . Get ( newUserID )
2017-10-21 00:27:47 +00:00
recordMustNotExist ( t , err , "UID #%d shouldn't be in the cache" , newUserID )
2017-10-16 07:32:58 +00:00
}
2017-11-11 04:06:16 +00:00
user , err = common . Users . Get ( newUserID )
2017-10-21 00:27:47 +00:00
recordMustExist ( t , err , "Couldn't find UID #%d" , newUserID )
expect ( t , user . ID == newUserID , fmt . Sprintf ( "The UID of the user record should be %d, not %d" , newUserID , user . ID ) )
expect ( t , ! user . IsSuperAdmin , "Sam should not be a super admin" )
expect ( t , ! user . IsAdmin , "Sam should not be an admin" )
expect ( t , ! user . IsSuperMod , "Sam should not be a super mod" )
expect ( t , ! user . IsMod , "Sam should not be a mod" )
expect ( t , ! user . IsBanned , "Sam should not be banned" )
2017-11-11 08:46:30 +00:00
expect ( t , user . Group == common . Config . DefaultGroup , fmt . Sprintf ( "Sam should be in group %d, not %d" , common . Config . DefaultGroup , user . Group ) )
2017-10-16 07:32:58 +00:00
// Permanent ban
duration , _ := time . ParseDuration ( "0" )
// TODO: Attempt a double ban, double activation, and double unban
err = user . Ban ( duration , 1 )
2017-10-21 00:27:47 +00:00
expectNilErr ( t , err )
2017-11-11 08:46:30 +00:00
expect ( t , user . Group == common . Config . DefaultGroup , fmt . Sprintf ( "Sam should be in group %d, not %d" , common . Config . DefaultGroup , user . Group ) )
2017-10-16 07:32:58 +00:00
2017-11-23 05:37:08 +00:00
if ucache != nil {
2017-10-16 07:32:58 +00:00
expectIntToBeX ( t , ucache . Length ( ) , 0 , "User cache length should be 0, not %d" )
2017-11-23 05:37:08 +00:00
_ , err = ucache . Get ( 2 )
2017-10-21 00:27:47 +00:00
recordMustNotExist ( t , err , "UID #%d shouldn't be in the cache" , newUserID )
2017-10-16 07:32:58 +00:00
}
2017-11-11 04:06:16 +00:00
user , err = common . Users . Get ( newUserID )
2017-10-21 00:27:47 +00:00
recordMustExist ( t , err , "Couldn't find UID #%d" , newUserID )
2017-11-23 05:37:08 +00:00
expect ( t , user . ID == newUserID , fmt . Sprintf ( "The UID of the user record should be %d" , newUserID ) )
2017-10-21 00:27:47 +00:00
expect ( t , ! user . IsSuperAdmin , "Sam should not be a super admin" )
expect ( t , ! user . IsAdmin , "Sam should not be an admin" )
expect ( t , ! user . IsSuperMod , "Sam should not be a super mod" )
expect ( t , ! user . IsMod , "Sam should not be a mod" )
expect ( t , user . IsBanned , "Sam should be banned" )
2017-11-11 08:46:30 +00:00
expectIntToBeX ( t , user . Group , common . BanGroup , "Sam should be in group %d" )
2017-10-16 07:32:58 +00:00
// TODO: Do tests against the scheduled updates table and the task system to make sure the ban exists there and gets revoked when it should
err = user . Unban ( )
2017-10-21 00:27:47 +00:00
expectNilErr ( t , err )
2017-11-11 08:46:30 +00:00
expectIntToBeX ( t , user . Group , common . BanGroup , "Sam should still be in the ban group in this copy" )
2017-10-16 07:32:58 +00:00
2017-11-23 05:37:08 +00:00
if ucache != nil {
2017-10-16 07:32:58 +00:00
expectIntToBeX ( t , ucache . Length ( ) , 0 , "User cache length should be 0, not %d" )
2017-11-23 05:37:08 +00:00
_ , err = ucache . Get ( newUserID )
2017-10-21 00:27:47 +00:00
recordMustNotExist ( t , err , "UID #%d shouldn't be in the cache" , newUserID )
2017-10-16 07:32:58 +00:00
}
2017-11-11 04:06:16 +00:00
user , err = common . Users . Get ( newUserID )
2017-10-21 00:27:47 +00:00
recordMustExist ( t , err , "Couldn't find UID #%d" , newUserID )
expectIntToBeX ( t , user . ID , newUserID , "The UID of the user record should be %d" )
expect ( t , ! user . IsSuperAdmin , "Sam should not be a super admin" )
expect ( t , ! user . IsAdmin , "Sam should not be an admin" )
expect ( t , ! user . IsSuperMod , "Sam should not be a super mod" )
expect ( t , ! user . IsMod , "Sam should not be a mod" )
expect ( t , ! user . IsBanned , "Sam should not be banned" )
2017-11-11 08:46:30 +00:00
expectIntToBeX ( t , user . Group , common . Config . DefaultGroup , "Sam should be back in group %d" )
2017-10-21 00:27:47 +00:00
2018-06-06 00:21:22 +00:00
var reportsForumID = 1 // TODO: Use the constant in common?
2017-10-21 00:27:47 +00:00
var generalForumID = 2
dummyResponseRecorder := httptest . NewRecorder ( )
bytesBuffer := bytes . NewBuffer ( [ ] byte ( "" ) )
2018-06-06 00:21:22 +00:00
dummyRequest1 := httptest . NewRequest ( "" , "/forum/" + strconv . Itoa ( reportsForumID ) , bytesBuffer )
dummyRequest2 := httptest . NewRequest ( "" , "/forum/" + strconv . Itoa ( generalForumID ) , bytesBuffer )
2017-10-21 00:27:47 +00:00
err = user . ChangeGroup ( 1 )
expectNilErr ( t , err )
2017-11-11 08:46:30 +00:00
expect ( t , user . Group == common . Config . DefaultGroup , "Someone's mutated this pointer elsewhere" )
2017-10-21 00:27:47 +00:00
2017-11-11 04:06:16 +00:00
user , err = common . Users . Get ( newUserID )
2017-10-21 00:27:47 +00:00
recordMustExist ( t , err , "Couldn't find UID #%d" , newUserID )
expectIntToBeX ( t , user . ID , newUserID , "The UID of the user record should be %d" )
2017-11-11 08:46:30 +00:00
var user2 * common . User = common . BlankUser ( )
2017-10-21 00:27:47 +00:00
* user2 = * user
expect ( t , ! user . IsSuperAdmin , "Sam should not be a super admin" )
expect ( t , user . IsAdmin , "Sam should be an admin" )
expect ( t , user . IsSuperMod , "Sam should be a super mod" )
expect ( t , user . IsMod , "Sam should be a mod" )
expect ( t , ! user . IsBanned , "Sam should not be banned" )
2017-11-11 08:46:30 +00:00
_ , ferr := common . ForumUserCheck ( dummyResponseRecorder , dummyRequest1 , user , reportsForumID )
2017-10-30 09:57:08 +00:00
expect ( t , ferr == nil , "There shouldn't be any errors in forumUserCheck" )
2017-10-21 00:27:47 +00:00
expect ( t , user . Perms . ViewTopic , "Admins should be able to access the reports forum" )
2017-11-11 08:46:30 +00:00
_ , ferr = common . ForumUserCheck ( dummyResponseRecorder , dummyRequest2 , user2 , generalForumID )
2017-10-30 09:57:08 +00:00
expect ( t , ferr == nil , "There shouldn't be any errors in forumUserCheck" )
2017-10-21 00:27:47 +00:00
expect ( t , user2 . Perms . ViewTopic , "Sam should be able to access the general forum" )
err = user . ChangeGroup ( 2 )
expectNilErr ( t , err )
expect ( t , user . Group == 1 , "Someone's mutated this pointer elsewhere" )
2017-11-11 04:06:16 +00:00
user , err = common . Users . Get ( newUserID )
2017-10-21 00:27:47 +00:00
recordMustExist ( t , err , "Couldn't find UID #%d" , newUserID )
expectIntToBeX ( t , user . ID , newUserID , "The UID of the user record should be %d" )
2017-11-11 08:46:30 +00:00
user2 = common . BlankUser ( )
2017-10-21 00:27:47 +00:00
* user2 = * user
expect ( t , ! user . IsSuperAdmin , "Sam should not be a super admin" )
expect ( t , ! user . IsAdmin , "Sam should not be an admin" )
expect ( t , user . IsSuperMod , "Sam should be a super mod" )
expect ( t , user . IsMod , "Sam should be a mod" )
expect ( t , ! user . IsBanned , "Sam should not be banned" )
2017-11-11 08:46:30 +00:00
_ , ferr = common . ForumUserCheck ( dummyResponseRecorder , dummyRequest1 , user , reportsForumID )
2017-10-30 09:57:08 +00:00
expect ( t , ferr == nil , "There shouldn't be any errors in forumUserCheck" )
2017-10-21 00:27:47 +00:00
expect ( t , user . Perms . ViewTopic , "Mods should be able to access the reports forum" )
2017-11-11 08:46:30 +00:00
_ , ferr = common . ForumUserCheck ( dummyResponseRecorder , dummyRequest2 , user2 , generalForumID )
2017-10-30 09:57:08 +00:00
expect ( t , ferr == nil , "There shouldn't be any errors in forumUserCheck" )
2017-10-21 00:27:47 +00:00
expect ( t , user2 . Perms . ViewTopic , "Sam should be able to access the general forum" )
err = user . ChangeGroup ( 3 )
expectNilErr ( t , err )
expect ( t , user . Group == 2 , "Someone's mutated this pointer elsewhere" )
2017-11-11 04:06:16 +00:00
user , err = common . Users . Get ( newUserID )
2017-10-21 00:27:47 +00:00
recordMustExist ( t , err , "Couldn't find UID #%d" , newUserID )
expectIntToBeX ( t , user . ID , newUserID , "The UID of the user record should be %d" )
2017-11-11 08:46:30 +00:00
user2 = common . BlankUser ( )
2017-10-21 00:27:47 +00:00
* user2 = * user
expect ( t , ! user . IsSuperAdmin , "Sam should not be a super admin" )
expect ( t , ! user . IsAdmin , "Sam should not be an admin" )
expect ( t , ! user . IsSuperMod , "Sam should not be a super mod" )
expect ( t , ! user . IsMod , "Sam should not be a mod" )
expect ( t , ! user . IsBanned , "Sam should not be banned" )
2017-11-11 08:46:30 +00:00
_ , ferr = common . ForumUserCheck ( dummyResponseRecorder , dummyRequest1 , user , reportsForumID )
2017-10-30 09:57:08 +00:00
expect ( t , ferr == nil , "There shouldn't be any errors in forumUserCheck" )
2017-10-21 00:27:47 +00:00
expect ( t , ! user . Perms . ViewTopic , "Members shouldn't be able to access the reports forum" )
2017-11-11 08:46:30 +00:00
_ , ferr = common . ForumUserCheck ( dummyResponseRecorder , dummyRequest2 , user2 , generalForumID )
2017-10-30 09:57:08 +00:00
expect ( t , ferr == nil , "There shouldn't be any errors in forumUserCheck" )
2017-10-21 00:27:47 +00:00
expect ( t , user2 . Perms . ViewTopic , "Sam should be able to access the general forum" )
expect ( t , user . Perms . ViewTopic != user2 . Perms . ViewTopic , "user.Perms.ViewTopic and user2.Perms.ViewTopic should never match" )
err = user . ChangeGroup ( 4 )
expectNilErr ( t , err )
expect ( t , user . Group == 3 , "Someone's mutated this pointer elsewhere" )
2017-11-11 04:06:16 +00:00
user , err = common . Users . Get ( newUserID )
2017-10-21 00:27:47 +00:00
recordMustExist ( t , err , "Couldn't find UID #%d" , newUserID )
expectIntToBeX ( t , user . ID , newUserID , "The UID of the user record should be %d" )
2017-11-11 08:46:30 +00:00
user2 = common . BlankUser ( )
2017-10-21 00:27:47 +00:00
* user2 = * user
expect ( t , ! user . IsSuperAdmin , "Sam should not be a super admin" )
expect ( t , ! user . IsAdmin , "Sam should not be an admin" )
expect ( t , ! user . IsSuperMod , "Sam should not be a super mod" )
expect ( t , ! user . IsMod , "Sam should not be a mod" )
expect ( t , user . IsBanned , "Sam should be banned" )
2017-11-11 08:46:30 +00:00
_ , ferr = common . ForumUserCheck ( dummyResponseRecorder , dummyRequest1 , user , reportsForumID )
2017-10-30 09:57:08 +00:00
expect ( t , ferr == nil , "There shouldn't be any errors in forumUserCheck" )
2017-10-21 00:27:47 +00:00
expect ( t , ! user . Perms . ViewTopic , "Members shouldn't be able to access the reports forum" )
2017-11-11 08:46:30 +00:00
_ , ferr = common . ForumUserCheck ( dummyResponseRecorder , dummyRequest2 , user2 , generalForumID )
2017-10-30 09:57:08 +00:00
expect ( t , ferr == nil , "There shouldn't be any errors in forumUserCheck" )
2017-10-21 00:27:47 +00:00
expect ( t , user2 . Perms . ViewTopic , "Sam should be able to access the general forum" )
err = user . ChangeGroup ( 5 )
expectNilErr ( t , err )
expect ( t , user . Group == 4 , "Someone's mutated this pointer elsewhere" )
2017-11-11 04:06:16 +00:00
user , err = common . Users . Get ( newUserID )
2017-10-21 00:27:47 +00:00
recordMustExist ( t , err , "Couldn't find UID #%d" , newUserID )
expectIntToBeX ( t , user . ID , newUserID , "The UID of the user record should be %d" )
2017-11-11 08:46:30 +00:00
user2 = common . BlankUser ( )
2017-10-21 00:27:47 +00:00
* user2 = * user
expect ( t , ! user . IsSuperAdmin , "Sam should not be a super admin" )
expect ( t , ! user . IsAdmin , "Sam should not be an admin" )
expect ( t , ! user . IsSuperMod , "Sam should not be a super mod" )
expect ( t , ! user . IsMod , "Sam should not be a mod" )
expect ( t , ! user . IsBanned , "Sam should not be banned" )
2017-11-11 08:46:30 +00:00
_ , ferr = common . ForumUserCheck ( dummyResponseRecorder , dummyRequest1 , user , reportsForumID )
2017-10-30 09:57:08 +00:00
expect ( t , ferr == nil , "There shouldn't be any errors in forumUserCheck" )
2017-10-21 00:27:47 +00:00
expect ( t , ! user . Perms . ViewTopic , "Members shouldn't be able to access the reports forum" )
2017-11-11 08:46:30 +00:00
_ , ferr = common . ForumUserCheck ( dummyResponseRecorder , dummyRequest2 , user2 , generalForumID )
2017-10-30 09:57:08 +00:00
expect ( t , ferr == nil , "There shouldn't be any errors in forumUserCheck" )
2017-10-21 00:27:47 +00:00
expect ( t , user2 . Perms . ViewTopic , "Sam should be able to access the general forum" )
err = user . ChangeGroup ( 6 )
expectNilErr ( t , err )
expect ( t , user . Group == 5 , "Someone's mutated this pointer elsewhere" )
2017-11-11 04:06:16 +00:00
user , err = common . Users . Get ( newUserID )
2017-10-21 00:27:47 +00:00
recordMustExist ( t , err , "Couldn't find UID #%d" , newUserID )
expectIntToBeX ( t , user . ID , newUserID , "The UID of the user record should be %d" )
2017-11-11 08:46:30 +00:00
user2 = common . BlankUser ( )
2017-10-21 00:27:47 +00:00
* user2 = * user
expect ( t , ! user . IsSuperAdmin , "Sam should not be a super admin" )
expect ( t , ! user . IsAdmin , "Sam should not be an admin" )
expect ( t , ! user . IsSuperMod , "Sam should not be a super mod" )
expect ( t , ! user . IsMod , "Sam should not be a mod" )
expect ( t , ! user . IsBanned , "Sam should not be banned" )
2017-11-11 08:46:30 +00:00
_ , ferr = common . ForumUserCheck ( dummyResponseRecorder , dummyRequest1 , user , reportsForumID )
2017-10-30 09:57:08 +00:00
expect ( t , ferr == nil , "There shouldn't be any errors in forumUserCheck" )
2017-10-21 00:27:47 +00:00
expect ( t , ! user . Perms . ViewTopic , "Members shouldn't be able to access the reports forum" )
2017-11-11 08:46:30 +00:00
_ , ferr = common . ForumUserCheck ( dummyResponseRecorder , dummyRequest2 , user2 , generalForumID )
2017-10-30 09:57:08 +00:00
expect ( t , ferr == nil , "There shouldn't be any errors in forumUserCheck" )
2017-10-21 00:27:47 +00:00
expect ( t , user2 . Perms . ViewTopic , "Sam should be able to access the general forum" )
2017-11-11 08:46:30 +00:00
err = user . ChangeGroup ( common . Config . DefaultGroup )
2017-10-21 00:27:47 +00:00
expectNilErr ( t , err )
expect ( t , user . Group == 6 , "Someone's mutated this pointer elsewhere" )
2017-10-16 07:32:58 +00:00
err = user . Delete ( )
2017-10-21 00:27:47 +00:00
expectNilErr ( t , err )
2017-11-11 08:46:30 +00:00
expect ( t , ! common . Users . Exists ( newUserID ) , fmt . Sprintf ( "UID #%d should no longer exist" , newUserID ) )
2017-10-16 07:32:58 +00:00
2017-11-23 05:37:08 +00:00
if ucache != nil {
2017-10-16 07:32:58 +00:00
expectIntToBeX ( t , ucache . Length ( ) , 0 , "User cache length should be 0, not %d" )
2017-11-23 05:37:08 +00:00
_ , err = ucache . Get ( newUserID )
2017-10-21 00:27:47 +00:00
recordMustNotExist ( t , err , "UID #%d shouldn't be in the cache" , newUserID )
2017-10-16 07:32:58 +00:00
}
2017-11-11 04:06:16 +00:00
_ , err = common . Users . Get ( newUserID )
2017-10-21 00:27:47 +00:00
recordMustNotExist ( t , err , "UID #%d shouldn't exist" , newUserID )
2017-11-05 01:04:57 +00:00
// TODO: Add tests for the Cache* methods
2017-10-21 00:27:47 +00:00
}
// TODO: Add an error message to this?
func expectNilErr ( t * testing . T , item error ) {
if item != nil {
debug . PrintStack ( )
t . Fatal ( item )
}
2017-10-16 07:32:58 +00:00
}
func expectIntToBeX ( t * testing . T , item int , expect int , errmsg string ) {
if item != expect {
debug . PrintStack ( )
t . Fatalf ( errmsg , item )
}
}
func expect ( t * testing . T , item bool , errmsg string ) {
if ! item {
debug . PrintStack ( )
2017-10-21 00:27:47 +00:00
t . Fatal ( errmsg )
2017-09-15 22:20:01 +00:00
}
}
2017-11-05 01:04:57 +00:00
func TestPermsMiddleware ( t * testing . T ) {
if ! gloinited {
err := gloinit ( )
if err != nil {
t . Fatal ( err )
}
}
2017-11-11 08:46:30 +00:00
if ! common . PluginsInited {
common . InitPlugins ( )
2017-11-05 01:04:57 +00:00
}
dummyResponseRecorder := httptest . NewRecorder ( )
bytesBuffer := bytes . NewBuffer ( [ ] byte ( "" ) )
dummyRequest := httptest . NewRequest ( "" , "/forum/1" , bytesBuffer )
2017-11-11 08:46:30 +00:00
user := common . BlankUser ( )
2017-11-05 01:04:57 +00:00
2017-11-11 08:46:30 +00:00
ferr := common . SuperModOnly ( dummyResponseRecorder , dummyRequest , * user )
2017-11-05 01:04:57 +00:00
expect ( t , ferr != nil , "Blank users shouldn't be supermods" )
user . IsSuperMod = false
2017-11-11 08:46:30 +00:00
ferr = common . SuperModOnly ( dummyResponseRecorder , dummyRequest , * user )
2017-11-05 01:04:57 +00:00
expect ( t , ferr != nil , "Non-supermods shouldn't be allowed through supermod gates" )
user . IsSuperMod = true
2017-11-11 08:46:30 +00:00
ferr = common . SuperModOnly ( dummyResponseRecorder , dummyRequest , * user )
2017-11-05 01:04:57 +00:00
expect ( t , ferr == nil , "Supermods should be allowed through supermod gates" )
// TODO: Loop over the Control Panel routes and make sure only supermods can get in
2017-11-05 09:55:34 +00:00
2017-11-11 08:46:30 +00:00
user = common . BlankUser ( )
2017-11-05 09:55:34 +00:00
2017-11-11 08:46:30 +00:00
ferr = common . MemberOnly ( dummyResponseRecorder , dummyRequest , * user )
2017-11-05 09:55:34 +00:00
expect ( t , ferr != nil , "Blank users shouldn't be considered loggedin" )
user . Loggedin = false
2017-11-11 08:46:30 +00:00
ferr = common . MemberOnly ( dummyResponseRecorder , dummyRequest , * user )
2017-11-05 09:55:34 +00:00
expect ( t , ferr != nil , "Guests shouldn't be able to access member areas" )
user . Loggedin = true
2017-11-11 08:46:30 +00:00
ferr = common . MemberOnly ( dummyResponseRecorder , dummyRequest , * user )
2017-11-05 09:55:34 +00:00
expect ( t , ferr == nil , "Logged in users should be able to access member areas" )
// TODO: Loop over the /user/ routes and make sure only members can access the ones other than /user/username
2017-12-19 03:53:13 +00:00
// TODO: Write tests for AdminOnly()
user = common . BlankUser ( )
ferr = common . SuperAdminOnly ( dummyResponseRecorder , dummyRequest , * user )
expect ( t , ferr != nil , "Blank users shouldn't be considered super admins" )
user . IsSuperAdmin = false
ferr = common . SuperAdminOnly ( dummyResponseRecorder , dummyRequest , * user )
expect ( t , ferr != nil , "Non-super admins shouldn't be allowed through the super admin gate" )
user . IsSuperAdmin = true
ferr = common . SuperAdminOnly ( dummyResponseRecorder , dummyRequest , * user )
expect ( t , ferr == nil , "Super admins should be allowed through super admin gates" )
// TODO: Make sure only super admins can access the backups route
//dummyResponseRecorder = httptest.NewRecorder()
//bytesBuffer = bytes.NewBuffer([]byte(""))
//dummyRequest = httptest.NewRequest("", "/panel/backups/", bytesBuffer)
2017-11-05 01:04:57 +00:00
}
2017-09-15 22:20:01 +00:00
func TestTopicStore ( t * testing . T ) {
if ! gloinited {
err := gloinit ( )
if err != nil {
t . Fatal ( err )
}
}
2017-11-11 08:46:30 +00:00
if ! common . PluginsInited {
common . InitPlugins ( )
2017-09-15 22:20:01 +00:00
}
2017-11-02 13:35:19 +00:00
var err error
2017-11-23 05:37:08 +00:00
tcache := common . NewMemoryTopicCache ( common . Config . TopicCacheCapacity )
common . Topics , err = common . NewDefaultTopicStore ( tcache )
2017-11-02 13:35:19 +00:00
expectNilErr ( t , err )
2017-09-15 22:20:01 +00:00
topicStoreTest ( t )
2017-11-23 05:37:08 +00:00
common . Topics , err = common . NewDefaultTopicStore ( nil )
2017-11-02 13:35:19 +00:00
expectNilErr ( t , err )
2017-09-15 22:20:01 +00:00
topicStoreTest ( t )
}
func topicStoreTest ( t * testing . T ) {
2017-11-11 08:46:30 +00:00
var topic * common . Topic
2017-09-15 22:20:01 +00:00
var err error
2017-11-11 04:06:16 +00:00
_ , err = common . Topics . Get ( - 1 )
2017-10-21 00:27:47 +00:00
recordMustNotExist ( t , err , "TID #-1 shouldn't exist" )
2017-09-15 22:20:01 +00:00
2017-11-11 04:06:16 +00:00
_ , err = common . Topics . Get ( 0 )
2017-10-21 00:27:47 +00:00
recordMustNotExist ( t , err , "TID #0 shouldn't exist" )
2017-09-15 22:20:01 +00:00
2017-11-11 04:06:16 +00:00
topic , err = common . Topics . Get ( 1 )
2017-10-16 07:32:58 +00:00
recordMustExist ( t , err , "Couldn't find TID #1" )
2017-09-03 04:50:31 +00:00
2017-09-15 22:20:01 +00:00
if topic . ID != 1 {
2018-04-23 21:08:31 +00:00
t . Errorf ( "topic.ID does not match the requested TID. Got '%d' instead." , topic . ID )
2017-09-03 04:50:31 +00:00
}
2017-09-15 22:20:01 +00:00
// TODO: Add BulkGetMap() to the TopicStore
2017-11-11 04:06:16 +00:00
ok := common . Topics . Exists ( - 1 )
2017-11-23 05:37:08 +00:00
expect ( t , ! ok , "TID #-1 shouldn't exist" )
2017-09-15 22:20:01 +00:00
2017-11-11 04:06:16 +00:00
ok = common . Topics . Exists ( 0 )
2017-11-23 05:37:08 +00:00
expect ( t , ! ok , "TID #0 shouldn't exist" )
2017-09-15 22:20:01 +00:00
2017-11-11 04:06:16 +00:00
ok = common . Topics . Exists ( 1 )
2017-11-23 05:37:08 +00:00
expect ( t , ok , "TID #1 should exist" )
2017-09-03 04:50:31 +00:00
2017-11-11 04:06:16 +00:00
count := common . Topics . GlobalCount ( )
2017-09-15 22:20:01 +00:00
if count <= 0 {
t . Error ( "The number of topics should be bigger than zero" )
t . Error ( "count" , count )
Added the Social Groups plugin. This is still under construction.
Made a few improvements to the ForumStore, including bringing it's API closer in line with the other datastores, adding stubs for future subforum functionality, and improving efficiency in a few places.
The auth interface now handles all the authentication stuff.
Renamed the debug config variable to debug_mode.
Added the PluginPerms API.
Internal Errors will now dump the stack trace in the console.
Added support for installable plugins.
Refactored the routing logic so that the router now handles the common PreRoute logic(exc. /static/)
Added the CreateTable method to the query generator. It might need some tweaking to better support other database systems.
Added the same CreateTable method to the query builder.
Began work on PostgreSQL support.
Added the string-string hook type
Added the pre_render hook type.
Added the ParentID and ParentType fields to forums.
Added the get_forum_url_prefix function.
Added a more generic build_slug function.
Added the get_topic_url_prefix function.
Added the override_perms and override_forum_perms functions for bulk setting and unsetting permissions.
Added more ExtData fields in a few structs and removed them on the Perms struct as the PluginPerms API supersedes them there.
Plugins can now see the router instance.
The plugin initialisation handlers can now throw errors.
Plugins are now initialised after all the forum's subsystems are.
Refactored the unit test logic. For instance, we now use the proper .Log method rather than fmt.Println in many cases.
Sorry, we'll have to break Github's generated file detection, as the build instructions aren't working, unless I put them at the top, and they're far, far more important than getting Github to recognise the generated code as generated code.
Fixed an issue with mysql.go's _init_database() overwriting the dbpassword variable. Not a huge issue, but it is a "gotcha" for those not expecting a ':' at the start.
Fixed an issue with forum creation where the forum permissions didn't get cached.
Fixed a bug in plugin_bbcode where negative numbers in rand would crash Gosora.
Made the outputs of plugin_markdown and plugin_bbcode more compliant with the tests.
Revamped the phrase system to make it easier for us to add language pack related features in the future.
Added the WidgetMenu widget type.
Revamped the theme again. I'm experimenting to see which approach I like most.
- Excuse the little W3C rage. Some things about CSS drive me crazy :p
Tests:
Added 22 bbcode_full_parse tests.
Added 19 bbcode_regex_parse tests.
Added 27 markdown_parse tests.
Added four UserStore tests. More to come when the test database functionality is added.
Added 18 name_to_slug tests.
Hooks:
Added the pre_render hook.
Added the pre_render_forum_list hook.
Added the pre_render_view_forum hook.
Added the pre_render_topic_list hook.
Added the pre_render_view_topic hook.
Added the pre_render_profile hook.
Added the pre_render_custom_page hook.
Added the pre_render_overview hook.
Added the pre_render_create_topic hook.
Added the pre_render_account_own_edit_critical hook.
Added the pre_render_account_own_edit_avatar hook.
Added the pre_render_account_own_edit_username hook.
Added the pre_render_account_own_edit_email hook.
Added the pre_render_login hook.
Added the pre_render_register hook.
Added the pre_render_ban hook.
Added the pre_render_panel_dashboard hook.
Added the pre_render_panel_forums hook.
Added the pre_render_panel_delete_forum hook.
Added the pre_render_panel_edit_forum hook.
Added the pre_render_panel_settings hook.
Added the pre_render_panel_setting hook.
Added the pre_render_panel_plugins hook.
Added the pre_render_panel_users hook.
Added the pre_render_panel_edit_user hook.
Added the pre_render_panel_groups hook.
Added the pre_render_panel_edit_group hook.
Added the pre_render_panel_edit_group_perms hook.
Added the pre_render_panel_themes hook.
Added the pre_render_panel_mod_log hook.
Added the pre_render_error hook.
Added the pre_render_security_error hook.
Added the create_group_preappend hook.
Added the intercept_build_widgets hook.
Added the simple_forum_check_pre_perms hook.
Added the forum_check_pre_perms hook.
2017-07-09 12:06:04 +00:00
}
2017-11-06 16:24:45 +00:00
// TODO: Test topic creation and retrieving that created topic plus reload and inspecting the cache
2017-07-12 11:05:18 +00:00
}
func TestForumStore ( t * testing . T ) {
2017-09-03 04:50:31 +00:00
if ! gloinited {
2017-07-12 11:05:18 +00:00
gloinit ( )
}
2017-11-11 08:46:30 +00:00
if ! common . PluginsInited {
common . InitPlugins ( )
2017-09-03 04:50:31 +00:00
}
2017-11-23 05:37:08 +00:00
_ , err := common . Forums . Get ( - 1 )
2017-10-21 00:27:47 +00:00
recordMustNotExist ( t , err , "FID #-1 shouldn't exist" )
2017-09-03 04:50:31 +00:00
2017-11-23 05:37:08 +00:00
_ , err = common . Forums . Get ( 0 )
2017-10-21 00:27:47 +00:00
recordMustNotExist ( t , err , "FID #0 shouldn't exist" )
2017-09-03 04:50:31 +00:00
2017-11-23 05:37:08 +00:00
forum , err := common . Forums . Get ( 1 )
2017-10-16 07:32:58 +00:00
recordMustExist ( t , err , "Couldn't find FID #1" )
2017-09-03 04:50:31 +00:00
if forum . ID != 1 {
2018-04-23 21:08:31 +00:00
t . Errorf ( "forum.ID doesn't not match the requested FID. Got '%d' instead.'" , forum . ID )
2017-09-03 04:50:31 +00:00
}
2017-11-05 01:04:57 +00:00
// TODO: Check the preset and forum permissions
expect ( t , forum . Name == "Reports" , fmt . Sprintf ( "FID #0 is named '%s' and not 'Reports'" , forum . Name ) )
expect ( t , ! forum . Active , fmt . Sprintf ( "The reports forum shouldn't be active" ) )
var expectDesc = "All the reports go here"
expect ( t , forum . Desc == expectDesc , fmt . Sprintf ( "The forum description should be '%s' not '%s'" , expectDesc , forum . Desc ) )
2017-09-03 04:50:31 +00:00
2017-11-23 05:37:08 +00:00
forum , err = common . Forums . Get ( 2 )
2017-10-16 07:32:58 +00:00
recordMustExist ( t , err , "Couldn't find FID #1" )
2017-09-10 16:57:22 +00:00
2017-11-05 01:04:57 +00:00
expect ( t , forum . ID == 2 , fmt . Sprintf ( "The FID should be 2 not %d" , forum . ID ) )
expect ( t , forum . Name == "General" , fmt . Sprintf ( "The name of the forum should be 'General' not '%s'" , forum . Name ) )
expect ( t , forum . Active , fmt . Sprintf ( "The general forum should be active" ) )
expectDesc = "A place for general discussions which don't fit elsewhere"
expect ( t , forum . Desc == expectDesc , fmt . Sprintf ( "The forum description should be '%s' not '%s'" , expectDesc , forum . Desc ) )
2017-09-15 22:20:01 +00:00
2017-11-23 05:37:08 +00:00
ok := common . Forums . Exists ( - 1 )
2017-11-05 01:04:57 +00:00
expect ( t , ! ok , "FID #-1 shouldn't exist" )
2017-11-23 05:37:08 +00:00
ok = common . Forums . Exists ( 0 )
2017-11-05 01:04:57 +00:00
expect ( t , ! ok , "FID #0 shouldn't exist" )
2017-11-23 05:37:08 +00:00
ok = common . Forums . Exists ( 1 )
2017-11-05 01:04:57 +00:00
expect ( t , ok , "FID #1 should exist" )
2017-12-25 06:12:19 +00:00
ok = common . Forums . Exists ( 2 )
expect ( t , ok , "FID #2 should exist" )
ok = common . Forums . Exists ( 3 )
expect ( t , ! ok , "FID #3 shouldn't exist" )
2017-11-05 01:04:57 +00:00
2017-12-25 06:12:19 +00:00
fid , err := common . Forums . Create ( "Test Forum" , "" , true , "all" )
expectNilErr ( t , err )
expect ( t , fid == 3 , "The first forum we create should have an ID of 3" )
ok = common . Forums . Exists ( 3 )
expect ( t , ok , "FID #2 should exist" )
forum , err = common . Forums . Get ( 3 )
recordMustExist ( t , err , "Couldn't find FID #3" )
2018-06-06 06:13:55 +00:00
expect ( t , forum . ID == 3 , fmt . Sprintf ( "The FID should be 3 not %d" , forum . ID ) )
2017-12-25 06:12:19 +00:00
expect ( t , forum . Name == "Test Forum" , fmt . Sprintf ( "The name of the forum should be 'Test Forum' not '%s'" , forum . Name ) )
expect ( t , forum . Active , fmt . Sprintf ( "The test forum should be active" ) )
2018-04-23 21:08:31 +00:00
expect ( t , forum . Desc == "" , fmt . Sprintf ( "The forum description should be blank not '%s'" , forum . Desc ) )
2017-12-25 06:12:19 +00:00
// TODO: More forum creation tests
2017-11-05 01:04:57 +00:00
// TODO: Test forum deletion
// TODO: Test forum update
}
// TODO: Implement this
func TestForumPermsStore ( t * testing . T ) {
if ! gloinited {
gloinit ( )
}
2017-11-13 05:22:37 +00:00
if ! common . PluginsInited {
common . InitPlugins ( )
2017-09-15 22:20:01 +00:00
}
}
2017-11-05 01:04:57 +00:00
// TODO: Test the group permissions
2017-09-15 22:20:01 +00:00
func TestGroupStore ( t * testing . T ) {
if ! gloinited {
gloinit ( )
}
2017-11-13 05:22:37 +00:00
if ! common . PluginsInited {
common . InitPlugins ( )
2017-09-15 22:20:01 +00:00
}
2017-11-23 05:37:08 +00:00
_ , err := common . Groups . Get ( - 1 )
2017-10-21 00:27:47 +00:00
recordMustNotExist ( t , err , "GID #-1 shouldn't exist" )
2017-09-15 22:20:01 +00:00
2017-10-16 07:32:58 +00:00
// TODO: Refactor the group store to remove GID #0
2017-11-23 05:37:08 +00:00
group , err := common . Groups . Get ( 0 )
2017-10-16 07:32:58 +00:00
recordMustExist ( t , err , "Couldn't find GID #0" )
2017-09-15 22:20:01 +00:00
2017-11-23 05:37:08 +00:00
expect ( t , group . ID == 0 , fmt . Sprintf ( "group.ID doesn't not match the requested GID. Got '%d' instead." , group . ID ) )
2017-10-21 00:27:47 +00:00
expect ( t , group . Name == "Unknown" , fmt . Sprintf ( "GID #0 is named '%s' and not 'Unknown'" , group . Name ) )
2017-09-15 22:20:01 +00:00
2017-11-23 05:37:08 +00:00
group , err = common . Groups . Get ( 1 )
2017-10-16 07:32:58 +00:00
recordMustExist ( t , err , "Couldn't find GID #1" )
2017-11-23 05:37:08 +00:00
expect ( t , group . ID == 1 , fmt . Sprintf ( "group.ID doesn't not match the requested GID. Got '%d' instead.'" , group . ID ) )
2017-09-15 22:20:01 +00:00
2017-11-23 05:37:08 +00:00
ok := common . Groups . Exists ( - 1 )
2017-10-21 00:27:47 +00:00
expect ( t , ! ok , "GID #-1 shouldn't exist" )
2017-09-15 22:20:01 +00:00
2017-10-21 00:27:47 +00:00
// 0 aka Unknown, for system posts and other oddities
2017-11-23 05:37:08 +00:00
ok = common . Groups . Exists ( 0 )
2017-10-21 00:27:47 +00:00
expect ( t , ok , "GID #0 should exist" )
2017-09-15 22:20:01 +00:00
2017-11-23 05:37:08 +00:00
ok = common . Groups . Exists ( 1 )
2017-10-21 00:27:47 +00:00
expect ( t , ok , "GID #1 should exist" )
var isAdmin = true
var isMod = true
var isBanned = false
2017-11-23 05:37:08 +00:00
gid , err := common . Groups . Create ( "Testing" , "Test" , isAdmin , isMod , isBanned )
2017-10-21 00:27:47 +00:00
expectNilErr ( t , err )
2017-11-23 05:37:08 +00:00
expect ( t , common . Groups . Exists ( gid ) , "The group we just made doesn't exist" )
2017-10-21 00:27:47 +00:00
2017-11-23 05:37:08 +00:00
group , err = common . Groups . Get ( gid )
2017-10-21 00:27:47 +00:00
expectNilErr ( t , err )
expect ( t , group . ID == gid , "The group ID should match the requested ID" )
expect ( t , group . IsAdmin , "This should be an admin group" )
expect ( t , group . IsMod , "This should be a mod group" )
expect ( t , ! group . IsBanned , "This shouldn't be a ban group" )
isAdmin = false
isMod = true
isBanned = true
2017-11-23 05:37:08 +00:00
gid , err = common . Groups . Create ( "Testing 2" , "Test" , isAdmin , isMod , isBanned )
2017-10-21 00:27:47 +00:00
expectNilErr ( t , err )
2017-11-23 05:37:08 +00:00
expect ( t , common . Groups . Exists ( gid ) , "The group we just made doesn't exist" )
2017-10-21 00:27:47 +00:00
2017-11-23 05:37:08 +00:00
group , err = common . Groups . Get ( gid )
2017-10-21 00:27:47 +00:00
expectNilErr ( t , err )
expect ( t , group . ID == gid , "The group ID should match the requested ID" )
expect ( t , ! group . IsAdmin , "This should not be an admin group" )
expect ( t , group . IsMod , "This should be a mod group" )
expect ( t , ! group . IsBanned , "This shouldn't be a ban group" )
// TODO: Make sure this pointer doesn't change once we refactor the group store to stop updating the pointer
err = group . ChangeRank ( false , false , true )
expectNilErr ( t , err )
2017-11-23 05:37:08 +00:00
group , err = common . Groups . Get ( gid )
2017-10-21 00:27:47 +00:00
expectNilErr ( t , err )
expect ( t , group . ID == gid , "The group ID should match the requested ID" )
expect ( t , ! group . IsAdmin , "This shouldn't be an admin group" )
expect ( t , ! group . IsMod , "This shouldn't be a mod group" )
expect ( t , group . IsBanned , "This should be a ban group" )
err = group . ChangeRank ( true , true , true )
expectNilErr ( t , err )
2017-11-23 05:37:08 +00:00
group , err = common . Groups . Get ( gid )
2017-10-21 00:27:47 +00:00
expectNilErr ( t , err )
expect ( t , group . ID == gid , "The group ID should match the requested ID" )
expect ( t , group . IsAdmin , "This should be an admin group" )
expect ( t , group . IsMod , "This should be a mod group" )
expect ( t , ! group . IsBanned , "This shouldn't be a ban group" )
err = group . ChangeRank ( false , true , true )
expectNilErr ( t , err )
2017-11-23 05:37:08 +00:00
group , err = common . Groups . Get ( gid )
2017-10-21 00:27:47 +00:00
expectNilErr ( t , err )
expect ( t , group . ID == gid , "The group ID should match the requested ID" )
expect ( t , ! group . IsAdmin , "This shouldn't be an admin group" )
expect ( t , group . IsMod , "This should be a mod group" )
expect ( t , ! group . IsBanned , "This shouldn't be a ban group" )
2017-11-05 01:04:57 +00:00
// Make sure the data is static
2017-11-23 05:37:08 +00:00
common . Groups . Reload ( gid )
2017-11-05 01:04:57 +00:00
2017-11-23 05:37:08 +00:00
group , err = common . Groups . Get ( gid )
2017-11-05 01:04:57 +00:00
expectNilErr ( t , err )
expect ( t , group . ID == gid , "The group ID should match the requested ID" )
expect ( t , ! group . IsAdmin , "This shouldn't be an admin group" )
expect ( t , group . IsMod , "This should be a mod group" )
expect ( t , ! group . IsBanned , "This shouldn't be a ban group" )
2017-10-21 00:27:47 +00:00
// TODO: Test group deletion
2017-11-05 01:04:57 +00:00
// TODO: Test group reload
// TODO: Test group cache set
Added the Social Groups plugin. This is still under construction.
Made a few improvements to the ForumStore, including bringing it's API closer in line with the other datastores, adding stubs for future subforum functionality, and improving efficiency in a few places.
The auth interface now handles all the authentication stuff.
Renamed the debug config variable to debug_mode.
Added the PluginPerms API.
Internal Errors will now dump the stack trace in the console.
Added support for installable plugins.
Refactored the routing logic so that the router now handles the common PreRoute logic(exc. /static/)
Added the CreateTable method to the query generator. It might need some tweaking to better support other database systems.
Added the same CreateTable method to the query builder.
Began work on PostgreSQL support.
Added the string-string hook type
Added the pre_render hook type.
Added the ParentID and ParentType fields to forums.
Added the get_forum_url_prefix function.
Added a more generic build_slug function.
Added the get_topic_url_prefix function.
Added the override_perms and override_forum_perms functions for bulk setting and unsetting permissions.
Added more ExtData fields in a few structs and removed them on the Perms struct as the PluginPerms API supersedes them there.
Plugins can now see the router instance.
The plugin initialisation handlers can now throw errors.
Plugins are now initialised after all the forum's subsystems are.
Refactored the unit test logic. For instance, we now use the proper .Log method rather than fmt.Println in many cases.
Sorry, we'll have to break Github's generated file detection, as the build instructions aren't working, unless I put them at the top, and they're far, far more important than getting Github to recognise the generated code as generated code.
Fixed an issue with mysql.go's _init_database() overwriting the dbpassword variable. Not a huge issue, but it is a "gotcha" for those not expecting a ':' at the start.
Fixed an issue with forum creation where the forum permissions didn't get cached.
Fixed a bug in plugin_bbcode where negative numbers in rand would crash Gosora.
Made the outputs of plugin_markdown and plugin_bbcode more compliant with the tests.
Revamped the phrase system to make it easier for us to add language pack related features in the future.
Added the WidgetMenu widget type.
Revamped the theme again. I'm experimenting to see which approach I like most.
- Excuse the little W3C rage. Some things about CSS drive me crazy :p
Tests:
Added 22 bbcode_full_parse tests.
Added 19 bbcode_regex_parse tests.
Added 27 markdown_parse tests.
Added four UserStore tests. More to come when the test database functionality is added.
Added 18 name_to_slug tests.
Hooks:
Added the pre_render hook.
Added the pre_render_forum_list hook.
Added the pre_render_view_forum hook.
Added the pre_render_topic_list hook.
Added the pre_render_view_topic hook.
Added the pre_render_profile hook.
Added the pre_render_custom_page hook.
Added the pre_render_overview hook.
Added the pre_render_create_topic hook.
Added the pre_render_account_own_edit_critical hook.
Added the pre_render_account_own_edit_avatar hook.
Added the pre_render_account_own_edit_username hook.
Added the pre_render_account_own_edit_email hook.
Added the pre_render_login hook.
Added the pre_render_register hook.
Added the pre_render_ban hook.
Added the pre_render_panel_dashboard hook.
Added the pre_render_panel_forums hook.
Added the pre_render_panel_delete_forum hook.
Added the pre_render_panel_edit_forum hook.
Added the pre_render_panel_settings hook.
Added the pre_render_panel_setting hook.
Added the pre_render_panel_plugins hook.
Added the pre_render_panel_users hook.
Added the pre_render_panel_edit_user hook.
Added the pre_render_panel_groups hook.
Added the pre_render_panel_edit_group hook.
Added the pre_render_panel_edit_group_perms hook.
Added the pre_render_panel_themes hook.
Added the pre_render_panel_mod_log hook.
Added the pre_render_error hook.
Added the pre_render_security_error hook.
Added the create_group_preappend hook.
Added the intercept_build_widgets hook.
Added the simple_forum_check_pre_perms hook.
Added the forum_check_pre_perms hook.
2017-07-09 12:06:04 +00:00
}
2017-10-12 03:24:14 +00:00
func TestReplyStore ( t * testing . T ) {
if ! gloinited {
gloinit ( )
}
2017-11-13 05:22:37 +00:00
if ! common . PluginsInited {
common . InitPlugins ( )
2017-10-12 03:24:14 +00:00
}
2017-11-11 04:06:16 +00:00
_ , err := common . Rstore . Get ( - 1 )
2017-10-21 00:27:47 +00:00
recordMustNotExist ( t , err , "RID #-1 shouldn't exist" )
2017-10-12 03:24:14 +00:00
2017-11-11 04:06:16 +00:00
_ , err = common . Rstore . Get ( 0 )
2017-10-21 00:27:47 +00:00
recordMustNotExist ( t , err , "RID #0 shouldn't exist" )
2017-11-11 04:06:16 +00:00
reply , err := common . Rstore . Get ( 1 )
2017-10-21 00:27:47 +00:00
expectNilErr ( t , err )
2017-11-06 16:24:45 +00:00
expect ( t , reply . ID == 1 , fmt . Sprintf ( "RID #1 has the wrong ID. It should be 1 not %d" , reply . ID ) )
expect ( t , reply . ParentID == 1 , fmt . Sprintf ( "The parent topic of RID #1 should be 1 not %d" , reply . ParentID ) )
expect ( t , reply . CreatedBy == 1 , fmt . Sprintf ( "The creator of RID #1 should be 1 not %d" , reply . CreatedBy ) )
expect ( t , reply . Content == "A reply!" , fmt . Sprintf ( "The contents of RID #1 should be 'A reply!' not %s" , reply . Content ) )
expect ( t , reply . IPAddress == "::1" , fmt . Sprintf ( "The IPAddress of RID#1 should be '::1' not %s" , reply . IPAddress ) )
2017-11-11 04:06:16 +00:00
_ , err = common . Rstore . Get ( 2 )
2017-11-06 16:24:45 +00:00
recordMustNotExist ( t , err , "RID #2 shouldn't exist" )
// TODO: Test Create and Get
//Create(tid int, content string, ipaddress string, fid int, uid int) (id int, err error)
2017-11-11 04:06:16 +00:00
topic , err := common . Topics . Get ( 1 )
2017-11-08 07:28:33 +00:00
expectNilErr ( t , err )
2017-11-11 04:06:16 +00:00
rid , err := common . Rstore . Create ( topic , "Fofofo" , "::1" , 1 )
2017-11-06 16:24:45 +00:00
expectNilErr ( t , err )
expect ( t , rid == 2 , fmt . Sprintf ( "The next reply ID should be 2 not %d" , rid ) )
2017-10-12 03:24:14 +00:00
2017-11-11 04:06:16 +00:00
reply , err = common . Rstore . Get ( 2 )
2017-11-06 16:24:45 +00:00
expectNilErr ( t , err )
expect ( t , reply . ID == 2 , fmt . Sprintf ( "RID #2 has the wrong ID. It should be 2 not %d" , reply . ID ) )
expect ( t , reply . ParentID == 1 , fmt . Sprintf ( "The parent topic of RID #2 should be 1 not %d" , reply . ParentID ) )
expect ( t , reply . CreatedBy == 1 , fmt . Sprintf ( "The creator of RID #2 should be 1 not %d" , reply . CreatedBy ) )
expect ( t , reply . Content == "Fofofo" , fmt . Sprintf ( "The contents of RID #2 should be 'Fofofo' not %s" , reply . Content ) )
expect ( t , reply . IPAddress == "::1" , fmt . Sprintf ( "The IPAddress of RID #2 should be '::1' not %s" , reply . IPAddress ) )
2017-10-12 03:24:14 +00:00
}
func TestProfileReplyStore ( t * testing . T ) {
if ! gloinited {
gloinit ( )
}
2017-11-13 05:22:37 +00:00
if ! common . PluginsInited {
common . InitPlugins ( )
2017-10-12 03:24:14 +00:00
}
2017-11-11 04:06:16 +00:00
_ , err := common . Prstore . Get ( - 1 )
2017-11-06 16:24:45 +00:00
recordMustNotExist ( t , err , "PRID #-1 shouldn't exist" )
2017-10-12 03:24:14 +00:00
2017-11-11 04:06:16 +00:00
_ , err = common . Prstore . Get ( 0 )
2017-11-06 16:24:45 +00:00
recordMustNotExist ( t , err , "PRID #0 shouldn't exist" )
2017-11-11 04:06:16 +00:00
_ , err = common . Prstore . Get ( 1 )
2017-11-07 22:38:15 +00:00
recordMustNotExist ( t , err , "PRID #1 shouldn't exist" )
2017-11-06 16:24:45 +00:00
2018-05-28 06:27:12 +00:00
// ? - Commented this one out as strong constraints like this put an unreasonable load on the database, we only want errors if a delete which should succeed fails
//profileReply := common.BlankProfileReply(1)
//err = profileReply.Delete()
//expect(t,err != nil,"You shouldn't be able to delete profile replies which don't exist")
2017-11-06 16:24:45 +00:00
var profileID = 1
2017-11-11 04:06:16 +00:00
prid , err := common . Prstore . Create ( profileID , "Haha" , 1 , "::1" )
2017-11-06 16:24:45 +00:00
expect ( t , err == nil , "Unable to create a profile reply" )
expect ( t , prid == 1 , "The first profile reply should have an ID of 1" )
2017-11-11 04:06:16 +00:00
profileReply , err := common . Prstore . Get ( 1 )
2017-11-06 16:24:45 +00:00
expect ( t , err == nil , "PRID #1 should exist" )
expect ( t , profileReply . ID == 1 , fmt . Sprintf ( "The profile reply should have an ID of 1 not %d" , profileReply . ID ) )
expect ( t , profileReply . ParentID == 1 , fmt . Sprintf ( "The parent ID of the profile reply should be 1 not %d" , profileReply . ParentID ) )
expect ( t , profileReply . Content == "Haha" , fmt . Sprintf ( "The profile reply's contents should be 'Haha' not '%s'" , profileReply . Content ) )
expect ( t , profileReply . CreatedBy == 1 , fmt . Sprintf ( "The profile reply's creator should be 1 not %d" , profileReply . CreatedBy ) )
expect ( t , profileReply . IPAddress == "::1" , fmt . Sprintf ( "The profile reply's IP Address should be '::1' not '%s'" , profileReply . IPAddress ) )
2018-05-28 06:27:12 +00:00
err = profileReply . Delete ( )
expectNilErr ( t , err )
_ , err = common . Prstore . Get ( 1 )
expect ( t , err != nil , "PRID #1 shouldn't exist after being deleted" )
2017-11-06 16:24:45 +00:00
2018-05-28 06:27:12 +00:00
// TODO: Test profileReply.SetBody() and profileReply.Creator()
2017-10-12 03:24:14 +00:00
}
Added the Social Groups plugin. This is still under construction.
Made a few improvements to the ForumStore, including bringing it's API closer in line with the other datastores, adding stubs for future subforum functionality, and improving efficiency in a few places.
The auth interface now handles all the authentication stuff.
Renamed the debug config variable to debug_mode.
Added the PluginPerms API.
Internal Errors will now dump the stack trace in the console.
Added support for installable plugins.
Refactored the routing logic so that the router now handles the common PreRoute logic(exc. /static/)
Added the CreateTable method to the query generator. It might need some tweaking to better support other database systems.
Added the same CreateTable method to the query builder.
Began work on PostgreSQL support.
Added the string-string hook type
Added the pre_render hook type.
Added the ParentID and ParentType fields to forums.
Added the get_forum_url_prefix function.
Added a more generic build_slug function.
Added the get_topic_url_prefix function.
Added the override_perms and override_forum_perms functions for bulk setting and unsetting permissions.
Added more ExtData fields in a few structs and removed them on the Perms struct as the PluginPerms API supersedes them there.
Plugins can now see the router instance.
The plugin initialisation handlers can now throw errors.
Plugins are now initialised after all the forum's subsystems are.
Refactored the unit test logic. For instance, we now use the proper .Log method rather than fmt.Println in many cases.
Sorry, we'll have to break Github's generated file detection, as the build instructions aren't working, unless I put them at the top, and they're far, far more important than getting Github to recognise the generated code as generated code.
Fixed an issue with mysql.go's _init_database() overwriting the dbpassword variable. Not a huge issue, but it is a "gotcha" for those not expecting a ':' at the start.
Fixed an issue with forum creation where the forum permissions didn't get cached.
Fixed a bug in plugin_bbcode where negative numbers in rand would crash Gosora.
Made the outputs of plugin_markdown and plugin_bbcode more compliant with the tests.
Revamped the phrase system to make it easier for us to add language pack related features in the future.
Added the WidgetMenu widget type.
Revamped the theme again. I'm experimenting to see which approach I like most.
- Excuse the little W3C rage. Some things about CSS drive me crazy :p
Tests:
Added 22 bbcode_full_parse tests.
Added 19 bbcode_regex_parse tests.
Added 27 markdown_parse tests.
Added four UserStore tests. More to come when the test database functionality is added.
Added 18 name_to_slug tests.
Hooks:
Added the pre_render hook.
Added the pre_render_forum_list hook.
Added the pre_render_view_forum hook.
Added the pre_render_topic_list hook.
Added the pre_render_view_topic hook.
Added the pre_render_profile hook.
Added the pre_render_custom_page hook.
Added the pre_render_overview hook.
Added the pre_render_create_topic hook.
Added the pre_render_account_own_edit_critical hook.
Added the pre_render_account_own_edit_avatar hook.
Added the pre_render_account_own_edit_username hook.
Added the pre_render_account_own_edit_email hook.
Added the pre_render_login hook.
Added the pre_render_register hook.
Added the pre_render_ban hook.
Added the pre_render_panel_dashboard hook.
Added the pre_render_panel_forums hook.
Added the pre_render_panel_delete_forum hook.
Added the pre_render_panel_edit_forum hook.
Added the pre_render_panel_settings hook.
Added the pre_render_panel_setting hook.
Added the pre_render_panel_plugins hook.
Added the pre_render_panel_users hook.
Added the pre_render_panel_edit_user hook.
Added the pre_render_panel_groups hook.
Added the pre_render_panel_edit_group hook.
Added the pre_render_panel_edit_group_perms hook.
Added the pre_render_panel_themes hook.
Added the pre_render_panel_mod_log hook.
Added the pre_render_error hook.
Added the pre_render_security_error hook.
Added the create_group_preappend hook.
Added the intercept_build_widgets hook.
Added the simple_forum_check_pre_perms hook.
Added the forum_check_pre_perms hook.
2017-07-09 12:06:04 +00:00
func TestSlugs ( t * testing . T ) {
2017-09-03 04:50:31 +00:00
var res string
2017-09-13 15:09:13 +00:00
var msgList [ ] MEPair
2018-04-03 04:34:07 +00:00
common . Config . BuildSlugs = true // Flip this switch, otherwise all the tests will fail
2017-09-03 04:50:31 +00:00
msgList = addMEPair ( msgList , "Unknown" , "unknown" )
msgList = addMEPair ( msgList , "Unknown2" , "unknown2" )
msgList = addMEPair ( msgList , "Unknown " , "unknown" )
msgList = addMEPair ( msgList , "Unknown 2" , "unknown-2" )
msgList = addMEPair ( msgList , "Unknown 2" , "unknown-2" )
msgList = addMEPair ( msgList , "Admin Alice" , "admin-alice" )
msgList = addMEPair ( msgList , "Admin_Alice" , "adminalice" )
msgList = addMEPair ( msgList , "Admin_Alice-" , "adminalice" )
msgList = addMEPair ( msgList , "-Admin_Alice-" , "adminalice" )
msgList = addMEPair ( msgList , "-Admin@Alice-" , "adminalice" )
msgList = addMEPair ( msgList , "-Admin😀Alice-" , "adminalice" )
msgList = addMEPair ( msgList , "u" , "u" )
msgList = addMEPair ( msgList , "" , "untitled" )
msgList = addMEPair ( msgList , " " , "untitled" )
msgList = addMEPair ( msgList , "-" , "untitled" )
msgList = addMEPair ( msgList , "--" , "untitled" )
msgList = addMEPair ( msgList , "é" , "é" )
msgList = addMEPair ( msgList , "-é-" , "é" )
2017-11-05 01:04:57 +00:00
msgList = addMEPair ( msgList , "-你好-" , "untitled" )
2017-09-03 04:50:31 +00:00
for _ , item := range msgList {
t . Log ( "Testing string '" + item . Msg + "'" )
2017-11-11 04:06:16 +00:00
res = common . NameToSlug ( item . Msg )
2017-09-03 04:50:31 +00:00
if res != item . Expects {
t . Error ( "Bad output:" , "'" + res + "'" )
t . Error ( "Expected:" , item . Expects )
}
}
Added the Social Groups plugin. This is still under construction.
Made a few improvements to the ForumStore, including bringing it's API closer in line with the other datastores, adding stubs for future subforum functionality, and improving efficiency in a few places.
The auth interface now handles all the authentication stuff.
Renamed the debug config variable to debug_mode.
Added the PluginPerms API.
Internal Errors will now dump the stack trace in the console.
Added support for installable plugins.
Refactored the routing logic so that the router now handles the common PreRoute logic(exc. /static/)
Added the CreateTable method to the query generator. It might need some tweaking to better support other database systems.
Added the same CreateTable method to the query builder.
Began work on PostgreSQL support.
Added the string-string hook type
Added the pre_render hook type.
Added the ParentID and ParentType fields to forums.
Added the get_forum_url_prefix function.
Added a more generic build_slug function.
Added the get_topic_url_prefix function.
Added the override_perms and override_forum_perms functions for bulk setting and unsetting permissions.
Added more ExtData fields in a few structs and removed them on the Perms struct as the PluginPerms API supersedes them there.
Plugins can now see the router instance.
The plugin initialisation handlers can now throw errors.
Plugins are now initialised after all the forum's subsystems are.
Refactored the unit test logic. For instance, we now use the proper .Log method rather than fmt.Println in many cases.
Sorry, we'll have to break Github's generated file detection, as the build instructions aren't working, unless I put them at the top, and they're far, far more important than getting Github to recognise the generated code as generated code.
Fixed an issue with mysql.go's _init_database() overwriting the dbpassword variable. Not a huge issue, but it is a "gotcha" for those not expecting a ':' at the start.
Fixed an issue with forum creation where the forum permissions didn't get cached.
Fixed a bug in plugin_bbcode where negative numbers in rand would crash Gosora.
Made the outputs of plugin_markdown and plugin_bbcode more compliant with the tests.
Revamped the phrase system to make it easier for us to add language pack related features in the future.
Added the WidgetMenu widget type.
Revamped the theme again. I'm experimenting to see which approach I like most.
- Excuse the little W3C rage. Some things about CSS drive me crazy :p
Tests:
Added 22 bbcode_full_parse tests.
Added 19 bbcode_regex_parse tests.
Added 27 markdown_parse tests.
Added four UserStore tests. More to come when the test database functionality is added.
Added 18 name_to_slug tests.
Hooks:
Added the pre_render hook.
Added the pre_render_forum_list hook.
Added the pre_render_view_forum hook.
Added the pre_render_topic_list hook.
Added the pre_render_view_topic hook.
Added the pre_render_profile hook.
Added the pre_render_custom_page hook.
Added the pre_render_overview hook.
Added the pre_render_create_topic hook.
Added the pre_render_account_own_edit_critical hook.
Added the pre_render_account_own_edit_avatar hook.
Added the pre_render_account_own_edit_username hook.
Added the pre_render_account_own_edit_email hook.
Added the pre_render_login hook.
Added the pre_render_register hook.
Added the pre_render_ban hook.
Added the pre_render_panel_dashboard hook.
Added the pre_render_panel_forums hook.
Added the pre_render_panel_delete_forum hook.
Added the pre_render_panel_edit_forum hook.
Added the pre_render_panel_settings hook.
Added the pre_render_panel_setting hook.
Added the pre_render_panel_plugins hook.
Added the pre_render_panel_users hook.
Added the pre_render_panel_edit_user hook.
Added the pre_render_panel_groups hook.
Added the pre_render_panel_edit_group hook.
Added the pre_render_panel_edit_group_perms hook.
Added the pre_render_panel_themes hook.
Added the pre_render_panel_mod_log hook.
Added the pre_render_error hook.
Added the pre_render_security_error hook.
Added the create_group_preappend hook.
Added the intercept_build_widgets hook.
Added the simple_forum_check_pre_perms hook.
Added the forum_check_pre_perms hook.
2017-07-09 12:06:04 +00:00
}
2017-07-12 11:05:18 +00:00
func TestAuth ( t * testing . T ) {
2017-09-03 04:50:31 +00:00
// bcrypt likes doing stupid things, so this test will probably fail
2018-05-28 06:27:12 +00:00
realPassword := "Madame Cassandra's Mystic Orb"
2017-11-13 05:22:37 +00:00
t . Logf ( "Set realPassword to '%s'" , realPassword )
2018-05-28 06:27:12 +00:00
t . Log ( "Hashing the real password with bcrypt" )
hashedPassword , _ , err := common . BcryptGeneratePassword ( realPassword )
if err != nil {
t . Error ( err )
}
passwordTest ( t , realPassword , hashedPassword )
// TODO: Peek at the prefix to verify this is a bcrypt hash
2017-09-03 04:50:31 +00:00
t . Log ( "Hashing the real password" )
2018-05-28 06:27:12 +00:00
hashedPassword2 , _ , err := common . GeneratePassword ( realPassword )
2017-09-03 04:50:31 +00:00
if err != nil {
t . Error ( err )
}
2018-05-28 06:27:12 +00:00
passwordTest ( t , realPassword , hashedPassword2 )
// TODO: Peek at the prefix to verify this is a bcrypt hash
2018-06-17 08:12:39 +00:00
_ , err , _ = common . Auth . Authenticate ( "None" , "password" )
2018-05-28 06:27:12 +00:00
errmsg := "Username None shouldn't exist"
if err != nil {
errmsg += "\n" + err . Error ( )
}
expect ( t , err == common . ErrNoUserByName , errmsg )
2018-06-17 08:12:39 +00:00
uid , err , _ := common . Auth . Authenticate ( "Admin" , "password" )
2018-05-28 06:27:12 +00:00
expectNilErr ( t , err )
expect ( t , uid == 1 , fmt . Sprintf ( "Default admin uid should be 1 not %d" , uid ) )
2018-06-17 08:12:39 +00:00
_ , err , _ = common . Auth . Authenticate ( "Sam" , "ReallyBadPassword" )
2018-05-28 06:27:12 +00:00
errmsg = "Username Sam shouldn't exist"
if err != nil {
errmsg += "\n" + err . Error ( )
}
expect ( t , err == common . ErrNoUserByName , errmsg )
admin , err := common . Users . Get ( 1 )
expectNilErr ( t , err )
// TODO: Move this into the user store tests to provide better coverage? E.g. To see if the installer and the user creator initialise the field differently
expect ( t , admin . Session == "" , "Admin session should be blank" )
2017-09-03 04:50:31 +00:00
2018-05-28 06:27:12 +00:00
session , err := common . Auth . CreateSession ( 1 )
expectNilErr ( t , err )
expect ( t , session != "" , "Admin session shouldn't be blank" )
// TODO: Test the actual length set in the setting in addition to this "too short" test
// TODO: We might be able to push up this minimum requirement
expect ( t , len ( session ) > 10 , "Admin session shouldn't be too short" )
expect ( t , admin . Session != session , "Old session should not match new one" )
admin , err = common . Users . Get ( 1 )
expectNilErr ( t , err )
expect ( t , admin . Session == session , "Sessions should match" )
// TODO: Tests for SessionCheck, GetCookies, and ForceLogout
}
// TODO: Vary the salts? Keep in mind that some algorithms store the salt in the hash therefore the salt string may be blank
func passwordTest ( t * testing . T , realPassword string , hashedPassword string ) {
if len ( hashedPassword ) < 10 {
t . Error ( "Hash too short" )
}
salt := ""
password := realPassword
2017-11-13 05:22:37 +00:00
t . Logf ( "Testing password '%s'" , password )
t . Logf ( "Testing salt '%s'" , salt )
2018-05-28 06:27:12 +00:00
err := common . CheckPassword ( hashedPassword , password , salt )
2017-11-13 05:22:37 +00:00
if err == common . ErrMismatchedHashAndPassword {
2017-09-03 04:50:31 +00:00
t . Error ( "The two don't match" )
2017-11-13 05:22:37 +00:00
} else if err == common . ErrPasswordTooLong {
2017-09-03 04:50:31 +00:00
t . Error ( "CheckPassword thinks the password is too long" )
} else if err != nil {
t . Error ( err )
}
password = "hahaha"
2017-11-13 05:22:37 +00:00
t . Logf ( "Testing password '%s'" , password )
t . Logf ( "Testing salt '%s'" , salt )
2017-11-11 04:06:16 +00:00
err = common . CheckPassword ( hashedPassword , password , salt )
2017-11-13 05:22:37 +00:00
if err == common . ErrPasswordTooLong {
2017-09-03 04:50:31 +00:00
t . Error ( "CheckPassword thinks the password is too long" )
} else if err == nil {
t . Error ( "The two shouldn't match!" )
}
password = "Madame Cassandra's Mystic"
2017-11-13 05:22:37 +00:00
t . Logf ( "Testing password '%s'" , password )
t . Logf ( "Testing salt '%s'" , salt )
2017-11-11 04:06:16 +00:00
err = common . CheckPassword ( hashedPassword , password , salt )
2017-11-13 05:22:37 +00:00
expect ( t , err != common . ErrPasswordTooLong , "CheckPassword thinks the password is too long" )
expect ( t , err != nil , "The two shouldn't match!" )
2017-07-12 11:05:18 +00:00
}
2018-06-26 02:30:29 +00:00
2018-06-26 04:54:20 +00:00
type METri struct {
Name string // Optional, this is here for tests involving invisible characters so we know what's going in
Msg string
Expects string
}
func addMETri ( msgList [ ] METri , args ... string ) [ ] METri {
if len ( args ) < 2 {
panic ( "need 2 or more args" )
}
if len ( args ) > 2 {
return append ( msgList , METri { args [ 0 ] , args [ 1 ] , args [ 2 ] } )
}
return append ( msgList , METri { "" , args [ 0 ] , args [ 1 ] } )
}
2018-06-26 02:30:29 +00:00
func TestPreparser ( t * testing . T ) {
var res string
2018-06-26 04:54:20 +00:00
var msgList [ ] METri
2018-06-26 02:30:29 +00:00
// Note: The open tag is evaluated without knowledge of the close tag for efficiency and simplicity, so the parser autofills the associated close tag when it finds an open tag without a partner
2018-06-26 04:54:20 +00:00
msgList = addMETri ( msgList , "" , "" )
msgList = addMETri ( msgList , " " , "" )
msgList = addMETri ( msgList , " hi" , "hi" )
msgList = addMETri ( msgList , "hi " , "hi" )
msgList = addMETri ( msgList , "hi" , "hi" )
msgList = addMETri ( msgList , ":grinning:" , "😀" )
msgList = addMETri ( msgList , "😀" , "😀" )
msgList = addMETri ( msgList , " " , "" )
msgList = addMETri ( msgList , "<p>" , "" )
msgList = addMETri ( msgList , "</p>" , "" )
msgList = addMETri ( msgList , "<p></p>" , "" )
2018-06-30 03:40:50 +00:00
msgList = addMETri ( msgList , "<" , "<" )
msgList = addMETri ( msgList , ">" , ">" )
msgList = addMETri ( msgList , "<meow>" , "<meow>" )
msgList = addMETri ( msgList , "<" , "&lt;" )
2018-06-30 04:34:07 +00:00
msgList = addMETri ( msgList , "&" , "&" )
2018-06-30 03:40:50 +00:00
2018-06-26 04:54:20 +00:00
// Note: strings.TrimSpace strips newlines, if there's nothing before or after them
msgList = addMETri ( msgList , "<br>" , "" )
msgList = addMETri ( msgList , "<br />" , "" )
msgList = addMETri ( msgList , "\\n" , "\n" , "" )
msgList = addMETri ( msgList , "\\n\\n" , "\n\n" , "" )
msgList = addMETri ( msgList , "\\n\\n\\n" , "\n\n\n" , "" )
msgList = addMETri ( msgList , "\\r\\n" , "\r\n" , "" ) // Windows style line ending
msgList = addMETri ( msgList , "\\n\\r" , "\n\r" , "" )
msgList = addMETri ( msgList , "ho<br>ho" , "ho\n\nho" )
msgList = addMETri ( msgList , "ho<br />ho" , "ho\n\nho" )
msgList = addMETri ( msgList , "ho\\nho" , "ho\nho" , "ho\nho" )
msgList = addMETri ( msgList , "ho\\n\\nho" , "ho\n\nho" , "ho\n\nho" )
//msgList = addMETri(msgList, "ho\\n\\n\\n\\nho", "ho\n\n\n\nho", "ho\n\n\nho")
msgList = addMETri ( msgList , "ho\\r\\nho" , "ho\r\nho" , "ho\nho" ) // Windows style line ending
msgList = addMETri ( msgList , "ho\\n\\rho" , "ho\n\rho" , "ho\nho" )
msgList = addMETri ( msgList , "<b></b>" , "<strong></strong>" )
msgList = addMETri ( msgList , "<b>hi</b>" , "<strong>hi</strong>" )
msgList = addMETri ( msgList , "<s>hi</s>" , "<del>hi</del>" )
msgList = addMETri ( msgList , "<del>hi</del>" , "<del>hi</del>" )
msgList = addMETri ( msgList , "<u>hi</u>" , "<u>hi</u>" )
msgList = addMETri ( msgList , "<em>hi</em>" , "<em>hi</em>" )
msgList = addMETri ( msgList , "<i>hi</i>" , "<em>hi</em>" )
msgList = addMETri ( msgList , "<strong>hi</strong>" , "<strong>hi</strong>" )
msgList = addMETri ( msgList , "<b><i>hi</i></b>" , "<strong><em>hi</em></strong>" )
msgList = addMETri ( msgList , "<strong><em>hi</em></strong>" , "<strong><em>hi</em></strong>" )
msgList = addMETri ( msgList , "<b><i><b>hi</b></i></b>" , "<strong><em><strong>hi</strong></em></strong>" )
msgList = addMETri ( msgList , "<strong><em><strong>hi</strong></em></strong>" , "<strong><em><strong>hi</strong></em></strong>" )
msgList = addMETri ( msgList , "<div>hi</div>" , "<div>hi</div>" )
msgList = addMETri ( msgList , "<span>hi</span>" , "hi" ) // This is stripped since the editor (Trumbowyg) likes blasting useless spans
msgList = addMETri ( msgList , "<span >hi</span>" , "hi" )
msgList = addMETri ( msgList , "<span style='background-color: yellow;'>hi</span>" , "hi" )
msgList = addMETri ( msgList , "<span style='background-color: yellow;'>>hi</span>" , ">hi" )
msgList = addMETri ( msgList , "<b>hi" , "<strong>hi</strong>" )
msgList = addMETri ( msgList , "hi</b>" , "hi</b>" )
msgList = addMETri ( msgList , "</b>" , "</b>" )
msgList = addMETri ( msgList , "</del>" , "</del>" )
msgList = addMETri ( msgList , "</strong>" , "</strong>" )
msgList = addMETri ( msgList , "<b>" , "<strong></strong>" )
msgList = addMETri ( msgList , "<span style='background-color: yellow;'>hi" , "hi" )
msgList = addMETri ( msgList , "hi</span>" , "hi" )
msgList = addMETri ( msgList , "</span>" , "" )
msgList = addMETri ( msgList , "<span></span>" , "" )
msgList = addMETri ( msgList , "<span ></span>" , "" )
msgList = addMETri ( msgList , "<></>" , "<></>" )
msgList = addMETri ( msgList , "</><>" , "</><>" )
msgList = addMETri ( msgList , "<>" , "<>" )
msgList = addMETri ( msgList , "</>" , "</>" )
//msgList = addMETri(msgList, "byte 0", string([]byte{0}), "")
msgList = addMETri ( msgList , "byte 'a'" , string ( [ ] byte { 'a' } ) , "a" )
//msgList = addMETri(msgList, "byte 255", string([]byte{255}), "")
//msgList = addMETri(msgList, "rune 0", string([]rune{0}), "")
// TODO: Do a test with invalid UTF-8 input
2018-06-26 02:30:29 +00:00
for _ , item := range msgList {
res = common . PreparseMessage ( item . Msg )
if res != item . Expects {
2018-06-26 04:54:20 +00:00
if item . Name != "" {
t . Error ( "Name: " , item . Name )
}
2018-06-26 02:30:29 +00:00
t . Error ( "Testing string '" + item . Msg + "'" )
t . Error ( "Bad output:" , "'" + res + "'" )
//t.Error("Ouput in bytes:", []byte(res))
t . Error ( "Expected:" , "'" + item . Expects + "'" )
}
}
}