From 8cf9badd46a4d97ef15b477fa32ee7fae33635e4 Mon Sep 17 00:00:00 2001 From: Azareal Date: Fri, 28 Jun 2019 09:35:34 +1000 Subject: [PATCH] Remove inline CSS for log pages. Darken links on hover in Nox. Add another group.CanSee test. --- misc_test.go | 3 ++- templates/account_logins.html | 9 +++++---- templates/panel_adminlogs.html | 10 +++++----- templates/panel_modlogs.html | 10 +++++----- templates/panel_reglogs.html | 10 +++++----- themes/cosora/public/main.css | 8 ++++++++ themes/nox/public/main.css | 7 +++++++ themes/shadow/public/main.css | 18 ++++++++++++------ themes/tempra_simple/public/main.css | 15 +++++++++++---- 9 files changed, 60 insertions(+), 30 deletions(-) diff --git a/misc_test.go b/misc_test.go index 8f86b32e..51582294 100644 --- a/misc_test.go +++ b/misc_test.go @@ -784,6 +784,7 @@ func TestForumPermsStore(t *testing.T) { } // TODO: Test the group permissions +// TODO: Test group.CanSee for forum presets + group perms func TestGroupStore(t *testing.T) { miscinit(t) if !c.PluginsInited { @@ -823,7 +824,7 @@ func TestGroupStore(t *testing.T) { expect(t, group.IsAdmin, "This should be an admin group") expect(t, group.IsMod, "This should be a mod group") expect(t, !group.IsBanned, "This shouldn't be a ban group") - // TODO: Add a proper CanSee test + expect(t, len(group.CanSee) == 0, "group.CanSee should be empty") isAdmin = false isMod = true diff --git a/templates/account_logins.html b/templates/account_logins.html index c567f8bb..289bc274 100644 --- a/templates/account_logins.html +++ b/templates/account_logins.html @@ -1,17 +1,18 @@

{{lang "account_logins_head"}}

-
+
{{range .ItemList}}
- + {{if .Success}}{{lang "account_logins_success"}}{{else}}{{lang "account_logins_failure"}}"{{end}}
- {{.IPAddress}} + {{.IPAddress}}
- {{.DoneAt}} + {{.DoneAt}} +
{{end}}
diff --git a/templates/panel_adminlogs.html b/templates/panel_adminlogs.html index 8b5fd273..1d5fff7c 100644 --- a/templates/panel_adminlogs.html +++ b/templates/panel_adminlogs.html @@ -1,17 +1,17 @@

{{lang "panel_logs_administration_head"}}

-
+
{{range .Logs}}
- + {{.Action}} - {{if $.CurrentUser.Perms.ViewIPs}}
{{.IPAddress}}{{end}} + {{if $.CurrentUser.Perms.ViewIPs}}
{{.IPAddress}}{{end}}
- {{.DoneAt}} + {{.DoneAt}} -
+
{{end}}
diff --git a/templates/panel_modlogs.html b/templates/panel_modlogs.html index 4c355828..b1fb61e4 100644 --- a/templates/panel_modlogs.html +++ b/templates/panel_modlogs.html @@ -1,17 +1,17 @@

{{lang "panel_logs_moderation_head"}}

-
+
{{range .Logs}}
- + {{.Action}} - {{if $.CurrentUser.Perms.ViewIPs}}
{{.IPAddress}}{{end}} + {{if $.CurrentUser.Perms.ViewIPs}}
{{.IPAddress}}{{end}}
- {{.DoneAt}} + {{.DoneAt}} -
+
{{end}}
diff --git a/templates/panel_reglogs.html b/templates/panel_reglogs.html index 387a839e..10e94d37 100644 --- a/templates/panel_reglogs.html +++ b/templates/panel_reglogs.html @@ -1,17 +1,17 @@

{{lang "panel_logs_registration_head"}}

-
+
{{range .Logs}}
- + {{if not .Success}}{{lang "panel_logs_registration_attempt"}}: {{end}}{{.Username}} ({{lang "panel_logs_registration_email"}}: {{.Email}}){{if .ParsedReason}} ({{lang "panel_logs_registration_reason"}}: {{.ParsedReason}}){{end}} - {{if $.CurrentUser.Perms.ViewIPs}}
{{.IPAddress}}{{end}} + {{if $.CurrentUser.Perms.ViewIPs}}
{{.IPAddress}}{{end}}
- {{.DoneAt}} + {{.DoneAt}} -
+
{{end}}
diff --git a/themes/cosora/public/main.css b/themes/cosora/public/main.css index 77cc1a0d..b898ba9a 100644 --- a/themes/cosora/public/main.css +++ b/themes/cosora/public/main.css @@ -786,6 +786,14 @@ textarea { padding: 16px; } +.loglist .to_left small { + margin-left: 2px; + font-size: 12px; +} +.loglist .to_right span { + font-size: 14px; +} + .topic_list .rowtopic { font-size: 16px; margin-right: 1px; diff --git a/themes/nox/public/main.css b/themes/nox/public/main.css index 62e88d4b..a815c960 100644 --- a/themes/nox/public/main.css +++ b/themes/nox/public/main.css @@ -15,6 +15,9 @@ a { color: #eeeeee; text-decoration: none; } +a:hover { + color: #cccccc; +} nav.nav { background: {{$darkest_bg}}; @@ -1110,6 +1113,10 @@ input[type=checkbox]:checked + label .sel { margin-left: 0px; margin-top: 0px; } +.loglist .to_left small { + margin-left: 2px; + font-size: 12px; +} .ip_search_block { margin-bottom: 12px; diff --git a/themes/shadow/public/main.css b/themes/shadow/public/main.css index 691bced4..d44392b2 100644 --- a/themes/shadow/public/main.css +++ b/themes/shadow/public/main.css @@ -223,6 +223,9 @@ h1, h2, h3, h4, h5 { } /* Align to right in a flex head */ +.to_left { + float: left; +} .to_right { float: right; margin-left: auto; @@ -231,8 +234,7 @@ h1, h2, h3, h4, h5 { /* Topic View */ /* TODO: How should we handle the sticky headers? */ -.topic_sticky_head { -} +.topic_sticky_head {} /* TODO: Add the avatars to the forum list */ .forum_list .forum_nodesc { @@ -515,6 +517,13 @@ textarea.large { .rowlist .formrow, .rowlist .formrow:first-child { margin-top: 0px; } +.loglist .to_left small { + margin-left: 2px; + font-size: 12px; +} +.loglist .to_right span { + font-size: 14px; +} input { background-color: var(--input-background-color); @@ -1166,10 +1175,7 @@ blockquote:first-child { .topic_list .topic_left { width: 100%; } - .topic_list .topic_right { - display: none; - } - #poweredBy span { + .topic_list .topic_right, #poweredBy span { display: none; } } diff --git a/themes/tempra_simple/public/main.css b/themes/tempra_simple/public/main.css index 3cc9604c..6dcb652d 100644 --- a/themes/tempra_simple/public/main.css +++ b/themes/tempra_simple/public/main.css @@ -343,6 +343,9 @@ h1, h2, h3, h4, h5 { display: none; } +.to_left { + float: left; +} .to_right { margin-left: auto; float: right; @@ -355,6 +358,13 @@ h1, h2, h3, h4, h5 { padding-top: 10px; padding-bottom: 10px; } +.loglist .to_left small { + margin-left: 2px; + font-size: 12px; +} +.loglist .to_right span { + font-size: 14px; +} .bgsub { display: none; } @@ -570,10 +580,7 @@ input, select { .quick_create_form .quick_button_row .formitem { display: flex; } -.quick_create_form .formbutton:first-child { - margin-left: 0px; - margin-right: 5px; -} +.quick_create_form .formbutton:first-child, .quick_create_form .formbutton:not(:first-child) { margin-left: 0px; margin-right: 5px;