From a52d9cc3719c8b3c1c76686f28020f566499e21d Mon Sep 17 00:00:00 2001
From: Azareal <azareal@users.noreply.github.com>
Date: Mon, 29 Apr 2019 23:21:53 +1000
Subject: [PATCH] Use <h1> instead of <a> in more spots in the control panel.
 Eliminate more instances of excessive indentation in the analytics panes.

---
 templates/panel_analytics_forums.html | 36 +++++++++++-----------
 templates/panel_analytics_posts.html  | 44 ++++++++++++++-------------
 templates/panel_analytics_topics.html | 44 ++++++++++++++-------------
 templates/panel_analytics_views.html  | 44 ++++++++++++++-------------
 templates/panel_forum_edit.html       |  4 ++-
 5 files changed, 90 insertions(+), 82 deletions(-)

diff --git a/templates/panel_analytics_forums.html b/templates/panel_analytics_forums.html
index 627be8f6..0e87aaa7 100644
--- a/templates/panel_analytics_forums.html
+++ b/templates/panel_analytics_forums.html
@@ -1,19 +1,19 @@
-		<div class="colstack_item colstack_head">
-			<div class="rowitem">
-				<h1>{{lang "panel_statistics_forums_head"}}</h1>
-				{{template "panel_analytics_time_range.html" . }}
-			</div>
-		</div>
-		<form id="timeRangeForm" name="timeRangeForm" action="/panel/analytics/forums/" method="get"></form>
-		<div id="panel_analytics_forums_chart" class="colstack_graph_holder">
-			<div class="ct_chart"></div>
-		</div>
-		<div id="panel_analytics_routes" class="colstack_item rowlist">
-			{{range .ItemList}}
-			<div class="rowitem panel_compactrow editable_parent">
-				<a href="/panel/analytics/forum/{{.Agent}}" class="panel_upshift">{{.FriendlyAgent}}</a>
-				<span class="panel_compacttext to_right">{{.Count}}{{lang "panel_statistics_views_suffix"}}</span>
-			</div>
-			{{else}}<div class="rowitem passive rowmsg">{{lang "panel_statistics_forums_no_forums"}}</div>{{end}}
-		</div>
+<div class="colstack_item colstack_head">
+	<div class="rowitem">
+		<h1>{{lang "panel_statistics_forums_head"}}</h1>
+		{{template "panel_analytics_time_range.html" . }}
+	</div>
+</div>
+<form id="timeRangeForm" name="timeRangeForm" action="/panel/analytics/forums/" method="get"></form>
+<div id="panel_analytics_forums_chart" class="colstack_graph_holder">
+	<div class="ct_chart"></div>
+</div>
+<div id="panel_analytics_routes" class="colstack_item rowlist">
+	{{range .ItemList}}
+	<div class="rowitem panel_compactrow editable_parent">
+		<a href="/panel/analytics/forum/{{.Agent}}" class="panel_upshift">{{.FriendlyAgent}}</a>
+		<span class="panel_compacttext to_right">{{.Count}}{{lang "panel_statistics_views_suffix"}}</span>
+	</div>
+	{{else}}<div class="rowitem passive rowmsg">{{lang "panel_statistics_forums_no_forums"}}</div>{{end}}
+</div>
 {{template "panel_analytics_script.html" . }}
\ No newline at end of file
diff --git a/templates/panel_analytics_posts.html b/templates/panel_analytics_posts.html
index 7675d808..38b8833d 100644
--- a/templates/panel_analytics_posts.html
+++ b/templates/panel_analytics_posts.html
@@ -1,22 +1,24 @@
-		<div class="colstack_item colstack_head">
-			<div class="rowitem">
-				<h1>{{lang "panel_statistics_post_counts_head"}}</h1>
-				{{template "panel_analytics_time_range.html" . }}
-			</div>
-		</div>
-		<form id="timeRangeForm" name="timeRangeForm" action="/panel/analytics/posts/" method="get"></form>
-		<div id="panel_analytics_posts" class="colstack_graph_holder">
-			<div class="ct_chart" aria-label="{{lang "panel_statistics_post_counts_chart_aria"}}"></div>
-		</div>
-		<div class="colstack_item colstack_head">
-			<div class="rowitem"><a>{{lang "panel_statistics_details_head"}}</a></div>
-		</div>
-		<div id="panel_analytics_posts_table" class="colstack_item rowlist" aria-label="{{lang "panel_statistics_post_counts_table_aria"}}">
-			{{range .ViewItems}}
-			<div class="rowitem panel_compactrow editable_parent">
-				<a class="panel_upshift {{if or (or (or (eq $.TimeRange "six-hours") (eq $.TimeRange "twelve-hours")) (eq $.TimeRange "one-day")) (eq $.TimeRange "two-days")}}unix_to_24_hour_time{{else}}unix_to_date{{end}}">{{.Time}}</a>
-				<span class="panel_compacttext to_right">{{.Count}}{{lang "panel_statistics_posts_suffix"}}</span>
-			</div>
-			{{else}}<div class="rowitem passive rowmsg">{{lang "panel_statistics_post_counts_no_post_counts"}}</div>{{end}}
-		</div>
+<div class="colstack_item colstack_head">
+	<div class="rowitem">
+		<h1>{{lang "panel_statistics_post_counts_head"}}</h1>
+		{{template "panel_analytics_time_range.html" . }}
+	</div>
+</div>
+<form id="timeRangeForm" name="timeRangeForm" action="/panel/analytics/posts/" method="get"></form>
+<div id="panel_analytics_posts" class="colstack_graph_holder">
+	<div class="ct_chart" aria-label="{{lang "panel_statistics_post_counts_chart_aria"}}"></div>
+</div>
+<div class="colstack_item colstack_head">
+	<div class="rowitem">
+		<h1>{{lang "panel_statistics_details_head"}}</h1>
+	</div>
+</div>
+<div id="panel_analytics_posts_table" class="colstack_item rowlist" aria-label="{{lang "panel_statistics_post_counts_table_aria"}}">
+	{{range .ViewItems}}
+	<div class="rowitem panel_compactrow editable_parent">
+		<a class="panel_upshift {{if or (or (or (eq $.TimeRange "six-hours") (eq $.TimeRange "twelve-hours")) (eq $.TimeRange "one-day")) (eq $.TimeRange "two-days")}}unix_to_24_hour_time{{else}}unix_to_date{{end}}">{{.Time}}</a>
+		<span class="panel_compacttext to_right">{{.Count}}{{lang "panel_statistics_posts_suffix"}}</span>
+	</div>
+	{{else}}<div class="rowitem passive rowmsg">{{lang "panel_statistics_post_counts_no_post_counts"}}</div>{{end}}
+</div>
 {{template "panel_analytics_script.html" . }}
\ No newline at end of file
diff --git a/templates/panel_analytics_topics.html b/templates/panel_analytics_topics.html
index 8d264f78..5a5d7710 100644
--- a/templates/panel_analytics_topics.html
+++ b/templates/panel_analytics_topics.html
@@ -1,22 +1,24 @@
-		<div class="colstack_item colstack_head">
-			<div class="rowitem">
-				<h1>{{lang "panel_statistics_topic_counts_head"}}</h1>
-				{{template "panel_analytics_time_range.html" . }}
-			</div>
-		</div>
-		<form id="timeRangeForm" name="timeRangeForm" action="/panel/analytics/topics/" method="get"></form>
-		<div id="panel_analytics_topics" class="colstack_graph_holder">
-			<div class="ct_chart" aria-label="{{lang "panel_statistics_topic_counts_chart_aria"}}"></div>
-		</div>
-		<div class="colstack_item colstack_head">
-			<div class="rowitem"><a>{{lang "panel_statistics_details_head"}}</a></div>
-		</div>
-		<div id="panel_analytics_topics_table" class="colstack_item rowlist" aria-label="{{lang "panel_statistics_topic_counts_table_aria"}}">
-			{{range .ViewItems}}
-			<div class="rowitem panel_compactrow editable_parent">
-				<a class="panel_upshift {{if or (or (or (eq $.TimeRange "six-hours") (eq $.TimeRange "twelve-hours")) (eq $.TimeRange "one-day")) (eq $.TimeRange "two-days")}}unix_to_24_hour_time{{else}}unix_to_date{{end}}">{{.Time}}</a>
-				<span class="panel_compacttext to_right">{{.Count}}{{lang "panel_statistics_topics_suffix"}}</span>
-			</div>
-			{{end}}
-		</div>
+<div class="colstack_item colstack_head">
+	<div class="rowitem">
+		<h1>{{lang "panel_statistics_topic_counts_head"}}</h1>
+		{{template "panel_analytics_time_range.html" . }}
+	</div>
+</div>
+<form id="timeRangeForm" name="timeRangeForm" action="/panel/analytics/topics/" method="get"></form>
+<div id="panel_analytics_topics" class="colstack_graph_holder">
+	<div class="ct_chart" aria-label="{{lang "panel_statistics_topic_counts_chart_aria"}}"></div>
+</div>
+<div class="colstack_item colstack_head">
+	<div class="rowitem">
+		<h1>{{lang "panel_statistics_details_head"}}</h1>
+	</div>
+</div>
+<div id="panel_analytics_topics_table" class="colstack_item rowlist" aria-label="{{lang "panel_statistics_topic_counts_table_aria"}}">
+	{{range .ViewItems}}
+	<div class="rowitem panel_compactrow editable_parent">
+		<a class="panel_upshift {{if or (or (or (eq $.TimeRange "six-hours") (eq $.TimeRange "twelve-hours")) (eq $.TimeRange "one-day")) (eq $.TimeRange "two-days")}}unix_to_24_hour_time{{else}}unix_to_date{{end}}">{{.Time}}</a>
+		<span class="panel_compacttext to_right">{{.Count}}{{lang "panel_statistics_topics_suffix"}}</span>
+	</div>
+	{{end}}
+</div>
 {{template "panel_analytics_script.html" . }}
\ No newline at end of file
diff --git a/templates/panel_analytics_views.html b/templates/panel_analytics_views.html
index 2c01c7ab..5b1d5428 100644
--- a/templates/panel_analytics_views.html
+++ b/templates/panel_analytics_views.html
@@ -1,22 +1,24 @@
-		<div class="colstack_item colstack_head">
-			<div class="rowitem">
-				<h1>{{lang "panel_statistics_requests_head"}}</h1>
-				{{template "panel_analytics_time_range.html" . }}
-			</div>
-		</div>
-		<form id="timeRangeForm" name="timeRangeForm" action="/panel/analytics/views/" method="get"></form>
-		<div id="panel_analytics_views" class="colstack_graph_holder">
-			<div class="ct_chart" aria-label="{{lang "panel_statistics_requests_chart_aria"}}"></div>
-		</div>
-		<div class="colstack_item colstack_head">
-			<div class="rowitem"><a>{{lang "panel_statistics_details_head"}}</a></div>
-		</div>
-		<div id="panel_analytics_views_table" class="colstack_item rowlist" aria-label="{{lang "panel_statistics_requests_table_aria"}}">
-			{{range .ViewItems}}
-			<div class="rowitem panel_compactrow editable_parent">
-				<a class="panel_upshift {{if or (or (or (eq $.TimeRange "six-hours") (eq $.TimeRange "twelve-hours")) (eq $.TimeRange "one-day")) (eq $.TimeRange "two-days")}}unix_to_24_hour_time{{else}}unix_to_date{{end}}">{{.Time}}</a>
-				<span class="panel_compacttext to_right">{{.Count}}{{lang "panel_statistics_views_suffix"}}</span>
-			</div>
-			{{end}}
-		</div>
+<div class="colstack_item colstack_head">
+	<div class="rowitem">
+		<h1>{{lang "panel_statistics_requests_head"}}</h1>
+		{{template "panel_analytics_time_range.html" . }}
+	</div>
+</div>
+<form id="timeRangeForm" name="timeRangeForm" action="/panel/analytics/views/" method="get"></form>
+<div id="panel_analytics_views" class="colstack_graph_holder">
+	<div class="ct_chart" aria-label="{{lang "panel_statistics_requests_chart_aria"}}"></div>
+</div>
+<div class="colstack_item colstack_head">
+	<div class="rowitem">
+		<h1>{{lang "panel_statistics_details_head"}}</h1>
+	</div>
+</div>
+<div id="panel_analytics_views_table" class="colstack_item rowlist" aria-label="{{lang "panel_statistics_requests_table_aria"}}">
+	{{range .ViewItems}}
+	<div class="rowitem panel_compactrow editable_parent">
+		<a class="panel_upshift {{if or (or (or (eq $.TimeRange "six-hours") (eq $.TimeRange "twelve-hours")) (eq $.TimeRange "one-day")) (eq $.TimeRange "two-days")}}unix_to_24_hour_time{{else}}unix_to_date{{end}}">{{.Time}}</a>
+		<span class="panel_compacttext to_right">{{.Count}}{{lang "panel_statistics_views_suffix"}}</span>
+	</div>
+	{{end}}
+</div>
 {{template "panel_analytics_script.html" . }}
\ No newline at end of file
diff --git a/templates/panel_forum_edit.html b/templates/panel_forum_edit.html
index fb8c19c0..40248a0d 100644
--- a/templates/panel_forum_edit.html
+++ b/templates/panel_forum_edit.html
@@ -38,7 +38,9 @@
 		</form>
 	</div>
 	<div class="colstack_item colstack_head">
-		<div class="rowitem"><a>{{lang "panel_forum_permissions_head"}}</a></div>
+		<div class="rowitem">
+			<h1>{{lang "panel_forum_permissions_head"}}</h1>
+		</div>
 	</div>
 	<div id="forum_quick_perms" class="colstack_item rowlist formlist the_form">
 		{{range .Groups}}