try to log panics better

fix LogNewLongRoute

common/alerts.go

@@ -325,6 +325,7 @@ func AddActivityAndNotifyTarget(a Alert) error {
 	// Live alerts, if the target is online and WebSockets is enabled
 	if EnableWebsockets {
 		go func() {
+			defer EatPanics()
 			_ = WsHub.pushAlert(a.TargetUserID, a)
 			//fmt.Println("err:",err)
 		}()
@@ -341,15 +342,18 @@ func NotifyWatchers(asid int) error {
 
 	// Alert the subscribers about this without blocking us from doing something else
 	if EnableWebsockets {
-		go notifyWatchers(asid)
+		go func() {
+			defer EatPanics()
+			notifyWatchers(asid)
+		}()
 	}
 	return nil
 }
 
 func notifyWatchers(asid int) {
-	rows, err := alertStmts.getWatchers.Query(asid)
+	rows, e := alertStmts.getWatchers.Query(asid)
-	if err != nil && err != ErrNoRows {
+	if e != nil && e != ErrNoRows {
-		LogError(err)
+		LogError(e)
 		return
 	}
 	defer rows.Close()
@@ -357,21 +361,20 @@ func notifyWatchers(asid int) {
 	var uid int
 	var uids []int
 	for rows.Next() {
-		err := rows.Scan(&uid)
+		if e := rows.Scan(&uid); e != nil {
-		if err != nil {
+			LogError(e)
-			LogError(err)
 			return
 		}
 		uids = append(uids, uid)
 	}
-	if err = rows.Err(); err != nil {
+	if e = rows.Err(); e != nil {
-		LogError(err)
+		LogError(e)
 		return
 	}
 
-	alert, err := Activity.Get(asid)
+	alert, e := Activity.Get(asid)
-	if err != nil && err != ErrNoRows {
+	if e != nil && e != ErrNoRows {
-		LogError(err)
+		LogError(e)
 		return
 	}
 	_ = WsHub.pushAlerts(uids, alert)

common/common.go

@@ -13,6 +13,7 @@ import (
 	"net"
 	"net/http"
 	"os"
+	"runtime/debug"
 	"strconv"
 	"strings"
 	"sync/atomic"
@@ -200,13 +201,12 @@ func DebugLogf(str string, args ...interface{}) {
 func Log(args ...interface{}) {
 	log.Print(args...)
 }
-func Err(args ...interface{}) {
-	ErrLogger.Print(args...)
-}
-
 func Logf(str string, args ...interface{}) {
 	log.Printf(str, args...)
 }
+func Err(args ...interface{}) {
+	ErrLogger.Print(args...)
+}
 
 func Count(stmt *sql.Stmt) (count int) {
 	e := stmt.QueryRow().Scan(&count)
@@ -327,3 +327,11 @@ func (cw *ConnWatcher) StateChange(conn net.Conn, state http.ConnState) {
 func (cw *ConnWatcher) Count() int {
 	return int(atomic.LoadInt64(&cw.n))
 }
+
+func EatPanics() {
+	if r := recover(); r != nil {
+		log.Print(r)
+		debug.PrintStack()
+		log.Fatal("Fatal error.")
+	}
+}

common/counters/memory.go

@@ -35,6 +35,7 @@ func NewMemoryCounter(acc *qgen.Accumulator) (*DefaultMemoryCounter, error) {
 	c.Tasks.Shutdown.Add(co.Tick)
 	ticker := time.NewTicker(time.Minute)
 	go func() {
+		defer c.EatPanics()
 		for {
 			select {
 			case <-ticker.C:

common/counters/performance.go

@@ -75,7 +75,7 @@ func (co *DefaultPerfCounter) insertChunk(low, high, avg int64) error {
 		return nil
 	}
 	c.DebugLogf("Inserting a pchunk with low %d, high %d, avg %d", low, high, avg)
-	if c.Dev.LogNewLongRoute && (high*1000*1000) > 5 {
+	if c.Dev.LogNewLongRoute && high > (5*1000*1000) {
 		c.Logf("pchunk high %d", high)
 	}
 	_, e := co.insert.Exec(low, high, avg)

common/thumbnailer.go

@@ -15,13 +15,14 @@ import (
 )
 
 func ThumbTask(thumbChan chan bool) {
+	defer EatPanics()
+	acc := qgen.NewAcc()
 	for {
 		// Put this goroutine to sleep until we have work to do
 		<-thumbChan
 
 		// TODO: Use a real queue
 		// TODO: Transactions? Self-repairing?
-		acc := qgen.NewAcc()
 		err := acc.Select("users_avatar_queue").Columns("uid").Limit("0,5").EachInt(func(uid int) error {
 			// TODO: Do a bulk user fetch instead?
 			u, err := Users.Get(uid)

common/tickloop.go

@@ -10,6 +10,8 @@ import (
 	"github.com/pkg/errors"
 )
 
+var CTickLoop *TickLoop
+
 type TickLoop struct {
 	HalfSec    *time.Ticker
 	Sec        *time.Ticker
@@ -42,6 +44,7 @@ func (l *TickLoop) Loop() {
 			LogError(e)
 		}
 	}
+	defer EatPanics()
 	for {
 		select {
 		case <-l.HalfSec.C:
@@ -199,8 +202,7 @@ func Dailies() (e error) {
 	if e = Tasks.Day.Run(); e != nil {
 		return e
 	}
-	e = ForumActionStore.DailyTick()
+	if e = ForumActionStore.DailyTick(); e != nil {
-	if e != nil {
 		return e
 	}
 

common/topic_list.go

@@ -77,11 +77,11 @@ func NewDefaultTopicList(acc *qgen.Accumulator) (*DefaultTopicList, error) {
 		getTopicsByForum: acc.Select("topics").Columns("tid,title,content,createdBy,is_closed,sticky,createdAt,lastReplyAt,lastReplyBy,lastReplyID,views,postCount,likeCount").Where("parentID=?").Orderby("sticky DESC,lastReplyAt DESC,createdBy DESC").Limit("?,?").Prepare(),
 		//getTidsByForum: acc.Select("topics").Columns("tid").Where("parentID=?").Orderby("sticky DESC,lastReplyAt DESC,createdBy DESC").Limit("?,?").Prepare(),
 	}
-	if err := acc.FirstError(); err != nil {
+	if e := acc.FirstError(); e != nil {
-		return nil, err
+		return nil, e
 	}
-	if err := tList.Tick(); err != nil {
+	if e := tList.Tick(); e != nil {
-		return nil, err
+		return nil, e
 	}
 
 	Tasks.HalfSec.Add(tList.Tick)

common/websockets.go

@@ -196,7 +196,10 @@ func wsPageResponses(wsUser *WSUser, conn *websocket.Conn, page string) {
 		watchers := len(adminStatsWatchers)
 		adminStatsWatchers[conn] = wsUser
 		if watchers == 0 {
-			go adminStatsTicker()
+			go func() {
+				defer EatPanics()
+				adminStatsTicker()
+			}()
 		}
 		adminStatsMutex.Unlock()
 	default:

common/ws_hub.go

@@ -46,6 +46,7 @@ func (h *WsHubImpl) Start() {
 	}()
 
 	go func() {
+		defer EatPanics()
 		for {
 			item := func(l *sync.RWMutex, userMap map[int]*WSUser) {
 				l.RLock()