a
/
gosora
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

fix shadowing issue in login

This commit is contained in:
Azareal 2020-03-27 09:30:59 +10:00
parent a47a0318a7
commit e68392387a
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
routes/account.go
View File

@ -41,9 +41,9 @@ func AccountLoginSubmit(w http.ResponseWriter, r *http.Request, user *c.User) c.
if err != nil { if err != nil {
// TODO: uid is currently set to 0 as authenticate fetches the user by username and password. Get the actual uid, so we can alert the user of attempted logins? What if someone takes advantage of the response times to deduce if an account exists? // TODO: uid is currently set to 0 as authenticate fetches the user by username and password. Get the actual uid, so we can alert the user of attempted logins? What if someone takes advantage of the response times to deduce if an account exists?
logItem := &c.LoginLogItem{UID: uid, Success: false, IP: user.GetIP()} logItem := &c.LoginLogItem{UID: uid, Success: false, IP: user.GetIP()}
_, err := logItem.Create() _, ierr := logItem.Create()
if err != nil { if ierr != nil {
return c.InternalError(err, w, r) return c.InternalError(ierr, w, r)
} }
return c.LocalError(err.Error(), w, r, user) return c.LocalError(err.Error(), w, r, user)
} }