a
/
realize
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

realize: don't guard against negative length 

len never returns negative value, so guarding against it
is confusing and misleading.
This commit is contained in:
Iskander Sharipov 2018-09-15 00:37:49 +03:00
parent 38566f0c4e
commit 1a7c6b7007
4 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
realize.go
View File

@ -1144,7 +1144,7 @@ func start(c *cli.Context) (err error) {
} }
// check project list length // check project list length
if len(r.Schema.Projects) <= 0 { if len(r.Schema.Projects) == 0 {
// create a new project based on given params // create a new project based on given params
project := r.Schema.New(c) project := r.Schema.New(c)
// Add to projects list // Add to projects list

2
realize/cli_test.go
View File

@ -44,7 +44,7 @@ func TestRealize_Prefix(t *testing.T) {
r := Realize{} r := Realize{}
input := "test" input := "test"
result := r.Prefix(input) result := r.Prefix(input)
if len(result) <= 0 && !strings.Contains(result, input) { if len(result) == 0 && !strings.Contains(result, input) {
t.Error("Unexpected error") t.Error("Unexpected error")
} }
} }

2
realize/projects.go
View File

@ -343,7 +343,7 @@ L:
// Validate a file path // Validate a file path
func (p *Project) Validate(path string, fcheck bool) bool { func (p *Project) Validate(path string, fcheck bool) bool {
if len(path) <= 0 { if len(path) == 0 {
return false return false
} }
// check if skip hidden // check if skip hidden

2
realize_test.go
View File

@ -56,7 +56,7 @@ func TestRealize_add(t *testing.T) {
if err := m.add(); err != nil { if err := m.add(); err != nil {
t.Error("Unexpected error") t.Error("Unexpected error")
} }
if len(m.Projects) <= 0 { if len(m.Projects) == 0 {
t.Error("Unexpected error") t.Error("Unexpected error")
} }