Commit Graph

3071 Commits

Author SHA1 Message Date
Tian Jian 59f667ec14
Fix: use pipe to spawn child process to re-enable file logging (#4293)
We pipe the child's stdout and stderr to the log file (and to the parent's streams) but since we used `inherit` for `stdio` this caused the child to use the parent's streams directly which made `child.stdout` and `child.stderr` non-existent and thus we had no file logging.

Using `pipe` creates stdin and stderr on the child.
2021-10-05 10:55:40 -05:00
Joe Previte 8a4ed5a2e0
Merge pull request #4306 from cdr/jsjoeio-fix-broken-tests
fix: revert CI change + fix broken tests
2021-10-04 12:20:31 -07:00
Joe Previte a8d873f9f8
refactor(ci): fix unit tests job 2021-10-04 12:07:45 -07:00
Joe Previte 7183b5a43e
chore(testing): fix casing in error messsage 2021-10-04 12:06:33 -07:00
Joe Previte 8136769b66
fix: close vscodeServer on server close if defined 2021-10-04 12:06:12 -07:00
Teffen Ellis 672038c6af Fix issue where marketplace is undefined.
- Fix error logging from child process.
2021-10-04 13:26:16 -04:00
Joe Previte 2d7aeb5bf9
Merge pull request #4290 from cdr/jsjoeio-vscode
chore(vscode): update to latest commit of fork
2021-10-01 14:57:02 -07:00
Joe Previte f342c327f3
chore(vscode): update to latest commit of fork 2021-10-01 14:47:20 -07:00
Joe Previte 4619786019
Merge pull request #4274 from cdr/jsjoeio-testing-guidelines
docs: update section around testing
2021-10-01 11:15:15 -07:00
Joe Previte 1dfcd0448e
Merge pull request #4273 from cdr/jsjoeio-bump-helm-chart
chore(helm-chart): bump to 1.0.5
2021-10-01 11:10:21 -07:00
Joe Previte 48ce49eec8
Merge pull request #4281 from toddewilliams/patch-1
Update collaboration.md
2021-09-30 16:43:48 -07:00
Teffen Ellis d8c344beda Refactor vscode endpoints to use fork directly. 2021-09-30 19:14:17 -04:00
Teffen Ellis beebf53adc Add linkup command to improve link functionality 2021-09-30 19:14:17 -04:00
Joe Previte a14fa862da
fixup! Update collaboration.md 2021-09-30 15:23:16 -07:00
Todd Williams fc0d127470
Update collaboration.md
I updated the CodeTogether description to include some enhancements that we just shipped in CodeTogether 4.2. I also added a bit more detail to the feature list and provided some hyperlinks in a couple of places where people would likely appreciate more detail. 

I made no changes to the other sections.
2021-09-30 11:51:42 -05:00
Joe Previte 6eda7ae81f
Merge pull request #4243 from cdr/renovate/ws-8.x
chore(deps): update dependency @types/ws to v8
2021-09-29 15:17:58 -07:00
Joe Previte 3f75aa2db1
Merge pull request #4254 from cdr/ipad-copy-paste
iPad docs: add copy & paste known issue
2021-09-29 15:11:20 -07:00
Renovate Bot 328b864534
chore(deps): update dependency @types/ws to v8 2021-09-29 22:06:02 +00:00
Ben Potter 876d0275b3
iPad docs: add copy & paste known issue 2021-09-29 15:04:51 -07:00
Joe Previte b9989ca2db
docs(MAINTAINING): add Testing section 2021-09-29 15:02:11 -07:00
Joe Previte 4e310b4985
docs(CONTRIBUTING): add scrip tests section 2021-09-29 15:02:11 -07:00
Joe Previte d54b4accac
fix 2021-09-29 14:39:48 -07:00
Joe Previte 5e7b419820
chore: bump helm-chart version to 1.0.5
We've had two patches to the helm-chart since the last time we bumped the Chart
version.

- 1ffca5751c
- 5a36627aae

This version bump ensures that chart version has the correct date.
2021-09-29 14:38:13 -07:00
Joe Previte 1b80244af7
Merge pull request #4265 from cdr/jsjoeio-add-tests
feat(cli): add test for defaultConfigFile
2021-09-28 16:19:32 -07:00
Joe Previte 999960eef5
Merge pull request #4236 from cdr/jsjoeio/fix-brew-bump
fix(brew-bump.sh): add checks and handle errors
2021-09-28 16:13:24 -07:00
Joe Previte 6c95f72d2b
refactor: make password param to defaultConfigFile 2021-09-28 16:13:13 -07:00
Joe Previte 8ef950af4c
feat(brew-bump): add check for cleanup step 2021-09-28 16:07:01 -07:00
Joe Previte e5f03e0b06
fix: add checks and handle errors brew-bump.sh
feat(script): add steps-lib, is_env_var_set & test

feat(brew-bump): add check for VERSION

feat(brew-bump): check HOMEBREW_GITHUB_API_TOKEN

feat(steps-lib): add directory_exists helper fn

fix(brew-bump): check that git clone worked

feat(brew-bump): add check for remote upstream

fix: remove upstream command thing

feat(steps-lib): add file_exists helper function

feat(brew-bump): add check for git-askpass.sh

feat(steps-lib): add is_executable function & test

feat(brew-bump): add check for is_executable

refactor: use GIT_ASKPASS as variable
2021-09-28 16:06:57 -07:00
Joe Previte 77c1150b8d
feat(cli): add test for defaultConfigFile 2021-09-28 15:45:44 -07:00
Joe Previte fb2625dbe8
chore(cli): export defaultConfigFile + add JSDoc 2021-09-28 15:38:59 -07:00
Joe Previte 82d93186f8
feat(cli): add test for defaultConfigFile 2021-09-28 14:41:38 -07:00
Jonathan Yu 8f72481712
chore: upgrade preview Node.js from 12 to 14 (#4255) 2021-09-28 09:21:39 -07:00
Joe Previte edb3b41800
Merge pull request #4253 from cdr/jsjoeio-codeowners
fix: update CODEOWNERS for helm-chart
2021-09-27 16:32:33 -07:00
Joe Previte 97a292235f
fix: update CODEOWNERS for helm-chart 2021-09-27 16:26:27 -07:00
Ben Potter 4c6e43d8d6
Merge pull request #4244 from jlandowner/main
Use Ingress v1 from Kubernetes v1.19 in helm chart
2021-09-27 13:24:58 -07:00
Joe Previte 8bae81dd83
Merge pull request #4251 from cdr/jsjoeio-fix-trivy
chore(deps): upgrade ansi-regex to 5.0.1 and tmpl to 1.0.5
2021-09-27 12:31:56 -07:00
Joe Previte be90b5de35
chore(deps): upgarde tmpl to 1.0.5 2021-09-27 12:20:04 -07:00
Joe Previte 1f819fa534
chore(deps): upgrade ansi-regex to 5.0.1 2021-09-27 12:15:18 -07:00
jlandowner 5a36627aae Use Ingress v1 from k8s v1.19 2021-09-25 23:07:06 +09:00
Abdullah Bin Jahed c11d51ed7a Update package.json 2021-09-24 17:49:58 -04:00
Joe Previte 900c34c613
Merge pull request #4234 from cdr/jsjoeio/update-npm-maintainence
docs(MAINTAINING): update release section + add team section
2021-09-23 22:52:34 +00:00
Joe Previte c91033c611
docs(maintaining): fix #4174 2021-09-23 15:45:29 -07:00
Joe Previte 2c6a47d42b
docs(maintaining): add note for each release platform 2021-09-23 15:45:28 -07:00
Joe Previte 05d66c1358
docs(maintaining): add onboarding and offboarding 2021-09-23 15:45:28 -07:00
Joe Previte bf10341e3f
docs(maintaining): refactor and add Team section 2021-09-23 15:45:27 -07:00
Joe Previte 83eade6897
docs: remove oxy from current maintainers 2021-09-23 15:45:27 -07:00
Joe Previte f3ef414fd2
Merge pull request #4231 from cdr/jsjoeio/revert-4116
Revert "fix: run postinstall script explicitly with bash (#4116)"
2021-09-23 19:33:46 +00:00
Joe Previte 014faf5b1c
feat: use sh in postinstall in build-release.sh 2021-09-23 11:41:51 -07:00
Joe Previte 1f95a23d1d
Revert "fix: run postinstall script explicitly with bash (#4116)"
This reverts commit b32b4edf3d.

We are reverting this because we found out that while this fixes the postinstall
on Windows, it breaks it on mac and other devices.  See:
https://github.com/cdr/code-server/issues/3874#issuecomment-925397980
2021-09-23 10:44:37 -07:00
Joe Previte ed0926819d
Merge pull request #4228 from cdr/bpmct/ipad-fixup
update iPad docs to reflect info in Sep 2021
2021-09-23 17:13:39 +00:00