83746c8a1f
refactor: remove null check in register.ts options.base
...
Inside registerServiceWorker, we were originally using the nullash coalescing
operator to check if options.base was null or undefined. However, I realized
this check is not necessary.
If you look at getOptions' return value, we return an object with a key "base"
which is of type "string". We get that value by calling resolveBase which always
returns a string.
As a result, we didn't need to check if options.base was null or undefined
because it never can be.
2021-04-23 17:09:03 -07:00
6f2709bcaa
feat: add tests for registerServiceWorker
2021-04-23 16:31:56 -07:00
5ad8e686bc
Merge pull request #3194 from cdr/jsjoeio/add-code-coverage-reporter
...
feat(testing): add codecov to generate test coverage reports
2021-04-22 22:46:45 +00:00
bb0414e7bb
feat: add ci step upload coverage report Codecov
2021-04-22 15:28:30 -07:00
537fbd040a
feat: add coverage script using codecov
2021-04-22 15:27:54 -07:00
a777bf05c7
feat: add clover to get test coverage in xml
...
Codecov requires .xml format.
We can get this from Jest by adding "clover"
to our coverageReporters.
2021-04-22 15:03:15 -07:00
72ca12c098
chore(lib/vscode): update netmask ( #3187 )
2021-04-22 02:57:35 +05:30
b9c80b8520
Merge pull request #3178 from code-asher/connections
...
Minor connections refactor
2021-04-21 12:22:45 -05:00
16fc315afa
Catch socket close during protocol handshake
...
zlib errors can cause the protocol handshake to not reject (until the
timeout).
2021-04-21 11:48:46 -05:00
f0bafa387f
Move connection logic into connection class
...
- Moved everything I could into the class itself.
- Improve the logging situation a bit.
- Switch some trace logs to debug.
- Get debug port from message arguments.
2021-04-21 11:48:45 -05:00
ae6089f852
Improve protocol class
...
- Move destroy logic into the class itself
- Improve logging a bit
- Remove the record option; we should always do this when using
permessage-deflate.
- Let debug port be null (it can be null in the message args).
- Add setSocket so we don't have to initiate a connection to set it.
- Move inflate bytes logic into the class itself.
2021-04-21 11:48:43 -05:00
4ed7ae9c96
chore(ranger): fix syntax for extension-request ( #3172 )
2021-04-20 10:27:06 -07:00
724ee93e81
chore(ci): migrate from hub to gh ( #3168 )
2021-04-20 02:21:33 +05:30
6d65680c23
Merge pull request #3141 from cdr/jsjoeio/fix-login-rate-limiter
...
fix(login): rate limiter shouldn't count successful logins
2021-04-19 20:29:11 +00:00
f80d5c3764
refactor: rateLimiter.canTry logic to check >= 1
2021-04-19 13:14:19 -07:00
7a5042176e
fix: update logic for removing token from limiter
2021-04-19 11:12:43 -07:00
958f01262b
refactor: check errorMessage in login e2e test
2021-04-19 11:11:52 -07:00
a3f18d6158
refactor: change limiter.Try() to .removeToken()
2021-04-19 10:57:50 -07:00
7928dc2bff
feat: add test for limiter.canTry()
2021-04-19 10:41:00 -07:00
d8e45057c7
refactor: update rateLimiter to check try
...
This changes adds a new method called `.canTry` to the rate limiter to check if
there are tokens remaining in the bucket.
It also adds suggestions from @oxy to make sure the user can brute force past
the rate limiter.
2021-04-19 10:40:59 -07:00
a8719e1f79
refactor: change config to save all e2e videos
2021-04-19 10:40:59 -07:00
1e6f4f2a14
feat(testing): add test for rate limiter
2021-04-19 10:40:59 -07:00
08521077f0
refactor(login): move rate limiter after successful login
...
Before, we weren't checking if a login was successful before counting it
against the rate limiter.
With this change, we only count unsuccessful logins against the rate limiter.
We did this because this was a bug but also because it caused problems with our
e2e tests hitting the rate limit.
2021-04-19 10:40:59 -07:00
83cfbf82cf
feat: increase timeout for playwright tests
2021-04-19 10:40:59 -07:00
faaa0a9e60
feat(testing): add e2e tests for password
2021-04-19 10:40:59 -07:00
ebbabc6e04
refactor(testing): combine loginPage with login
2021-04-19 10:40:58 -07:00
58e17c5e50
feat(testing): add tests for RateLimiter
2021-04-19 10:40:58 -07:00
4683d8a077
fix: update comment and export rateLimiter
2021-04-19 10:40:58 -07:00
f21884cce5
chore(deps): deduplicate deps in yarn.lock ( #3167 )
2021-04-19 22:22:07 +05:30
818e2207f8
chore(deps): bump ssri from 6.0.1 to 6.0.2 in /lib/vscode ( #3165 )
...
Bumps [ssri](https://github.com/npm/ssri ) from 6.0.1 to 6.0.2.
- [Release notes](https://github.com/npm/ssri/releases )
- [Changelog](https://github.com/npm/ssri/blob/v6.0.2/CHANGELOG.md )
- [Commits](https://github.com/npm/ssri/compare/v6.0.1...v6.0.2 )
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2021-04-19 20:35:48 +05:30
7f6b3da8d5
chore(deps): bump ws from 7.4.4 to 7.4.5 ( #3163 )
...
Bumps [ws](https://github.com/websockets/ws ) from 7.4.4 to 7.4.5.
- [Release notes](https://github.com/websockets/ws/releases )
- [Commits](https://github.com/websockets/ws/compare/7.4.4...7.4.5 )
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2021-04-19 20:31:57 +05:30
4ae9e43362
security: upgrade parcel-bundler from 1.12.4 to 1.12.5 ( #3161 )
...
Upgrade parcel-bundler due to a transitive dependency on is-svg.
This resolves CVE-2021-28092.
2021-04-19 07:20:45 -07:00
e46941fa58
Merge pull request #3148 from cdr/jsjoeio/add-security-policy
...
docs: add security policy
2021-04-16 22:34:44 +00:00
dc98399d2b
fixup: docs
2021-04-16 15:20:07 -07:00
24c713e054
Create SECURITY.md
2021-04-16 14:57:40 -07:00
cbc2e8bc92
chore(ci): remove images and update publish flow ( #3147 )
...
* chore(ci): remove unmaintained images
* chore(ci): update publish workflow
2021-04-17 01:17:24 +05:30
006438db33
chore(deps-dev): bump @types/node from 12.20.8 to 12.20.10 ( #3143 )
...
Bumps [@types/node](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/node ) from 12.20.8 to 12.20.10.
- [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases )
- [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/node )
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2021-04-16 21:38:49 +05:30
e9985bd658
feat(vscode): update to version 1.55.2
2021-04-16 02:10:06 +05:30
0b8a06863b
fix(update-vscode): add check/docs for git-subtree ( #3129 )
2021-04-16 01:07:28 +05:30
578b2de131
chore(lib/vscode): clean up comments
2021-04-16 00:39:02 +05:30
97fbbfaecc
Merge pull request #3133 from cdr/jsjoeio/migrate-to-playwright-test
...
refactor(testing): migrate to playwright-test from jest-playwright
2021-04-15 19:04:24 +00:00
73e316eae3
Merge pull request #3138 from cdr/dependabot/npm_and_yarn/types/node-12.20.8
...
chore(deps-dev): bump @types/node from 12.20.7 to 12.20.8
2021-04-15 11:47:37 -07:00
3b5416cbb2
Merge pull request #3137 from cdr/dependabot/npm_and_yarn/eslint-plugin-prettier-3.4.0
...
chore(deps-dev): bump eslint-plugin-prettier from 3.3.1 to 3.4.0
2021-04-15 11:47:28 -07:00
e741ebf50b
Merge pull request #3136 from cdr/dependabot/npm_and_yarn/js-yaml-4.1.0
...
chore(deps): bump js-yaml from 4.0.0 to 4.1.0
2021-04-15 11:47:17 -07:00
450fcd5ba7
refactor: pass all args to test-e2e script
2021-04-15 11:46:45 -07:00
d6f0725399
fix: update path for e2e videos
2021-04-15 11:46:45 -07:00
c9fa931a0b
fix: add retry 2 for failing e2e tests
2021-04-15 11:46:44 -07:00
92b7c1e9a8
refactor: test-e2e.sh script
2021-04-15 11:46:44 -07:00
6c3bb101cd
chore(deps): add resolution for newest playwright
2021-04-15 11:46:44 -07:00
7ea6d22b3e
refactor: add login to config.js for e2e tests
2021-04-15 11:46:44 -07:00
Joe Previte
repo-ranger[bot]
Akash Satheesan
Asher
dependabot[bot]
Jonathan Yu