2988c1e444
pkgerrors: remove fmt dep
2019-01-02 13:19:14 -08:00
adb19ff852
Merge branch 'master' into stacktrace
2019-01-02 12:11:57 -08:00
c482b20623
ConsoleWriter: fix race condition ( #120 )
...
Alternative approach to #118 : fix the race condition by replacing the package-level customization settings with curried functions.
2018-12-07 09:59:01 -08:00
7179aeef58
ConsoleWriter: reset buffer before returning it to the pool ( #119 )
...
The buffers put back into the pool should be equivalent to those generated by the `New` function.
2018-12-05 07:46:12 +00:00
8747b7b3a5
Add ErrorHandler global to allow handling of write errors
2018-11-20 10:56:21 -08:00
848482bc3d
Fix "could not write" error missing carriage return (again)
2018-11-12 17:50:30 -08:00
7bcaa1a99e
fix: console ts with json number ( #115 )
2018-11-12 00:50:17 -08:00
8e30c71369
Revert the wrapping of write errors
...
All errors generated by Go libraries on stderr won't be json encoded
anyway, so it does not make sense to have such a treatment for this one.
2018-11-08 14:49:44 -08:00
3f112dae87
Fix "could not write" error missing carriage return
2018-11-07 15:21:38 -08:00
a4c54e5d8b
Fix the ConsoleWriter default parts order ( #113 )
...
In order to prevent incorrect output when somebody uses a different name eg. for the "MessageFieldName",
the `consoleDefaultPartsOrder` variable has been switched to a function, which is called in `Write()`,
in order to pick up the custom name.
Related: rs/zerolog#92
2018-11-07 09:39:38 -08:00
96f91bb4f5
Refactored zerolog.ConsoleWriter to allow customization ( #92 )
...
* Added a simple benchmarking test for the ConsoleWriter
* Refactored `zerolog.ConsoleWriter` to allow customization
Closes #84
2018-11-05 02:15:13 -08:00
51c79ca476
Fix com typo
2018-11-02 13:06:29 -07:00
e7627a4f73
diode: let use a waiter instead of a poller by using 0 as a poolInterval
2018-10-31 16:57:15 -07:00
baa31cfa85
Fix nil pointer dereference when call Fields with a typed nil value ( #112 )
2018-10-31 10:40:46 -07:00
8e36cbf881
Don't call panic() and os.Exit(1) on .WithLevel() ( #110 )
...
* Don't call panic() and os.Exit(1) on .WithLevel()
* Explain behavior of WithLevel(), compared to Panic() & Fatal()
2018-09-27 18:11:43 -07:00
20ad1708e7
Fix nil pointer exception on Discard when called with nil logger
...
Fixes #108
2018-09-26 09:52:52 -07:00
338f9bc140
Fix typo
2018-09-19 07:40:00 -07:00
e0f8de6c35
Fix usage of sync.Pool
...
The current usage of sync.Pool is leaky because it stores an arbitrary
sized buffer into the pool. However, sync.Pool assumes that all items in the
pool are interchangeable from a memory cost perspective. Due to the unbounded
size of a buffer that may be added, it is possible for the pool to eventually
pin arbitrarily large amounts of memory in a live-lock situation.
As a simple fix, we just set a maximum size that we permit back into the pool.
2018-09-19 00:20:01 -07:00
972f27185c
Remove unused hook field on event
2018-09-19 00:20:01 -07:00
624b3116d8
Fix sub-logger by context example ( #106 )
...
Not quite sure but looks like the example is using the wrong API.
2018-09-18 07:57:53 -07:00
785a567b10
Add a mention to logbench
2018-09-18 02:18:32 -07:00
84794124e9
Use gh-readme template for zerolog.io
2018-09-17 10:28:18 -07:00
fc5bbcd9d6
Create CNAME
2018-09-16 19:21:46 -07:00
1c8b5945b1
Set theme jekyll-theme-hacker
2018-09-16 19:21:33 -07:00
2da253048d
Fix binary test too
2018-09-16 19:15:55 -07:00
8aa660046f
Add hlog.IDFromCtx
2018-09-16 19:00:10 -07:00
470da8d0bb
Fix failing test introduced by last commit
2018-09-16 18:53:09 -07:00
1dde226d45
BasicSampler prints first message ( fix #104 )
2018-09-16 15:54:54 -07:00
b6f076edc8
Add note for default writing to os.Stderr ( #97 )
2018-08-31 09:46:32 -07:00
85255a5e26
Fix typo on documentation ( #94 )
2018-08-14 19:23:11 -07:00
71e1f5e052
Add the ability to discard an event from a hook
...
The Discard method has been added to the Event type so it can be called
from a hook to prevent the event from behing printed. This new method
works outside of the context of a hook too.
Fixes #90
2018-07-26 15:53:02 -07:00
bae001d86b
Allow devs to change the width of the logging level column in consolewriter ( #87 )
...
* Allow user to change the width of the logging level column
* Change default level width to 0 (no dynamic width)
2018-07-25 10:05:55 -07:00
e8a8508f09
fix caller file and line number in context hook ( #89 )
...
* fix caller file and line number report in context hook
* update comment
* update comment
2018-07-25 02:48:22 -07:00
372015deb4
add linter to check for missing finishers ( #85 )
2018-07-20 08:05:08 -07:00
9cd6f6eef2
ctx: store logger in context when missing or different that stored one ( #81 )
...
Current implementation stores a copy of the logger as a pointer and
update its content, which is now unecessary since the introduction of
WithContext.
The new WithContext now takes the pointer and store it in the context if
none is stored already or if the last one stored is a different pointer.
This way it is still possible to update the context of a logger stored
in the context, but it is also possible to store a copy of the logger in
a sub-context.
Fix #80
2018-07-02 18:23:53 -07:00
1c6d99b455
Add custom error serialization support and provide sane defaults ( #78 )
...
As per https://github.com/rs/zerolog/issues/9 and to offer a different approach from https://github.com/rs/zerolog/pull/11 and https://github.com/rs/zerolog/pull/35 this PR introduces custom error serialization with sane defaults without breaking the existing APIs.
This is just a first draft and is missing tests. Also, a bit of code duplication which I feel could be reduced but it serves to get the idea across.
It provides global error marshalling by exposing a `var ErrorMarshalFunc func(error) interface{}` in zerolog package that by default is a function that returns the passed argument. It should be overriden if you require custom error marshalling.
Then in every function that accept error or array of errors `ErrorMarshalFunc` is called on the error and then the result of it is processed like this:
- if it implements `LogObjectMarshaler`, serialize it as an object
- if it is a string serialize as a string
- if it is an error, serialize as a string with the result of `Error()`
- else serialize it as an interface
The side effect of this change is that the encoders don't need the `AppendError/s` methods anymore, as the errors are serialized directly to other types.
2018-07-02 12:46:01 -07:00
1a88fbfdd0
Update readme at example for Caller() ( #76 )
...
* Update readme at example for Caller()
2018-06-03 22:57:37 -07:00
dabc72c15b
fix README ( #74 )
2018-05-31 10:33:44 -07:00
c19f1e5eed
Diode module Documentation update ( #71 )
...
* Updated Diode example to match new style
* DOC: changed w to wr in assigment to reduce ambiguity
2018-05-25 14:45:33 -07:00
77db4b4f35
Embed the diode lib to avoid test dependencies
...
This commit introduces a breaking change in the diode API in order to
hide the diodes package interface. This removes a good number of
dependencies introduced by the test framework used by the diodes
package.
2018-05-24 19:15:40 -07:00
64faaa6980
Add go.mod file
2018-05-23 09:50:46 -07:00
80d6806aae
Fix comments (bis)
2018-05-21 11:01:34 -07:00
ea197802eb
Fix comments
2018-05-17 16:48:29 -07:00
c62533f761
Fix ConsoleWriter test
2018-05-17 16:35:57 -07:00
fb469685aa
Fix ConsoleWriter when zerolog is configured to use UNIX timestamp
2018-05-17 16:10:49 -07:00
a025d45231
EmbedObject() API and knob to change caller frames ( #66 )
...
* Fix for a bug in cbor decodeFloat
* Add EmbedObject() method
* knob to change the depth of caller frames to skip
* removed EmbedObj() for array - since it is same as Object()
2018-05-16 18:42:33 -07:00
b5207c012d
Fix type in README ( fix #62 )
2018-05-12 22:12:35 -07:00
533ee32d5d
fix needed after calling encoder via interface ( #60 )
2018-05-10 18:21:30 -07:00
ea1184be2b
Get back some ns by removing the extra inferance added by binary support
...
benchstat old new
name old time/op new time/op delta
LogEmpty-8 15.2ns ±14% 13.4ns ± 3% -12.11% (p=0.008 n=5+5)
Disabled-8 2.50ns ± 1% 2.28ns ± 6% -8.81% (p=0.008 n=5+5)
Info-8 44.4ns ± 1% 36.4ns ± 4% -17.99% (p=0.008 n=5+5)
ContextFields-8 47.6ns ± 1% 39.4ns ± 7% -17.30% (p=0.008 n=5+5)
ContextAppend-8 18.9ns ± 4% 15.2ns ± 4% -19.68% (p=0.008 n=5+5)
LogFields-8 181ns ± 2% 173ns ± 2% -4.63% (p=0.008 n=5+5)
LogArrayObject-8 530ns ± 3% 487ns ± 3% -8.11% (p=0.008 n=5+5)
LogFieldType/Int-8 29.5ns ± 3% 28.8ns ± 2% ~ (p=0.167 n=5+5)
LogFieldType/Interface-8 180ns ± 7% 175ns ± 4% ~ (p=0.579 n=5+5)
LogFieldType/Interface(Object)-8 87.8ns ± 3% 80.5ns ± 1% -8.29% (p=0.008 n=5+5)
LogFieldType/Object-8 83.7ns ± 2% 77.2ns ± 3% -7.76% (p=0.008 n=5+5)
LogFieldType/Bools-8 34.6ns ± 3% 32.3ns ± 6% -6.64% (p=0.032 n=5+5)
LogFieldType/Float-8 43.0ns ± 4% 40.5ns ± 4% -5.86% (p=0.016 n=5+5)
LogFieldType/Str-8 29.8ns ± 2% 26.5ns ± 5% -11.01% (p=0.008 n=5+5)
LogFieldType/Err-8 32.8ns ± 2% 29.8ns ± 4% -9.21% (p=0.008 n=5+5)
LogFieldType/Durs-8 309ns ± 3% 304ns ± 3% ~ (p=0.238 n=5+5)
LogFieldType/Floats-8 175ns ± 2% 174ns ± 3% ~ (p=0.968 n=5+5)
LogFieldType/Strs-8 51.0ns ± 3% 48.4ns ± 6% -5.06% (p=0.032 n=5+5)
LogFieldType/Dur-8 44.5ns ± 3% 41.3ns ± 3% -7.11% (p=0.008 n=5+5)
LogFieldType/Interface(Objects)-8 758ns ± 3% 760ns ± 6% ~ (p=1.000 n=5+5)
LogFieldType/Interfaces-8 772ns ± 5% 762ns ± 4% ~ (p=0.794 n=5+5)
LogFieldType/Bool-8 28.0ns ± 6% 26.5ns ± 9% ~ (p=0.143 n=5+5)
LogFieldType/Ints-8 49.6ns ± 2% 46.2ns ± 2% -6.70% (p=0.008 n=5+5)
LogFieldType/Errs-8 46.5ns ±11% 40.9ns ± 4% -11.92% (p=0.008 n=5+5)
LogFieldType/Time-8 115ns ± 3% 113ns ± 3% ~ (p=0.167 n=5+5)
LogFieldType/Times-8 810ns ± 1% 811ns ± 3% ~ (p=0.889 n=5+5)
ContextFieldType/Errs-8 158ns ± 6% 156ns ±12% ~ (p=1.000 n=5+5)
ContextFieldType/Times-8 165ns ±11% 173ns ± 9% ~ (p=0.651 n=5+5)
ContextFieldType/Interface-8 289ns ±13% 287ns ±11% ~ (p=0.690 n=5+5)
ContextFieldType/Interface(Object)-8 285ns ±12% 297ns ± 6% ~ (p=0.238 n=5+5)
ContextFieldType/Interface(Objects)-8 941ns ± 6% 941ns ± 5% ~ (p=1.000 n=5+5)
ContextFieldType/Object-8 201ns ± 5% 210ns ±12% ~ (p=0.262 n=5+5)
ContextFieldType/Ints-8 173ns ±10% 165ns ± 9% ~ (p=0.198 n=5+5)
ContextFieldType/Floats-8 297ns ± 6% 292ns ± 7% ~ (p=0.579 n=5+5)
ContextFieldType/Timestamp-8 174ns ± 9% 174ns ±11% ~ (p=0.810 n=5+5)
ContextFieldType/Durs-8 445ns ± 9% 425ns ± 3% ~ (p=0.151 n=5+5)
ContextFieldType/Interfaces-8 944ns ± 6% 876ns ±10% ~ (p=0.095 n=5+5)
ContextFieldType/Strs-8 179ns ±11% 165ns ±13% ~ (p=0.135 n=5+5)
ContextFieldType/Dur-8 158ns ± 8% 160ns ±19% ~ (p=1.000 n=5+5)
ContextFieldType/Time-8 152ns ±15% 148ns ±14% ~ (p=0.952 n=5+5)
ContextFieldType/Str-8 146ns ±12% 147ns ±16% ~ (p=0.841 n=5+5)
ContextFieldType/Err-8 138ns ±12% 145ns ±17% ~ (p=0.595 n=5+5)
ContextFieldType/Int-8 145ns ±10% 146ns ±13% ~ (p=0.873 n=5+5)
ContextFieldType/Float-8 181ns ± 9% 162ns ±12% ~ (p=0.151 n=5+5)
ContextFieldType/Bool-8 153ns ±10% 131ns ±19% ~ (p=0.063 n=5+5)
ContextFieldType/Bools-8 149ns ±11% 160ns ±16% ~ (p=0.500 n=5+5)
2018-05-10 15:01:41 -07:00
a572c9d1f6
Add missing support for zerolog marshable objects to Fields
2018-05-09 03:52:30 -07:00
Olivier Poitrey
Ingmar Stein
Yongzheng Lai
Karel Minarik
anthony
Vojtech Vitek
Thiago Caiubi
jayven
Duncan Hall
Marcelo Aymone
Dave McCormick
su21
Dušan Kasan
Josh Rendek
Pichugin Dmitry
Rafael Passos
Ravi Raju